154047 2016-02-09 14:22:13 -0800 Don't crash if we fail to parse a builtin 2016-02-09 14:42:21 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1163287 0 fpizlo 2016-02-09 14:22:13 -0800 Crashing probably seemed like a good idea at the time, but we could get here in case of a near stack overflow, so that the parser bails because of recursion. 1163288 1 270953 fpizlo 2016-02-09 14:24:01 -0800 Created attachment 270953 the patch 1163290 2 270953 mark.lam 2016-02-09 14:26:37 -0800 Comment on attachment 270953 the patch r=me 1163293 3 fpizlo 2016-02-09 14:42:21 -0800 Landed in http://trac.webkit.org/changeset/196337 270953 2016-02-09 14:24:01 -0800 2016-02-09 14:26:37 -0800 the patch blah.patch text/plain 1516 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk2MzM2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDE2LTAyLTA5ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg RG9uJ3QgY3Jhc2ggaWYgd2UgZmFpbCB0byBwYXJzZSBhIGJ1aWx0aW4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NDA0NworICAgICAgICByZGFyOi8v cHJvYmxlbS8yNDMwMDYxNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIENyYXNoaW5nIHByb2JhYmx5IHNlZW1lZCBsaWtlIGEgZ29vZCBpZGVhIGF0IHRo ZSB0aW1lLCBidXQgd2UgY291bGQgZ2V0IGhlcmUgaW4gY2FzZSBvZiBhCisgICAgICAgIG5lYXIg c3RhY2sgb3ZlcmZsb3csIHNvIHRoYXQgdGhlIHBhcnNlciBiYWlscyBiZWNhdXNlIG9mIHJlY3Vy c2lvbi4KKworICAgICAgICAqIHBhcnNlci9QYXJzZXIuaDoKKyAgICAgICAgKEpTQzo6cGFyc2Up OgorCiAyMDE2LTAyLTA3ICBHYXZpbiBCYXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNv bT4KIAogICAgICAgICBHZXRWYWx1ZUZ1bmMvUHV0VmFsdWVGdW5jIHNob3VsZCBub3QgdGFrZSBi b3RoIHNsb3RCYXNlIGFuZCB0aGlzVmFsdWUKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9w YXJzZXIvUGFyc2VyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNl ci9QYXJzZXIuaAkocmV2aXNpb24gMTk2MzIyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3Bh cnNlci9QYXJzZXIuaAkod29ya2luZyBjb3B5KQpAQCAtMTU0Miw4ICsxNTQyLDggQEAgc3RkOjp1 bmlxdWVfcHRyPFBhcnNlZE5vZGU+IHBhcnNlKAogICAgICAgICBpZiAoYnVpbHRpbk1vZGUgPT0g SlNQYXJzZXJCdWlsdGluTW9kZTo6QnVpbHRpbikgewogICAgICAgICAgICAgaWYgKCFyZXN1bHQp CiAgICAgICAgICAgICAgICAgV1RGOjpkYXRhTG9nKCJFcnJvciBjb21waWxpbmcgYnVpbHRpbjog IiwgZXJyb3IubWVzc2FnZSgpLCAiXG4iKTsKLSAgICAgICAgICAgIFJFTEVBU0VfQVNTRVJUKHJl c3VsdCk7Ci0gICAgICAgICAgICByZXN1bHQtPnNldENsb3NlZFZhcmlhYmxlcyhwYXJzZXIuY2xv c2VkVmFyaWFibGVzKCkpOworICAgICAgICAgICAgZWxzZQorICAgICAgICAgICAgICAgIHJlc3Vs dC0+c2V0Q2xvc2VkVmFyaWFibGVzKHBhcnNlci5jbG9zZWRWYXJpYWJsZXMoKSk7CiAgICAgICAg IH0KICAgICAgICAgcmV0dXJuIHJlc3VsdDsKICAgICB9Cg==