15403 2007-10-06 11:42:05 -0700 svg/custom/use-css-events.svg seems to have regressed on feature-branch 2007-12-02 21:45:20 -0800 1 1 1 Unclassified WebKit SVG 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED http://trac.webkit.org/projects/webkit/browser/branches/feature-branch/LayoutTests/svg/custom/use-css-events.svg?format=raw P2 Normal --- 1 eric zimmermann oldest_to_newest 57955 0 eric 2007-10-06 11:42:05 -0700 svg/custom/use-css-events.svg seems to have regressed on feature-branch Not sure when or how. But actual and expected images seem to disagree. 57975 1 eric 2007-10-06 19:34:47 -0700 The test case is still rather complicated. Not entirely sure what it's testing. 63035 2 17656 zimmermann 2007-12-02 16:54:22 -0800 Created attachment 17656 Initial patch Also fixes several existing other test cases (all regresssions). 63036 3 17656 aroben 2007-12-02 16:57:59 -0800 Comment on attachment 17656 Initial patch r=me 63038 4 zimmermann 2007-12-02 17:05:54 -0800 Landed in r28325. 63079 5 17656 eric 2007-12-02 21:45:20 -0800 Comment on attachment 17656 Initial patch Um, it's seems kinda lame that any code depends on inner SVG's having width() height() set on their renderer. width()/height() are HTML rendering tree concepts. I guess they can be re-used in this manner. 17656 2007-12-02 16:54:22 -0800 2007-12-02 16:57:59 -0800 Initial patch FixSVGCSSRegression.diff text/plain 3093 zimmermann SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDI4MzI0 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjMgQEAKKzIwMDctMTIt MDIgIE5pa29sYXMgWmltbWVybWFubiAgPHppbW1lcm1hbm5Aa2RlLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW5kZXJTVkdWaWV3cG9ydENv bnRhaW5lciBzZXRzIHdyb25nIHdpZHRoL2hlaWdodC4KKyAgICAgICAgU2hhcmUgY29kZSB3aXRo IFJlbmRlclNWR0NvbnRhaW5lciBpbiBhIGNlbnRyYWwgY2FsY0JvdW5kcygpIGZ1bmN0aW9uLgor CisgICAgICAgIEZpeGVzOgorICAgICAgICAtIHN2Zy9jdXN0b20vdXNlLWNzcy1ldmVudHMuc3Zn IChodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTQwMykKKyAgICAgICAg LSBzdmcvY3VzdG9tL2RlZXAtZHluYW1pYy11cGRhdGVzLnN2ZworICAgICAgICAtIHN2Zy9jdXN0 b20vdXNlLWNsaXBwZWQtaGl0LnN2ZworICAgICAgICAtIHN2Zy9jdXN0b20vaW1hZ2UtY2xpcHBl ZC1oaXQuc3ZnCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyU1ZHQ29udGFpbmVyLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclNWR0NvbnRhaW5lcjo6bGF5b3V0KToKKyAgICAgICAg KFdlYkNvcmU6OlJlbmRlclNWR0NvbnRhaW5lcjo6Y2FsY0JvdW5kcyk6CisgICAgICAgICogcmVu ZGVyaW5nL1JlbmRlclNWR0NvbnRhaW5lci5oOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJT VkdWaWV3cG9ydENvbnRhaW5lci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJTVkdWaWV3 cG9ydENvbnRhaW5lcjo6bGF5b3V0KToKKwogMjAwNy0xMi0wMiAgQnJhZHkgRWlkc29uIDxiZWlk c29uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbgpJbmRleDogcmVuZGVy aW5nL1JlbmRlclNWR0NvbnRhaW5lci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gcmVuZGVyaW5nL1JlbmRl clNWR0NvbnRhaW5lci5jcHAJKHJldmlzaW9uIDI4MzE4KQorKysgcmVuZGVyaW5nL1JlbmRlclNW R0NvbnRhaW5lci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI1NCwxMCArMjU0LDcgQEAgdm9pZCBS ZW5kZXJTVkdDb250YWluZXI6OmxheW91dCgpCiAgICAgICAgIEFTU0VSVCghY2hpbGQtPm5lZWRz TGF5b3V0KCkpOwogICAgIH0KIAotICAgIC8vIENhbGN1bGF0ZSB3aWR0aCAmIGhlaWdodAotICAg IG1fd2lkdGggPSBjYWxjUmVwbGFjZWRXaWR0aCgpOwotICAgIG1faGVpZ2h0ID0gY2FsY1JlcGxh Y2VkSGVpZ2h0KCk7Ci0gICAgbV9hYnNvbHV0ZUJvdW5kcyA9IGFic29sdXRlQ2xpcHBlZE92ZXJm bG93UmVjdCgpOworICAgIGNhbGNCb3VuZHMoKTsKIAogICAgIGlmIChjaGVja0ZvclJlcGFpbnQp CiAgICAgICAgIHJlcGFpbnRBZnRlckxheW91dElmTmVlZGVkKG9sZEJvdW5kcywgb2xkT3V0bGlu ZUJveCk7CkBAIC0zMDcsNiArMzA0LDEzIEBAIHZvaWQgUmVuZGVyU1ZHQ29udGFpbmVyOjphcHBs eUFkZGl0aW9uYWwKICAgICAvLyBuby1vcAogfQogCit2b2lkIFJlbmRlclNWR0NvbnRhaW5lcjo6 Y2FsY0JvdW5kcygpCit7CisgICAgbV93aWR0aCA9IGNhbGNSZXBsYWNlZFdpZHRoKCk7CisgICAg bV9oZWlnaHQgPSBjYWxjUmVwbGFjZWRIZWlnaHQoKTsKKyAgICBtX2Fic29sdXRlQm91bmRzID0g YWJzb2x1dGVDbGlwcGVkT3ZlcmZsb3dSZWN0KCk7Cit9CisKIGJvb2wgUmVuZGVyU1ZHQ29udGFp bmVyOjpzZWxmV2lsbFBhaW50KCkgY29uc3QKIHsKICNpZiBFTkFCTEUoU1ZHX0VYUEVSSU1FTlRB TF9GRUFUVVJFUykKSW5kZXg6IHJlbmRlcmluZy9SZW5kZXJTVkdDb250YWluZXIuaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSByZW5kZXJpbmcvUmVuZGVyU1ZHQ29udGFpbmVyLmgJKHJldmlzaW9uIDI4MzE4KQor KysgcmVuZGVyaW5nL1JlbmRlclNWR0NvbnRhaW5lci5oCSh3b3JraW5nIGNvcHkpCkBAIC05Miw2 ICs5Miw4IEBAIHByb3RlY3RlZDoKICAgICB2aXJ0dWFsIHZvaWQgYXBwbHlDb250ZW50VHJhbnNm b3JtcyhQYWludEluZm8mKTsKICAgICB2aXJ0dWFsIHZvaWQgYXBwbHlBZGRpdGlvbmFsVHJhbnNm b3JtcyhQYWludEluZm8mKTsKIAorICAgIHZvaWQgY2FsY0JvdW5kcygpOworCiBwcml2YXRlOgog ICAgIGludCBjYWxjUmVwbGFjZWRXaWR0aCgpIGNvbnN0OwogICAgIGludCBjYWxjUmVwbGFjZWRI ZWlnaHQoKSBjb25zdDsKSW5kZXg6IHJlbmRlcmluZy9SZW5kZXJTVkdWaWV3cG9ydENvbnRhaW5l ci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gcmVuZGVyaW5nL1JlbmRlclNWR1ZpZXdwb3J0Q29udGFpbmVy LmNwcAkocmV2aXNpb24gMjgzMTgpCisrKyByZW5kZXJpbmcvUmVuZGVyU1ZHVmlld3BvcnRDb250 YWluZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01OCwxMCArNTgsOCBAQCB2b2lkIFJlbmRlclNW R1ZpZXdwb3J0Q29udGFpbmVyOjpsYXlvdXQoCiAgICAgYm9vbCBjaGVja0ZvclJlcGFpbnQgPSBj aGVja0ZvclJlcGFpbnREdXJpbmdMYXlvdXQoKSAmJiBzZWxmTmVlZHNMYXlvdXQoKTsKICAgICBp ZiAoY2hlY2tGb3JSZXBhaW50KQogICAgICAgICBvbGRPdXRsaW5lQm94ID0gYWJzb2x1dGVPdXRs aW5lQm94KCk7Ci0gICAgCi0gICAgY2FsY1dpZHRoKCk7Ci0gICAgCi0gICAgbV9hYnNvbHV0ZUJv dW5kcyA9IGFic29sdXRlQ2xpcHBlZE92ZXJmbG93UmVjdCgpOworICAgCisgICAgY2FsY0JvdW5k cygpOwkKICAgICAKICAgICBmb3IgKFJlbmRlck9iamVjdCogY2hpbGQgPSBmaXJzdENoaWxkKCk7 IGNoaWxkOyBjaGlsZCA9IGNoaWxkLT5uZXh0U2libGluZygpKSB7CiAgICAgICAgIGlmIChzZWxm TmVlZHNMYXlvdXQoKSkK