154020 2016-02-08 16:53:46 -0800 B3::foldPathConstants() needs to execute its insertion set 2016-02-08 17:06:47 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 150279 1 fpizlo fpizlo commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1163065 0 fpizlo 2016-02-08 16:53:46 -0800 Patch forthcoming. 1163067 1 270895 fpizlo 2016-02-08 16:56:03 -0800 Created attachment 270895 the patch 1163068 2 commit-queue 2016-02-08 16:57:27 -0800 Attachment 270895 did not pass style-queue: ERROR: Source/JavaScriptCore/b3/testb3.cpp:10063: Consider using CHECK_EQ instead of CHECK(a == b) [readability/check] [2] ERROR: Source/JavaScriptCore/b3/testb3.cpp:10064: Consider using CHECK_EQ instead of CHECK(a == b) [readability/check] [2] ERROR: Source/JavaScriptCore/b3/testb3.cpp:10064: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/JavaScriptCore/b3/testb3.cpp:10065: Consider using CHECK_EQ instead of CHECK(a == b) [readability/check] [2] ERROR: Source/JavaScriptCore/b3/testb3.cpp:10065: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 5 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1163074 3 fpizlo 2016-02-08 17:06:47 -0800 Landed in http://trac.webkit.org/changeset/196280 270895 2016-02-08 16:56:03 -0800 2016-02-08 16:58:18 -0800 the patch blah.patch text/plain 2952 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk2Mjc5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE2LTAyLTA4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg QjM6OmZvbGRQYXRoQ29uc3RhbnRzKCkgbmVlZHMgdG8gZXhlY3V0ZSBpdHMgaW5zZXJ0aW9uIHNl dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU0MDIw CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBiMy9C M0ZvbGRQYXRoQ29uc3RhbnRzLmNwcDoKKyAgICAgICAgKiBiMy90ZXN0YjMuY3BwOgorICAgICAg ICAoSlNDOjpCMzo6dGVzdEZvbGRQYXRoRXF1YWwpOiBBZGRlZCB0aGlzLiBJdCB1c2VkIHRvIGNy YXNoIGluIHZhbGlkYXRpb24uCisgICAgICAgIChKU0M6OkIzOjpydW4pOgorCiAyMDE2LTAyLTA4 ICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgogCiAgICAgICAgIFtKU0Nd IEludHJvZHVjZSBAaXNPYmplY3QgYnl0ZWNvZGUgaW50cmluc2ljIGFuZCB1c2UgaXQgaW5zdGVh ZCBvZiBKUyBpbXBsZW1lbnRlZCBvbmUKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9C M0ZvbGRQYXRoQ29uc3RhbnRzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENv cmUvYjMvQjNGb2xkUGF0aENvbnN0YW50cy5jcHAJKHJldmlzaW9uIDE5NjI3MikKKysrIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9iMy9CM0ZvbGRQYXRoQ29uc3RhbnRzLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMTk0LDYgKzE5NCw3IEBAIHB1YmxpYzoKICAgICAgICAgICAgICAgICAgICAgICAgIGNo aWxkID0gb3ZlcnJpZGUudmFsdWVOb2RlOwogICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAg IH0KKyAgICAgICAgICAgIG1faW5zZXJ0aW9uU2V0LmV4ZWN1dGUoYmxvY2spOwogICAgICAgICB9 CiAKICAgICAgICAgaWYgKGNoYW5nZWQpIHsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9i My90ZXN0YjMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy90ZXN0 YjMuY3BwCShyZXZpc2lvbiAxOTYyNzIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvdGVz dGIzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTAwMzcsNiArMTAwMzcsMzQgQEAgdm9pZCB0ZXN0 VHJpdmlhbEluZmluaXRlTG9vcCgpCiAgICAgY29tcGlsZShwcm9jKTsKIH0KIAordm9pZCB0ZXN0 Rm9sZFBhdGhFcXVhbCgpCit7CisgICAgUHJvY2VkdXJlIHByb2M7CisgICAgQmFzaWNCbG9jayog cm9vdCA9IHByb2MuYWRkQmxvY2soKTsKKyAgICBCYXNpY0Jsb2NrKiB0aGVuQmxvY2sgPSBwcm9j LmFkZEJsb2NrKCk7CisgICAgQmFzaWNCbG9jayogZWxzZUJsb2NrID0gcHJvYy5hZGRCbG9jaygp OworCisgICAgVmFsdWUqIGFyZyA9IHJvb3QtPmFwcGVuZE5ldzxBcmd1bWVudFJlZ1ZhbHVlPihw cm9jLCBPcmlnaW4oKSwgR1BSSW5mbzo6YXJndW1lbnRHUFIwKTsKKworICAgIHJvb3QtPmFwcGVu ZE5ldzxDb250cm9sVmFsdWU+KAorICAgICAgICBwcm9jLCBCcmFuY2gsIE9yaWdpbigpLCBhcmcs IEZyZXF1ZW50ZWRCbG9jayh0aGVuQmxvY2spLCBGcmVxdWVudGVkQmxvY2soZWxzZUJsb2NrKSk7 CisKKyAgICB0aGVuQmxvY2stPmFwcGVuZE5ldzxDb250cm9sVmFsdWU+KAorICAgICAgICBwcm9j LCBSZXR1cm4sIE9yaWdpbigpLAorICAgICAgICB0aGVuQmxvY2stPmFwcGVuZE5ldzxWYWx1ZT4o CisgICAgICAgICAgICBwcm9jLCBFcXVhbCwgT3JpZ2luKCksIGFyZywgdGhlbkJsb2NrLT5hcHBl bmROZXc8Q29uc3RQdHJWYWx1ZT4ocHJvYywgT3JpZ2luKCksIDApKSk7CisKKyAgICBlbHNlQmxv Y2stPmFwcGVuZE5ldzxDb250cm9sVmFsdWU+KAorICAgICAgICBwcm9jLCBSZXR1cm4sIE9yaWdp bigpLAorICAgICAgICBlbHNlQmxvY2stPmFwcGVuZE5ldzxWYWx1ZT4oCisgICAgICAgICAgICBw cm9jLCBFcXVhbCwgT3JpZ2luKCksIGFyZywgZWxzZUJsb2NrLT5hcHBlbmROZXc8Q29uc3RQdHJW YWx1ZT4ocHJvYywgT3JpZ2luKCksIDApKSk7CisKKyAgICBhdXRvIGNvZGUgPSBjb21waWxlKHBy b2MpOworICAgIENIRUNLKGludm9rZTxpbnRwdHJfdD4oKmNvZGUsIDApID09IDEpOworICAgIENI RUNLKGludm9rZTxpbnRwdHJfdD4oKmNvZGUsIDEpID09IDApOworICAgIENIRUNLKGludm9rZTxp bnRwdHJfdD4oKmNvZGUsIDQyKSA9PSAwKTsKK30KKwogLy8gTWFrZSBzdXJlIHRoZSBjb21waWxl ciBkb2VzIG5vdCB0cnkgdG8gb3B0aW1pemUgYW55dGhpbmcgb3V0LgogTkVWRVJfSU5MSU5FIGRv dWJsZSB6ZXJvKCkKIHsKQEAgLTExNDM1LDEwICsxMTQ2Myw5IEBAIHZvaWQgcnVuKGNvbnN0IGNo YXIqIGZpbHRlcikKICAgICBSVU4odGVzdFNTaHJTaGw2NCgtNDIwMDAwMDAwMDAsIDgsIDgpKTsK IAogICAgIFJVTih0ZXN0Q2hlY2tNdWw2NFNTaHIoKSk7Ci0KICAgICBSVU4odGVzdENvbXB1dGVE aXZpc2lvbk1hZ2ljPGludDMyX3Q+KDIsIC0yMTQ3NDgzNjQ3LCAwKSk7Ci0KICAgICBSVU4odGVz dFRyaXZpYWxJbmZpbml0ZUxvb3AoKSk7CisgICAgUlVOKHRlc3RGb2xkUGF0aEVxdWFsKCkpOwog CiAgICAgaWYgKHRhc2tzLmlzRW1wdHkoKSkKICAgICAgICAgdXNhZ2UoKTsK