154016 2016-02-08 16:09:27 -0800 Web Inspector: Search doesn't seem to find text that is present in multiple places 2016-02-08 17:55:54 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1163051 0 joepeck 2016-02-08 16:09:27 -0800 * SUMMARY Search doesn't seem to find text that is present in multiple places. * STEPS TO REPRODUCE 1. Inspect https://www.icloud.com/#photos 2. Global search for “SFNSText” => doesn't seem to find results in packed.css => inspector seems broken (try 1+1 in console) * NOTES It looks like the inspector is sending search requests for the thousands of anonymous, unnamed script evaluations. While potentially useful, I don't think we should be including unnamed scripts when considering search. We should prioritize resources, named scripts, and the DOM. 1163052 1 joepeck 2016-02-08 16:09:34 -0800 <rdar://problem/23391307> 1163053 2 270891 joepeck 2016-02-08 16:11:05 -0800 Created attachment 270891 [PATCH] Proposed Fix 1163073 3 270891 bburg 2016-02-08 17:06:38 -0800 Comment on attachment 270891 [PATCH] Proposed Fix r=me 1163095 4 270891 commit-queue 2016-02-08 17:55:50 -0800 Comment on attachment 270891 [PATCH] Proposed Fix Clearing flags on attachment: 270891 Committed r196285: <http://trac.webkit.org/changeset/196285> 1163096 5 commit-queue 2016-02-08 17:55:54 -0800 All reviewed patches have been landed. Closing bug. 270891 2016-02-08 16:11:05 -0800 2016-02-08 17:55:50 -0800 [PATCH] Proposed Fix searching.patch text/plain 2672 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDUzNWQzYmIuLmQ4MWY3YmIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDE2LTAyLTA4ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogU2VhcmNo IGRvZXNuJ3Qgc2VlbSB0byBmaW5kIHRleHQgdGhhdCBpcyBwcmVzZW50IGluIG11bHRpcGxlIHBs YWNlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU0 MDE2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yMzM5MTMwNz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvQ29udHJvbGxl cnMvRGVidWdnZXJNYW5hZ2VyLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRlYnVnZ2VyTWFu YWdlci5wcm90b3R5cGUuZ2V0IHNlYXJjaGFibGVTY3JpcHRzKToKKyAgICAgICAgKiBVc2VySW50 ZXJmYWNlL1ZpZXdzL1NlYXJjaFNpZGViYXJQYW5lbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rv ci5TZWFyY2hTaWRlYmFyUGFuZWwucHJvdG90eXBlLnBlcmZvcm1TZWFyY2gpOgorICAgICAgICBP bmx5IHNlYXJjaCBzY3JpcHRzIHdpdGggYSBVUkwuIERvbid0IHNlYXJjaCB0aGUgcG90ZW50aWFs bHkKKyAgICAgICAgbGFyZ2UgbnVtYmVyIG9mIGFub255bW91cyBzY3JpcHRzLgorCisyMDE2LTAy LTA4ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAgICAgV2Vi IEluc3BlY3RvcjogWm9vbWluZyBpbiBvbiB0aGUgdGltZWxpbmUgZ3JhcGggZG9lcyBub3QgaW5j cmVhc2UgaXRzIHRpbWUgcmVzb2x1dGlvbiBmcm9tIG1pbnV0ZXMKICAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NDAxMwogICAgICAgICA8cmRhcjovL3By b2JsZW0vMjM4NDQ1Mjc+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9Db250cm9sbGVycy9EZWJ1Z2dlck1hbmFnZXIuanMgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9EZWJ1Z2dlck1hbmFnZXIuanMKaW5kZXgg NDI3YWRiMC4uMzQ0NDRmZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvQ29udHJvbGxlcnMvRGVidWdnZXJNYW5hZ2VyLmpzCisrKyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0RlYnVnZ2VyTWFuYWdlci5qcwpA QCAtMzE2LDYgKzMxNiwxMSBAQCBXZWJJbnNwZWN0b3IuRGVidWdnZXJNYW5hZ2VyID0gY2xhc3Mg RGVidWdnZXJNYW5hZ2VyIGV4dGVuZHMgV2ViSW5zcGVjdG9yLk9iamVjdAogICAgICAgICBEZWJ1 Z2dlckFnZW50LmNvbnRpbnVlVG9Mb2NhdGlvbih7c2NyaXB0SWQ6IHNjcmlwdElkZW50aWZpZXIs IGxpbmVOdW1iZXIsIGNvbHVtbk51bWJlcn0pOwogICAgIH0KIAorICAgIGdldCBzZWFyY2hhYmxl U2NyaXB0cygpCisgICAgeworICAgICAgICByZXR1cm4gdGhpcy5rbm93bk5vblJlc291cmNlU2Ny aXB0cy5maWx0ZXIoKHNjcmlwdCkgPT4gISFzY3JpcHQudXJsKTsKKyAgICB9CisKICAgICBnZXQg a25vd25Ob25SZXNvdXJjZVNjcmlwdHMoKQogICAgIHsKICAgICAgICAgbGV0IGtub3duU2NyaXB0 cyA9IFtdOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvU2VhcmNoU2lkZWJhclBhbmVsLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvU2VhcmNoU2lkZWJhclBhbmVsLmpzCmluZGV4IDgxYzg1ODguLmJkMDVm ZDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L1NlYXJjaFNpZGViYXJQYW5lbC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9WaWV3cy9TZWFyY2hTaWRlYmFyUGFuZWwuanMKQEAgLTI3MCw3ICsyNzAsNyBAQCBX ZWJJbnNwZWN0b3IuU2VhcmNoU2lkZWJhclBhbmVsID0gY2xhc3MgU2VhcmNoU2lkZWJhclBhbmVs IGV4dGVuZHMgV2ViSW5zcGVjdG9yLgogICAgICAgICBpZiAod2luZG93LlBhZ2VBZ2VudCkKICAg ICAgICAgICAgIFBhZ2VBZ2VudC5zZWFyY2hJblJlc291cmNlcyhzZWFyY2hRdWVyeSwgaXNDYXNl U2Vuc2l0aXZlLCBpc1JlZ2V4LCByZXNvdXJjZXNDYWxsYmFjay5iaW5kKHRoaXMpKTsKIAotICAg ICAgICBzZXRUaW1lb3V0KHNlYXJjaFNjcmlwdHMuYmluZCh0aGlzLCBXZWJJbnNwZWN0b3IuZGVi dWdnZXJNYW5hZ2VyLmtub3duTm9uUmVzb3VyY2VTY3JpcHRzKSwgMCk7CisgICAgICAgIHNldFRp bWVvdXQoc2VhcmNoU2NyaXB0cy5iaW5kKHRoaXMsIFdlYkluc3BlY3Rvci5kZWJ1Z2dlck1hbmFn ZXIuc2VhcmNoYWJsZVNjcmlwdHMpLCAwKTsKIAogICAgICAgICBpZiAod2luZG93LkRPTUFnZW50 KSB7CiAgICAgICAgICAgICBpZiAodGhpcy5fZG9tU2VhcmNoSWRlbnRpZmllcikgewo=