154006 2016-02-08 13:48:42 -0800 Web Inspector: ⇧⌘→ when editing text in the Elements tree shouldn't switch inspector tab 2016-02-11 22:12:31 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=154154 InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1163002 0 joepeck 2016-02-08 13:48:42 -0800 * SUMMARY ⇧⌘→ when editing text in the Elements tree shouldn't switch inspector tab * STEPS TO REPRODUCE 1. Inspect this page 2. Start editing a DOM element attribute 3. ⇧⌘→ => expected selection change, not tab switch 1163003 1 joepeck 2016-02-08 13:48:49 -0800 <rdar://problem/22892489> 1163004 2 270880 joepeck 2016-02-08 13:49:42 -0800 Created attachment 270880 [PATCH] Proposed Fix 1163008 3 270880 commit-queue 2016-02-08 14:07:52 -0800 Comment on attachment 270880 [PATCH] Proposed Fix Clearing flags on attachment: 270880 Committed r196271: <http://trac.webkit.org/changeset/196271> 1163009 4 commit-queue 2016-02-08 14:07:56 -0800 All reviewed patches have been landed. Closing bug. 270880 2016-02-08 13:49:42 -0800 2016-02-08 14:07:52 -0800 [PATCH] Proposed Fix editing.patch text/plain 1407 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDdiOWMyZTkuLmE1Y2UxNDggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE2LTAyLTA4ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3Rvcjog4oen4oyY 4oaSIHdoZW4gZWRpdGluZyB0ZXh0IGluIHRoZSBFbGVtZW50cyB0cmVlIHNob3VsZG4ndCBzd2l0 Y2ggaW5zcGVjdG9yIHRhYgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTU0MDA2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yMjg5MjQ4OT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZh Y2UvVmlld3MvRWRpdGluZ1N1cHBvcnQuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuaXNFdmVu dFRhcmdldEFuRWRpdGFibGVGaWVsZCk6CisgICAgICAgIENoZWNrIHRoZSBXZWJJbnNwZWN0b3In cyBjdXN0b20gX19lZGl0aW5nIHN0YXRlLgorCisyMDE2LTAyLTA4ICBKb3NlcGggUGVjb3Jhcm8g IDxwZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogVW5jYXVnaHQg ZXhjZXB0aW9uIG1lcmdpbmcgc2NyaXB0IHByb2ZpbGVyIHJlY29yZHMKICAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NDAwNAogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9FZGl0aW5nU3VwcG9ydC5q cyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0VkaXRpbmdTdXBw b3J0LmpzCmluZGV4IGQ2M2ViMWQuLjNhZDkyMjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0VkaXRpbmdTdXBwb3J0LmpzCisrKyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0VkaXRpbmdTdXBwb3J0LmpzCkBA IC03MSw2ICs3MSw5IEBAIFdlYkluc3BlY3Rvci5pc0V2ZW50VGFyZ2V0QW5FZGl0YWJsZUZpZWxk ID0gZnVuY3Rpb24oZXZlbnQpCiAgICAgaWYgKGV2ZW50LnRhcmdldC5lbmNsb3NpbmdOb2RlT3JT ZWxmV2l0aENsYXNzKCJ0ZXh0LXByb21wdCIpKQogICAgICAgICByZXR1cm4gdHJ1ZTsKIAorICAg IGlmIChXZWJJbnNwZWN0b3IuaXNCZWluZ0VkaXRlZChldmVudC50YXJnZXQpKQorICAgICAgICBy ZXR1cm4gdHJ1ZTsKKwogICAgIHJldHVybiBmYWxzZTsKIH07CiAK