154004 2016-02-08 13:41:13 -0800 Web Inspector: Uncaught exception merging script profiler records 2016-02-08 19:33:24 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1162995 0 joepeck 2016-02-08 13:41:13 -0800 * SUMMARY Uncaught exception merging script profiler records. [Error] Uncaught exception in inspector page while handling event ScriptProfiler.trackingComplete TypeError: null is not an object (evaluating 'record2.startTime') 1162996 1 webkit-bug-importer 2016-02-08 13:41:42 -0800 <rdar://problem/24554961> 1162998 2 270879 joepeck 2016-02-08 13:42:12 -0800 Created attachment 270879 [PATCH] Proposed Fix 1163000 3 270879 bburg 2016-02-08 13:46:53 -0800 Comment on attachment 270879 [PATCH] Proposed Fix r=me is there a way to test this regression? 1163122 4 joepeck 2016-02-08 19:05:46 -0800 > is there a way to test this regression? There is a lot in TimelineManager that we probably should be testing. But I'd rather leave it until we rewrite some more of this code later. The Web wrapping events stuff is unfortunate. As we get closer to a ProfileView and TimelinesUI stuff, we might even be able to drop some of this code. 1163131 5 270879 commit-queue 2016-02-08 19:33:20 -0800 Comment on attachment 270879 [PATCH] Proposed Fix Clearing flags on attachment: 270879 Committed r196301: <http://trac.webkit.org/changeset/196301> 1163132 6 commit-queue 2016-02-08 19:33:24 -0800 All reviewed patches have been landed. Closing bug. 270879 2016-02-08 13:42:12 -0800 2016-02-08 19:33:20 -0800 [PATCH] Proposed Fix uncaught.patch text/plain 1716 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDk5YTRlMjkuLjdiOWMyZTkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE2LTAyLTA4ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVW5jYXVn aHQgZXhjZXB0aW9uIG1lcmdpbmcgc2NyaXB0IHByb2ZpbGVyIHJlY29yZHMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NDAwNAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9Db250 cm9sbGVycy9UaW1lbGluZU1hbmFnZXIuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGltZWxp bmVNYW5hZ2VyLnByb3RvdHlwZS5fbWVyZ2VTY3JpcHRQcm9maWxlUmVjb3Jkcyk6CisgICAgICAg IFN0b3AgaWYgd2UndmUgbWVyZ2VkIGFsbCBzY3JpcHQgcHJvZmlsZXIgcmVjb3Jkcy4KKwogMjAx Ni0wMi0wNSAgTmlraXRhIFZhc2lseWV2ICA8bnZhc2lseWV2QGFwcGxlLmNvbT4KIAogICAgICAg ICBSRUdSRVNTSU9OIChyMTkzOTEzKTogV2ViIEluc3BlY3RvcjogV3Jvbmcgei1pbmRleCBvZiBp bm5lciBzZWN0aW9ucwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvQ29udHJvbGxlcnMvVGltZWxpbmVNYW5hZ2VyLmpzIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvVGltZWxpbmVNYW5hZ2VyLmpzCmluZGV4IGFh ODIwNWEuLmM5ZGE2OTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL0NvbnRyb2xsZXJzL1RpbWVsaW5lTWFuYWdlci5qcworKysgYi9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9UaW1lbGluZU1hbmFnZXIuanMKQEAg LTc1MSw3ICs3NTEsNyBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVNYW5hZ2VyID0gY2xhc3MgVGlt ZWxpbmVNYW5hZ2VyIGV4dGVuZHMgV2ViSW5zcGVjdG9yLk9iamVjdAogICAgICAgICBsZXQgd2Vi UmVjb3JkID0gbmV4dFdlYlRpbWVsaW5lUmVjb3JkKCk7CiAgICAgICAgIGxldCBwcm9maWxlclJl Y29yZCA9IG5leHRTY3JpcHRQcm9maWxlclJlY29yZCgpOwogCi0gICAgICAgIHdoaWxlICh3ZWJS ZWNvcmQpIHsKKyAgICAgICAgd2hpbGUgKHdlYlJlY29yZCAmJiBwcm9maWxlclJlY29yZCkgewog ICAgICAgICAgICAgLy8gU2tpcCB3ZWIgcmVjb3JkcyB3aXRoIHBhcmVudCB3ZWIgcmVjb3Jkcy4g Rm9yIGV4YW1wbGUgYW4gRXZhbHVhdGVTY3JpcHQgd2l0aCBhbiBFdmFsdWF0ZVNjcmlwdCBwYXJl bnQuCiAgICAgICAgICAgICBpZiAod2ViUmVjb3JkLnBhcmVudCBpbnN0YW5jZW9mIFdlYkluc3Bl Y3Rvci5TY3JpcHRUaW1lbGluZVJlY29yZCkgewogICAgICAgICAgICAgICAgIGNvbnNvbGUuYXNz ZXJ0KHJlY29yZEVuY2xvc2VzUmVjb3JkKHdlYlJlY29yZC5wYXJlbnQsIHdlYlJlY29yZCksICJU aW1lbGluZSBSZWNvcmQgaW5jb3JyZWN0bHkgd3JhcHBpbmcgYW5vdGhlciBUaW1lbGluZSBSZWNv cmQiKTsK