154002 2016-02-08 12:35:42 -0800 CodeCache should give up on evals if there are variables under TDZ 2016-02-08 14:35:54 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 154010 1 fpizlo fpizlo commit-queue ggaren keith_miller mark.lam msaboff saam oldest_to_newest 1162979 0 fpizlo 2016-02-08 12:35:42 -0800 This is pretty sad, and it's another reason why we should not have used a separate check_tdz opcode to check TDZ of scoped variable loads. 1162981 1 270875 fpizlo 2016-02-08 12:43:14 -0800 Created attachment 270875 the patch 1162982 2 270875 mark.lam 2016-02-08 12:46:59 -0800 Comment on attachment 270875 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=270875&action=review r=me > Source/JavaScriptCore/ChangeLog:16 > + compilersm and caches can see the intended meaning of the bytecode more easily. typo: compilersm ==> compilers 1163021 3 fpizlo 2016-02-08 14:35:54 -0800 Landed in http://trac.webkit.org/changeset/196272 270875 2016-02-08 12:43:14 -0800 2016-02-08 12:46:59 -0800 the patch blah.patch text/plain 2444 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk2MjY2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBA CisyMDE2LTAyLTA4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg Q29kZUNhY2hlIHNob3VsZCBnaXZlIHVwIG9uIGV2YWxzIGlmIHRoZXJlIGFyZSB2YXJpYWJsZXMg dW5kZXIgVERaCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNTQwMDIKKyAgICAgICAgcmRhcjovL3Byb2JsZW0vMjQzMDA5OTgKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEaXNhYmxlIHRoZSBjb2RlIGNhY2hl IG9wdGltaXphdGlvbiBiZWNhdXNlIG91ciBhcHByb2FjaCB0byBURFogZm9yIHNjb3BlZCB2YXJp YWJsZXMgLSB1c2luZworICAgICAgICBhIHNlcGFyYXRlIGNoZWNrX3RkeiBvcGNvZGUgd2hlbiBs b2dpY2FsbHkgaXQncyB0aGUgZ2V0X2Zyb21fc2NvcGUncyBqb2IgdG8gZG8gaXQgLSBtYWtlcwor ICAgICAgICBjYWNoaW5nIGNvZGUgaW1wb3NzaWJsZSBpZiB0aGVyZSBhcmUgYW55IHZhcmlhYmxl cyBpbiBURFouCisKKyAgICAgICAgV2Ugc2hvdWxkIGRvIHRoZSByaWdodCB0aGluZyBpbiB0aGUg ZnV0dXJlLCBhbmQgZm9sZCB0aGUgVERaIGNoZWNrIGludG8gdGhlIGdldF9mcm9tX3Njb3BlLgor ICAgICAgICBUaGlzIGlzIGJldHRlciBub3Qgb25seSBiZWNhdXNlIGl0IHdpbGwgcmVzdG9yZSBj YWNoaW5nLCBidXQgYmVjYXVzZSBvdXIgYnl0ZWNvZGUgZm9yIGhlYXAKKyAgICAgICAgYWNjZXNz ZXMgaXMgdXN1YWxseSBhdCB0aGUgaGlnaGVzdCBwcmFjdGljYWxseSBkb2FibGUgbGV2ZWwgb2Yg YWJzdHJhY3Rpb24sIHNvIHRoYXQgSUNzLAorICAgICAgICBjb21waWxlcnNtIGFuZCBjYWNoZXMg Y2FuIHNlZSB0aGUgaW50ZW5kZWQgbWVhbmluZyBvZiB0aGUgYnl0ZWNvZGUgbW9yZSBlYXNpbHku CisKKyAgICAgICAgKiBydW50aW1lL0NvZGVDYWNoZS5jcHA6CisgICAgICAgIChKU0M6OkNvZGVD YWNoZTo6Z2V0R2xvYmFsQ29kZUJsb2NrKToKKwogMjAxNi0wMi0wOCAgU2thY2hrb3YgT2xla3Nh bmRyICA8Z3NrYWNoa292QGdtYWlsLmNvbT4KIAogICAgICAgICBbRVM2XSBBcnJvdyBmdW5jdGlv biBzeW50YXguIFVzaW5nICdzdXBlcicgaW4gYXJyb3cgZnVuY3Rpb24gdGhhdCBkZWNsYXJlZCBv dXQgb2YgdGhlIGNsYXNzIHNob3VsZCBsZWFkIHRvIFN5bnRheCBlcnJvcgpJbmRleDogU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29kZUNhY2hlLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Db2RlQ2FjaGUuY3BwCShyZXZpc2lvbiAxOTYyNTcp CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Db2RlQ2FjaGUuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC04Nyw3ICs4Nyw3IEBAIFVubGlua2VkQ29kZUJsb2NrVHlwZSogQ29kZUNhY2hl OjpnZXRHbG8KIHsKICAgICBTb3VyY2VDb2RlS2V5IGtleSA9IFNvdXJjZUNvZGVLZXkoc291cmNl LCBTdHJpbmcoKSwgQ2FjaGVUeXBlczxVbmxpbmtlZENvZGVCbG9ja1R5cGU+Ojpjb2RlVHlwZSwg YnVpbHRpbk1vZGUsIHN0cmljdE1vZGUsIHRoaXNURFpNb2RlKTsKICAgICBTb3VyY2VDb2RlVmFs dWUqIGNhY2hlID0gbV9zb3VyY2VDb2RlLmZpbmRDYWNoZUFuZFVwZGF0ZUFnZShrZXkpOwotICAg IGJvb2wgY2FuQ2FjaGUgPSBkZWJ1Z2dlck1vZGUgPT0gRGVidWdnZXJPZmYgJiYgcHJvZmlsZXJN b2RlID09IFByb2ZpbGVyT2ZmICYmICF2bS50eXBlUHJvZmlsZXIoKSAmJiAhdm0uY29udHJvbEZs b3dQcm9maWxlcigpOworICAgIGJvb2wgY2FuQ2FjaGUgPSBkZWJ1Z2dlck1vZGUgPT0gRGVidWdn ZXJPZmYgJiYgcHJvZmlsZXJNb2RlID09IFByb2ZpbGVyT2ZmICYmICF2bS50eXBlUHJvZmlsZXIo KSAmJiAhdm0uY29udHJvbEZsb3dQcm9maWxlcigpICYmICF2YXJpYWJsZXNVbmRlclREWi0+c2l6 ZSgpOwogICAgIGlmIChjYWNoZSAmJiBjYW5DYWNoZSkgewogICAgICAgICBVbmxpbmtlZENvZGVC bG9ja1R5cGUqIHVubGlua2VkQ29kZUJsb2NrID0ganNDYXN0PFVubGlua2VkQ29kZUJsb2NrVHlw ZSo+KGNhY2hlLT5jZWxsLmdldCgpKTsKICAgICAgICAgdW5zaWduZWQgZmlyc3RMaW5lID0gc291 cmNlLmZpcnN0TGluZSgpICsgdW5saW5rZWRDb2RlQmxvY2stPmZpcnN0TGluZSgpOwo=