153995 2016-02-08 11:06:00 -0800 Infinite loop when processing mouse events synchronously 2016-02-08 11:41:20 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 153740 1 cgarcia webkit-unassigned andersca bugs-noreply darin sam oldest_to_newest 1162933 0 cgarcia 2016-02-08 11:06:00 -0800 This happened with WTR in the GTK+ port after landing patch in bug #153740. The thing is that WTR forces events handling IPC messages to be synchronous. When a drag and drop operation is in progress, the web process ignores mouse move events and replies with DidReceiveEvent signal. The DidReceiveEvent message handler in WebPageProxy checks if we have a m_nextMouseMoveEvent and handles it, but when all this happens synchronously the m_nextMouseMoveEvent is the current one because we haven't returned yet from handleMouseEvent(). We need to invalidate the m_nextMouseMoveEvent before calling handleMouseEvent(). #0 0x00007ffff5bbb133 in IPC::Connection::sendMessage(std::unique_ptr<IPC::MessageEncoder, std::default_delete<IPC::MessageEncoder> >, unsigned int, bool) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #1 0x00007ffff5bbc48c in IPC::Connection::sendSyncMessage(unsigned long, std::unique_ptr<IPC::MessageEncoder, std::default_delete<IPC::MessageEncoder> >, std::chrono::duration<long, std::ratio<1l, 1000l> >, unsigned int) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #2 0x00007ffff5bbb1f5 in IPC::Connection::sendMessage(std::unique_ptr<IPC::MessageEncoder, std::default_delete<IPC::MessageEncoder> >, unsigned int, bool) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #3 0x00007ffff5c20e37 in WebKit::ChildProcessProxy::sendMessage(std::unique_ptr<IPC::MessageEncoder, std::default_delete<IPC::MessageEncoder> >, unsigned int) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #4 0x00007ffff5c5c02a in bool WebKit::ChildProcessProxy::send<Messages::WebPage::MouseEvent>(Messages::WebPage::MouseEvent&&, unsigned long, unsigned int) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #5 0x00007ffff5c4579c in WebKit::WebPageProxy::handleMouseEvent(WebKit::NativeWebMouseEvent const&) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #6 0x00007ffff5c5170a in WebKit::WebPageProxy::didReceiveEvent(unsigned int, bool) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #7 0x00007ffff5e686f7 in WebKit::WebPageProxy::didReceiveMessage(IPC::Connection&, IPC::MessageDecoder&) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #8 0x00007ffff5bbf039 in IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::MessageDecoder&) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #9 0x00007ffff5c75102 in WebKit::WebProcessProxy::didReceiveMessage(IPC::Connection&, IPC::MessageDecoder&) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #10 0x00007ffff5bbb546 in IPC::Connection::dispatchMessage(std::unique_ptr<IPC::MessageDecoder, std::default_delete<IPC::MessageDecoder> >) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #11 0x00007ffff5bbb89e in IPC::Connection::SyncMessageState::dispatchMessages(IPC::Connection*) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #12 0x00007ffff5bbb4a1 in IPC::Connection::dispatchSyncMessage(IPC::MessageDecoder&) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #13 0x00007ffff5bbb5bd in IPC::Connection::dispatchMessage(std::unique_ptr<IPC::MessageDecoder, std::default_delete<IPC::MessageDecoder> >) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #14 0x00007ffff5bbb89e in IPC::Connection::SyncMessageState::dispatchMessages(IPC::Connection*) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #15 0x00007ffff5bbbd8f in IPC::Connection::waitForSyncReply(unsigned long, std::chrono::duration<long, std::ratio<1l, 1000l> >, unsigned int) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #16 0x00007ffff5bbc4b8 in IPC::Connection::sendSyncMessage(unsigned long, std::unique_ptr<IPC::MessageEncoder, std::default_delete<IPC::MessageEncoder> >, std::chrono::duration<long, std::ratio<1l, 1000l> >, unsigned int) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #17 0x00007ffff5bbb1f5 in IPC::Connection::sendMessage(std::unique_ptr<IPC::MessageEncoder, std::default_delete<IPC::MessageEncoder> >, unsigned int, bool) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #18 0x00007ffff5c20e37 in WebKit::ChildProcessProxy::sendMessage(std::unique_ptr<IPC::MessageEncoder, std::default_delete<IPC::MessageEncoder> >, unsigned int) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 ...... 1162935 1 270867 cgarcia 2016-02-08 11:08:12 -0800 Created attachment 270867 Patch 1162939 2 270867 darin 2016-02-08 11:13:21 -0800 Comment on attachment 270867 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270867&action=review > Source/WebKit2/UIProcess/WebPageProxy.cpp:4581 > + auto nextMouseMoveEvent = WTFMove(m_nextMouseMoveEvent); > + handleMouseEvent(*nextMouseMoveEvent); Could also write this as a one-liner using std::exchange. 1162944 3 cgarcia 2016-02-08 11:20:17 -0800 (In reply to comment #2) > Comment on attachment 270867 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=270867&action=review > > > Source/WebKit2/UIProcess/WebPageProxy.cpp:4581 > > + auto nextMouseMoveEvent = WTFMove(m_nextMouseMoveEvent); > > + handleMouseEvent(*nextMouseMoveEvent); > > Could also write this as a one-liner using std::exchange. Right, good point. 1162961 4 cgarcia 2016-02-08 11:41:20 -0800 Committed r196264: <http://trac.webkit.org/changeset/196264> 270867 2016-02-08 11:08:12 -0800 2016-02-08 11:13:21 -0800 Patch wk2-infinite-loop.diff text/plain 2093 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBiNmZjMTZlLi4zYzY4YmZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjYg QEAKIDIwMTYtMDItMDggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCisgICAgICAgIEluZmluaXRlIGxvb3Agd2hlbiBwcm9jZXNzaW5nIG1vdXNlIGV2ZW50cyBz eW5jaHJvbm91c2x5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNTM5OTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUaGlzIGhhcHBlbmVkIHdpdGggV1RSIGluIHRoZSBHVEsrIHBvcnQgYWZ0ZXIgbGFuZGlu ZyBwYXRjaCBpbiBidWcKKyAgICAgICAgIzE1Mzc0MC4gVGhlIHRoaW5nIGlzIHRoYXQgV1RSIGZv cmNlcyBldmVudHMgaGFuZGxpbmcgSVBDIG1lc3NhZ2VzCisgICAgICAgIHRvIGJlIHN5bmNocm9u b3VzLiBXaGVuIGEgZHJhZyBhbmQgZHJvcCBvcGVyYXRpb24gaXMgaW4gcHJvZ3Jlc3MsCisgICAg ICAgIHRoZSB3ZWIgcHJvY2VzcyBpZ25vcmVzIG1vdXNlIG1vdmUgZXZlbnRzIGFuZCByZXBsaWVz IHdpdGgKKyAgICAgICAgRGlkUmVjZWl2ZUV2ZW50IHNpZ25hbC4gVGhlIERpZFJlY2VpdmVFdmVu dCBtZXNzYWdlIGhhbmRsZXIgaW4KKyAgICAgICAgV2ViUGFnZVByb3h5IGNoZWNrcyBpZiB3ZSBo YXZlIGEgbV9uZXh0TW91c2VNb3ZlRXZlbnQgYW5kIGhhbmRsZXMKKyAgICAgICAgaXQsIGJ1dCB3 aGVuIGFsbCB0aGlzIGhhcHBlbnMgc3luY2hyb25vdXNseSB0aGUKKyAgICAgICAgbV9uZXh0TW91 c2VNb3ZlRXZlbnQgaXMgdGhlIGN1cnJlbnQgb25lIGJlY2F1c2Ugd2UgaGF2ZW4ndAorICAgICAg ICByZXR1cm5lZCB5ZXQgZnJvbSBoYW5kbGVNb3VzZUV2ZW50KCkuIFdlIG5lZWQgdG8gaW52YWxp ZGF0ZSB0aGUKKyAgICAgICAgbV9uZXh0TW91c2VNb3ZlRXZlbnQgYmVmb3JlIGNhbGxpbmcgaGFu ZGxlTW91c2VFdmVudCgpLgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHA6 CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6ZGlkUmVjZWl2ZUV2ZW50KToKKworMjAx Ni0wMi0wOCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKICAg ICAgICAgW0dUS10gV2ViS2l0V2ViVmlldyBzaG91bGQgc2VuZCBjcm9zc2luZyBldmVudHMgdG8g dGhlIFdlYlByb2Nlc3MKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE1Mzc0MAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2Vi UGFnZVByb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3Bw CmluZGV4IDcxNjUxZWEuLjM4MjRhZDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9XZWJQYWdlUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQ YWdlUHJveHkuY3BwCkBAIC00NTc3LDggKzQ1NzcsOCBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6ZGlk UmVjZWl2ZUV2ZW50KHVpbnQzMl90IG9wYXF1ZVR5cGUsIGJvb2wgaGFuZGxlZCkKICAgICBjYXNl IFdlYkV2ZW50OjpNb3VzZU1vdmU6CiAgICAgICAgIG1fcHJvY2Vzc2luZ01vdXNlTW92ZUV2ZW50 ID0gZmFsc2U7CiAgICAgICAgIGlmIChtX25leHRNb3VzZU1vdmVFdmVudCkgewotICAgICAgICAg ICAgaGFuZGxlTW91c2VFdmVudCgqbV9uZXh0TW91c2VNb3ZlRXZlbnQpOwotICAgICAgICAgICAg bV9uZXh0TW91c2VNb3ZlRXZlbnQgPSBudWxscHRyOworICAgICAgICAgICAgYXV0byBuZXh0TW91 c2VNb3ZlRXZlbnQgPSBXVEZNb3ZlKG1fbmV4dE1vdXNlTW92ZUV2ZW50KTsKKyAgICAgICAgICAg IGhhbmRsZU1vdXNlRXZlbnQoKm5leHRNb3VzZU1vdmVFdmVudCk7CiAgICAgICAgIH0KICAgICAg ICAgYnJlYWs7CiAgICAgY2FzZSBXZWJFdmVudDo6TW91c2VEb3duOgo=