153989 2016-02-08 09:29:10 -0800 [GTK] WebKit2Gtk crashes when creating a webview with g_object_new. 2016-02-08 10:43:26 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 danilo.eu webkit-unassigned berto bugs-noreply cgarcia commit-queue gustavo mcatanzaro mrobinson oldest_to_newest 1162896 0 danilo.eu 2016-02-08 09:29:10 -0800 WebKit2Gtk crashes when creating a WebView with g_object_new(WEBKIT_TYPE_WEB_VIEW, NULL). It happens because _WebViewBasePrivate is initialized with a call to RunLoop::main(), but it has never been initialized (as it's only initialized when we get a context, like the webkit_get_default_context() call). Initializing only the RunLoop causes other issue, so I realized that a full call to WebKit2Initialize should be made. Patch is coming next... 1162897 1 270858 danilo.eu 2016-02-08 09:33:29 -0800 Created attachment 270858 patch v1 1162899 2 commit-queue 2016-02-08 09:36:06 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1162902 3 270858 cgarcia 2016-02-08 09:53:39 -0800 Comment on attachment 270858 patch v1 Thanks! 1162919 4 270858 commit-queue 2016-02-08 10:43:21 -0800 Comment on attachment 270858 patch v1 Clearing flags on attachment: 270858 Committed r196257: <http://trac.webkit.org/changeset/196257> 1162920 5 commit-queue 2016-02-08 10:43:26 -0800 All reviewed patches have been landed. Closing bug. 270858 2016-02-08 09:33:29 -0800 2016-02-08 10:43:21 -0800 patch v1 0001-GTK-Fix-crash-when-creating-webview-with-g_object_ne.patch text/plain 2800 danilo.eu RnJvbSBiZTgwZDQ0ZDQwYTUzZDY0MjVkMzkzZTFlYmE5ZjdlNDQxNWM3ODM1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYW5pbG8gQ2VzYXIgTGVtZXMgZGUgUGF1bGEgPGRhbmlsby5j ZXNhckBjb2xsYWJvcmEuY28udWs+CkRhdGU6IE1vbiwgOCBGZWIgMjAxNiAxNToyOTo0MCAtMDIw MApTdWJqZWN0OiBbUEFUQ0hdIFtHVEtdIEZpeCBjcmFzaCB3aGVuIGNyZWF0aW5nIHdlYnZpZXcg d2l0aCBnX29iamVjdF9uZXcKCmh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNTM5ODkKZ19vYmplY3RfbmV3KFdFQktJVF9UWVBFX1dFQl9WSUVXLCBOVUxMKSBjcmFzaGVz IHdlYmtpdAphcyBfV2ViS2l0V2ViVmlld0Jhc2VQcml2YXRlIGNvbnN0cnVjdG9yIHJlcXVpcmVz IGEgbWFpbmxvb3AsIGJ1dAp3ZWJraXQgaXMgb25seSBpbml0aWFsaXplZCB3aGVuIGEgY29udGV4 dCBpcyBjcmVhdGVkICh3aGljaApkb2Vzbid0IGhhcHBlbiB3aXRoIGEgZGlyZWN0IGNhbGwgdG8g Z19vYmplY3RfbmV3KS4KLS0tCiBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgfCAxNSArKysrKysrKysrKysrKysKIFNvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcCB8ICA2ICsrKysrKwogMiBmaWxl cyBjaGFuZ2VkLCAyMSBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv Q2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IDBhMWU1MzAuLmJjMzkw ODIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxNi0wMi0wOCAgRGFuaWxvIENlc2Fy IExlbWVzIGRlIFBhdWxhICA8ZGFuaWxvLmNlc2FyQGNvbGxhYm9yYS5jby51az4KKworICAgICAg ICBbR1RLXSBGaXggY3Jhc2ggd2hlbiBjcmVhdGluZyB3ZWJ2aWV3IHdpdGggZ19vYmplY3RfbmV3 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTM5ODkK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBnX29iamVj dF9uZXcoV0VCS0lUX1RZUEVfV0VCX1ZJRVcsIE5VTEwpIGNyYXNoZXMgd2Via2l0CisgICAgICAg IGFzIF9XZWJLaXRXZWJWaWV3QmFzZVByaXZhdGUgY29uc3RydWN0b3IgcmVxdWlyZXMgYSBtYWlu bG9vcCwgYnV0CisgICAgICAgIHdlYmtpdCBpcyBvbmx5IGluaXRpYWxpemVkIHdoZW4gYSBjb250 ZXh0IGlzIGNyZWF0ZWQgKHdoaWNoCisgICAgICAgIGRvZXNuJ3QgaGFwcGVuIHdpdGggYSBkaXJl Y3QgY2FsbCB0byBnX29iamVjdF9uZXcpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsv V2ViS2l0V2ViVmlld0Jhc2UuY3BwOgorICAgICAgICAod2Via2l0X3dlYl92aWV3X2Jhc2VfY2xh c3NfaW5pdCk6CisKIDIwMTYtMDItMDUgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5A d2Via2l0Lm9yZz4KIAogICAgICAgICBDbGVhbiB1cCBCbG9iIGNvZGUKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcCBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcAppbmRl eCBjOTNjMDY4Li42OGM2MDAyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCkBAIC00Miw2ICs0Miw3IEBACiAjaW5j bHVkZSAiV2ViRXZlbnRGYWN0b3J5LmgiCiAjaW5jbHVkZSAiV2ViRnVsbFNjcmVlbkNsaWVudEd0 ay5oIgogI2luY2x1ZGUgIldlYkluc3BlY3RvclByb3h5LmgiCisjaW5jbHVkZSAiV2ViS2l0Mklu aXRpYWxpemUuaCIKICNpbmNsdWRlICJXZWJLaXRBdXRoZW50aWNhdGlvbkRpYWxvZy5oIgogI2lu Y2x1ZGUgIldlYktpdFByaXZhdGUuaCIKICNpbmNsdWRlICJXZWJLaXRXZWJWaWV3QmFzZUFjY2Vz c2libGUuaCIKQEAgLTExMDIsNiArMTEwMywxMSBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX3Zp ZXdfYmFzZV9jbGFzc19pbml0KFdlYktpdFdlYlZpZXdCYXNlQ2xhc3MqIHdlYmtpdFdlYlZpZQog ICAgIGNvbnRhaW5lckNsYXNzLT5hZGQgPSB3ZWJraXRXZWJWaWV3QmFzZUNvbnRhaW5lckFkZDsK ICAgICBjb250YWluZXJDbGFzcy0+cmVtb3ZlID0gd2Via2l0V2ViVmlld0Jhc2VDb250YWluZXJS ZW1vdmU7CiAgICAgY29udGFpbmVyQ2xhc3MtPmZvcmFsbCA9IHdlYmtpdFdlYlZpZXdCYXNlQ29u dGFpbmVyRm9yYWxsOworCisgICAgLy8gQmVmb3JlIGNyZWF0aW5nIGEgV2ViS2l0V2ViVmlld0Jh c2VQcml2IHdlIG5lZWQgdG8gYmUgc3VyZSB0aGF0IFdlYktpdCBpcyBzdGFydGVkLgorICAgIC8v IFVzdWFsbHkgc3RhcnRpbmcgYSBjb250ZXh0IHRyaWdnZXJzIEluaXRpYWxpemVXZWJLaXQyLCBi dXQgaW4gY2FzZQorICAgIC8vIHdlIGNyZWF0ZSBhIHZpZXcgd2l0aG91dCBhc2tpbmcgYmVmb3Jl IGZvciBhIGRlZmF1bHRfY29udGV4dCB3ZSBnZXQgYSBjcmFzaC4KKyAgICBXZWJLaXQ6OkluaXRp YWxpemVXZWJLaXQyKCk7CiB9CiAKIFdlYktpdFdlYlZpZXdCYXNlKiB3ZWJraXRXZWJWaWV3QmFz ZUNyZWF0ZShjb25zdCBBUEk6OlBhZ2VDb25maWd1cmF0aW9uJiBjb25maWd1cmF0aW9uKQotLSAK Mi41LjAKCg==