153985 2016-02-08 07:39:18 -0800 Remove __weak from WKAirPlayRoutePicker.mm to fix build warning. 2017-11-02 11:34:23 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jeremyj-wk jeremyj-wk commit-queue webkit-bug-importer oldest_to_newest 1162871 0 jeremyj-wk 2016-02-08 07:39:18 -0800 Remove __weak from WKAirPlayRoutePicker.mm to fix build warning. 1162872 1 jeremyj-wk 2016-02-08 07:40:30 -0800 rdar://problem/24485348 1162873 2 270854 jeremyj-wk 2016-02-08 07:42:55 -0800 Created attachment 270854 Patch 1162888 3 270854 darin 2016-02-08 08:54:19 -0800 Comment on attachment 270854 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270854&action=review > Source/WebKit2/UIProcess/ios/forms/WKAirPlayRoutePicker.mm:53 > - __weak WKContentView* _view; // Weak reference. > + __unsafe_unretained WKContentView* _view; // Weak reference. Since this code is not ARC, we should not have any modifier at all. Is there any value to stating __unsafe_unretained here? 1162889 4 270854 darin 2016-02-08 08:54:43 -0800 Comment on attachment 270854 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270854&action=review >> Source/WebKit2/UIProcess/ios/forms/WKAirPlayRoutePicker.mm:53 >> + __unsafe_unretained WKContentView* _view; // Weak reference. > > Since this code is not ARC, we should not have any modifier at all. Is there any value to stating __unsafe_unretained here? I suggest removing __weak and not replacing it with anything. 1162911 5 jeremyj-wk 2016-02-08 10:25:21 -0800 (In reply to comment #4) > Comment on attachment 270854 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=270854&action=review > > >> Source/WebKit2/UIProcess/ios/forms/WKAirPlayRoutePicker.mm:53 > >> + __unsafe_unretained WKContentView* _view; // Weak reference. > > > > Since this code is not ARC, we should not have any modifier at all. Is there any value to stating __unsafe_unretained here? > > I suggest removing __weak and not replacing it with anything. If this were a header that might get included in an ARC code, it would be necessary. Since it is in an .mm file, the only value is in annotating the fact that this is an unretained reference. I'll remove it. 1162913 6 270863 jeremyj-wk 2016-02-08 10:28:41 -0800 Created attachment 270863 Patch for landing. 1162946 7 270863 commit-queue 2016-02-08 11:27:03 -0800 Comment on attachment 270863 Patch for landing. Clearing flags on attachment: 270863 Committed r196260: <http://trac.webkit.org/changeset/196260> 270854 2016-02-08 07:42:55 -0800 2016-02-08 08:54:43 -0800 Patch bug-153985-20160208074232.patch text/plain 1588 jeremyj-wk U3VidmVyc2lvbiBSZXZpc2lvbjogMTk2MjAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMGFkYWY1Mjk4MGI4YzA4 ODdhYzdhYTMyYjRmZWI4NDNmODlkZGEyOS4uMTI2YTk4ZTc3ZDNiNWNlYTM1Zjg0NTllNTg2YTk4 YmYzMzg4ZmRlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTAyLTA4ICBKZXJl bXkgSm9uZXMgIDxqZXJlbXlqQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgX193ZWFrIGZy b20gV0tBaXJQbGF5Um91dGVQaWNrZXIubW0gdG8gZml4IGJ1aWxkIHdhcm5pbmcuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTM5ODUKKyAgICAgICAg cmRhcjovL3Byb2JsZW0vMjQ0ODUzNDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBVc2UgX191bnNhZmVfdW5yZXRhaW5lZCwgc2luY2UgX193ZWFrIGlz IG9ubHkgYXZhaWxhYmxlIHdoZW4gdXNpbmcgQVJDLgorCisgICAgICAgICogVUlQcm9jZXNzL2lv cy9mb3Jtcy9XS0FpclBsYXlSb3V0ZVBpY2tlci5tbToKKwogMjAxNi0wMi0wNSAgVGltb3RoeSBI YXRjaGVyICA8dGltb3RoeUBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogRXJy b3Igd2hlbiBjbG9zaW5nIHBhZ2Ugd2l0aCBXZWJJbnNwZWN0b3Igb3BlbgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9mb3Jtcy9XS0FpclBsYXlSb3V0ZVBpY2tlci5t bSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvZm9ybXMvV0tBaXJQbGF5Um91dGVQaWNr ZXIubW0KaW5kZXggYjhlNmFkMDVkMTQwMjg4ZjY0N2ExZWNlMTZhYjc3MGI0YWE1M2EwNS4uZjgz MzFmNTdkMDNmYzU4OGU5YjY4ZjMwY2NkMjNmYWY3ZjQ4Y2U0MiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL2lvcy9mb3Jtcy9XS0FpclBsYXlSb3V0ZVBpY2tlci5tbQorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL2Zvcm1zL1dLQWlyUGxheVJvdXRlUGlja2Vy Lm1tCkBAIC01MCw3ICs1MCw3IEBAIHVzaW5nIG5hbWVzcGFjZSBXZWJLaXQ7CiAgICAgUmV0YWlu UHRyPE1QQVZSb3V0aW5nQ29udHJvbGxlcj4gX3JvdXRpbmdDb250cm9sbGVyOwogICAgIFJldGFp blB0cjxNUEF1ZGlvVmlkZW9Sb3V0aW5nUG9wb3ZlckNvbnRyb2xsZXI+IF9wb3BvdmVyQ29udHJv bGxlcjsgIC8vIGlQYWQKICAgICBSZXRhaW5QdHI8TVBBdWRpb1ZpZGVvUm91dGluZ0FjdGlvblNo ZWV0PiBfYWN0aW9uU2hlZXQ7ICAgICAgICAgICAgICAvLyBpUGhvbmUKLSAgICBfX3dlYWsgV0tD b250ZW50VmlldyogX3ZpZXc7ICAgLy8gV2VhayByZWZlcmVuY2UuCisgICAgX191bnNhZmVfdW5y ZXRhaW5lZCBXS0NvbnRlbnRWaWV3KiBfdmlldzsgLy8gV2VhayByZWZlcmVuY2UuCiB9CiAKIC0g KGluc3RhbmNldHlwZSlpbml0V2l0aFZpZXc6KFdLQ29udGVudFZpZXcgKil2aWV3Cg== 270863 2016-02-08 10:28:41 -0800 2016-02-08 11:27:03 -0800 Patch for landing. bug-153985-20160208102819.patch text/plain 1550 jeremyj-wk U3VidmVyc2lvbiBSZXZpc2lvbjogMTk2MjAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMGFkYWY1Mjk4MGI4YzA4 ODdhYzdhYTMyYjRmZWI4NDNmODlkZGEyOS4uZTM3ZmYxZTU0NTg4NGE2NDkzM2IxOTlkODQwYjhh Yjc2NzhhNGU0YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTAyLTA4ICBKZXJl bXkgSm9uZXMgIDxqZXJlbXlqQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgX193ZWFrIGZy b20gV0tBaXJQbGF5Um91dGVQaWNrZXIubW0gdG8gZml4IGJ1aWxkIHdhcm5pbmcuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTM5ODUKKyAgICAgICAg cmRhcjovL3Byb2JsZW0vMjQ0ODUzNDgKKworICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxl ci4KKworICAgICAgICBSZW1vdmUgX193ZWFrIHNpbmNlIGl0IGlzIG9ubHkgYXZhaWxhYmxlIHdo ZW4gdXNpbmcgQVJDLgorCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9mb3Jtcy9XS0FpclBsYXlS b3V0ZVBpY2tlci5tbToKKwogMjAxNi0wMi0wNSAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBh cHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogRXJyb3Igd2hlbiBjbG9zaW5nIHBh Z2Ugd2l0aCBXZWJJbnNwZWN0b3Igb3BlbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL2lvcy9mb3Jtcy9XS0FpclBsYXlSb3V0ZVBpY2tlci5tbSBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9pb3MvZm9ybXMvV0tBaXJQbGF5Um91dGVQaWNrZXIubW0KaW5kZXggYjhlNmFk MDVkMTQwMjg4ZjY0N2ExZWNlMTZhYjc3MGI0YWE1M2EwNS4uMTY0MTYzNTJlNDFkODkyMGYyOGM1 ZmU4MWU1NDVmZDRhNGVkYzc3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L2lvcy9mb3Jtcy9XS0FpclBsYXlSb3V0ZVBpY2tlci5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvaW9zL2Zvcm1zL1dLQWlyUGxheVJvdXRlUGlja2VyLm1tCkBAIC01MCw3ICs1MCw3 IEBAIHVzaW5nIG5hbWVzcGFjZSBXZWJLaXQ7CiAgICAgUmV0YWluUHRyPE1QQVZSb3V0aW5nQ29u dHJvbGxlcj4gX3JvdXRpbmdDb250cm9sbGVyOwogICAgIFJldGFpblB0cjxNUEF1ZGlvVmlkZW9S b3V0aW5nUG9wb3ZlckNvbnRyb2xsZXI+IF9wb3BvdmVyQ29udHJvbGxlcjsgIC8vIGlQYWQKICAg ICBSZXRhaW5QdHI8TVBBdWRpb1ZpZGVvUm91dGluZ0FjdGlvblNoZWV0PiBfYWN0aW9uU2hlZXQ7 ICAgICAgICAgICAgICAvLyBpUGhvbmUKLSAgICBfX3dlYWsgV0tDb250ZW50VmlldyogX3ZpZXc7 ICAgLy8gV2VhayByZWZlcmVuY2UuCisgICAgV0tDb250ZW50VmlldyogX3ZpZXc7IC8vIFdlYWsg cmVmZXJlbmNlLgogfQogCiAtIChpbnN0YW5jZXR5cGUpaW5pdFdpdGhWaWV3OihXS0NvbnRlbnRW aWV3ICopdmlldwo=