153975 2016-02-07 23:05:50 -0800 Parser should detect error before calls to parseAssignmentExpression() 2016-02-08 10:53:23 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1162833 0 fpizlo 2016-02-07 23:05:50 -0800 Patch forthcoming. 1162836 1 270845 fpizlo 2016-02-07 23:11:26 -0800 Created attachment 270845 the patch 1162837 2 270846 fpizlo 2016-02-07 23:12:18 -0800 Created attachment 270846 the patch 1162894 3 270846 saam 2016-02-08 09:08:51 -0800 Comment on attachment 270846 the patch I'm surprised we only had one such call site :) 1162923 4 fpizlo 2016-02-08 10:51:46 -0800 (In reply to comment #3) > Comment on attachment 270846 [details] > the patch > > I'm surprised we only had one such call site :) Maybe there are others? 1162925 5 fpizlo 2016-02-08 10:53:23 -0800 Landed in http://trac.webkit.org/changeset/196258 270845 2016-02-07 23:11:26 -0800 2016-02-07 23:12:18 -0800 the patch blah.patch text/plain 1992 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk2MjQ4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDE2LTAyLTA3ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg UGFyc2VyIHNob3VsZCBkZXRlY3QgZXJyb3IgaW5zaWRlIHBhcnNlQXNzaWdubWVudEV4cHJlc3Np b24oKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUz OTc1CisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzI0MjkxMjMxCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4ZXMgYSB2ZXJ5IGhhcmQtdG8tY3JlYXRl IHNpdHVhdGlvbiB0aGF0IGFuIGludGVybmFsIHRlc3QgcGlja2VkIHVwLgorCisgICAgICAgICog cGFyc2VyL1BhcnNlci5jcHA6CisgICAgICAgIChKU0M6OlBhcnNlcjxMZXhlclR5cGU+OjpwYXJz ZVZhcmlhYmxlRGVjbGFyYXRpb25MaXN0KToKKyAgICAgICAgKEpTQzo6UGFyc2VyPExleGVyVHlw ZT46OnBhcnNlQXNzaWdubWVudEV4cHJlc3Npb24pOgorCiAyMDE2LTAyLTA3ICBTYWFtIGJhcmF0 aSAgPHNiYXJhdGlAYXBwbGUuY29tPgogCiAgICAgICAgIEZvbGxvdyB1cCBwYXRjaCB0bzogW0VT Nl0gYm91bmQgZnVuY3Rpb25zIC5uYW1lIHByb3BlcnR5IHNob3VsZCBiZSAiYm91bmQgIiArIHRo ZSB0YXJnZXQgZnVuY3Rpb24ncyBuYW1lIApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3Bh cnNlci9QYXJzZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJz ZXIvUGFyc2VyLmNwcAkocmV2aXNpb24gMTk2MjM5KQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L3BhcnNlci9QYXJzZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03MTQsNiArNzE0LDcgQEAgdGVt cGxhdGUgPGNsYXNzIFRyZWVCdWlsZGVyPiBUcmVlRXhwcmVzcwogICAgICAgICAgICAgICAgIEpT VGV4dFBvc2l0aW9uIHZhckRpdm90ID0gdG9rZW5TdGFydFBvc2l0aW9uKCkgKyAxOwogICAgICAg ICAgICAgICAgIGluaXRTdGFydCA9IHRva2VuU3RhcnRQb3NpdGlvbigpOwogICAgICAgICAgICAg ICAgIG5leHQoVHJlZUJ1aWxkZXI6OkRvbnRCdWlsZFN0cmluZ3MpOyAvLyBjb25zdW1lICc9Jwor ICAgICAgICAgICAgICAgIHByb3BhZ2F0ZUVycm9yKCk7CiAgICAgICAgICAgICAgICAgVHJlZUV4 cHJlc3Npb24gaW5pdGlhbGl6ZXIgPSBwYXJzZUFzc2lnbm1lbnRFeHByZXNzaW9uKGNvbnRleHQp OwogICAgICAgICAgICAgICAgIGluaXRFbmQgPSBsYXN0VG9rZW5FbmRQb3NpdGlvbigpOwogICAg ICAgICAgICAgICAgIGxhc3RJbml0aWFsaXplciA9IGluaXRpYWxpemVyOwpAQCAtMjk0Nyw2ICsy OTQ4LDggQEAgdGVtcGxhdGUgPHR5cGVuYW1lIFRyZWVCdWlsZGVyPiBUcmVlRXhwcgogdGVtcGxh dGUgPHR5cGVuYW1lIExleGVyVHlwZT4KIHRlbXBsYXRlIDx0eXBlbmFtZSBUcmVlQnVpbGRlcj4g VHJlZUV4cHJlc3Npb24gUGFyc2VyPExleGVyVHlwZT46OnBhcnNlQXNzaWdubWVudEV4cHJlc3Np b24oVHJlZUJ1aWxkZXImIGNvbnRleHQsIEV4cHJlc3Npb25FcnJvckNsYXNzaWZpZXImIGNsYXNz aWZpZXIpCiB7CisgICAgQVNTRVJUKCFoYXNFcnJvcigpKTsKKyAgICAKICAgICBmYWlsSWZTdGFj a092ZXJmbG93KCk7CiAgICAgSlNUZXh0UG9zaXRpb24gc3RhcnQgPSB0b2tlblN0YXJ0UG9zaXRp b24oKTsKICAgICBKU1Rva2VuTG9jYXRpb24gbG9jYXRpb24odG9rZW5Mb2NhdGlvbigpKTsK 270846 2016-02-07 23:12:18 -0800 2016-02-08 09:08:51 -0800 the patch blah.patch text/plain 2001 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk2MjQ4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDE2LTAyLTA3ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg UGFyc2VyIHNob3VsZCBkZXRlY3QgZXJyb3IgYmVmb3JlIGNhbGxzIHRvIHBhcnNlQXNzaWdubWVu dEV4cHJlc3Npb24oKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTUzOTc1CisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzI0MjkxMjMxCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4ZXMgYSB2ZXJ5IGhhcmQt dG8tY3JlYXRlIHNpdHVhdGlvbiB0aGF0IGFuIGludGVybmFsIHRlc3QgcGlja2VkIHVwLgorCisg ICAgICAgICogcGFyc2VyL1BhcnNlci5jcHA6CisgICAgICAgIChKU0M6OlBhcnNlcjxMZXhlclR5 cGU+OjpwYXJzZVZhcmlhYmxlRGVjbGFyYXRpb25MaXN0KToKKyAgICAgICAgKEpTQzo6UGFyc2Vy PExleGVyVHlwZT46OnBhcnNlQXNzaWdubWVudEV4cHJlc3Npb24pOgorCiAyMDE2LTAyLTA3ICBT YWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgogCiAgICAgICAgIEZvbGxvdyB1cCBwYXRj aCB0bzogW0VTNl0gYm91bmQgZnVuY3Rpb25zIC5uYW1lIHByb3BlcnR5IHNob3VsZCBiZSAiYm91 bmQgIiArIHRoZSB0YXJnZXQgZnVuY3Rpb24ncyBuYW1lIApJbmRleDogU291cmNlL0phdmFTY3Jp cHRDb3JlL3BhcnNlci9QYXJzZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9wYXJzZXIvUGFyc2VyLmNwcAkocmV2aXNpb24gMTk2MjM5KQorKysgU291cmNlL0phdmFT Y3JpcHRDb3JlL3BhcnNlci9QYXJzZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03MTQsNiArNzE0 LDcgQEAgdGVtcGxhdGUgPGNsYXNzIFRyZWVCdWlsZGVyPiBUcmVlRXhwcmVzcwogICAgICAgICAg ICAgICAgIEpTVGV4dFBvc2l0aW9uIHZhckRpdm90ID0gdG9rZW5TdGFydFBvc2l0aW9uKCkgKyAx OwogICAgICAgICAgICAgICAgIGluaXRTdGFydCA9IHRva2VuU3RhcnRQb3NpdGlvbigpOwogICAg ICAgICAgICAgICAgIG5leHQoVHJlZUJ1aWxkZXI6OkRvbnRCdWlsZFN0cmluZ3MpOyAvLyBjb25z dW1lICc9JworICAgICAgICAgICAgICAgIHByb3BhZ2F0ZUVycm9yKCk7CiAgICAgICAgICAgICAg ICAgVHJlZUV4cHJlc3Npb24gaW5pdGlhbGl6ZXIgPSBwYXJzZUFzc2lnbm1lbnRFeHByZXNzaW9u KGNvbnRleHQpOwogICAgICAgICAgICAgICAgIGluaXRFbmQgPSBsYXN0VG9rZW5FbmRQb3NpdGlv bigpOwogICAgICAgICAgICAgICAgIGxhc3RJbml0aWFsaXplciA9IGluaXRpYWxpemVyOwpAQCAt Mjk0Nyw2ICsyOTQ4LDggQEAgdGVtcGxhdGUgPHR5cGVuYW1lIFRyZWVCdWlsZGVyPiBUcmVlRXhw cgogdGVtcGxhdGUgPHR5cGVuYW1lIExleGVyVHlwZT4KIHRlbXBsYXRlIDx0eXBlbmFtZSBUcmVl QnVpbGRlcj4gVHJlZUV4cHJlc3Npb24gUGFyc2VyPExleGVyVHlwZT46OnBhcnNlQXNzaWdubWVu dEV4cHJlc3Npb24oVHJlZUJ1aWxkZXImIGNvbnRleHQsIEV4cHJlc3Npb25FcnJvckNsYXNzaWZp ZXImIGNsYXNzaWZpZXIpCiB7CisgICAgQVNTRVJUKCFoYXNFcnJvcigpKTsKKyAgICAKICAgICBm YWlsSWZTdGFja092ZXJmbG93KCk7CiAgICAgSlNUZXh0UG9zaXRpb24gc3RhcnQgPSB0b2tlblN0 YXJ0UG9zaXRpb24oKTsKICAgICBKU1Rva2VuTG9jYXRpb24gbG9jYXRpb24odG9rZW5Mb2NhdGlv bigpKTsK