153972 2016-02-07 21:28:37 -0800 Make sure that locking code that relies on module boundaries for compiler fences uses NEVER_INLINE 2016-02-08 10:58:27 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo benjamin cdumez cmarcelo commit-queue oldest_to_newest 1162827 0 fpizlo 2016-02-07 21:28:37 -0800 ... 1162828 1 fpizlo 2016-02-07 21:29:14 -0800 One example is the locking code. I don't know what would happen if the locking slow paths were inlined, and the compiler could "see" the locking code at a lock acquisition site. 1162830 2 270842 fpizlo 2016-02-07 21:59:36 -0800 Created attachment 270842 the patch 1162929 3 fpizlo 2016-02-08 10:58:27 -0800 Landed in http://trac.webkit.org/changeset/196259 270842 2016-02-07 21:59:36 -0800 2016-02-08 02:05:56 -0800 the patch blah.patch text/plain 4214 fpizlo SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxOTYyNDgpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDE2LTAyLTA3ICBGaWxpcCBQaXpsbyAgPGZwaXps b0BhcHBsZS5jb20+CisKKyAgICAgICAgTWFrZSBzdXJlIHRoYXQgbG9ja2luZyBjb2RlIHRoYXQg cmVsaWVzIG9uIG1vZHVsZSBib3VuZGFyaWVzIGZvciBjb21waWxlciBmZW5jZXMgdXNlcyBORVZF Ul9JTkxJTkUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE1Mzk3MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFdoZW4gdGhpcyBjb2RlIHdhcyB3cml0dGVuLCB3ZSBhc3N1bWVkIHRoYXQgbW9kdWxlIGJvdW5k YXJpZXMgd2VyZSBjb21waWxlciBmZW5jZXMuIFRoYXQgbWlnaHQKKyAgICAgICAgbm90IGJlIHRo ZSBjYXNlIGlmIHdlIGV2ZXIgZG8gTFRPLgorCisgICAgICAgICogd3RmL0xvY2suY3BwOgorICAg ICAgICAoV1RGOjpMb2NrQmFzZTo6bG9ja1Nsb3cpOgorICAgICAgICAoV1RGOjpMb2NrQmFzZTo6 dW5sb2NrU2xvdyk6CisgICAgICAgICogd3RmL1BhcmtpbmdMb3QuY3BwOgorICAgICAgICAoV1RG OjpQYXJraW5nTG90OjpwYXJrQ29uZGl0aW9uYWxseSk6CisgICAgICAgIChXVEY6OlBhcmtpbmdM b3Q6OnVucGFya09uZSk6CisgICAgICAgIChXVEY6OlBhcmtpbmdMb3Q6OnVucGFya0FsbCk6Cisg ICAgICAgIChXVEY6OlBhcmtpbmdMb3Q6OmZvckVhY2gpOgorICAgICAgICAqIHd0Zi9Xb3JkTG9j ay5jcHA6CisgICAgICAgIChXVEY6OldvcmRMb2NrOjpsb2NrU2xvdyk6CisgICAgICAgIChXVEY6 OldvcmRMb2NrOjp1bmxvY2tTbG93KToKKwogMjAxNi0wMi0wNyAgWXVzdWtlIFN1enVraSAgPHV0 YXRhbmUudGVhQGdtYWlsLmNvbT4KIAogICAgICAgICBbR1RLXVtFRkxdIEVuYWJsZSBTYW1wbGlu Z1Byb2ZpbGVyCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9Mb2NrLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV1RGL3d0Zi9Mb2NrLmNwcAkocmV2aXNpb24gMTk2MjQ4KQorKysgU291cmNlL1dURi93 dGYvTG9jay5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM2LDcgKzM2LDcgQEAgbmFtZXNwYWNlIFdU RiB7CiAKIHN0YXRpYyBjb25zdCBib29sIHZlcmJvc2UgPSBmYWxzZTsKIAotdm9pZCBMb2NrQmFz ZTo6bG9ja1Nsb3coKQorTkVWRVJfSU5MSU5FIHZvaWQgTG9ja0Jhc2U6OmxvY2tTbG93KCkKIHsK ICAgICB1bnNpZ25lZCBzcGluQ291bnQgPSAwOwogCkBAIC03NCw3ICs3NCw3IEBAIHZvaWQgTG9j a0Jhc2U6OmxvY2tTbG93KCkKICAgICB9CiB9CiAKLXZvaWQgTG9ja0Jhc2U6OnVubG9ja1Nsb3co KQorTkVWRVJfSU5MSU5FIHZvaWQgTG9ja0Jhc2U6OnVubG9ja1Nsb3coKQogewogICAgIC8vIFdl IGNvdWxkIGdldCBoZXJlIGJlY2F1c2UgdGhlIHdlYWsgQ0FTIGluIHVubG9jaygpIGZhaWxlZCBz cHVyaW91c2x5LCBvciBiZWNhdXNlIHRoZXJlIGlzCiAgICAgLy8gc29tZW9uZSBwYXJrZWQuIFNv LCB3ZSBuZWVkIGEgQ0FTIGxvb3A6IGV2ZW4gaWYgcmlnaHQgbm93IHRoZSBsb2NrIGlzIGp1c3Qg aGVsZCwgaXQgY291bGQKSW5kZXg6IFNvdXJjZS9XVEYvd3RmL1BhcmtpbmdMb3QuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL1BhcmtpbmdMb3QuY3BwCShyZXZpc2lvbiAxOTYyNDgp CisrKyBTb3VyY2UvV1RGL3d0Zi9QYXJraW5nTG90LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTA3 LDcgKzUwNyw3IEBAIGJvb2wgZGVxdWV1ZSgKIAogfSAvLyBhbm9ueW1vdXMgbmFtZXNwYWNlCiAK LWJvb2wgUGFya2luZ0xvdDo6cGFya0NvbmRpdGlvbmFsbHkoCitORVZFUl9JTkxJTkUgYm9vbCBQ YXJraW5nTG90OjpwYXJrQ29uZGl0aW9uYWxseSgKICAgICBjb25zdCB2b2lkKiBhZGRyZXNzLAog ICAgIHN0ZDo6ZnVuY3Rpb248Ym9vbCgpPiB2YWxpZGF0aW9uLAogICAgIHN0ZDo6ZnVuY3Rpb248 dm9pZCgpPiBiZWZvcmVTbGVlcCwKQEAgLTU5Miw3ICs1OTIsNyBAQCBib29sIFBhcmtpbmdMb3Q6 OnBhcmtDb25kaXRpb25hbGx5KAogICAgIHJldHVybiAhZGlkRmluZDsKIH0KIAotYm9vbCBQYXJr aW5nTG90Ojp1bnBhcmtPbmUoY29uc3Qgdm9pZCogYWRkcmVzcykKK05FVkVSX0lOTElORSBib29s IFBhcmtpbmdMb3Q6OnVucGFya09uZShjb25zdCB2b2lkKiBhZGRyZXNzKQogewogICAgIGlmICh2 ZXJib3NlKQogICAgICAgICBkYXRhTG9nKHRvU3RyaW5nKGN1cnJlbnRUaHJlYWQoKSwgIjogdW5w YXJraW5nIG9uZS5cbiIpKTsKQEAgLTYyMyw3ICs2MjMsNyBAQCBib29sIFBhcmtpbmdMb3Q6OnVu cGFya09uZShjb25zdCB2b2lkKiBhCiAgICAgcmV0dXJuIHJlc3VsdDsKIH0KIAotdm9pZCBQYXJr aW5nTG90Ojp1bnBhcmtPbmUoCitORVZFUl9JTkxJTkUgdm9pZCBQYXJraW5nTG90Ojp1bnBhcmtP bmUoCiAgICAgY29uc3Qgdm9pZCogYWRkcmVzcywKICAgICBzdGQ6OmZ1bmN0aW9uPHZvaWQoYm9v bCBkaWRVbnBhcmtUaHJlYWQsIGJvb2wgbWF5SGF2ZU1vcmVUaHJlYWRzKT4gY2FsbGJhY2spCiB7 CkBAIC02NTYsNyArNjU2LDcgQEAgdm9pZCBQYXJraW5nTG90Ojp1bnBhcmtPbmUoCiAgICAgdGhy ZWFkRGF0YS0+cGFya2luZ0NvbmRpdGlvbi5ub3RpZnlfb25lKCk7CiB9CiAKLXZvaWQgUGFya2lu Z0xvdDo6dW5wYXJrQWxsKGNvbnN0IHZvaWQqIGFkZHJlc3MpCitORVZFUl9JTkxJTkUgdm9pZCBQ YXJraW5nTG90Ojp1bnBhcmtBbGwoY29uc3Qgdm9pZCogYWRkcmVzcykKIHsKICAgICBpZiAodmVy Ym9zZSkKICAgICAgICAgZGF0YUxvZyh0b1N0cmluZyhjdXJyZW50VGhyZWFkKCksICI6IHVucGFy a2luZyBhbGwgZnJvbSAiLCBSYXdQb2ludGVyKGFkZHJlc3MpLCAiLlxuIikpOwpAQCAtNjkwLDcg KzY5MCw3IEBAIHZvaWQgUGFya2luZ0xvdDo6dW5wYXJrQWxsKGNvbnN0IHZvaWQqIGEKICAgICAg ICAgZGF0YUxvZyh0b1N0cmluZyhjdXJyZW50VGhyZWFkKCksICI6IGRvbmUgdW5wYXJraW5nLlxu IikpOwogfQogCi12b2lkIFBhcmtpbmdMb3Q6OmZvckVhY2goc3RkOjpmdW5jdGlvbjx2b2lkKFRo cmVhZElkZW50aWZpZXIsIGNvbnN0IHZvaWQqKT4gY2FsbGJhY2spCitORVZFUl9JTkxJTkUgdm9p ZCBQYXJraW5nTG90Ojpmb3JFYWNoKHN0ZDo6ZnVuY3Rpb248dm9pZChUaHJlYWRJZGVudGlmaWVy LCBjb25zdCB2b2lkKik+IGNhbGxiYWNrKQogewogICAgIFZlY3RvcjxCdWNrZXQqPiBidWNrZXRz VG9VbmxvY2sgPSBsb2NrSGFzaHRhYmxlKCk7CiAKSW5kZXg6IFNvdXJjZS9XVEYvd3RmL1dvcmRM b2NrLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9Xb3JkTG9jay5jcHAJKHJldmlz aW9uIDE5NjI0OCkKKysrIFNvdXJjZS9XVEYvd3RmL1dvcmRMb2NrLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtNzcsNyArNzcsNyBAQCBUaHJlYWREYXRhKiBteVRocmVhZERhdGEoKQogCiB9IC8vIGFu b255bW91cyBuYW1lc3BhY2UKIAotdm9pZCBXb3JkTG9jazo6bG9ja1Nsb3coKQorTkVWRVJfSU5M SU5FIHZvaWQgV29yZExvY2s6OmxvY2tTbG93KCkKIHsKICAgICB1bnNpZ25lZCBzcGluQ291bnQg PSAwOwogCkBAIC0xNzgsNyArMTc4LDcgQEAgdm9pZCBXb3JkTG9jazo6bG9ja1Nsb3coKQogICAg IH0KIH0KIAotdm9pZCBXb3JkTG9jazo6dW5sb2NrU2xvdygpCitORVZFUl9JTkxJTkUgdm9pZCBX b3JkTG9jazo6dW5sb2NrU2xvdygpCiB7CiAgICAgLy8gVGhlIGZhc3QgcGF0aCBjYW4gZmFpbCBl aXRoZXIgYmVjYXVzZSBvZiBzcHVyaW91cyB3ZWFrIENBUyBmYWlsdXJlLCBvciBiZWNhdXNlIHNv bWVvbmUgcHV0IGEKICAgICAvLyB0aHJlYWQgb24gdGhlIHF1ZXVlLCBvciB0aGUgcXVldWUgbG9j ayBpcyBoZWxkLiBJZiB0aGUgcXVldWUgbG9jayBpcyBoZWxkLCBpdCBjYW4gb25seSBiZQo=