153971 2016-02-07 19:25:12 -0800 Web Inspector: WebInspector.Setting should have a "reset" method 2016-02-10 14:57:18 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED EasyFix, InRadar P2 Normal --- 1 mattbaker mattbaker bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1162819 0 mattbaker 2016-02-07 19:25:12 -0800 * SUMMARY WebInspector.Setting should have a "reset" method. Restoring a setting to it's default value would come in handy for the future Settings tab (https://bugs.webkit.org/show_bug.cgi?id=149284). 1162820 1 webkit-bug-importer 2016-02-07 19:25:24 -0800 <rdar://problem/24544101> 1162822 2 webkit-bug-importer 2016-02-07 19:49:28 -0800 <rdar://problem/24544167> 1162823 3 270839 mattbaker 2016-02-07 19:49:35 -0800 Created attachment 270839 [Patch] Proposed Fix 1162824 4 270840 mattbaker 2016-02-07 19:51:18 -0800 Created attachment 270840 [Patch] Proposed Fix 1162900 5 270840 bburg 2016-02-08 09:36:24 -0800 Comment on attachment 270840 [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=270840&action=review r=me > Source/WebInspectorUI/UserInterface/Base/Setting.js:97 > + this.value = JSON.parse(JSON.stringify(this._defaultValue)); Can we extract this to Utilities.js, something like Object.deepCopyIfSerializable ? We do this idiom in several places, but we never check that _defaultValue is actually serializable, so this can throw an exception. The helper could be more paranoid. 1162906 6 270840 commit-queue 2016-02-08 10:23:11 -0800 Comment on attachment 270840 [Patch] Proposed Fix Clearing flags on attachment: 270840 Committed r196255: <http://trac.webkit.org/changeset/196255> 1162907 7 commit-queue 2016-02-08 10:23:15 -0800 All reviewed patches have been landed. Closing bug. 1163308 8 270840 joepeck 2016-02-09 15:30:05 -0800 Comment on attachment 270840 [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=270840&action=review > Source/WebInspectorUI/UserInterface/Base/Setting.js:94 > + reset() This could, and should, have a test. LayoutTests/inspector/unit-tests/setting.html 1163630 9 mattbaker 2016-02-10 14:57:18 -0800 (In reply to comment #8) > Comment on attachment 270840 [details] > [Patch] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=270840&action=review > > > Source/WebInspectorUI/UserInterface/Base/Setting.js:94 > > + reset() > > This could, and should, have a test. > LayoutTests/inspector/unit-tests/setting.html https://bugs.webkit.org/show_bug.cgi?id=154092 270839 2016-02-07 19:49:35 -0800 2016-02-07 19:51:15 -0800 [Patch] Proposed Fix bug-153971-20160207194912.patch text/plain 803 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMTk2MjQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9CYXNlL1NldHRpbmcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9CYXNlL1NldHRpbmcuanMKaW5kZXggNDE4NDJjZjI1MTdlYTY4MDg3 OGFkMzEyMzYzZWMzZTgwYzEyYWY1MS4uMjc4MTkwMmYxMzkyZjBiMWYxZDg1MzA3MDI3N2QzYmVk ZGNiYzFhMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv QmFzZS9TZXR0aW5nLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L0Jhc2UvU2V0dGluZy5qcwpAQCAtOTAsNiArOTAsMTIgQEAgV2ViSW5zcGVjdG9yLlNldHRpbmcg PSBjbGFzcyBTZXR0aW5nIGV4dGVuZHMgV2ViSW5zcGVjdG9yLk9iamVjdAogCiAgICAgICAgIHRo aXMuZGlzcGF0Y2hFdmVudFRvTGlzdGVuZXJzKFdlYkluc3BlY3Rvci5TZXR0aW5nLkV2ZW50LkNo YW5nZWQsIHRoaXMuX3ZhbHVlLCB7bmFtZTogdGhpcy5fbmFtZX0pOwogICAgIH0KKworICAgIHJl c2V0KCkKKyAgICB7CisgICAgICAgIC8vIE1ha2UgYSBjb3B5IG9mIHRoZSBkZWZhdWx0IHZhbHVl IHNvIGNoYW5nZXMgdG8gb2JqZWN0IHZhbHVlcyBkb24ndCBtb2RpZnkgdGhlIGRlZmF1bHQgdmFs dWUuCisgICAgICAgIHRoaXMudmFsdWUgPSBKU09OLnBhcnNlKEpTT04uc3RyaW5naWZ5KHRoaXMu X2RlZmF1bHRWYWx1ZSkpOworICAgIH0KIH07CiAKIFdlYkluc3BlY3Rvci5TZXR0aW5nLkV2ZW50 ID0gewo= 270840 2016-02-07 19:51:18 -0800 2016-02-08 10:23:11 -0800 [Patch] Proposed Fix bug-153971-20160207195055.patch text/plain 1855 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMTk2MjQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA3 NGJiZDBlYWRjNzg1MThmZmM3ZDhjY2NjNjQyYzUwNDI4MzQyMDU5Li40MGYyMTgzNzlkNWQ5NTZm MTFiZDVhNmY3NjdiMDdmMWFhNzQ5OWE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxNi0wMi0wNyAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogV2ViSW5zcGVjdG9yLlNldHRpbmcgc2hvdWxkIGhh dmUgYSAicmVzZXQiIG1ldGhvZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTUzOTcxCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yNDU0NDEwMT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDdXJyZW50bHkg VUkgbmVlZGluZyB0byByZXN0b3JlIGEgc2V0dGluZyB0byBpdHMgZGVmYXVsdCBtdXN0IHJldGFp biBhIGNvcHkKKyAgICAgICAgb2YgdGhlIGRlZmF1bHQgdmFsdWUuIFRoaXMgc2hvdWxkIGJlIGEg YmFzaWMgb3BlcmF0aW9uIG9mIFdlYkluc3BlY3Rvci5TZXR0aW5nLgorCisgICAgICAgICogVXNl ckludGVyZmFjZS9CYXNlL1NldHRpbmcuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU2V0dGlu Zyk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU2V0dGluZy5wcm90b3R5cGUucmVzZXQpOgorICAg ICAgICBTZXRzIHZhbHVlIHRvIGEgY29weSBvZiB0aGUgZGVmYXVsdC4KKwogMjAxNi0wMi0wNiAg TmlraXRhIFZhc2lseWV2ICA8bnZhc2lseWV2QGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNT SU9OIChyMTk1NDMyKTogV2ViIEluc3BlY3RvcjogYm90dG9tIHJpZ2h0IHNlY3Rpb24gb2YgdGhl IHN0eWxlcyBzaWRlYmFyIGlzIDFweCB0YWxsZXIgdGhhbiB0aGUgY29uc29sZSBwcm9tcHQKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvU2V0dGlu Zy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvU2V0dGluZy5q cwppbmRleCA0MTg0MmNmMjUxN2VhNjgwODc4YWQzMTIzNjNlYzNlODBjMTJhZjUxLi4yNzgxOTAy ZjEzOTJmMGIxZjFkODUzMDcwMjc3ZDNiZWRkY2JjMWEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL1NldHRpbmcuanMKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9TZXR0aW5nLmpzCkBAIC05MCw2ICs5MCwx MiBAQCBXZWJJbnNwZWN0b3IuU2V0dGluZyA9IGNsYXNzIFNldHRpbmcgZXh0ZW5kcyBXZWJJbnNw ZWN0b3IuT2JqZWN0CiAKICAgICAgICAgdGhpcy5kaXNwYXRjaEV2ZW50VG9MaXN0ZW5lcnMoV2Vi SW5zcGVjdG9yLlNldHRpbmcuRXZlbnQuQ2hhbmdlZCwgdGhpcy5fdmFsdWUsIHtuYW1lOiB0aGlz Ll9uYW1lfSk7CiAgICAgfQorCisgICAgcmVzZXQoKQorICAgIHsKKyAgICAgICAgLy8gTWFrZSBh IGNvcHkgb2YgdGhlIGRlZmF1bHQgdmFsdWUgc28gY2hhbmdlcyB0byBvYmplY3QgdmFsdWVzIGRv bid0IG1vZGlmeSB0aGUgZGVmYXVsdCB2YWx1ZS4KKyAgICAgICAgdGhpcy52YWx1ZSA9IEpTT04u cGFyc2UoSlNPTi5zdHJpbmdpZnkodGhpcy5fZGVmYXVsdFZhbHVlKSk7CisgICAgfQogfTsKIAog V2ViSW5zcGVjdG9yLlNldHRpbmcuRXZlbnQgPSB7Cg==