153970 2016-02-07 19:13:20 -0800 Remove unnecessary respondsToSelector checks for methods that exist on all supported platforms 2016-02-07 19:20:19 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sam sam oldest_to_newest 1162815 0 sam 2016-02-07 19:13:20 -0800 Remove unncessary respondsToSelector checks for methods that exist on all support platforms 1162816 1 270837 sam 2016-02-07 19:16:41 -0800 Created attachment 270837 Patch 1162817 2 270837 mitz 2016-02-07 19:18:34 -0800 Comment on attachment 270837 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270837&action=review > Source/WebCore/ChangeLog:3 > + Remove unnecessary respondsToSelector checks for methods that exist on all support platforms supported 1162818 3 sam 2016-02-07 19:20:19 -0800 Committed r196247: <http://trac.webkit.org/changeset/196247> 270837 2016-02-07 19:16:41 -0800 2016-02-07 19:18:34 -0800 Patch bug-153970-20160207191618.patch text/plain 7207 sam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5NjI0NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMwIEBACisyMDE2LTAyLTA3ICBTYW0gV2Vp bmlnICA8c2FtQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmVtb3ZlIHVubmVjZXNzYXJ5IHJlc3Bv bmRzVG9TZWxlY3RvciBjaGVja3MgZm9yIG1ldGhvZHMgdGhhdCBleGlzdCBvbiBhbGwgc3VwcG9y dCBwbGF0Zm9ybXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE1Mzk3MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIC1bTlNTY3JvbGxlckltcCBtb3VzZUVudGVyZWRTY3JvbGxlcl0sIC1bTlNTY3JvbGxlcklt cCBleHBhbnNpb25UcmFuc2l0aW9uUHJvZ3Jlc3NdLAorICAgICAgICAtW05TU2Nyb2xsZXJJbXBQ YWlyIGNvbnRlbnRBcmVhU2Nyb2xsZWRJbkRpcmVjdGlvbjpdLCBhbmQgLVtOU1Njcm9sbGVySW1w IHNldEV4cGFuZGVkOl0KKyAgICAgICAgYXJlIG5vdyBhdmFpbGFibGUgb24gYWxsIHN1cHBvcnRl ZCBPUydzLiBObyBuZWVkIHRvIGNoZWNrIGZvciB0aGVtLgorCisgICAgICAgICogcGxhdGZvcm0v bWFjL1Njcm9sbEFuaW1hdG9yTWFjLm1tOgorICAgICAgICAobWFjU2Nyb2xsYmFyVGhlbWUpOgor ICAgICAgICAoLVtXZWJTY3JvbGxiYXJQYWludGVyRGVsZWdhdGUgc2Nyb2xsZXJJbXA6YW5pbWF0 ZVVJU3RhdGVUcmFuc2l0aW9uV2l0aER1cmF0aW9uOl0pOgorICAgICAgICAoLVtXZWJTY3JvbGxi YXJQYWludGVyRGVsZWdhdGUgc2Nyb2xsZXJJbXA6YW5pbWF0ZUV4cGFuc2lvblRyYW5zaXRpb25X aXRoRHVyYXRpb246XSk6CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxBbmltYXRvck1hYzo6bW91 c2VFbnRlcmVkU2Nyb2xsYmFyKToKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbEFuaW1hdG9yTWFj Ojptb3VzZUV4aXRlZFNjcm9sbGJhcik6CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxBbmltYXRv ck1hYzo6c2VuZENvbnRlbnRBcmVhU2Nyb2xsZWQpOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xs QW5pbWF0b3JNYWM6OnNlbmRDb250ZW50QXJlYVNjcm9sbGVkVGltZXJGaXJlZCk6CisgICAgICAg IChzdXBwb3J0c1VJU3RhdGVUcmFuc2l0aW9uUHJvZ3Jlc3MpOiBEZWxldGVkLgorICAgICAgICAo c3VwcG9ydHNFeHBhbnNpb25UcmFuc2l0aW9uUHJvZ3Jlc3MpOiBEZWxldGVkLgorICAgICAgICAo c3VwcG9ydHNDb250ZW50QXJlYVNjcm9sbGVkSW5EaXJlY3Rpb24pOiBEZWxldGVkLgorICAgICAg ICAqIHBsYXRmb3JtL21hYy9TY3JvbGxiYXJUaGVtZU1hYy5tbToKKyAgICAgICAgKCtbV2ViU2Ny b2xsYmFyUHJlZnNPYnNlcnZlciBhcHBlYXJhbmNlUHJlZnNDaGFuZ2VkOl0pOgorICAgICAgICAo K1tXZWJTY3JvbGxiYXJQcmVmc09ic2VydmVyIGJlaGF2aW9yUHJlZnNDaGFuZ2VkOl0pOgorICAg ICAgICAoV2ViQ29yZTo6U2Nyb2xsYmFyVGhlbWVNYWM6OnNjcm9sbGJhclRoaWNrbmVzcyk6CisK IDIwMTYtMDItMDcgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBVc2Ug bW9kZXJuIFNQSSBoZWFkZXIgaWRpb20gZm9yIE5TU2Nyb2xsZXJJbXAgYW5kIE5TU2Nyb2xsZXJJ bXBQYWlyCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvU2Nyb2xsQW5pbWF0b3JN YWMubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1Njcm9sbEFu aW1hdG9yTWFjLm1tCShyZXZpc2lvbiAxOTYyNDYpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9tYWMvU2Nyb2xsQW5pbWF0b3JNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTQ1LDI1ICs0NSw2 IEBACiAKIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogCi1zdGF0aWMgYm9vbCBzdXBwb3J0c1VJ U3RhdGVUcmFuc2l0aW9uUHJvZ3Jlc3MoKQotewotICAgIC8vIEZJWE1FOiBUaGlzIGlzIHRlbXBv cmFyeSB1bnRpbCBhbGwgcGxhdGZvcm1zIHRoYXQgc3VwcG9ydCBTY3JvbGxiYXJQYWludGVyIHN1 cHBvcnQgdGhpcyBwYXJ0IG9mIHRoZSBBUEkuCi0gICAgc3RhdGljIGNvbnN0IGJvb2wgZ2xvYmFs U3VwcG9ydHNVSVN0YXRlVHJhbnNpdGlvblByb2dyZXNzID0gW1tOU1Njcm9sbGVySW1wIGNsYXNz XSBpbnN0YW5jZXNSZXNwb25kVG9TZWxlY3RvcjpAc2VsZWN0b3IobW91c2VFbnRlcmVkU2Nyb2xs ZXIpXTsKLSAgICByZXR1cm4gZ2xvYmFsU3VwcG9ydHNVSVN0YXRlVHJhbnNpdGlvblByb2dyZXNz OwotfQotCi1zdGF0aWMgYm9vbCBzdXBwb3J0c0V4cGFuc2lvblRyYW5zaXRpb25Qcm9ncmVzcygp Ci17Ci0gICAgc3RhdGljIGNvbnN0IGJvb2wgZ2xvYmFsU3VwcG9ydHNFeHBhbnNpb25UcmFuc2l0 aW9uUHJvZ3Jlc3MgPSBbW05TU2Nyb2xsZXJJbXAgY2xhc3NdIGluc3RhbmNlc1Jlc3BvbmRUb1Nl bGVjdG9yOkBzZWxlY3RvcihleHBhbnNpb25UcmFuc2l0aW9uUHJvZ3Jlc3MpXTsKLSAgICByZXR1 cm4gZ2xvYmFsU3VwcG9ydHNFeHBhbnNpb25UcmFuc2l0aW9uUHJvZ3Jlc3M7Ci19Ci0KLXN0YXRp YyBib29sIHN1cHBvcnRzQ29udGVudEFyZWFTY3JvbGxlZEluRGlyZWN0aW9uKCkKLXsKLSAgICBz dGF0aWMgY29uc3QgYm9vbCBnbG9iYWxTdXBwb3J0c0NvbnRlbnRBcmVhU2Nyb2xsZWRJbkRpcmVj dGlvbiA9IFtbTlNTY3JvbGxlckltcFBhaXIgY2xhc3NdIGluc3RhbmNlc1Jlc3BvbmRUb1NlbGVj dG9yOkBzZWxlY3Rvcihjb250ZW50QXJlYVNjcm9sbGVkSW5EaXJlY3Rpb246KV07Ci0gICAgcmV0 dXJuIGdsb2JhbFN1cHBvcnRzQ29udGVudEFyZWFTY3JvbGxlZEluRGlyZWN0aW9uOwotfQotCiBz dGF0aWMgU2Nyb2xsYmFyVGhlbWVNYWMqIG1hY1Njcm9sbGJhclRoZW1lKCkKIHsKICAgICBTY3Jv bGxiYXJUaGVtZSYgc2Nyb2xsYmFyVGhlbWUgPSBTY3JvbGxiYXJUaGVtZTo6dGhlbWUoKTsKQEAg LTU1Niw5ICs1MzcsNiBAQCAtICh2b2lkKXNjcm9sbGVySW1wOihOU1Njcm9sbGVySW1wICopc2Ny CiAgICAgaWYgKCFfc2Nyb2xsYmFyKQogICAgICAgICByZXR1cm47CiAKLSAgICBpZiAoIXN1cHBv cnRzVUlTdGF0ZVRyYW5zaXRpb25Qcm9ncmVzcygpKQotICAgICAgICByZXR1cm47Ci0KICAgICBB U1NFUlQoc2Nyb2xsZXJJbXAgPT0gc2Nyb2xsYmFyUGFpbnRlckZvclNjcm9sbGJhcigqX3Njcm9s bGJhcikpOwogCiAgICAgU2Nyb2xsYmFyUGFpbnRlciBzY3JvbGxiYXJQYWludGVyID0gKFNjcm9s bGJhclBhaW50ZXIpc2Nyb2xsZXJJbXA7CkBAIC01OTAsOSArNTY4LDYgQEAgLSAodm9pZClzY3Jv bGxlckltcDooTlNTY3JvbGxlckltcCAqKXNjcgogICAgIGlmICghX3Njcm9sbGJhcikKICAgICAg ICAgcmV0dXJuOwogCi0gICAgaWYgKCFzdXBwb3J0c0V4cGFuc2lvblRyYW5zaXRpb25Qcm9ncmVz cygpKQotICAgICAgICByZXR1cm47Ci0KICAgICBBU1NFUlQoc2Nyb2xsZXJJbXAgPT0gc2Nyb2xs YmFyUGFpbnRlckZvclNjcm9sbGJhcigqX3Njcm9sbGJhcikpOwogCiAgICAgU2Nyb2xsYmFyUGFp bnRlciBzY3JvbGxiYXJQYWludGVyID0gKFNjcm9sbGJhclBhaW50ZXIpc2Nyb2xsZXJJbXA7CkBA IC04NDAsOCArODE1LDYgQEAgdm9pZCBTY3JvbGxBbmltYXRvck1hYzo6bW91c2VFbnRlcmVkU2Ny bwogICAgIGlmIChbbV9zY3JvbGxiYXJQYWludGVyQ29udHJvbGxlciBvdmVybGF5U2Nyb2xsZXJT dGF0ZUlzTG9ja2VkXSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgaWYgKCFzdXBwb3J0c1VJU3Rh dGVUcmFuc2l0aW9uUHJvZ3Jlc3MoKSkKLSAgICAgICAgcmV0dXJuOwogICAgIGlmIChTY3JvbGxi YXJQYWludGVyIHBhaW50ZXIgPSBzY3JvbGxiYXJQYWludGVyRm9yU2Nyb2xsYmFyKCpzY3JvbGxi YXIpKQogICAgICAgICBbcGFpbnRlciBtb3VzZUVudGVyZWRTY3JvbGxlcl07CiB9CkBAIC04NTUs OCArODI4LDYgQEAgdm9pZCBTY3JvbGxBbmltYXRvck1hYzo6bW91c2VFeGl0ZWRTY3JvbAogICAg IGlmIChbbV9zY3JvbGxiYXJQYWludGVyQ29udHJvbGxlciBvdmVybGF5U2Nyb2xsZXJTdGF0ZUlz TG9ja2VkXSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgaWYgKCFzdXBwb3J0c1VJU3RhdGVUcmFu c2l0aW9uUHJvZ3Jlc3MoKSkKLSAgICAgICAgcmV0dXJuOwogICAgIGlmIChTY3JvbGxiYXJQYWlu dGVyIHBhaW50ZXIgPSBzY3JvbGxiYXJQYWludGVyRm9yU2Nyb2xsYmFyKCpzY3JvbGxiYXIpKQog ICAgICAgICBbcGFpbnRlciBtb3VzZUV4aXRlZFNjcm9sbGVyXTsKIH0KQEAgLTE0MDMsMTAgKzEz NzQsNyBAQCB2b2lkIFNjcm9sbEFuaW1hdG9yTWFjOjpzZW5kQ29udGVudEFyZWFTCiAKIHZvaWQg U2Nyb2xsQW5pbWF0b3JNYWM6OnNlbmRDb250ZW50QXJlYVNjcm9sbGVkKGNvbnN0IEZsb2F0U2l6 ZSYgZGVsdGEpCiB7Ci0gICAgaWYgKHN1cHBvcnRzQ29udGVudEFyZWFTY3JvbGxlZEluRGlyZWN0 aW9uKCkpCi0gICAgICAgIFttX3Njcm9sbGJhclBhaW50ZXJDb250cm9sbGVyIGNvbnRlbnRBcmVh U2Nyb2xsZWRJbkRpcmVjdGlvbjpOU01ha2VQb2ludChkZWx0YS53aWR0aCgpLCBkZWx0YS5oZWln aHQoKSldOwotICAgIGVsc2UKLSAgICAgICAgW21fc2Nyb2xsYmFyUGFpbnRlckNvbnRyb2xsZXIg Y29udGVudEFyZWFTY3JvbGxlZF07CisgICAgW21fc2Nyb2xsYmFyUGFpbnRlckNvbnRyb2xsZXIg Y29udGVudEFyZWFTY3JvbGxlZEluRGlyZWN0aW9uOk5TTWFrZVBvaW50KGRlbHRhLndpZHRoKCks IGRlbHRhLmhlaWdodCgpKV07CiB9CiAKIHZvaWQgU2Nyb2xsQW5pbWF0b3JNYWM6OnNlbmRDb250 ZW50QXJlYVNjcm9sbGVkVGltZXJGaXJlZCgpCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9tYWMvU2Nyb2xsYmFyVGhlbWVNYWMubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vbWFjL1Njcm9sbGJhclRoZW1lTWFjLm1tCShyZXZpc2lvbiAxOTYyNDYpCisrKyBT b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvU2Nyb2xsYmFyVGhlbWVNYWMubW0JKHdvcmtpbmcg Y29weSkKQEAgLTY4LDE0ICs2OCwxNCBAQCBAaW50ZXJmYWNlIFdlYlNjcm9sbGJhclByZWZzT2Jz ZXJ2ZXIgOiBOCiB9CiAKICsgKHZvaWQpcmVnaXN0ZXJBc09ic2VydmVyOwotKyAodm9pZClhcHBl YXJhbmNlUHJlZnNDaGFuZ2VkOihOU05vdGlmaWNhdGlvbiopdGhlTm90aWZpY2F0aW9uOwotKyAo dm9pZCliZWhhdmlvclByZWZzQ2hhbmdlZDooTlNOb3RpZmljYXRpb24qKXRoZU5vdGlmaWNhdGlv bjsKKysgKHZvaWQpYXBwZWFyYW5jZVByZWZzQ2hhbmdlZDooTlNOb3RpZmljYXRpb24gKil0aGVO b3RpZmljYXRpb247CisrICh2b2lkKWJlaGF2aW9yUHJlZnNDaGFuZ2VkOihOU05vdGlmaWNhdGlv biAqKXRoZU5vdGlmaWNhdGlvbjsKIAogQGVuZAogCiBAaW1wbGVtZW50YXRpb24gV2ViU2Nyb2xs YmFyUHJlZnNPYnNlcnZlcgogCi0rICh2b2lkKWFwcGVhcmFuY2VQcmVmc0NoYW5nZWQ6KE5TTm90 aWZpY2F0aW9uKil1bnVzZWROb3RpZmljYXRpb24KKysgKHZvaWQpYXBwZWFyYW5jZVByZWZzQ2hh bmdlZDooTlNOb3RpZmljYXRpb24gKil1bnVzZWROb3RpZmljYXRpb24KIHsKICAgICBVTlVTRURf UEFSQU0odW51c2VkTm90aWZpY2F0aW9uKTsKIApAQCAtOTMsNyArOTMsNyBAQCArICh2b2lkKWFw cGVhcmFuY2VQcmVmc0NoYW5nZWQ6KE5TTm90aWZpCiAgICAgfQogfQogCi0rICh2b2lkKWJlaGF2 aW9yUHJlZnNDaGFuZ2VkOihOU05vdGlmaWNhdGlvbiopdW51c2VkTm90aWZpY2F0aW9uCisrICh2 b2lkKWJlaGF2aW9yUHJlZnNDaGFuZ2VkOihOU05vdGlmaWNhdGlvbiAqKXVudXNlZE5vdGlmaWNh dGlvbgogewogICAgIFVOVVNFRF9QQVJBTSh1bnVzZWROb3RpZmljYXRpb24pOwogCkBAIC0xMzYs MTMgKzEzNiw2IEBAIHN0YXRpYyBib29sIGdVc2VzT3ZlcmxheVNjcm9sbGJhcnMgPSBmYWwKIAog c3RhdGljIFNjcm9sbGJhckJ1dHRvbnNQbGFjZW1lbnQgZ0J1dHRvblBsYWNlbWVudCA9IFNjcm9s bGJhckJ1dHRvbnNEb3VibGVFbmQ7CiAKLXN0YXRpYyBib29sIHN1cHBvcnRzRXhwYW5kZWRTY3Jv bGxiYXJzKCkKLXsKLSAgICAvLyBGSVhNRTogVGhpcyBpcyB0ZW1wb3JhcnkgdW50aWwgYWxsIHBs YXRmb3JtcyB0aGF0IHN1cHBvcnQgU2Nyb2xsYmFyUGFpbnRlciBzdXBwb3J0IHRoaXMgcGFydCBv ZiB0aGUgQVBJLgotICAgIHN0YXRpYyBib29sIGdsb2JhbFN1cHBvcnRzRXhwYW5kZWRTY3JvbGxi YXJzID0gW1tOU1Njcm9sbGVySW1wIGNsYXNzXSBpbnN0YW5jZXNSZXNwb25kVG9TZWxlY3RvcjpA c2VsZWN0b3Ioc2V0RXhwYW5kZWQ6KV07Ci0gICAgcmV0dXJuIGdsb2JhbFN1cHBvcnRzRXhwYW5k ZWRTY3JvbGxiYXJzOwotfQotCiBzdGF0aWMgTlNDb250cm9sU2l6ZSBzY3JvbGxiYXJDb250cm9s U2l6ZVRvTlNDb250cm9sU2l6ZShTY3JvbGxiYXJDb250cm9sU2l6ZSBjb250cm9sU2l6ZSkKIHsK ICAgICBzd2l0Y2ggKGNvbnRyb2xTaXplKSB7CkBAIC0yMjYsOCArMjE5LDcgQEAgaW50IFNjcm9s bGJhclRoZW1lTWFjOjpzY3JvbGxiYXJUaGlja25lcwogewogICAgIEJFR0lOX0JMT0NLX09CSkNf RVhDRVBUSU9OUzsKICAgICBTY3JvbGxiYXJQYWludGVyIHNjcm9sbGJhclBhaW50ZXIgPSBbTlNT Y3JvbGxlckltcCBzY3JvbGxlckltcFdpdGhTdHlsZTpyZWNvbW1lbmRlZFNjcm9sbGVyU3R5bGUo KSBjb250cm9sU2l6ZTpzY3JvbGxiYXJDb250cm9sU2l6ZVRvTlNDb250cm9sU2l6ZShjb250cm9s U2l6ZSkgaG9yaXpvbnRhbDpOTyByZXBsYWNpbmdTY3JvbGxlckltcDpuaWxdOwotICAgIGlmIChz dXBwb3J0c0V4cGFuZGVkU2Nyb2xsYmFycygpKQotICAgICAgICBbc2Nyb2xsYmFyUGFpbnRlciBz ZXRFeHBhbmRlZDpZRVNdOworICAgIFtzY3JvbGxiYXJQYWludGVyIHNldEV4cGFuZGVkOllFU107 CiAgICAgcmV0dXJuIFtzY3JvbGxiYXJQYWludGVyIHRyYWNrQm94V2lkdGhdOwogICAgIEVORF9C TE9DS19PQkpDX0VYQ0VQVElPTlM7CiB9Cg==