15397 2007-10-06 05:24:43 -0700 Layout tests freeze in HashTable::lookup 2007-10-08 11:15:57 -0700 1 1 1 Unclassified WebKit WebCore Misc. 523.x (Safari 3) Mac (PowerPC) OS X 10.4 RESOLVED FIXED P1 Normal --- 1 ap ap hyatt oldest_to_newest 57937 0 ap 2007-10-06 05:24:43 -0700 The below reliably freezes for me: $ run-webkit-tests svg/W3C-SVG-1.1/text-align-06-b.svg --pixel The problem is in FontPlatformData constructor: "sending to nil" Cocoa magic doesn't work with non-integral values: if (f) CFRetain(f); m_size = [f pointSize]; This results in emptyValue being non-zero, and deeply confuses WTF::HashTable. 57938 1 16567 ap 2007-10-06 05:29:32 -0700 Created attachment 16567 proposed fix 57939 2 ap 2007-10-06 05:38:34 -0700 Looks like this issue isn't present on trunk - at least, I couldn't find such code there. 57973 3 16567 eric 2007-10-06 19:25:55 -0700 Comment on attachment 16567 proposed fix The change looks sane. I don't understand the removal of the -1 checks (or why they were there in the first place). 58000 4 ap 2007-10-07 01:44:48 -0700 I have removed the -1 checks because there was an unchecked call to [font pointSize] in this function anyway - so guarding against the same problem in other places wasn't really helpful. 58089 5 16567 darin 2007-10-08 08:28:47 -0700 Comment on attachment 16567 proposed fix If the checks for -1 really aren't necessary, then perhaps m_font can be changed into a RetainPtr? r=me 58097 6 ap 2007-10-08 09:27:53 -0700 > If the checks for -1 really aren't necessary, then perhaps m_font can be > changed into a RetainPtr? It's OK for m_font to be -1 (it's a special value used for "Deleted"), but apparently not for setFont() parameter. 58100 7 ap 2007-10-08 09:31:20 -0700 Committed revision 26105. 58107 8 hyatt 2007-10-08 10:38:06 -0700 Thanks for catching this. 58111 9 ap 2007-10-08 11:15:57 -0700 (In reply to comment #6) > It's OK for m_font to be -1 (it's a special value used for "Deleted"), but > apparently not for setFont() parameter. Oops, one of the removed checks was necessary in fact: - if (m_font && m_font != (NSFont*)-1) + if (m_font) Restored it in r26107. 16567 2007-10-06 05:29:32 -0700 2007-10-08 08:28:47 -0700 proposed fix 15397r1_patch.txt text/plain 1842 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNjA4MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDctMTAtMDYgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJr aXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1Mzk3CisgICAgICAgIExh eW91dCB0ZXN0cyBmcmVlemUgaW4gSGFzaFRhYmxlOjpsb29rdXAKKworICAgICAgICBGaXhlcyBh IERSVCBmcmVlemUgb24gUG93ZXJQQy4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy9Gb250UGxh dGZvcm1EYXRhTWFjLm1tOgorICAgICAgICAoV2ViQ29yZTo6Rm9udFBsYXRmb3JtRGF0YTo6Rm9u dFBsYXRmb3JtRGF0YSk6IERvbid0IGFzayBmb3IgYSBzaXplIG9mIGEgbmlsIGZvbnQsCisgICAg ICAgIHRoZSByZXN1bHQgaXMgdW5kZWZpbmVkLgorICAgICAgICAoV2ViQ29yZTo6Rm9udFBsYXRm b3JtRGF0YTo6c2V0Rm9udCk6IERpdHRvLiBBbHNvIHJlbW92ZWQgc29tZSBjaGVja3MgZm9yIC0x IHRoYXQKKyAgICAgICAgd2VyZSBub3Qgc3VmZmljaWVudCwgYW5kIHRodXMgbGlrZWx5IHVubmVj ZXNzYXJ5LAorCiAyMDA3LTEwLTA2ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAd2Via2l0Lm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBNaXR6LgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9t YWMvRm9udFBsYXRmb3JtRGF0YU1hYy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3Jt L21hYy9Gb250UGxhdGZvcm1EYXRhTWFjLm1tCShyZXZpc2lvbiAyNjA3OSkKKysrIFdlYkNvcmUv cGxhdGZvcm0vbWFjL0ZvbnRQbGF0Zm9ybURhdGFNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTMy LDcgKzMyLDcgQEAgRm9udFBsYXRmb3JtRGF0YTo6Rm9udFBsYXRmb3JtRGF0YShOU0Zvbgogewog ICAgIGlmIChmKQogICAgICAgICBDRlJldGFpbihmKTsKLSAgICBtX3NpemUgPSBbZiBwb2ludFNp emVdOworICAgIG1fc2l6ZSA9IGYgPyBbZiBwb2ludFNpemVdIDogMC4wZjsKICAgICBtX2NnRm9u dCA9IHdrR2V0Q0dGb250RnJvbU5TRm9udChmKTsKICAgICBtX2F0c3VGb250SUQgPSB3a0dldE5T Rm9udEFUU1VGb250SWQoZik7CiB9CkBAIC01NiwxMiArNTYsMTIgQEAgRm9udFBsYXRmb3JtRGF0 YTo6IH5Gb250UGxhdGZvcm1EYXRhKCkKIHZvaWQgRm9udFBsYXRmb3JtRGF0YTo6c2V0Rm9udChO U0ZvbnQqIGZvbnQpIHsKICAgICBpZiAobV9mb250ID09IGZvbnQpCiAgICAgICAgIHJldHVybjsK LSAgICBpZiAoZm9udCAmJiBmb250ICE9IChOU0ZvbnQqKS0xKQorICAgIGlmIChmb250KQogICAg ICAgICBDRlJldGFpbihmb250KTsKLSAgICBpZiAobV9mb250ICYmIG1fZm9udCAhPSAoTlNGb250 KiktMSkKKyAgICBpZiAobV9mb250KQogICAgICAgICBDRlJlbGVhc2UobV9mb250KTsKICAgICBt X2ZvbnQgPSBmb250OwotICAgIG1fc2l6ZSA9IFtmb250IHBvaW50U2l6ZV07CisgICAgbV9zaXpl ID0gZm9udCA/IFtmb250IHBvaW50U2l6ZV0gOiAwLjBmOwogICAgIG1fY2dGb250ID0gd2tHZXRD R0ZvbnRGcm9tTlNGb250KGZvbnQpOwogICAgIG1fYXRzdUZvbnRJRCA9IHdrR2V0TlNGb250QVRT VUZvbnRJZChmb250KTsKIH0K