153961 2016-02-07 08:20:56 -0800 [cmake] Move LLVM detection for LLVMDisassembler to OptionsCommon.cmake 2016-02-07 11:25:39 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 annulen webkit-unassigned bugs-noreply commit-queue lforschler mcatanzaro ossy oldest_to_newest 1162729 0 annulen 2016-02-07 08:20:56 -0800 In r196077 ENABLE_FTL_JIT was replaced with USE_LLVM_DISASSEMBLER, however x86_64 requirement is appropriate only for FTL. 1162731 1 270818 annulen 2016-02-07 08:24:09 -0800 Created attachment 270818 Patch 1162732 2 annulen 2016-02-07 08:25:45 -0800 BTW, it may be better to move this check to OptionsCommon, however it would require consensus on required LLVM version. 1162735 3 270818 mcatanzaro 2016-02-07 09:07:49 -0800 Comment on attachment 270818 Patch I agree, it'd be better to move this from the platform-specific options files to OptionsCommon. We don't care about the required LLVM version since we don't expose USE_LLVM_DISASSEMBLER. I suspect LLVM 3.7 was only required for FTL. 1162742 4 270820 annulen 2016-02-07 09:49:58 -0800 Created attachment 270820 Patch 1162752 5 annulen 2016-02-07 10:18:10 -0800 (In reply to comment #3) > Comment on attachment 270818 [details] > Patch > > I agree, it'd be better to move this from the platform-specific options > files to OptionsCommon. Done. 1162754 6 270820 mcatanzaro 2016-02-07 10:39:30 -0800 Comment on attachment 270820 Patch Great, thanks. 1162761 7 270820 commit-queue 2016-02-07 11:25:34 -0800 Comment on attachment 270820 Patch Clearing flags on attachment: 270820 Committed r196241: <http://trac.webkit.org/changeset/196241> 1162762 8 commit-queue 2016-02-07 11:25:39 -0800 All reviewed patches have been landed. Closing bug. 270818 2016-02-07 08:24:09 -0800 2016-02-07 09:49:50 -0800 Patch bug-153961-20160207192346.patch text/plain 1453 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMTk2MjM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IGRkMTgw MTM0YjRhODRmNTNlZjc1NTVhZGE0ZWViOWI0YTQyMmVhYWUuLmY3YjljYzNhNzk5NDAxMTQ2NjYy N2UxYzRhNmIxYjM5YzhjN2IwOTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC0yMzUsMTUgKzIz NSwxMSBAQCBpZiAoRU5BQkxFX0NSRURFTlRJQUxfU1RPUkFHRSkKIGVuZGlmICgpCiAKIGlmIChV U0VfTExWTV9ESVNBU1NFTUJMRVIpCi0gICAgaWYgKFdURl9DUFVfWDg2XzY0KQotICAgICAgICBm aW5kX3BhY2thZ2UoTExWTSAzLjcpCi0gICAgICAgIGlmIChOT1QgTExWTV9GT1VORCkKLSAgICAg ICAgICAgIG1lc3NhZ2UoRkFUQUxfRVJST1IgIkxMVk0gMy43IGlzIHJlcXVpcmVkIGZvciBVU0Vf TExWTV9ESVNBU1NFTUJMRVIiKQotICAgICAgICBlbmRpZiAoKQotICAgICAgICBTRVRfQU5EX0VY UE9TRV9UT19CVUlMRChIQVZFX0xMVk0gVFJVRSkKLSAgICBlbHNlICgpCi0gICAgICAgIG1lc3Nh Z2UoRkFUQUxfRVJST1IgIkZUTCBpcyBvbmx5IHN1cHBvcnRlZCBmb3IgWDg2XzY0IikKKyAgICBm aW5kX3BhY2thZ2UoTExWTSAzLjcpCisgICAgaWYgKE5PVCBMTFZNX0ZPVU5EKQorICAgICAgICBt ZXNzYWdlKEZBVEFMX0VSUk9SICJMTFZNIDMuNyBpcyByZXF1aXJlZCBmb3IgVVNFX0xMVk1fRElT QVNTRU1CTEVSIikKICAgICBlbmRpZiAoKQorICAgIFNFVF9BTkRfRVhQT1NFX1RPX0JVSUxEKEhB VkVfTExWTSBUUlVFKQogZW5kaWYgKCkKIAogaWYgKEVOQUJMRV9HQU1FUEFEX0RFUFJFQ0FURUQp CmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggZjliM2MyNmVhMDBlMWY2 ZDNhNjVlYjE5NWZiODdjZmEwYWFhMmViOS4uZGFiN2M5YzQ2MmM2OTNmOTVlNmE3NmIwODI1MTJm MTgxYTQ1ZTc1NyAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDEyIEBACisyMDE2LTAyLTA3ICBLb25zdGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRl eC5ydT4KKworICAgICAgICBbR1RLXSBMTFZNIGRpc2Fzc2VtYmxlciBpcyBub3QgeDg2XzY0LXNw ZWNpZmljCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NTM5NjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFNvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlOgorCiAyMDE2LTAyLTA0ICBDc2FiYSBPc3p0 cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCBub24gWDg2 XzY0IGJ1aWxkZml4IGFmdGVyIHIxOTYwNzcuCg== 270820 2016-02-07 09:49:58 -0800 2016-02-07 11:25:34 -0800 Patch bug-153961-20160207204935.patch text/plain 2791 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMTk2MjM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0NvbW1vbi5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCmluZGV4 IDQ2ZDY5NWU5MjkxZThlN2RiMmQwNjYwOTEzNjA5ODMwNTQxODhmMDYuLjM4ZGU1ZGRhYWVhMjdh MTVlYmJhMmViZjViNmI0YmZjMzYwODM5NmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRp b25zQ29tbW9uLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCkBA IC0xMjQsNiArMTI0LDExIEBAIGlmIChVTklYIEFORCBOT1QgQVBQTEUgQU5EIE5PVCBFTkFCTEVE X0NPTVBJTEVSX1NBTklUSVpFUlMpCiAgICAgc2V0KENNQUtFX1NIQVJFRF9MSU5LRVJfRkxBR1Mg Ii1XbCwtLW5vLXVuZGVmaW5lZCAke0NNQUtFX1NIQVJFRF9MSU5LRVJfRkxBR1N9IikKIGVuZGlm ICgpCiAKK2lmIChVU0VfTExWTV9ESVNBU1NFTUJMRVIpCisgICAgZmluZF9wYWNrYWdlKExMVk0g UkVRVUlSRUQpCisgICAgU0VUX0FORF9FWFBPU0VfVE9fQlVJTEQoSEFWRV9MTFZNIFRSVUUpCitl bmRpZiAoKQorCiAjIEVuYWJsZSB0aGUgdXNhZ2Ugb2YgT3Blbk1QLgogIyAgLSBBdCB0aGlzIG1v bWVudCwgT3Blbk1QIGlzIG9ubHkgdXNlZCBhcyBhbiBhbHRlcm5hdGl2ZSBpbXBsZW1lbnRhdGlv bgogIyAgICB0byBuYXRpdmUgdGhyZWFkcyBmb3IgdGhlIHBhcmFsbGVsaXphdGlvbiBvZiB0aGUg U1ZHIGZpbHRlcnMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFrZSBi L1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCmluZGV4IDA2ZTFlMmZjYTdjMmE4MGM2OTAz YjZlMDA4ZTQ3NjBiNmM3ZTY3MzIuLjQwODFmY2MxNWY0MjU4ZjFmOWQ5NjQxNzAyYzUxNzYzOTQ3 YzMxNWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCisrKyBiL1Nv dXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCkBAIC0yODIsMTEgKzI4Miw2IEBAIGlmIChFTkFC TEVfU1BFRUNIX1NZTlRIRVNJUykKICAgICBmaW5kX3BhY2thZ2UoRXNwZWFrIFJFUVVJUkVEKQog ZW5kaWYgKCkKIAotaWYgKFVTRV9MTFZNX0RJU0FTU0VNQkxFUikKLSAgICBmaW5kX3BhY2thZ2Uo TExWTSBSRVFVSVJFRCkKLSAgICBTRVRfQU5EX0VYUE9TRV9UT19CVUlMRChIQVZFX0xMVk0gVFJV RSkKLWVuZGlmICgpCi0KIGlmIChFTkFCTEVfRlRMX0pJVCBBTkQgTk9UIFdURl9DUFVfWDg2XzY0 IEFORCBOT1QgREVWRUxPUEVSX01PREUpCiAgICAgbWVzc2FnZShGQVRBTF9FUlJPUiAiRlRMIEpJ VCBpcyBvbmx5IGF2YWlsYWJsZSBvbiBYODZfNjQgYXJjaGl0ZWN0dXJlLiIpCiBlbmRpZiAoKQpk aWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2UgYi9Tb3VyY2UvY21ha2Uv T3B0aW9uc0dUSy5jbWFrZQppbmRleCBkZDE4MDEzNGI0YTg0ZjUzZWY3NTU1YWRhNGVlYjliNGE0 MjJlYWFlLi41MjM1OGZiOGUxODA4YzliZjUwMDMxZDE2ZGEwOWY3MWYxZmI1YmZjIDEwMDY0NAot LS0gYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZQpAQCAtMjM0LDE4ICsyMzQsNiBAQCBpZiAoRU5BQkxFX0NSRURFTlRJQUxf U1RPUkFHRSkKICAgICBlbmRpZiAoKQogZW5kaWYgKCkKIAotaWYgKFVTRV9MTFZNX0RJU0FTU0VN QkxFUikKLSAgICBpZiAoV1RGX0NQVV9YODZfNjQpCi0gICAgICAgIGZpbmRfcGFja2FnZShMTFZN IDMuNykKLSAgICAgICAgaWYgKE5PVCBMTFZNX0ZPVU5EKQotICAgICAgICAgICAgbWVzc2FnZShG QVRBTF9FUlJPUiAiTExWTSAzLjcgaXMgcmVxdWlyZWQgZm9yIFVTRV9MTFZNX0RJU0FTU0VNQkxF UiIpCi0gICAgICAgIGVuZGlmICgpCi0gICAgICAgIFNFVF9BTkRfRVhQT1NFX1RPX0JVSUxEKEhB VkVfTExWTSBUUlVFKQotICAgIGVsc2UgKCkKLSAgICAgICAgbWVzc2FnZShGQVRBTF9FUlJPUiAi RlRMIGlzIG9ubHkgc3VwcG9ydGVkIGZvciBYODZfNjQiKQotICAgIGVuZGlmICgpCi1lbmRpZiAo KQotCiBpZiAoRU5BQkxFX0dBTUVQQURfREVQUkVDQVRFRCkKICAgICBmaW5kX3BhY2thZ2UoR1Vk ZXYpCiAgICAgaWYgKE5PVCBHVURFVl9GT1VORCkKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0No YW5nZUxvZwppbmRleCBmOWIzYzI2ZWEwMGUxZjZkM2E2NWViMTk1ZmI4N2NmYTBhYWEyZWI5Li4w ODIwNDEzZDc0ZjJlMjQwZjFiYzNiOTcyNDU3NjBmMTQzOWNiMzQwIDEwMDY0NAotLS0gYS9DaGFu Z2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTYtMDItMDcgIEtvbnN0 YW50aW4gVG9rYXJldiAgPGFubnVsZW5AeWFuZGV4LnJ1PgorCisgICAgICAgIFtjbWFrZV0gTW92 ZSBMTFZNIGRldGVjdGlvbiBmb3IgTExWTURpc2Fzc2VtYmxlciB0byBPcHRpb25zQ29tbW9uLmNt YWtlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTM5 NjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNv dXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlOgorICAgICAgICAqIFNvdXJjZS9jbWFrZS9P cHRpb25zRWZsLmNtYWtlOgorICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtl OgorCiAyMDE2LTAyLTA0ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAK ICAgICAgICAgVW5yZXZpZXdlZCBub24gWDg2XzY0IGJ1aWxkZml4IGFmdGVyIHIxOTYwNzcuCg==