153955 2016-02-06 15:08:14 -0800 FTL must store the call site index before runtime calls, even if it's the tail call slow path 2016-02-06 17:51:26 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1162667 0 fpizlo 2016-02-06 15:08:14 -0800 Patch forthcoming. 1162670 1 270807 fpizlo 2016-02-06 15:14:00 -0800 Created attachment 270807 the patch 1162674 2 270807 saam 2016-02-06 15:23:07 -0800 Comment on attachment 270807 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=270807&action=review > Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:5216 > + // with the call site index of our frame. Bad things happen if it's not set. Might be worth adding a test for this if it's not too difficult to write one. 1162675 3 270807 saam 2016-02-06 15:24:04 -0800 Comment on attachment 270807 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=270807&action=review > Source/JavaScriptCore/ChangeLog:9 > + The reasoning is explained in a comment in compileTailCall(). It's probably worth writing out the comment in the change log for posterity. 1162683 4 fpizlo 2016-02-06 17:40:42 -0800 (In reply to comment #2) > Comment on attachment 270807 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=270807&action=review > > > Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:5216 > > + // with the call site index of our frame. Bad things happen if it's not set. > > Might be worth adding a test for this if it's not too difficult to write one. I'll try. :-) 1162684 5 fpizlo 2016-02-06 17:40:49 -0800 (In reply to comment #3) > Comment on attachment 270807 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=270807&action=review > > > Source/JavaScriptCore/ChangeLog:9 > > + The reasoning is explained in a comment in compileTailCall(). > > It's probably worth writing out the comment in the change log for posterity. Will do. 1162686 6 fpizlo 2016-02-06 17:51:26 -0800 Landed in http://trac.webkit.org/changeset/196232 270807 2016-02-06 15:14:00 -0800 2016-02-06 15:23:07 -0800 the patch blah.patch text/plain 2292 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk2MjIyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE2LTAyLTA2ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg RlRMIG11c3Qgc3RvcmUgdGhlIGNhbGwgc2l0ZSBpbmRleCBiZWZvcmUgcnVudGltZSBjYWxscywg ZXZlbiBpZiBpdCdzIHRoZSB0YWlsIGNhbGwgc2xvdyBwYXRoCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTM5NTUKKyAgICAgICAgcmRhcjovL3Byb2Js ZW0vMjQyOTA5NzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUaGUgcmVhc29uaW5nIGlzIGV4cGxhaW5lZCBpbiBhIGNvbW1lbnQgaW4gY29tcGlsZVRh aWxDYWxsKCkuCisKKyAgICAgICAgKiBmdGwvRlRMTG93ZXJERkdUb0xMVk0uY3BwOgorICAgICAg ICAoSlNDOjpGVEw6OkRGRzo6TG93ZXJERkdUb0xMVk06OmNvbXBpbGVUYWlsQ2FsbCk6CisKIDIw MTYtMDItMDYgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBPYmpl Y3QuZ2V0T3duUHJvcGVydHlEZXNjcmlwdG9yKCkgZG9lcyBub3Qgd29yayBvbiBzdWItZnJhbWUn cyB3aW5kb3cKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0xM Vk0uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJE RkdUb0xMVk0uY3BwCShyZXZpc2lvbiAxOTYxNzcpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUv ZnRsL0ZUTExvd2VyREZHVG9MTFZNLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTE4Niw2ICs1MTg2 LDcgQEAgcHJpdmF0ZToKICAgICAgICAgcGF0Y2hwb2ludC0+c2V0R2VuZXJhdG9yKAogICAgICAg ICAgICAgWz1dIChDQ2FsbEhlbHBlcnMmIGppdCwgY29uc3QgU3RhY2ttYXBHZW5lcmF0aW9uUGFy YW1zJiBwYXJhbXMpIHsKICAgICAgICAgICAgICAgICBBbGxvd01hY3JvU2NyYXRjaFJlZ2lzdGVy VXNhZ2UgYWxsb3dTY3JhdGNoKGppdCk7CisgICAgICAgICAgICAgICAgQ2FsbFNpdGVJbmRleCBj YWxsU2l0ZUluZGV4ID0gc3RhdGUtPmppdENvZGUtPmNvbW1vbi5hZGRVbmlxdWVDYWxsU2l0ZUlu ZGV4KGNvZGVPcmlnaW4pOwogCiAgICAgICAgICAgICAgICAgQ2FsbEZyYW1lU2h1ZmZsZURhdGEg c2h1ZmZsZURhdGE7CiAgICAgICAgICAgICAgICAgc2h1ZmZsZURhdGEubnVtTG9jYWxzID0gc3Rh dGUtPmppdENvZGUtPmNvbW1vbi5mcmFtZVJlZ2lzdGVyQ291bnQ7CkBAIC01MjEwLDYgKzUyMTEs MTMgQEAgcHJpdmF0ZToKIAogICAgICAgICAgICAgICAgIHNsb3dQYXRoLmxpbmsoJmppdCk7CiAK KyAgICAgICAgICAgICAgICAvLyBZZXMsIHRoaXMgaXMgcmVhbGx5IG5lY2Vzc2FyeS4gWW91IGNv dWxkIHRocm93IGFuIGV4Y2VwdGlvbiBpbiBhIGhvc3QgY2FsbCBvbiB0aGUKKyAgICAgICAgICAg ICAgICAvLyBzbG93IHBhdGguIFRoYXQnbGwgcm91dGUgdXMgdG8gbG9va3VwRXhjZXB0aW9uSGFu ZGxlcigpLCB3aGljaCB1bndpbmRzIHN0YXJ0aW5nCisgICAgICAgICAgICAgICAgLy8gd2l0aCB0 aGUgY2FsbCBzaXRlIGluZGV4IG9mIG91ciBmcmFtZS4gQmFkIHRoaW5ncyBoYXBwZW4gaWYgaXQn cyBub3Qgc2V0LgorICAgICAgICAgICAgICAgIGppdC5zdG9yZTMyKAorICAgICAgICAgICAgICAg ICAgICBDQ2FsbEhlbHBlcnM6OlRydXN0ZWRJbW0zMihjYWxsU2l0ZUluZGV4LmJpdHMoKSksCisg ICAgICAgICAgICAgICAgICAgIENDYWxsSGVscGVyczo6dGFnRm9yKFZpcnR1YWxSZWdpc3RlcihK U1N0YWNrOjpBcmd1bWVudENvdW50KSkpOworCiAgICAgICAgICAgICAgICAgQ2FsbEZyYW1lU2h1 ZmZsZXIgc2xvd1BhdGhTaHVmZmxlcihqaXQsIHNodWZmbGVEYXRhKTsKICAgICAgICAgICAgICAg ICBzbG93UGF0aFNodWZmbGVyLnNldENhbGxlZUpTVmFsdWVSZWdzKEpTVmFsdWVSZWdzKEdQUklu Zm86OnJlZ1QwKSk7CiAgICAgICAgICAgICAgICAgc2xvd1BhdGhTaHVmZmxlci5wcmVwYXJlRm9y U2xvd1BhdGgoKTsK