153954 2016-02-06 14:13:46 -0800 Call CFRelease() on SecRequirementRef when no longer needed 2016-02-06 18:03:26 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Local Build Mac OS X 10.11 RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates aestes andersca bfulgham mitz sam webkit-bug-importer oldest_to_newest 1162661 0 dbates 2016-02-06 14:13:46 -0800 We should call CFRelease() on the SecRequirementRef allocated by SecRequirementCreateWithString() when we are done using it to avoid a memory leak. 1162662 1 webkit-bug-importer 2016-02-06 14:14:50 -0800 <rdar://problem/24540259> 1162663 2 270804 dbates 2016-02-06 14:17:28 -0800 Created attachment 270804 Patch 1162688 3 270804 dbates 2016-02-06 18:03:23 -0800 Comment on attachment 270804 Patch Clearing flags on attachment: 270804 Committed r196234: <http://trac.webkit.org/changeset/196234> 1162689 4 dbates 2016-02-06 18:03:26 -0800 All reviewed patches have been landed. Closing bug. 270804 2016-02-06 14:17:28 -0800 2016-02-06 18:03:23 -0800 Patch bug-153954-20160206141706.patch text/plain 2544 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTk2MjIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggY2FiOGMyOGUzZDI2NWNk MWEwMGMxYzczNzY3Y2M1YzlkNjZiNGJkNy4uMGQ4YzRhYTcwODJhMmFlMGZmNmIzMTUxNWJmZTc4 NWVkZDE4MThkOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE2LTAyLTA2ICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBDYWxsIENGUmVsZWFzZSgp IG9uIFNlY1JlcXVpcmVtZW50UmVmIHdoZW4gbm8gbG9uZ2VyIG5lZWRlZAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUzOTU0CisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS8yNDU0MDI1OT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFNoYXJlZC9tYWMvQ2hpbGRQcm9jZXNzTWFjLm1tOgorICAgICAgICAo V2ViS2l0OjpDaGlsZFByb2Nlc3M6OmluaXRpYWxpemVTYW5kYm94KToKKwogMjAxNi0wMi0wNiAg Q2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5y ZXZpZXdlZC4gRml4IG1vcmUgaW5jb3JyZWN0IEFTU0VSVCBpbnRyb2R1Y2VkIGluIHIxOTYwNTMu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvbWFjL0NoaWxkUHJvY2Vzc01hYy5t bSBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9tYWMvQ2hpbGRQcm9jZXNzTWFjLm1tCmluZGV4IGZm YzkxNDMyMjE1ZjlhNGUxNGNiNzM2NzExN2RkNTRjMzY0YTM0MWYuLmI5ZmYyYTYxODY4NjUxNmY2 NzYxOTRkNmYzZTU2ODJhOGZiZjdkYmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJl ZC9tYWMvQ2hpbGRQcm9jZXNzTWFjLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9tYWMv Q2hpbGRQcm9jZXNzTWFjLm1tCkBAIC0xMDIsNyArMTAyLDcgQEAgdm9pZCBDaGlsZFByb2Nlc3M6 OmluaXRpYWxpemVTYW5kYm94KGNvbnN0IENoaWxkUHJvY2Vzc0luaXRpYWxpemF0aW9uUGFyYW1l dGVycyYKICAgICAgICAgICAgIFJFTEVBU0VfQVNTRVJUKGNvZGUpOwogCiAgICAgICAgICAgICBD RlN0cmluZ1JlZiBhcHBsZVNpZ25lZE9yTWFjQXBwU3RvcmVTaWduZWRPckFwcGxlRGV2ZWxvcGVy U2lnbmVkUmVxdWlyZW1lbnQgPSBDRlNUUigiKGFuY2hvciBhcHBsZSkgb3IgKGFuY2hvciBhcHBs ZSBnZW5lcmljIGFuZCBjZXJ0aWZpY2F0ZSBsZWFmW2ZpZWxkLjEuMi44NDAuMTEzNjM1LjEwMC42 LjEuOV0pIG9yIChhbmNob3IgYXBwbGUgZ2VuZXJpYyBhbmQgY2VydGlmaWNhdGUgMVtmaWVsZC4x LjIuODQwLjExMzYzNS4xMDAuNi4yLjZdIGFuZCBjZXJ0aWZpY2F0ZSBsZWFmW2ZpZWxkLjEuMi44 NDAuMTEzNjM1LjEwMC42LjEuMTNdKSIpOwotICAgICAgICAgICAgU2VjUmVxdWlyZW1lbnRSZWYg c2lnbmluZ1JlcXVpcmVtZW50OworICAgICAgICAgICAgU2VjUmVxdWlyZW1lbnRSZWYgc2lnbmlu Z1JlcXVpcmVtZW50ID0gbnVsbHB0cjsKICAgICAgICAgICAgIE9TU3RhdHVzIHN0YXR1cyA9IFNl Y1JlcXVpcmVtZW50Q3JlYXRlV2l0aFN0cmluZyhhcHBsZVNpZ25lZE9yTWFjQXBwU3RvcmVTaWdu ZWRPckFwcGxlRGV2ZWxvcGVyU2lnbmVkUmVxdWlyZW1lbnQsIGtTZWNDU0RlZmF1bHRGbGFncywg JnNpZ25pbmdSZXF1aXJlbWVudCk7CiAgICAgICAgICAgICBSRUxFQVNFX0FTU0VSVChzdGF0dXMg PT0gZXJyU2VjU3VjY2Vzcyk7CiAKQEAgLTEyNiw2ICsxMjYsNyBAQCB2b2lkIENoaWxkUHJvY2Vz czo6aW5pdGlhbGl6ZVNhbmRib3goY29uc3QgQ2hpbGRQcm9jZXNzSW5pdGlhbGl6YXRpb25QYXJh bWV0ZXJzJgogICAgICAgICAgICAgICAgICAgICBzYW5kYm94UGFyYW1ldGVycy5zZXRVc2VyRGly ZWN0b3J5U3VmZml4KFttYWtlU3RyaW5nKHVzZXJEaXJlY3RvcnlTdWZmaXgtPnZhbHVlLCAnLycs IFN0cmluZyhbW05TQnVuZGxlIG1haW5CdW5kbGVdIGJ1bmRsZUlkZW50aWZpZXJdKSkgZmlsZVN5 c3RlbVJlcHJlc2VudGF0aW9uXSk7CiAgICAgICAgICAgICAgICAgc2FuZGJveFBhcmFtZXRlcnMu c2V0VXNlckRpcmVjdG9yeVN1ZmZpeChtYWtlU3RyaW5nKFN0cmluZyhbW05TQnVuZGxlIG1haW5C dW5kbGVdIGJ1bmRsZUlkZW50aWZpZXJdKSwgJysnLCBwYXJhbWV0ZXJzLmNsaWVudElkZW50aWZp ZXIpKTsKICAgICAgICAgICAgIH0KKyAgICAgICAgICAgIENGUmVsZWFzZShzaWduaW5nUmVxdWly ZW1lbnQpOwogICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAgLy8gTGVnYWN5IGNsaWVudAog ICAgICAgICAgICAgc2FuZGJveFBhcmFtZXRlcnMuc2V0VXNlckRpcmVjdG9yeVN1ZmZpeChtYWtl U3RyaW5nKFN0cmluZyhbW05TQnVuZGxlIG1haW5CdW5kbGVdIGJ1bmRsZUlkZW50aWZpZXJdKSwg JysnLCBwYXJhbWV0ZXJzLmNsaWVudElkZW50aWZpZXIpKTsK