153945 2016-02-06 09:35:07 -0800 REGRESSION(r196183): [GTK] Broke TestInspector 2016-02-09 22:54:06 -0800 1 1 1 Unclassified WebKit WebKitGTK Other PC Linux RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=152867 P2 Normal --- 1 mcatanzaro webkit-unassigned bugs-noreply cgarcia mcatanzaro timothy oldest_to_newest 1162624 0 mcatanzaro 2016-02-06 09:35:07 -0800 r196183 broke TestInspector: TEST: ./Tools/gtk/../../WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestInspector... (pid=6821) /webkit2/WebKitWebInspector/default: OK /webkit2/WebKitWebInspector/manual-attach-detach: (./Tools/gtk/../../WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestInspector:6821): Gtk-CRITICAL **: gtk_container_remove: assertion 'gtk_widget_get_parent (widget) == GTK_WIDGET (container) || GTK_IS_ASSISTANT (container) || GTK_IS_ACTION_BAR (container) || GTK_IS_POPOVER_MENU (container)' failed FAIL 1163165 1 270920 cgarcia 2016-02-09 03:18:48 -0800 Created attachment 270920 Patch 1163411 2 cgarcia 2016-02-09 22:54:06 -0800 Committed r196363: <http://trac.webkit.org/changeset/196363> 270920 2016-02-09 03:18:48 -0800 2016-02-09 06:50:10 -0800 Patch wk2-inspector-detach-on-close.diff text/plain 2550 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA4Nzk0MzVhLi40NWMxNzkxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYg QEAKKzIwMTYtMDItMDkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFJFR1JFU1NJT04ocjE5NjE4Myk6IFtHVEtdIEJyb2tlIFRlc3RJbnNwZWN0 b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1Mzk0 NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4g dGhlIGluc3BlY3RvciB2aWV3IGlzIGRldGFjaGVkIGFuZCBub3QgYWRkZWQgdG8gYSB3aW5kb3cs CisgICAgICAgIHdoaWNoIGhhcHBlbnMgd2hlbiBpdCdzIGNsb3NlZCwgdGhlIGluc3BlY3RvciB2 aWV3IGlzIGRlc3Ryb3llZAorICAgICAgICBiZWNhdXNlIGl0IGRvZXNuJ3QgaGF2ZSBhIHBhcmVu dCBhbnltb3JlLiBXaGVuIHRoZSBpbnNwZWN0b3IgdmlldworICAgICAgICBpcyBkZXN0cm95ZWQg d2Ugbm90aWZ5IHRoZSB3ZWIgcHJvY2VzcyB0aGF0IHRoZSBpbnNwZWN0b3Igd2FzCisgICAgICAg IGNsb3NlZC4gQmVmb3JlIHIxOTYxODMgdGhpcyB3YXMgbm90IGEgcHJvYmxlbSwgYmVjYXVzZSB0 aGUgY2FsbCB0bworICAgICAgICBXZWJJbnNwZWN0b3JQcm94eTo6ZGlkQ2xvc2UoKSBmcm9tIHBs YXRmb3JtRGV0YWNoKCkgcmV0dXJuZWQgZWFybHkKKyAgICAgICAgYmVjYXVzZSBXZWJJbnNwZWN0 b3JQcm94eTo6ZGlkQ2xvc2UoKSBoYWQgYWxyZWFkeSBzZXQKKyAgICAgICAgbV9pbnNwZWN0b3JQ YWdlIHRvIG51bGxwdHIuIEluIHIxOTYxODMgbV9pbnNwZWN0b3JQYWdlIGlzIHNldCB0bworICAg ICAgICBudWxscHRyIGFmdGVyIHBsYXRmb3JtRGV0YWNoKCksIHNvIHdlIGVuZCB1cCB0cnlpbmcg dG8gZGV0YWNoIHRoZQorICAgICAgICBpbnBlY3RvciB2aWV3IGFnYWluLiBUbyBwcmV2ZW50IHRo aXMgY3ljbGUsIHdlIHNob3VsZCBkaXNjb25uZWN0CisgICAgICAgIHRoZSBkZXN0cm95ZWQgc2ln bmFsIGhhbmRsZXIgZnJvbSB0aGUgaW5zcGVjdG9yIHZpZXcgd2hlbgorICAgICAgICBwbGF0Zm9y bURldGFjaCgpIGlzIGNhbGxlZCBmcm9tIFdlYkluc3BlY3RvclByb3h5OjpkaWRDbG9zZSgpLgor CisgICAgICAgICogVUlQcm9jZXNzL2d0ay9XZWJJbnNwZWN0b3JQcm94eUd0ay5jcHA6CisgICAg ICAgIChXZWJLaXQ6OldlYkluc3BlY3RvclByb3h5OjpwbGF0Zm9ybURldGFjaCk6CisKIDIwMTYt MDItMDkgIEZ1amlpIEhpcm9ub3JpICA8SGlyb25vcmkuRnVqaWlAanAuc29ueS5jb20+CiAKICAg ICAgICAgcG9zc2libGUgYnVmZmVyIG92ZXJydW4gaW4gQ29ubmVjdGlvbjo6cHJvY2Vzc01lc3Nh Z2Ugb2YgU291cmNlL1dlYktpdDIvUGxhdGZvcm0vSVBDL3VuaXgvQ29ubmVjdGlvblVuaXguY3Bw CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1dlYkluc3BlY3RvclBy b3h5R3RrLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsvV2ViSW5zcGVjdG9yUHJv eHlHdGsuY3BwCmluZGV4IDA3ZTEzZmQuLjJjMGUxNDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9ndGsvV2ViSW5zcGVjdG9yUHJveHlHdGsuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9ndGsvV2ViSW5zcGVjdG9yUHJveHlHdGsuY3BwCkBAIC0zMTksOCAr MzE5LDE1IEBAIHZvaWQgV2ViSW5zcGVjdG9yUHJveHk6OnBsYXRmb3JtRGV0YWNoKCkKICAgICAg ICAgICAgIGd0a19jb250YWluZXJfcmVtb3ZlKEdUS19DT05UQUlORVIocGFyZW50KSwgbV9pbnNw ZWN0b3JWaWV3KTsKICAgICB9CiAKLSAgICBpZiAoIW1faXNWaXNpYmxlKQorICAgIC8vIFJldHVy biBlYXJseSBpZiB3ZSBhcmUgbm90IHZpc2libGUuIFRoaXMgbWVhbnMgdGhlIGluc3BlY3RvciB3 YXMgY2xvc2VkIHdoaWxlIGF0dGFjaGVkCisgICAgLy8gYW5kIHdlIHNob3VsZCBub3QgY3JlYXRl IGFuZCBzaG93IHRoZSBpbnNwZWN0b3Igd2luZG93LgorICAgIGlmICghbV9pc1Zpc2libGUpIHsK KyAgICAgICAgLy8gVGhlIGluc3BlY3RvciB2aWV3IHdpbGwgYmUgZGVzdHJveWVkLCBidXQgd2Ug ZG9uJ3QgbmVlZCB0byBub3RpZnkgdGhlIHdlYiBwcm9jZXNzIHRvIGNsb3NlIHRoZQorICAgICAg ICAvLyBpbnNwZWN0b3IgaW4gdGhpcyBjYXNlLCBzaW5jZSBpdCdzIGFscmVhZHkgY2xvc2VkLgor ICAgICAgICBnX3NpZ25hbF9oYW5kbGVyc19kaXNjb25uZWN0X2J5X2Z1bmMobV9pbnNwZWN0b3JW aWV3LCByZWludGVycHJldF9jYXN0PHZvaWQqPihpbnNwZWN0b3JWaWV3RGVzdHJveWVkKSwgdGhp cyk7CisgICAgICAgIG1faW5zcGVjdG9yVmlldyA9IG51bGxwdHI7CiAgICAgICAgIHJldHVybjsK KyAgICB9CiAKICAgICBjcmVhdGVJbnNwZWN0b3JXaW5kb3coKTsKIH0K