153900 2016-02-04 15:48:55 -0800 Fix iOS API tests after r196802 2016-02-05 13:53:08 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achristensen achristensen ap commit-queue dbates ddkilzer jer.noble ryanhaddad oldest_to_newest 1162224 0 achristensen 2016-02-04 15:48:55 -0800 Fix iOS API tests after r196802 1162225 1 270700 achristensen 2016-02-04 15:49:07 -0800 Created attachment 270700 Patch 1162226 2 achristensen 2016-02-04 15:50:09 -0800 This is the output when I run "run-api-tests -v --ios-simulator WebCoreNSURLSessionTest" without this patch: ASSERTION FAILED: allocator /Volumes/Code/fuji/OpenSource/Source/JavaScriptCore/jit/ExecutableAllocatorFixedVMPool.cpp(129) : JSC::ExecutableAllocator::ExecutableAllocator(JSC::VM &) 1 0x10ee3845d WTFCrash 2 0x10e879b72 JSC::ExecutableAllocator::ExecutableAllocator(JSC::VM&) 3 0x10e879b9d JSC::ExecutableAllocator::ExecutableAllocator(JSC::VM&) 4 0x10edc8fc3 JSC::VM::VM(JSC::VM::VMType, JSC::HeapType) 5 0x10edcc841 JSC::VM::VM(JSC::VM::VMType, JSC::HeapType) 6 0x10edcde56 JSC::VM::create(JSC::HeapType) 7 0x10edcde8a JSC::VM::createLeaked(JSC::HeapType) 8 0x113f2788a WebCore::JSDOMWindowBase::commonVM() 9 0x114710ac4 WebCore::PageScriptDebugServer::PageScriptDebugServer(WebCore::Page&) 10 0x114710b1d WebCore::PageScriptDebugServer::PageScriptDebugServer(WebCore::Page&) 11 0x113cb7334 WebCore::InspectorController::InspectorController(WebCore::Page&, WebCore::InspectorClient*) 12 0x113cbcc95 WebCore::InspectorController::InspectorController(WebCore::Page&, WebCore::InspectorClient*) 13 0x1146e3e14 std::_Unique_if<WebCore::InspectorController>::_Single_object std::make_unique<WebCore::InspectorController, WebCore::Page&, WebCore::InspectorClient*&>(WebCore::Page&&&, WebCore::InspectorClient*&&&) 14 0x1146dafaf WebCore::Page::Page(WebCore::PageConfiguration&) 15 0x1146dbced WebCore::Page::Page(WebCore::PageConfiguration&) 16 0x11f952e86 -[WebView(WebPrivate) _commonInitializationWithFrameName:groupName:] 17 0x11f953e49 -[WebView(WebPrivate) _initWithFrame:frameName:groupName:] 18 0x11f96346f -[WebView initWithFrame:frameName:groupName:] 19 0x11f9633ca -[WebView initWithFrame:] 20 0x10dde1a10 TestWebKitAPI::WebCoreNSURLSessionTest::SetUp() 21 0x10ddfd46e testing::Test::Run() 22 0x10ddfdd7d testing::internal::TestInfoImpl::Run() 23 0x10ddfe8bd testing::TestCase::Run() 24 0x10de046bb testing::internal::UnitTestImpl::RunAllTests() 25 0x10de04339 testing::UnitTest::Run() 26 0x10dd6e4cc TestWebKitAPI::TestsController::run(int, char**) 27 0x10ddc3b65 main 28 0x11cbb78d1 start 29 0x2 Child process terminated with signal 11: Segmentation fault ASSERTION FAILED: allocator /Volumes/Code/fuji/OpenSource/Source/JavaScriptCore/jit/ExecutableAllocatorFixedVMPool.cpp(129) : JSC::ExecutableAllocator::ExecutableAllocator(JSC::VM &) 1 0x1086a145d WTFCrash 2 0x1080e2b72 JSC::ExecutableAllocator::ExecutableAllocator(JSC::VM&) 3 0x1080e2b9d JSC::ExecutableAllocator::ExecutableAllocator(JSC::VM&) 4 0x108631fc3 JSC::VM::VM(JSC::VM::VMType, JSC::HeapType) 5 0x108635841 JSC::VM::VM(JSC::VM::VMType, JSC::HeapType) 6 0x108636e56 JSC::VM::create(JSC::HeapType) 7 0x108636e8a JSC::VM::createLeaked(JSC::HeapType) 8 0x10d79088a WebCore::JSDOMWindowBase::commonVM() 9 0x10df79ac4 WebCore::PageScriptDebugServer::PageScriptDebugServer(WebCore::Page&) 10 0x10df79b1d WebCore::PageScriptDebugServer::PageScriptDebugServer(WebCore::Page&) 11 0x10d520334 WebCore::InspectorController::InspectorController(WebCore::Page&, WebCore::InspectorClient*) 12 0x10d525c95 WebCore::InspectorController::InspectorController(WebCore::Page&, WebCore::InspectorClient*) 13 0x10df4ce14 std::_Unique_if<WebCore::InspectorController>::_Single_object std::make_unique<WebCore::InspectorController, WebCore::Page&, WebCore::InspectorClient*&>(WebCore::Page&&&, WebCore::InspectorClient*&&&) 14 0x10df43faf WebCore::Page::Page(WebCore::PageConfiguration&) 15 0x10df44ced WebCore::Page::Page(WebCore::PageConfiguration&) 16 0x1191bbe86 -[WebView(WebPrivate) _commonInitializationWithFrameName:groupName:] 17 0x1191bce49 -[WebView(WebPrivate) _initWithFrame:frameName:groupName:] 18 0x1191cc46f -[WebView initWithFrame:frameName:groupName:] 19 0x1191cc3ca -[WebView initWithFrame:] 20 0x10764aa10 TestWebKitAPI::WebCoreNSURLSessionTest::SetUp() 21 0x10766646e testing::Test::Run() 22 0x107666d7d testing::internal::TestInfoImpl::Run() 23 0x1076678bd testing::TestCase::Run() 24 0x10766d6bb testing::internal::UnitTestImpl::RunAllTests() 25 0x10766d339 testing::UnitTest::Run() 26 0x1075d74cc TestWebKitAPI::TestsController::run(int, char**) 27 0x10762cb65 main 28 0x1164208d1 start 29 0x2 1162230 3 270700 ap 2016-02-04 15:57:34 -0800 Comment on attachment 270700 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270700&action=review > Tools/TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:115 > + WTF::initializeMainThread(); > + JSC::initializeThreading(); > + RunLoop::initializeMainRunLoop(); > view = [[WebView alloc] initWithFrame:NSZeroRect]; Why does this not happen automatically? I thought that WebView class instantiation was supposed to do this. 1162231 4 achristensen 2016-02-04 15:58:34 -0800 I don't know, but this fixes the test all the time. 1162235 5 270703 achristensen 2016-02-04 16:07:25 -0800 Created attachment 270703 Patch 1162236 6 achristensen 2016-02-04 16:08:16 -0800 This solves it, too. There are lots of places where we have !PLATFORM(IOS) protections around initializeThreading calls, and I don't know why. 1162247 7 ap 2016-02-04 17:12:58 -0800 Perhaps Dan or David remember why? 1162477 8 270766 achristensen 2016-02-05 13:20:25 -0800 Created attachment 270766 Patch 1162482 9 achristensen 2016-02-05 13:27:05 -0800 This is instead of https://bugs.webkit.org/show_bug.cgi?id=153885 1162489 10 jer.noble 2016-02-05 13:52:48 -0800 *** Bug 153885 has been marked as a duplicate of this bug. *** 1162490 11 270766 commit-queue 2016-02-05 13:53:04 -0800 Comment on attachment 270766 Patch Clearing flags on attachment: 270766 Committed r196189: <http://trac.webkit.org/changeset/196189> 1162491 12 commit-queue 2016-02-05 13:53:08 -0800 All reviewed patches have been landed. Closing bug. 270700 2016-02-04 15:49:07 -0800 2016-02-04 16:07:22 -0800 Patch bug-153900-20160204154844.patch text/plain 1523 achristensen SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE5NjE1MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE2LTAyLTA0ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdl YmtpdC5vcmc+CisKKyAgICAgICAgRml4IGlPUyBBUEkgdGVzdHMgYWZ0ZXIgcjE5NjgwMgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUzOTAwCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0 QVBJL1Rlc3RzL1dlYkNvcmUvV2ViQ29yZU5TVVJMU2Vzc2lvbi5tbToKKyAgICAgICAgKFRlc3RX ZWJLaXRBUEk6OldlYkNvcmVOU1VSTFNlc3Npb25UZXN0OjpTZXRVcCk6CisKIDIwMTYtMDItMDMg IEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBydW4tanNjLXN0cmVz cy10ZXN0cyBzaG91bGQgYmUgYmV0dGVyIGF0IHRlbGxpbmcgeW91IGRldGFpbHMgYWJvdXQgdGVz dCBmYWlsdXJlcwpJbmRleDogVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL1dlYkNv cmVOU1VSTFNlc3Npb24ubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0 cy9XZWJDb3JlL1dlYkNvcmVOU1VSTFNlc3Npb24ubW0JKHJldmlzaW9uIDE5NjE0NCkKKysrIFRv b2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS9XZWJDb3JlTlNVUkxTZXNzaW9uLm1tCSh3 b3JraW5nIGNvcHkpCkBAIC0yOCw2ICsyOCw3IEBACiAjaWYgUExBVEZPUk0oSU9TKSB8fCBfX01B Q19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwMTEwMAogCiAjaW1wb3J0ICJQbGF0Zm9y bVV0aWxpdGllcy5oIgorI2ltcG9ydCA8SmF2YVNjcmlwdENvcmUvSW5pdGlhbGl6ZVRocmVhZGlu Zy5oPgogI2ltcG9ydCA8V2ViS2l0L1dlYlZpZXcuaD4KICNpbXBvcnQgPFdlYkNvcmUvRnJhbWVM b2FkUmVxdWVzdC5oPgogI2ltcG9ydCA8V2ViQ29yZS9NYWluRnJhbWUuaD4KQEAgLTEwOCw2ICsx MDksOSBAQCBwdWJsaWM6CiAKICAgICB2aXJ0dWFsIHZvaWQgU2V0VXAoKQogICAgIHsKKyAgICAg ICAgV1RGOjppbml0aWFsaXplTWFpblRocmVhZCgpOworICAgICAgICBKU0M6OmluaXRpYWxpemVU aHJlYWRpbmcoKTsKKyAgICAgICAgUnVuTG9vcDo6aW5pdGlhbGl6ZU1haW5SdW5Mb29wKCk7CiAg ICAgICAgIHZpZXcgPSBbW1dlYlZpZXcgYWxsb2NdIGluaXRXaXRoRnJhbWU6TlNaZXJvUmVjdF07 CiAgICAgICAgIHZpZXcuZnJhbWVMb2FkRGVsZWdhdGUgPSBbW1tUZXN0TlNVUkxTZXNzaW9uTG9h ZGVyRGVsZWdhdGUgYWxsb2NdIGluaXRdIGF1dG9yZWxlYXNlXTsKIAo= 270703 2016-02-04 16:07:25 -0800 2016-02-05 13:20:23 -0800 Patch bug-153900-20160204160701.patch text/plain 1282 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5NjE1NCkKKysrIFNvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE2LTAyLTA0 ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAg Rml4IGlPUyBBUEkgdGVzdHMgYWZ0ZXIgcjE5NjgwMgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUzOTAwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJWaWV3L1dlYlZpZXcubW06CisgICAgICAgICgr W1dlYlZpZXcgaW5pdGlhbGl6ZV0pOgorCiAyMDE2LTAyLTAzICBKZXNzaWUgQmVybGluICA8amJl cmxpbkB3ZWJraXQub3JnPgogCiAgICAgICAgIEJ1aWxkIGZpeC4KSW5kZXg6IFNvdXJjZS9XZWJL aXQvbWFjL1dlYlZpZXcvV2ViVmlldy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L21h Yy9XZWJWaWV3L1dlYlZpZXcubW0JKHJldmlzaW9uIDE5NjE0NCkKKysrIFNvdXJjZS9XZWJLaXQv bWFjL1dlYlZpZXcvV2ViVmlldy5tbQkod29ya2luZyBjb3B5KQpAQCAtNDcxOCwxMSArNDcxOCwx MSBAQCArICh2b2lkKWluaXRpYWxpemUKICAgICBpbml0aWFsaXplZCA9IFlFUzsKIAogICAgIElu aXRXZWJDb3JlU3lzdGVtSW50ZXJmYWNlKCk7Ci0jaWYgIVBMQVRGT1JNKElPUykKICAgICBKU0M6 OmluaXRpYWxpemVUaHJlYWRpbmcoKTsKKyNpZiAhUExBVEZPUk0oSU9TKQogICAgIFdURjo6aW5p dGlhbGl6ZU1haW5UaHJlYWRUb1Byb2Nlc3NNYWluVGhyZWFkKCk7Ci0gICAgUnVuTG9vcDo6aW5p dGlhbGl6ZU1haW5SdW5Mb29wKCk7CiAjZW5kaWYKKyAgICBSdW5Mb29wOjppbml0aWFsaXplTWFp blJ1bkxvb3AoKTsKIAogI2lmICFQTEFURk9STShJT1MpCiAgICAgW1tOU05vdGlmaWNhdGlvbkNl bnRlciBkZWZhdWx0Q2VudGVyXSBhZGRPYnNlcnZlcjpzZWxmIHNlbGVjdG9yOkBzZWxlY3Rvcihf YXBwbGljYXRpb25XaWxsVGVybWluYXRlKSBuYW1lOk5TQXBwbGljYXRpb25XaWxsVGVybWluYXRl Tm90aWZpY2F0aW9uIG9iamVjdDpOU0FwcF07Cg== 270766 2016-02-05 13:20:25 -0800 2016-02-05 13:53:04 -0800 Patch bug-153900-20160205132004.patch text/plain 1545 achristensen SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE5NjE1MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE2LTAyLTA0ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdl YmtpdC5vcmc+CisKKyAgICAgICAgRml4IGlPUyBBUEkgdGVzdHMgYWZ0ZXIgcjE5NjA4MgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUzOTAwCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0 QVBJL1Rlc3RzL1dlYkNvcmUvV2ViQ29yZU5TVVJMU2Vzc2lvbi5tbToKKyAgICAgICAgKFRlc3RX ZWJLaXRBUEk6OldlYkNvcmVOU1VSTFNlc3Npb25UZXN0OjpTZXRVcCk6CisgICAgICAgIFtXZWJW aWV3IGluaXRpYWxpemVdIGRvZXNuJ3QgY2FsbCBKU0M6OmluaXRpYWxpemVUaHJlYWRpbmcgb24g aU9TLgorCiAyMDE2LTAyLTAzICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAg ICAgICAgcnVuLWpzYy1zdHJlc3MtdGVzdHMgc2hvdWxkIGJlIGJldHRlciBhdCB0ZWxsaW5nIHlv dSBkZXRhaWxzIGFib3V0IHRlc3QgZmFpbHVyZXMKSW5kZXg6IFRvb2xzL1Rlc3RXZWJLaXRBUEkv VGVzdHMvV2ViQ29yZS9XZWJDb3JlTlNVUkxTZXNzaW9uLm1tCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xz L1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS9XZWJDb3JlTlNVUkxTZXNzaW9uLm1tCShyZXZp c2lvbiAxOTYxNDQpCisrKyBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvV2ViQ29y ZU5TVVJMU2Vzc2lvbi5tbQkod29ya2luZyBjb3B5KQpAQCAtMjgsNiArMjgsNyBAQAogI2lmIFBM QVRGT1JNKElPUykgfHwgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDExMDAK IAogI2ltcG9ydCAiUGxhdGZvcm1VdGlsaXRpZXMuaCIKKyNpbXBvcnQgPEphdmFTY3JpcHRDb3Jl L0luaXRpYWxpemVUaHJlYWRpbmcuaD4KICNpbXBvcnQgPFdlYktpdC9XZWJWaWV3Lmg+CiAjaW1w b3J0IDxXZWJDb3JlL0ZyYW1lTG9hZFJlcXVlc3QuaD4KICNpbXBvcnQgPFdlYkNvcmUvTWFpbkZy YW1lLmg+CkBAIC0xMDgsNiArMTA5LDkgQEAgcHVibGljOgogCiAgICAgdmlydHVhbCB2b2lkIFNl dFVwKCkKICAgICB7CisjaWYgUExBVEZPUk0oSU9TKQorICAgICAgICBKU0M6OmluaXRpYWxpemVU aHJlYWRpbmcoKTsKKyNlbmRpZgogICAgICAgICB2aWV3ID0gW1tXZWJWaWV3IGFsbG9jXSBpbml0 V2l0aEZyYW1lOk5TWmVyb1JlY3RdOwogICAgICAgICB2aWV3LmZyYW1lTG9hZERlbGVnYXRlID0g W1tbVGVzdE5TVVJMU2Vzc2lvbkxvYWRlckRlbGVnYXRlIGFsbG9jXSBpbml0XSBhdXRvcmVsZWFz ZV07CiAK