153881 2016-02-04 11:52:32 -0800 WebKit for iOS Simulator fails to build with public iOS SDK 2016-02-13 11:01:57 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build iPhone / iPad iOS 9.3 RESOLVED FIXED P2 Normal --- 1 dbates dbates alexcheng1982 lforschler lpromero oldest_to_newest 1162101 0 dbates 2016-02-04 11:52:32 -0800 The build fails to link WebCore with the following errors: duplicate symbol _kMGQAppleInternalInstallCapability in: /Users/dbates/Desktop/WebKit/WebKitBuild/WebCore.build/Debug-iphonesimulator/WebCore.build/Objects-normal/x86_64/Device.o /Users/dbates/Desktop/WebKit/WebKitBuild/WebCore.build/Debug-iphonesimulator/WebCore.build/Objects-normal/x86_64/NavigatorBase.o duplicate symbol _kMGQiPadCapability in: /Users/dbates/Desktop/WebKit/WebKitBuild/WebCore.build/Debug-iphonesimulator/WebCore.build/Objects-normal/x86_64/Device.o /Users/dbates/Desktop/WebKit/WebKitBuild/WebCore.build/Debug-iphonesimulator/WebCore.build/Objects-normal/x86_64/NavigatorBase.o ... duplicate symbol _kMGQMainScreenScale in: /Users/dbates/Desktop/WebKit/WebKitBuild/WebCore.build/Debug-iphonesimulator/WebCore.build/Objects-normal/x86_64/Device.o /Users/dbates/Desktop/WebKit/WebKitBuild/WebCore.build/Debug-iphonesimulator/WebCore.build/Objects-normal/x86_64/UserAgentIOS.o ld: 24 duplicate symbols for architecture x86_64 clang: error: linker command failed with exit code 1 (use -v to see invocation) And fails to compile WebKit2 because of redefinition/declaration-mismatch errors with the definitions/declarations in file Source/WebKit2/Platform/spi/ios/UIKitSPI.h. 1162104 1 270679 dbates 2016-02-04 11:59:04 -0800 Created attachment 270679 Patch 1162149 2 270679 achristensen 2016-02-04 13:15:09 -0800 Comment on attachment 270679 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270679&action=review > Source/WebKit2/Platform/spi/ios/UIKitSPI.h:236 > +#if __IPHONE_OS_VERSION_MIN_REQUIRED < 90200 Shouldn't this have something to do with MAX if we are checking that it is < a number? > Source/WebKit2/Platform/spi/ios/UIKitSPI.h:292 > +#if __IPHONE_OS_VERSION_MIN_REQUIRED < 90100 ditto 1162174 3 dbates 2016-02-04 13:50:45 -0800 (In reply to comment #2) > Comment on attachment 270679 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=270679&action=review > > > Source/WebKit2/Platform/spi/ios/UIKitSPI.h:236 > > +#if __IPHONE_OS_VERSION_MIN_REQUIRED < 90200 > > Shouldn't this have something to do with MAX if we are checking that it is < > a number? Oops! We should use __IPHONE_OS_VERSION_MAX_ALLOWED, which is the SDK version. > > > Source/WebKit2/Platform/spi/ios/UIKitSPI.h:292 > > +#if __IPHONE_OS_VERSION_MIN_REQUIRED < 90100 > > ditto Will change to use __IPHONE_OS_VERSION_MAX_ALLOWED. 1162179 4 dbates 2016-02-04 13:52:52 -0800 Committed r196148: <http://trac.webkit.org/changeset/196148> 1164557 5 dbates 2016-02-13 11:01:57 -0800 *** Bug 153620 has been marked as a duplicate of this bug. *** 270679 2016-02-04 11:59:04 -0800 2016-02-04 13:15:09 -0800 Patch bug-153881-20160204115841.patch text/plain 3653 dbates SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5NjAxMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE2LTAyLTA0ICBEYW5pZWwg QmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBXZWJLaXQgZm9yIGlPUyBTaW11 bGF0b3IgZmFpbHMgdG8gYnVpbGQgd2l0aCBwdWJsaWMgaU9TIFNESworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUzODgxCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSBjb25zdGFudHMgaGF2ZSBpbnRl cm5hbCBsaW5rYWdlIHRvIG1hdGNoIHRoZSBBcHBsZSBJbnRlcm5hbCBTREsuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9zcGkvaW9zL01vYmlsZUdlc3RhbHRTUEkuaDoKKwogMjAxNi0wMi0wMiAgRXJp YyBDYXJsc29uICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBBbGxvdyBwb3J0 cyB0byBkaXNhYmxlIGF1dG9tYXRpYyB0ZXh0IHRyYWNrIHNlbGVjdGlvbgpJbmRleDogU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vc3BpL2lvcy9Nb2JpbGVHZXN0YWx0U1BJLmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vc3BpL2lvcy9Nb2JpbGVHZXN0YWx0U1BJLmgJKHJl dmlzaW9uIDE5NjAxMSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3NwaS9pb3MvTW9iaWxl R2VzdGFsdFNQSS5oCSh3b3JraW5nIGNvcHkpCkBAIC0zOCwxMiArMzgsMTIgQEAKIAogI2Vsc2UK IAotRVhURVJOX0MgY29uc3QgQ0ZTdHJpbmdSZWYga01HUUFwcGxlSW50ZXJuYWxJbnN0YWxsQ2Fw YWJpbGl0eSA9IENGU1RSKCJhcHBsZS1pbnRlcm5hbC1pbnN0YWxsIik7Ci1FWFRFUk5fQyBjb25z dCBDRlN0cmluZ1JlZiBrTUdRTWFpblNjcmVlblBpdGNoID0gQ0ZTVFIoIm1haW4tc2NyZWVuLXBp dGNoIik7Ci1FWFRFUk5fQyBjb25zdCBDRlN0cmluZ1JlZiBrTUdRTWFpblNjcmVlblNjYWxlID0g Q0ZTVFIoIm1haW4tc2NyZWVuLXNjYWxlIik7Ci1FWFRFUk5fQyBjb25zdCBDRlN0cmluZ1JlZiBr TUdRaVBhZENhcGFiaWxpdHkgPSBDRlNUUigiaXBhZCIpOwotRVhURVJOX0MgY29uc3QgQ0ZTdHJp bmdSZWYga01HUURldmljZU5hbWUgPSBDRlNUUigiRGV2aWNlTmFtZSIpOwotRVhURVJOX0MgY29u c3QgQ0ZTdHJpbmdSZWYga01HUURldmljZUNsYXNzTnVtYmVyID0gQ0ZTVFIoIkRldmljZUNsYXNz TnVtYmVyIik7CitzdGF0aWMgY29uc3QgQ0ZTdHJpbmdSZWYga01HUUFwcGxlSW50ZXJuYWxJbnN0 YWxsQ2FwYWJpbGl0eSA9IENGU1RSKCJhcHBsZS1pbnRlcm5hbC1pbnN0YWxsIik7CitzdGF0aWMg Y29uc3QgQ0ZTdHJpbmdSZWYga01HUU1haW5TY3JlZW5QaXRjaCA9IENGU1RSKCJtYWluLXNjcmVl bi1waXRjaCIpOworc3RhdGljIGNvbnN0IENGU3RyaW5nUmVmIGtNR1FNYWluU2NyZWVuU2NhbGUg PSBDRlNUUigibWFpbi1zY3JlZW4tc2NhbGUiKTsKK3N0YXRpYyBjb25zdCBDRlN0cmluZ1JlZiBr TUdRaVBhZENhcGFiaWxpdHkgPSBDRlNUUigiaXBhZCIpOworc3RhdGljIGNvbnN0IENGU3RyaW5n UmVmIGtNR1FEZXZpY2VOYW1lID0gQ0ZTVFIoIkRldmljZU5hbWUiKTsKK3N0YXRpYyBjb25zdCBD RlN0cmluZ1JlZiBrTUdRRGV2aWNlQ2xhc3NOdW1iZXIgPSBDRlNUUigiRGV2aWNlQ2xhc3NOdW1i ZXIiKTsKIAogdHlwZWRlZiBlbnVtIHsKICAgICBNR0RldmljZUNsYXNzSW52YWxpZCA9IC0xLApJ bmRleDogU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQyL0NoYW5nZUxvZwkocmV2aXNpb24gMTk2MTM3KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTYtMDItMDQgIERhbmllbCBC YXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIFdlYktpdCBmb3IgaU9TIFNpbXVs YXRvciBmYWlscyB0byBidWlsZCB3aXRoIHB1YmxpYyBpT1MgU0RLCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTM4ODEKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgdmVyc2lvbiBndWFyZHMgYXJvdW5k IFNQSSB0aGF0IGlzIG5vdyBBUEkgYXMgb2YgaU9TIFNESyA5LjIuIFVudGlsIHdlIHVwZ3JhZGUg dGhlIGlPUyBFV1MKKyAgICAgICAgYW5kIGlPUyBidWlsZGJvdHMgdG8gdXNlIHRoZSA5LjIgU0RL IHdlIG5lZWQgdG8ga2VlcCB0aGVzZSBTUEkgZGVjbGFyYXRpb25zIHRvIGF2b2lkIGJyZWFraW5n CisgICAgICAgIHRoZSBidWlsZC4KKworICAgICAgICAqIFBsYXRmb3JtL3NwaS9pb3MvVUlLaXRT UEkuaDoKKwogMjAxNi0wMi0wNCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAg ICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxOTYwNjcuCkluZGV4OiBTb3VyY2UvV2Vi S2l0Mi9QbGF0Zm9ybS9zcGkvaW9zL1VJS2l0U1BJLmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdDIvUGxhdGZvcm0vc3BpL2lvcy9VSUtpdFNQSS5oCShyZXZpc2lvbiAxOTYwMTEpCisrKyBT b3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9zcGkvaW9zL1VJS2l0U1BJLmgJKHdvcmtpbmcgY29weSkK QEAgLTIzMyw3ICsyMzMsOSBAQCB0eXBlZGVmIGVudW0gewogCiBAaW50ZXJmYWNlIFVJR2VzdHVy ZVJlY29nbml6ZXIgKCkKIC0gKHZvaWQpcmVxdWlyZU90aGVyR2VzdHVyZVRvRmFpbDooVUlHZXN0 dXJlUmVjb2duaXplciAqKWdlc3R1cmVSZWNvZ25pemVyOworI2lmIF9fSVBIT05FX09TX1ZFUlNJ T05fTUlOX1JFUVVJUkVEIDwgOTAyMDAKIEBwcm9wZXJ0eShub25hdG9taWMsIGNvcHkpIE5TQXJy YXk8TlNOdW1iZXIgKj4gKmFsbG93ZWRUb3VjaFR5cGVzOworI2VuZGlmCiBAZW5kCiAKIEBpbnRl cmZhY2UgVUlMb25nUHJlc3NHZXN0dXJlUmVjb2duaXplciAoKQpAQCAtMjg3LDYgKzI4OSw3IEBA IHR5cGVkZWYgZW51bSB7CiAtIChDQURpc3BsYXkgKilfZGlzcGxheTsKIEBlbmQKIAorI2lmIF9f SVBIT05FX09TX1ZFUlNJT05fTUlOX1JFUVVJUkVEIDwgOTAxMDAKIHR5cGVkZWYgZW51bSB7CiAg ICAgVUlUb3VjaFR5cGVEaXJlY3QKIH0gVUlUb3VjaFR5cGU7CkBAIC0yOTQsNiArMjk3LDcgQEAg dHlwZWRlZiBlbnVtIHsKIEBpbnRlcmZhY2UgVUlUb3VjaCAoKQogQHByb3BlcnR5KG5vbmF0b21p YyxyZWFkb25seSkgVUlUb3VjaFR5cGUgdHlwZTsKIEBlbmQKKyNlbmRpZgogCiBAaW50ZXJmYWNl IFVJU2Nyb2xsVmlldyAoKQogLSAodm9pZClfc3RvcFNjcm9sbGluZ0FuZFpvb21pbmdBbmltYXRp b25zOwo=