153878 2016-02-04 11:32:59 -0800 Fix the !ENABLE(NETSCAPE_PLUGIN_API) build after r196053 2016-02-04 22:52:55 -0800 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 151992 1 ossy ossy cgarcia commit-queue darin oldest_to_newest 1162080 0 ossy 2016-02-04 11:32:59 -0800 build log: In file included from ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:28:0: ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:39:59: error: expected class-name before '{' token ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:42:40: error: 'Display' has not been declared ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:49:13: error: 'NPWindowType' does not name a type ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:51:13: error: 'NPSetWindowCallbackStruct' does not name a type ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:54:33: error: 'WebCore::GraphicsContext' has not been declared ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:54:66: error: 'IntRect' in namespace 'WebCore' does not name a type ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:55:41: error: 'WebMouseEvent' does not name a type ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:56:41: error: 'WebWheelEvent' does not name a type ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:57:46: error: 'WebMouseEvent' does not name a type ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:58:46: error: 'WebMouseEvent' does not name a type ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:59:44: error: 'WebKeyboardEvent' does not name a type ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:63:5: error: 'Display' does not name a type ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:65:5: error: 'NPSetWindowCallbackStruct' does not name a type ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:50:19: error: 'virtual void* WebKit::NetscapePluginX11::window() const' marked override, but does not override ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:52:18: error: 'virtual void WebKit::NetscapePluginX11::geometryDidChange()' marked override, but does not override ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:53:18: error: 'virtual void WebKit::NetscapePluginX11::visibilityDidChange()' marked override, but does not override ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:54:18: error: 'virtual void WebKit::NetscapePluginX11::paint(int&, const int&)' marked override, but does not override ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:55:18: error: 'virtual bool WebKit::NetscapePluginX11::handleMouseEvent(const int&)' marked override, but does not override ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:56:18: error: 'virtual bool WebKit::NetscapePluginX11::handleWheelEvent(const int&)' marked override, but does not override ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:57:18: error: 'virtual bool WebKit::NetscapePluginX11::handleMouseEnterEvent(const int&)' marked override, but does not override ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:58:18: error: 'virtual bool WebKit::NetscapePluginX11::handleMouseLeaveEvent(const int&)' marked override, but does not override ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:59:18: error: 'virtual bool WebKit::NetscapePluginX11::handleKeyboardEvent(const int&)' marked override, but does not override ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:60:18: error: 'virtual void WebKit::NetscapePluginX11::setFocus(bool)' marked override, but does not override ICECC[12723] 20:26:07: Compiled on 10.6.1.14 1162081 1 270675 ossy 2016-02-04 11:34:32 -0800 Created attachment 270675 Patch 1162112 2 270675 commit-queue 2016-02-04 12:06:29 -0800 Comment on attachment 270675 Patch Clearing flags on attachment: 270675 Committed r196138: <http://trac.webkit.org/changeset/196138> 1162113 3 commit-queue 2016-02-04 12:06:34 -0800 All reviewed patches have been landed. Closing bug. 1162337 4 cgarcia 2016-02-04 22:52:55 -0800 Sorry about this, thanks for fixing it Ossy. 270675 2016-02-04 11:34:32 -0800 2016-02-04 12:06:29 -0800 Patch bug-153878-20160204203408.patch text/plain 1457 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTk2MTMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYzIyZDlhNTU5ZGQ4MGY5 N2JmNDU3ZWFkNDczYWQyZGMyZGRjOGEzNS4uNmExYmVhMzU0MjY3N2VmZTU3NTk4ZGI1YmUxN2Nm YTZmNWExMGMzYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE2LTAyLTA0ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IHRoZSAhRU5B QkxFKE5FVFNDQVBFX1BMVUdJTl9BUEkpIGJ1aWxkIGFmdGVyIHIxOTYwNTMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1Mzg3OAorCisgICAgICAgIFVu cmV2aWV3ZWQgYnVpbGRmaXguCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2Nh cGUveDExL05ldHNjYXBlUGx1Z2luWDExLmg6CisKIDIwMTYtMDItMDQgIENocmlzIER1bWV6ICA8 Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTk2 MDY3LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNj YXBlL3gxMS9OZXRzY2FwZVBsdWdpblgxMS5oIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9Q bHVnaW5zL05ldHNjYXBlL3gxMS9OZXRzY2FwZVBsdWdpblgxMS5oCmluZGV4IGE2MDkwMzgyYzY3 YmY5MWFjMGU2ZGIyMzYyMThiMDYxNDAwYTY5MDYuLmZkMWU4OTkwY2RjZDUzNTA4YWRhYmUzNmMy N2EwYzE0MDQ3YzZjOWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1 Z2lucy9OZXRzY2FwZS94MTEvTmV0c2NhcGVQbHVnaW5YMTEuaAorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUveDExL05ldHNjYXBlUGx1Z2luWDExLmgKQEAg LTI3LDcgKzI3LDcgQEAKICNpZm5kZWYgTmV0c2NhcGVQbHVnaW5YMTFfaAogI2RlZmluZSBOZXRz Y2FwZVBsdWdpblgxMV9oCiAKLSNpZiBQTFVHSU5fQVJDSElURUNUVVJFKFgxMSkKKyNpZiBQTFVH SU5fQVJDSElURUNUVVJFKFgxMSkgJiYgRU5BQkxFKE5FVFNDQVBFX1BMVUdJTl9BUEkpCiAKICNp bmNsdWRlICJOZXRzY2FwZVBsdWdpblVuaXguaCIKICNpbmNsdWRlIDxXZWJDb3JlL1hVbmlxdWVS ZXNvdXJjZS5oPgpAQCAtNzEsNiArNzEsNiBAQCBwcml2YXRlOgogfTsKIH0gLy8gbmFtZXNwYWNl IFdlYktpdAogCi0jZW5kaWYgLy8gUExVR0lOX0FSQ0hJVEVDVFVSRShYMTEpCisjZW5kaWYgLy8g UExVR0lOX0FSQ0hJVEVDVFVSRShYMTEpICYmIEVOQUJMRShORVRTQ0FQRV9QTFVHSU5fQVBJKQog CiAjZW5kaWYgLy8gTmV0c2NhcGVQbHVnaW5YMTFfaAo=