<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>153875</bug_id>
          
          <creation_ts>2016-02-04 10:45:52 -0800</creation_ts>
          <short_desc>Fix the EFL clean build after r196123</short_desc>
          <delta_ts>2016-02-14 22:20:25 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P1</priority>
          <bug_severity>Critical</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>153677</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Csaba Osztrogonác">ossy</reporter>
          <assigned_to name="Chris Dumez">cdumez</assigned_to>
          <cc>achristensen</cc>
    
    <cc>cdumez</cc>
    
    <cc>cgarcia</cc>
    
    <cc>clopez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>hs85.jeong</cc>
    
    <cc>jh718.park</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>ossy</cc>
    
    <cc>sam</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1162037</commentid>
    <comment_count>0</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2016-02-04 10:45:52 -0800</bug_when>
    <thetext>https://trac.webkit.org/changeset/196123 broke the clean build on EFL.

error log:
c++: error: DerivedSources/WebCore/JSDOMSettableTokenList.cpp: No such file or directory
c++: fatal error: no input files
compilation terminated.

The problem is that DOMSettableTokenList.idl is guarded since r196123 and 
DerivedSources/WebCore/JSDOMSettableTokenList.cpp isn&apos;t generated at all.

EWS and buildbot didn&apos;t notice this error, because the stale generated file remained in WebKitBuild.

cc-ing EFL maintainers to fix the broken build.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1162038</commentid>
    <comment_count>1</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2016-02-04 10:46:34 -0800</bug_when>
    <thetext>https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/26477</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1162039</commentid>
    <comment_count>2</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2016-02-04 10:47:32 -0800</bug_when>
    <thetext>Hmm, I updated CMakeList.txt to stop referring to JSDOMSettableTokenList.cpp though, odd.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1162042</commentid>
    <comment_count>3</comment_count>
      <attachid>270666</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2016-02-04 10:51:24 -0800</bug_when>
    <thetext>Created attachment 270666
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1162043</commentid>
    <comment_count>4</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2016-02-04 10:51:51 -0800</bug_when>
    <thetext>Letting EWS chew on this speculative fix.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1162044</commentid>
    <comment_count>5</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2016-02-04 10:52:35 -0800</bug_when>
    <thetext>(In reply to comment #2)
&gt; Hmm, I updated CMakeList.txt to stop referring to JSDOMSettableTokenList.cpp
&gt; though, odd.

AFAIK JSDOMSettableTokenList.cpp name is generated from DOMSettableTokenList.idl
filename and automatically added to the build by a cmake macro.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1162048</commentid>
    <comment_count>6</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2016-02-04 10:54:01 -0800</bug_when>
    <thetext>(In reply to comment #4)
&gt; Letting EWS chew on this speculative fix.

Unfortunately EWS won&apos;t be able to check it, because it is an 
incremental build issue. The stale generated cpp is still on the bot.

Doesn&apos;t GTK port need this idl?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1162050</commentid>
    <comment_count>7</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2016-02-04 10:54:29 -0800</bug_when>
    <thetext>(In reply to comment #5)
&gt; (In reply to comment #2)
&gt; &gt; Hmm, I updated CMakeList.txt to stop referring to JSDOMSettableTokenList.cpp
&gt; &gt; though, odd.
&gt; 
&gt; AFAIK JSDOMSettableTokenList.cpp name is generated from
&gt; DOMSettableTokenList.idl
&gt; filename and automatically added to the build by a cmake macro.

Ok, that&apos;s what I figured. So my speculative fix drops the idl file from the CMakeLists.txt. EFL does not need to know about this IDL file at all.

GTK does care about this IDL though but I am hoping the change is fine because the PlatformGTK.cmake file includes DOMSettableTokenList.idl still.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1162054</commentid>
    <comment_count>8</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2016-02-04 10:57:12 -0800</bug_when>
    <thetext>(In reply to comment #7)
&gt; (In reply to comment #5)
&gt; &gt; (In reply to comment #2)
&gt; &gt; &gt; Hmm, I updated CMakeList.txt to stop referring to JSDOMSettableTokenList.cpp
&gt; &gt; &gt; though, odd.
&gt; &gt; 
&gt; &gt; AFAIK JSDOMSettableTokenList.cpp name is generated from
&gt; &gt; DOMSettableTokenList.idl
&gt; &gt; filename and automatically added to the build by a cmake macro.
&gt; 
&gt; Ok, that&apos;s what I figured. So my speculative fix drops the idl file from the
&gt; CMakeLists.txt. EFL does not need to know about this IDL file at all.
&gt; 
&gt; GTK does care about this IDL though but I am hoping the change is fine
&gt; because the PlatformGTK.cmake file includes DOMSettableTokenList.idl still.

Hmm, GTK EWS seems unhappy after all. I am unsure how to fix it then.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1162059</commentid>
    <comment_count>9</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2016-02-04 11:03:12 -0800</bug_when>
    <thetext>(In reply to comment #8)
&gt; (In reply to comment #7)
&gt; &gt; (In reply to comment #5)
&gt; &gt; &gt; (In reply to comment #2)
&gt; &gt; &gt; &gt; Hmm, I updated CMakeList.txt to stop referring to JSDOMSettableTokenList.cpp
&gt; &gt; &gt; &gt; though, odd.
&gt; &gt; &gt; 
&gt; &gt; &gt; AFAIK JSDOMSettableTokenList.cpp name is generated from
&gt; &gt; &gt; DOMSettableTokenList.idl
&gt; &gt; &gt; filename and automatically added to the build by a cmake macro.
&gt; &gt; 
&gt; &gt; Ok, that&apos;s what I figured. So my speculative fix drops the idl file from the
&gt; &gt; CMakeLists.txt. EFL does not need to know about this IDL file at all.
&gt; &gt; 
&gt; &gt; GTK does care about this IDL though but I am hoping the change is fine
&gt; &gt; because the PlatformGTK.cmake file includes DOMSettableTokenList.idl still.
&gt; 
&gt; Hmm, GTK EWS seems unhappy after all. I am unsure how to fix it then.

maybe these lines in the GTK cmake system helps: (absolutely speculative)

list(APPEND WebCore_IDL_FILES
    html/DOMSettableTokenList.idl
)

Otherwise EFL clean build is happy with this change.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1162060</commentid>
    <comment_count>10</comment_count>
      <attachid>270670</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2016-02-04 11:05:15 -0800</bug_when>
    <thetext>Created attachment 270670
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1162061</commentid>
    <comment_count>11</comment_count>
      <attachid>270670</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2016-02-04 11:06:48 -0800</bug_when>
    <thetext>Comment on attachment 270670
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270670&amp;action=review

&gt; Source/WebCore/PlatformGTK.cmake:-718
&gt; -    html/DOMSettableTokenList.idl

Someone from the GTK port should confirm but I think I was told it is fine to drop as long as they are in the &quot;Unstable&quot; API list.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1162064</commentid>
    <comment_count>12</comment_count>
      <attachid>270671</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2016-02-04 11:13:10 -0800</bug_when>
    <thetext>Created attachment 270671
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1162089</commentid>
    <comment_count>13</comment_count>
      <attachid>270671</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2016-02-04 11:37:02 -0800</bug_when>
    <thetext>Comment on attachment 270671
Patch

Indeed, since it&apos;s in the unstable list, let&apos;s just drop it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1162091</commentid>
    <comment_count>14</comment_count>
      <attachid>270671</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2016-02-04 11:38:15 -0800</bug_when>
    <thetext>Comment on attachment 270671
Patch

Clearing flags on attachment: 270671

Committed r196136: &lt;http://trac.webkit.org/changeset/196136&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1162092</commentid>
    <comment_count>15</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2016-02-04 11:38:20 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1162166</commentid>
    <comment_count>16</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2016-02-04 13:29:28 -0800</bug_when>
    <thetext>(In reply to comment #14)
&gt; Comment on attachment 270671 [details]
&gt; Patch
&gt; 
&gt; Clearing flags on attachment: 270671
&gt; 
&gt; Committed r196136: &lt;http://trac.webkit.org/changeset/196136&gt;

It broke the Apple Mac cmake build.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1163507</commentid>
    <comment_count>17</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2016-02-10 10:07:32 -0800</bug_when>
    <thetext>(In reply to comment #16)
&gt; &gt; Committed r196136: &lt;http://trac.webkit.org/changeset/196136&gt;
&gt; 
&gt; It broke the Apple Mac cmake build.

The cmake build is still broken a week ago due to this change.
Is the Mac cmake build maintained?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1164618</commentid>
    <comment_count>18</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2016-02-14 03:37:26 -0800</bug_when>
    <thetext>(In reply to comment #17)
&gt; (In reply to comment #16)
&gt; &gt; &gt; Committed r196136: &lt;http://trac.webkit.org/changeset/196136&gt;
&gt; &gt; 
&gt; &gt; It broke the Apple Mac cmake build.
&gt; 
&gt; The cmake build is still broken a week ago due to this change.
&gt; Is the Mac cmake build maintained?

ping?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1164676</commentid>
    <comment_count>19</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2016-02-14 22:20:25 -0800</bug_when>
    <thetext>(In reply to comment #18)
&gt; (In reply to comment #17)
&gt; &gt; (In reply to comment #16)
&gt; &gt; &gt; &gt; Committed r196136: &lt;http://trac.webkit.org/changeset/196136&gt;
&gt; &gt; &gt; 
&gt; &gt; &gt; It broke the Apple Mac cmake build.
&gt; &gt; 
&gt; &gt; The cmake build is still broken a week ago due to this change.
&gt; &gt; Is the Mac cmake build maintained?
&gt; 
&gt; ping?

I landed a couple of fixes but there are still more issues (unrelated to my change).</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>270666</attachid>
            <date>2016-02-04 10:51:24 -0800</date>
            <delta_ts>2016-02-04 11:05:11 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-153875-20160204105100.patch</filename>
            <type>text/plain</type>
            <size>1050</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTk2MTMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDg4MmI3YzlmNDA0NTIw
OTlmY2VkYWVmMjYyYTI1NmM5NGI2YzYyZi4uYzY5ZDY4MjVhMDcwOTE3YTRjMGJiNmJkNDQ0NGJm
MGQ5YWFmZTI1MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEwIEBACisyMDE2LTAyLTA0ICBDaHJp
cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgVW5yZXZpZXdlZCBhdHRlbXB0
IHRvIGZpeCB0aGUgRUZMIGJ1aWxkIGFmdGVyIHIxOTYxMjMuCisgICAgICAgIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTM4NzUKKworICAgICAgICAqIENNYWtlTGlz
dHMudHh0OgorCiAyMDE2LTAyLTA0ICBFcmljIENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUu
Y29tPgogCiAgICAgICAgIERvbid0IGRpc2NhcmQgaW4tYmFuZCBjdWVzIHdpdGggbmVnYXRpdmUg
c3RhcnQgdGltZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0IGIv
U291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKaW5kZXggNGEwMjdiOWQ4MjVkMWU4ODE0YzQ2
YWVlNDM3MWIzMzk5NzY5MzViYi4uYzNiMDdlYWE1MTU4YWUzZWFhMjNlMDNjMmMyMTQ4ZjExNGIy
M2UxNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKKysrIGIvU291
cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKQEAgLTQzNiw3ICs0MzYsNiBAQCBzZXQoV2ViQ29y
ZV9OT05fU1ZHX0lETF9GSUxFUwogICAgIGZpbGVhcGkvRmlsZVJlYWRlclN5bmMuaWRsCiAKICAg
ICBodG1sL0RPTUZvcm1EYXRhLmlkbAotICAgIGh0bWwvRE9NU2V0dGFibGVUb2tlbkxpc3QuaWRs
CiAgICAgaHRtbC9ET01Ub2tlbkxpc3QuaWRsCiAgICAgaHRtbC9ET01VUkwuaWRsCiAgICAgaHRt
bC9IVE1MQWxsQ29sbGVjdGlvbi5pZGwK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>270670</attachid>
            <date>2016-02-04 11:05:15 -0800</date>
            <delta_ts>2016-02-04 11:13:05 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-153875-20160204110452.patch</filename>
            <type>text/plain</type>
            <size>3256</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTk2MTMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDg4MmI3YzlmNDA0NTIw
OTlmY2VkYWVmMjYyYTI1NmM5NGI2YzYyZi4uMjQzNTkxNTMyODFjMzRlZDY5ZTQwN2JkNzE4NzAz
Y2IyZTNjNWRlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE2LTAyLTA0ICBDaHJp
cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgVW5yZXZpZXdlZCwgZml4IHRo
ZSBFRkwgY2xlYW4gYnVpbGQgYWZ0ZXIgcjE5NjEyMworICAgICAgICBodHRwczovL2J1Z3Mud2Vi
a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUzODc1CisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4
dDoKKyAgICAgICAgKiBQbGF0Zm9ybUdUSy5jbWFrZToKKyAgICAgICAgKiBQbGF0Zm9ybU1hYy5j
bWFrZToKKyAgICAgICAgKiBodG1sL0RPTVNldHRhYmxlVG9rZW5MaXN0Lmg6CisgICAgICAgICog
aHRtbC9ET01TZXR0YWJsZVRva2VuTGlzdC5pZGw6CisKIDIwMTYtMDItMDQgIEVyaWMgQ2FybHNv
biAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgRG9uJ3QgZGlzY2FyZCBpbi1i
YW5kIGN1ZXMgd2l0aCBuZWdhdGl2ZSBzdGFydCB0aW1lcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl
YkNvcmUvQ01ha2VMaXN0cy50eHQgYi9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dAppbmRl
eCA0YTAyN2I5ZDgyNWQxZTg4MTRjNDZhZWU0MzcxYjMzOTk3NjkzNWJiLi5jM2IwN2VhYTUxNThh
ZTNlYWEyM2UwM2MyYzIxNDhmMTE0YjIzZTE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9D
TWFrZUxpc3RzLnR4dAorKysgYi9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dApAQCAtNDM2
LDcgKzQzNiw2IEBAIHNldChXZWJDb3JlX05PTl9TVkdfSURMX0ZJTEVTCiAgICAgZmlsZWFwaS9G
aWxlUmVhZGVyU3luYy5pZGwKIAogICAgIGh0bWwvRE9NRm9ybURhdGEuaWRsCi0gICAgaHRtbC9E
T01TZXR0YWJsZVRva2VuTGlzdC5pZGwKICAgICBodG1sL0RPTVRva2VuTGlzdC5pZGwKICAgICBo
dG1sL0RPTVVSTC5pZGwKICAgICBodG1sL0hUTUxBbGxDb2xsZWN0aW9uLmlkbApkaWZmIC0tZ2l0
IGEvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1HVEsuY21ha2UgYi9Tb3VyY2UvV2ViQ29yZS9QbGF0
Zm9ybUdUSy5jbWFrZQppbmRleCA5ZTJkZmYyZmZkMTc5MDRkMDM3M2M5OWY1NTQ1ZjJjZTYwMzZl
ZTQ1Li43MmQ1MTZlZWMyMjBlYTYxZDY1MzkwMDIyM2M5Zjk2ODkyMjA3MjQ4IDEwMDY0NAotLS0g
YS9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUdUSy5jbWFrZQorKysgYi9Tb3VyY2UvV2ViQ29yZS9Q
bGF0Zm9ybUdUSy5jbWFrZQpAQCAtNzE1LDcgKzcxNSw2IEBAIGxpc3QoQVBQRU5EIEdPYmplY3RE
T01CaW5kaW5nc1Vuc3RhYmxlX0lETF9GSUxFUwogICAgIGRvbS9Ub3VjaC5pZGwKICAgICBkb20v
V2ViS2l0TmFtZWRGbG93LmlkbAogCi0gICAgaHRtbC9ET01TZXR0YWJsZVRva2VuTGlzdC5pZGwK
ICAgICBodG1sL0RPTVRva2VuTGlzdC5pZGwKICAgICBodG1sL0hUTUxEZXRhaWxzRWxlbWVudC5p
ZGwKICAgICBodG1sL0hUTUxLZXlnZW5FbGVtZW50LmlkbApkaWZmIC0tZ2l0IGEvU291cmNlL1dl
YkNvcmUvUGxhdGZvcm1NYWMuY21ha2UgYi9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybU1hYy5jbWFr
ZQppbmRleCBlMGIyM2Y4NGU5ZjU3OTZhODNkNDk0NDUxODJjZTY1YTU4NTFhNzM1Li5hOWRiNTI2
MDhhOWU3YTgxMWYxOTg1Mzg1NGNjZjEyY2NkMGM0MmM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi
Q29yZS9QbGF0Zm9ybU1hYy5jbWFrZQorKysgYi9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybU1hYy5j
bWFrZQpAQCAtNzkxLDYgKzc5MSw3IEBAIHNldChPYmpDX0JpbmRpbmdzX0lETF9GSUxFUwogICAg
IGZpbGVhcGkvRmlsZS5pZGwKICAgICBmaWxlYXBpL0ZpbGVMaXN0LmlkbAogCisgICAgaHRtbC9E
T01TZXR0YWJsZVRva2VuTGlzdC5pZGwKICAgICBodG1sL0RPTVRva2VuTGlzdC5pZGwKICAgICBo
dG1sL0hUTUxBbmNob3JFbGVtZW50LmlkbAogICAgIGh0bWwvSFRNTEFwcGxldEVsZW1lbnQuaWRs
CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0RPTVNldHRhYmxlVG9rZW5MaXN0Lmgg
Yi9Tb3VyY2UvV2ViQ29yZS9odG1sL0RPTVNldHRhYmxlVG9rZW5MaXN0LmgKaW5kZXggYTNkYmNh
ODI4NDk1NWY0NzRhZjYyNmYxNDg4YjlmZWRmNDA2ZjQ4Ni4uMDdlZDIyOWQ2MDU2YmMxZDc3NTIw
YTRiY2U5N2M5YjlkNWU5NTVjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9ET01T
ZXR0YWJsZVRva2VuTGlzdC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvRE9NU2V0dGFibGVU
b2tlbkxpc3QuaApAQCAtMzIsNyArMzIsNyBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLS8v
IE9ubHkgdXNlZCBieSBPYmpDIGFuZCBHT2JqZWN0IGJpbmRpbmdzLgorLy8gT25seSB1c2VkIGJ5
IE9iakMgYmluZGluZ3MuCiBjbGFzcyBET01TZXR0YWJsZVRva2VuTGlzdCA6IHB1YmxpYyBET01U
b2tlbkxpc3QgewogICAgIFdURl9NQUtFX0ZBU1RfQUxMT0NBVEVEOwogfTsKZGlmZiAtLWdpdCBh
L1NvdXJjZS9XZWJDb3JlL2h0bWwvRE9NU2V0dGFibGVUb2tlbkxpc3QuaWRsIGIvU291cmNlL1dl
YkNvcmUvaHRtbC9ET01TZXR0YWJsZVRva2VuTGlzdC5pZGwKaW5kZXggMjViNWI3Zjc5NDJhOGRi
ZTUyMzk0MGJlZmIxNzE4NDMzZTUxZDllOC4uOWZiZTllYjUzZGIzZGE4MDBhOTU1NmFlYmI4ZmQ4
YzFmMzMxNGFlMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9ET01TZXR0YWJsZVRv
a2VuTGlzdC5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9ET01TZXR0YWJsZVRva2VuTGlz
dC5pZGwKQEAgLTIyLDcgKzIyLDcgQEAKICAqIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0Yg
VEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgogICovCiAKLSNpZiBkZWZpbmVkKExBTkdV
QUdFX09CSkVDVElWRV9DKSAmJiBMQU5HVUFHRV9PQkpFQ1RJVkVfQyB8fCBkZWZpbmVkKExBTkdV
QUdFX0dPQkpFQ1QpICYmIExBTkdVQUdFX0dPQkpFQ1QKKyNpZiBkZWZpbmVkKExBTkdVQUdFX09C
SkVDVElWRV9DKSAmJiBMQU5HVUFHRV9PQkpFQ1RJVkVfQwogCiBbCiAgICAgTm9JbnRlcmZhY2VP
YmplY3QsCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>270671</attachid>
            <date>2016-02-04 11:13:10 -0800</date>
            <delta_ts>2016-02-04 11:38:15 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-153875-20160204111247.patch</filename>
            <type>text/plain</type>
            <size>3971</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTk2MTMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDg4MmI3YzlmNDA0NTIw
OTlmY2VkYWVmMjYyYTI1NmM5NGI2YzYyZi4uMjQzNTkxNTMyODFjMzRlZDY5ZTQwN2JkNzE4NzAz
Y2IyZTNjNWRlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE2LTAyLTA0ICBDaHJp
cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgVW5yZXZpZXdlZCwgZml4IHRo
ZSBFRkwgY2xlYW4gYnVpbGQgYWZ0ZXIgcjE5NjEyMworICAgICAgICBodHRwczovL2J1Z3Mud2Vi
a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUzODc1CisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4
dDoKKyAgICAgICAgKiBQbGF0Zm9ybUdUSy5jbWFrZToKKyAgICAgICAgKiBQbGF0Zm9ybU1hYy5j
bWFrZToKKyAgICAgICAgKiBodG1sL0RPTVNldHRhYmxlVG9rZW5MaXN0Lmg6CisgICAgICAgICog
aHRtbC9ET01TZXR0YWJsZVRva2VuTGlzdC5pZGw6CisKIDIwMTYtMDItMDQgIEVyaWMgQ2FybHNv
biAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgRG9uJ3QgZGlzY2FyZCBpbi1i
YW5kIGN1ZXMgd2l0aCBuZWdhdGl2ZSBzdGFydCB0aW1lcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl
YkNvcmUvQ01ha2VMaXN0cy50eHQgYi9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dAppbmRl
eCA0YTAyN2I5ZDgyNWQxZTg4MTRjNDZhZWU0MzcxYjMzOTk3NjkzNWJiLi5jM2IwN2VhYTUxNThh
ZTNlYWEyM2UwM2MyYzIxNDhmMTE0YjIzZTE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9D
TWFrZUxpc3RzLnR4dAorKysgYi9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dApAQCAtNDM2
LDcgKzQzNiw2IEBAIHNldChXZWJDb3JlX05PTl9TVkdfSURMX0ZJTEVTCiAgICAgZmlsZWFwaS9G
aWxlUmVhZGVyU3luYy5pZGwKIAogICAgIGh0bWwvRE9NRm9ybURhdGEuaWRsCi0gICAgaHRtbC9E
T01TZXR0YWJsZVRva2VuTGlzdC5pZGwKICAgICBodG1sL0RPTVRva2VuTGlzdC5pZGwKICAgICBo
dG1sL0RPTVVSTC5pZGwKICAgICBodG1sL0hUTUxBbGxDb2xsZWN0aW9uLmlkbApkaWZmIC0tZ2l0
IGEvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1HVEsuY21ha2UgYi9Tb3VyY2UvV2ViQ29yZS9QbGF0
Zm9ybUdUSy5jbWFrZQppbmRleCA5ZTJkZmYyZmZkMTc5MDRkMDM3M2M5OWY1NTQ1ZjJjZTYwMzZl
ZTQ1Li43MmQ1MTZlZWMyMjBlYTYxZDY1MzkwMDIyM2M5Zjk2ODkyMjA3MjQ4IDEwMDY0NAotLS0g
YS9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUdUSy5jbWFrZQorKysgYi9Tb3VyY2UvV2ViQ29yZS9Q
bGF0Zm9ybUdUSy5jbWFrZQpAQCAtNzE1LDcgKzcxNSw2IEBAIGxpc3QoQVBQRU5EIEdPYmplY3RE
T01CaW5kaW5nc1Vuc3RhYmxlX0lETF9GSUxFUwogICAgIGRvbS9Ub3VjaC5pZGwKICAgICBkb20v
V2ViS2l0TmFtZWRGbG93LmlkbAogCi0gICAgaHRtbC9ET01TZXR0YWJsZVRva2VuTGlzdC5pZGwK
ICAgICBodG1sL0RPTVRva2VuTGlzdC5pZGwKICAgICBodG1sL0hUTUxEZXRhaWxzRWxlbWVudC5p
ZGwKICAgICBodG1sL0hUTUxLZXlnZW5FbGVtZW50LmlkbApkaWZmIC0tZ2l0IGEvU291cmNlL1dl
YkNvcmUvUGxhdGZvcm1NYWMuY21ha2UgYi9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybU1hYy5jbWFr
ZQppbmRleCBlMGIyM2Y4NGU5ZjU3OTZhODNkNDk0NDUxODJjZTY1YTU4NTFhNzM1Li5hOWRiNTI2
MDhhOWU3YTgxMWYxOTg1Mzg1NGNjZjEyY2NkMGM0MmM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi
Q29yZS9QbGF0Zm9ybU1hYy5jbWFrZQorKysgYi9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybU1hYy5j
bWFrZQpAQCAtNzkxLDYgKzc5MSw3IEBAIHNldChPYmpDX0JpbmRpbmdzX0lETF9GSUxFUwogICAg
IGZpbGVhcGkvRmlsZS5pZGwKICAgICBmaWxlYXBpL0ZpbGVMaXN0LmlkbAogCisgICAgaHRtbC9E
T01TZXR0YWJsZVRva2VuTGlzdC5pZGwKICAgICBodG1sL0RPTVRva2VuTGlzdC5pZGwKICAgICBo
dG1sL0hUTUxBbmNob3JFbGVtZW50LmlkbAogICAgIGh0bWwvSFRNTEFwcGxldEVsZW1lbnQuaWRs
CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nb2JqZWN0L1dlYktpdERPTUN1
c3RvbS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nb2JqZWN0L1dlYktpdERPTUN1c3Rv
bS5jcHAKaW5kZXggZDc2MWQ3NWVmY2ViNmY2MzYzY2U3YzU4MjVkZjA3MjFjMGMyY2ZlNS4uNjYx
MWRmMDYwY2JjZTU0YWQ5ZTFkZWNkNTNmOWI4Y2RhMTlkZGI2NyAxMDA2NDQKLS0tIGEvU291cmNl
L1dlYkNvcmUvYmluZGluZ3MvZ29iamVjdC9XZWJLaXRET01DdXN0b20uY3BwCisrKyBiL1NvdXJj
ZS9XZWJDb3JlL2JpbmRpbmdzL2dvYmplY3QvV2ViS2l0RE9NQ3VzdG9tLmNwcApAQCAtMTksMTAg
KzE5LDkgQEAKICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJXZWJLaXRET01DdXN0b20u
aCIKIAotI2luY2x1ZGUgIkRPTVNldHRhYmxlVG9rZW5MaXN0LmgiCisjaW5jbHVkZSAiRE9NVG9r
ZW5MaXN0LmgiCiAjaW5jbHVkZSAiSlNNYWluVGhyZWFkRXhlY1N0YXRlLmgiCiAjaW5jbHVkZSAi
U2VyaWFsaXplZFNjcmlwdFZhbHVlLmgiCi0jaW5jbHVkZSAiV2ViS2l0RE9NRE9NU2V0dGFibGVU
b2tlbkxpc3RQcml2YXRlLmgiCiAjaW5jbHVkZSAiV2ViS2l0RE9NRE9NV2luZG93UHJpdmF0ZS5o
IgogI2luY2x1ZGUgIldlYktpdERPTUhUTUxJbnB1dEVsZW1lbnQuaCIKICNpbmNsdWRlICJXZWJL
aXRET01IVE1MSW5wdXRFbGVtZW50UHJpdmF0ZS5oIgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv
cmUvaHRtbC9ET01TZXR0YWJsZVRva2VuTGlzdC5oIGIvU291cmNlL1dlYkNvcmUvaHRtbC9ET01T
ZXR0YWJsZVRva2VuTGlzdC5oCmluZGV4IGEzZGJjYTgyODQ5NTVmNDc0YWY2MjZmMTQ4OGI5ZmVk
ZjQwNmY0ODYuLjA3ZWQyMjlkNjA1NmJjMWQ3NzUyMGE0YmNlOTdjOWI5ZDVlOTU1YzUgMTAwNjQ0
Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvRE9NU2V0dGFibGVUb2tlbkxpc3QuaAorKysgYi9T
b3VyY2UvV2ViQ29yZS9odG1sL0RPTVNldHRhYmxlVG9rZW5MaXN0LmgKQEAgLTMyLDcgKzMyLDcg
QEAKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCi0vLyBPbmx5IHVzZWQgYnkgT2JqQyBhbmQgR09i
amVjdCBiaW5kaW5ncy4KKy8vIE9ubHkgdXNlZCBieSBPYmpDIGJpbmRpbmdzLgogY2xhc3MgRE9N
U2V0dGFibGVUb2tlbkxpc3QgOiBwdWJsaWMgRE9NVG9rZW5MaXN0IHsKICAgICBXVEZfTUFLRV9G
QVNUX0FMTE9DQVRFRDsKIH07CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0RPTVNl
dHRhYmxlVG9rZW5MaXN0LmlkbCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvRE9NU2V0dGFibGVUb2tl
bkxpc3QuaWRsCmluZGV4IDI1YjViN2Y3OTQyYThkYmU1MjM5NDBiZWZiMTcxODQzM2U1MWQ5ZTgu
LjlmYmU5ZWI1M2RiM2RhODAwYTk1NTZhZWJiOGZkOGMxZjMzMTRhZTIgMTAwNjQ0Ci0tLSBhL1Nv
dXJjZS9XZWJDb3JlL2h0bWwvRE9NU2V0dGFibGVUb2tlbkxpc3QuaWRsCisrKyBiL1NvdXJjZS9X
ZWJDb3JlL2h0bWwvRE9NU2V0dGFibGVUb2tlbkxpc3QuaWRsCkBAIC0yMiw3ICsyMiw3IEBACiAg
KiBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERB
TUFHRS4KICAqLwogCi0jaWYgZGVmaW5lZChMQU5HVUFHRV9PQkpFQ1RJVkVfQykgJiYgTEFOR1VB
R0VfT0JKRUNUSVZFX0MgfHwgZGVmaW5lZChMQU5HVUFHRV9HT0JKRUNUKSAmJiBMQU5HVUFHRV9H
T0JKRUNUCisjaWYgZGVmaW5lZChMQU5HVUFHRV9PQkpFQ1RJVkVfQykgJiYgTEFOR1VBR0VfT0JK
RUNUSVZFX0MKIAogWwogICAgIE5vSW50ZXJmYWNlT2JqZWN0LAo=
</data>

          </attachment>
      

    </bug>

</bugzilla>