153869 2016-02-04 08:43:57 -0800 Removed unused Settings::setPrivateBrowsingEnabled. 2016-02-04 11:20:56 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 annulen webkit-unassigned ap commit-queue kling mhock oldest_to_newest 1161990 0 annulen 2016-02-04 08:43:57 -0800 Implementation of Settings::setPrivateBrowsingEnabled was removed in r166661, but declaration is still here. 1161991 1 270659 annulen 2016-02-04 08:49:54 -0800 Created attachment 270659 Patch 1162007 2 270659 commit-queue 2016-02-04 09:39:36 -0800 Comment on attachment 270659 Patch Rejecting attachment 270659 from review queue. annulen@yandex.ru does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. 1162008 3 270659 commit-queue 2016-02-04 09:40:13 -0800 Comment on attachment 270659 Patch Rejecting attachment 270659 from commit-queue. annulen@yandex.ru does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 1162013 4 270659 annulen 2016-02-04 09:46:14 -0800 Comment on attachment 270659 Patch Sorry, I've really meant to set flags to '?'. 1162024 5 270659 ap 2016-02-04 10:15:02 -0800 Comment on attachment 270659 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270659&action=review > Source/WebCore/ChangeLog:18 > + * page/Settings.h: > + (WebCore::Settings::dnsPrefetchingEnabled): Deleted. > + (WebCore::Settings::userStyleSheetLocation): Deleted. > + (WebCore::Settings::needsAcrobatFrameReloadingQuirk): Deleted. > + (WebCore::Settings::minimumDOMTimerInterval): Deleted. > + (WebCore::Settings::domTimerAlignmentInterval): Deleted. This is not accurate, please fix the ChangeLog. 1162030 6 270664 annulen 2016-02-04 10:29:21 -0800 Created attachment 270664 Patch 1162031 7 270659 annulen 2016-02-04 10:30:21 -0800 Comment on attachment 270659 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270659&action=review >> Source/WebCore/ChangeLog:18 >> + (WebCore::Settings::domTimerAlignmentInterval): Deleted. > > This is not accurate, please fix the ChangeLog. Looks like prepare-ChangeLog should be the next target of my perl exercises :) 1162071 8 270664 commit-queue 2016-02-04 11:20:51 -0800 Comment on attachment 270664 Patch Clearing flags on attachment: 270664 Committed r196134: <http://trac.webkit.org/changeset/196134> 1162072 9 commit-queue 2016-02-04 11:20:56 -0800 All reviewed patches have been landed. Closing bug. 270659 2016-02-04 08:49:54 -0800 2016-02-04 10:29:13 -0800 Patch bug-153869-20160204194930.patch text/plain 2237 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMTk2MTE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTU1NWY3ODgwNjFhMGI1 NzBlY2FjNzk1Njc0NTc0ZTZiNzg0MjVhZC4uOGEyNmFlY2FhMjVlYTEyMmE1ZjNlYmZjOGQxYzI0 ZjczODgzMzc2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE2LTAyLTA0ICBLb25z dGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4KKworICAgICAgICBSZW1vdmVkIHVu dXNlZCBTZXR0aW5nczo6c2V0UHJpdmF0ZUJyb3dzaW5nRW5hYmxlZC4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1Mzg2OQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEltcGxlbWVudGF0aW9uIG9mIFNldHRp bmdzOjpzZXRQcml2YXRlQnJvd3NpbmdFbmFibGVkIHdhcyByZW1vdmVkCisgICAgICAgIGluIHIx NjY2NjEsIGJ1dCBkZWNsYXJhdGlvbiBpcyBzdGlsbCBoZXJlLgorCisgICAgICAgIE5vIG5ldyB0 ZXN0cyBuZWVkZWQuCisKKyAgICAgICAgKiBwYWdlL1NldHRpbmdzLmg6CisgICAgICAgIChXZWJD b3JlOjpTZXR0aW5nczo6ZG5zUHJlZmV0Y2hpbmdFbmFibGVkKTogRGVsZXRlZC4KKyAgICAgICAg KFdlYkNvcmU6OlNldHRpbmdzOjp1c2VyU3R5bGVTaGVldExvY2F0aW9uKTogRGVsZXRlZC4KKyAg ICAgICAgKFdlYkNvcmU6OlNldHRpbmdzOjpuZWVkc0Fjcm9iYXRGcmFtZVJlbG9hZGluZ1F1aXJr KTogRGVsZXRlZC4KKyAgICAgICAgKFdlYkNvcmU6OlNldHRpbmdzOjptaW5pbXVtRE9NVGltZXJJ bnRlcnZhbCk6IERlbGV0ZWQuCisgICAgICAgIChXZWJDb3JlOjpTZXR0aW5nczo6ZG9tVGltZXJB bGlnbm1lbnRJbnRlcnZhbCk6IERlbGV0ZWQuCisKIDIwMTYtMDItMDQgIFlvdWVubiBGYWJsZXQg IDx5b3Vlbm4uZmFibGV0QGNyZi5jYW5vbi5mcj4KIAogICAgICAgICBVbnJldmlld2VkLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9TZXR0aW5ncy5oIGIvU291cmNlL1dlYkNvcmUv cGFnZS9TZXR0aW5ncy5oCmluZGV4IGJhNGE3OTVkNWNjMmZjNzViYmZmZDY4Njg0NzI4OGZlYWIy M2I0ZjEuLjA5OGY4YjFmNDU2YTdjZmUxNjRmNzVmNzI1NjMwZjUxMmRjZGEzMmYgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvU2V0dGluZ3MuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w YWdlL1NldHRpbmdzLmgKQEAgLTE0NiwyMSArMTQ2LDYgQEAgcHVibGljOgogICAgIFdFQkNPUkVf RVhQT1JUIHZvaWQgc2V0UGx1Z2luc0VuYWJsZWQoYm9vbCk7CiAgICAgYm9vbCBhcmVQbHVnaW5z RW5hYmxlZCgpIGNvbnN0IHsgcmV0dXJuIG1fYXJlUGx1Z2luc0VuYWJsZWQ7IH0KIAotICAgIC8v IFdoZW4gdGhpcyBvcHRpb24gaXMgc2V0LCBXZWJDb3JlIHdpbGwgYXZvaWQgc3RvcmluZyBhbnkg cmVjb3JkIG9mIGJyb3dzaW5nIGFjdGl2aXR5Ci0gICAgLy8gdGhhdCBtYXkgcGVyc2lzdCBvbiBk aXNrIG9yIHJlbWFpbiBkaXNwbGF5ZWQgd2hlbiB0aGUgb3B0aW9uIGlzIHJlc2V0LgotICAgIC8v IFRoaXMgb3B0aW9uIGRvZXMgbm90IGFmZmVjdCB0aGUgc3RvcmFnZSBvZiBzdWNoIGluZm9ybWF0 aW9uIGluIFJBTS4KLSAgICAvLyBUaGUgZm9sbG93aW5nIGZ1bmN0aW9ucyByZXNwZWN0IHRoaXMg c2V0dGluZzoKLSAgICAvLyAgLSBIVE1MNS9ET00gU3RvcmFnZQotICAgIC8vICAtIEljb24gRGF0 YWJhc2UKLSAgICAvLyAgLSBDb25zb2xlIE1lc3NhZ2VzCi0gICAgLy8gIC0gTWVtb3J5Q2FjaGUK LSAgICAvLyAgLSBBcHBsaWNhdGlvbiBDYWNoZQotICAgIC8vICAtIEJhY2svRm9yd2FyZCBQYWdl IEhpc3RvcnkKLSAgICAvLyAgLSBQYWdlIFNlYXJjaCBSZXN1bHRzCi0gICAgLy8gIC0gSFRUUCBD b29raWVzCi0gICAgLy8gIC0gUGx1Zy1pbnMgKHRoYXQgc3VwcG9ydCBOUE5WcHJpdmF0ZU1vZGVC b29sKQotICAgIHZvaWQgc2V0UHJpdmF0ZUJyb3dzaW5nRW5hYmxlZChib29sKTsKLQogICAgIFdF QkNPUkVfRVhQT1JUIHZvaWQgc2V0RE5TUHJlZmV0Y2hpbmdFbmFibGVkKGJvb2wpOwogICAgIGJv b2wgZG5zUHJlZmV0Y2hpbmdFbmFibGVkKCkgY29uc3QgeyByZXR1cm4gbV9kbnNQcmVmZXRjaGlu Z0VuYWJsZWQ7IH0KIAo= 270664 2016-02-04 10:29:21 -0800 2016-02-04 11:20:51 -0800 Patch bug-153869-20160204212856.patch text/plain 1976 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMTk2MTE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTU1NWY3ODgwNjFhMGI1 NzBlY2FjNzk1Njc0NTc0ZTZiNzg0MjVhZC4uMWUyZTY5MGE3ZGQ2YWU0YzM4ODM4ZTY0NzA0OGNh NDNmYTY2YjRlZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE2LTAyLTA0ICBLb25z dGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4KKworICAgICAgICBSZW1vdmVkIHVu dXNlZCBTZXR0aW5nczo6c2V0UHJpdmF0ZUJyb3dzaW5nRW5hYmxlZC4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1Mzg2OQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEltcGxlbWVudGF0aW9uIG9mIFNldHRp bmdzOjpzZXRQcml2YXRlQnJvd3NpbmdFbmFibGVkIHdhcyByZW1vdmVkCisgICAgICAgIGluIHIx NjY2NjEsIGJ1dCBkZWNsYXJhdGlvbiBpcyBzdGlsbCBoZXJlLgorCisgICAgICAgIE5vIG5ldyB0 ZXN0cyBuZWVkZWQuCisKKyAgICAgICAgKiBwYWdlL1NldHRpbmdzLmg6CisgICAgICAgIChXZWJD b3JlOjpTZXR0aW5nczo6c2V0UHJpdmF0ZUJyb3dzaW5nRW5hYmxlZCk6IERlbGV0ZWQuCisKIDIw MTYtMDItMDQgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm4uZmFibGV0QGNyZi5jYW5vbi5mcj4KIAog ICAgICAgICBVbnJldmlld2VkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9TZXR0 aW5ncy5oIGIvU291cmNlL1dlYkNvcmUvcGFnZS9TZXR0aW5ncy5oCmluZGV4IGJhNGE3OTVkNWNj MmZjNzViYmZmZDY4Njg0NzI4OGZlYWIyM2I0ZjEuLjA5OGY4YjFmNDU2YTdjZmUxNjRmNzVmNzI1 NjMwZjUxMmRjZGEzMmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvU2V0dGluZ3Mu aAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1NldHRpbmdzLmgKQEAgLTE0NiwyMSArMTQ2LDYg QEAgcHVibGljOgogICAgIFdFQkNPUkVfRVhQT1JUIHZvaWQgc2V0UGx1Z2luc0VuYWJsZWQoYm9v bCk7CiAgICAgYm9vbCBhcmVQbHVnaW5zRW5hYmxlZCgpIGNvbnN0IHsgcmV0dXJuIG1fYXJlUGx1 Z2luc0VuYWJsZWQ7IH0KIAotICAgIC8vIFdoZW4gdGhpcyBvcHRpb24gaXMgc2V0LCBXZWJDb3Jl IHdpbGwgYXZvaWQgc3RvcmluZyBhbnkgcmVjb3JkIG9mIGJyb3dzaW5nIGFjdGl2aXR5Ci0gICAg Ly8gdGhhdCBtYXkgcGVyc2lzdCBvbiBkaXNrIG9yIHJlbWFpbiBkaXNwbGF5ZWQgd2hlbiB0aGUg b3B0aW9uIGlzIHJlc2V0LgotICAgIC8vIFRoaXMgb3B0aW9uIGRvZXMgbm90IGFmZmVjdCB0aGUg c3RvcmFnZSBvZiBzdWNoIGluZm9ybWF0aW9uIGluIFJBTS4KLSAgICAvLyBUaGUgZm9sbG93aW5n IGZ1bmN0aW9ucyByZXNwZWN0IHRoaXMgc2V0dGluZzoKLSAgICAvLyAgLSBIVE1MNS9ET00gU3Rv cmFnZQotICAgIC8vICAtIEljb24gRGF0YWJhc2UKLSAgICAvLyAgLSBDb25zb2xlIE1lc3NhZ2Vz Ci0gICAgLy8gIC0gTWVtb3J5Q2FjaGUKLSAgICAvLyAgLSBBcHBsaWNhdGlvbiBDYWNoZQotICAg IC8vICAtIEJhY2svRm9yd2FyZCBQYWdlIEhpc3RvcnkKLSAgICAvLyAgLSBQYWdlIFNlYXJjaCBS ZXN1bHRzCi0gICAgLy8gIC0gSFRUUCBDb29raWVzCi0gICAgLy8gIC0gUGx1Zy1pbnMgKHRoYXQg c3VwcG9ydCBOUE5WcHJpdmF0ZU1vZGVCb29sKQotICAgIHZvaWQgc2V0UHJpdmF0ZUJyb3dzaW5n RW5hYmxlZChib29sKTsKLQogICAgIFdFQkNPUkVfRVhQT1JUIHZvaWQgc2V0RE5TUHJlZmV0Y2hp bmdFbmFibGVkKGJvb2wpOwogICAgIGJvb2wgZG5zUHJlZmV0Y2hpbmdFbmFibGVkKCkgY29uc3Qg eyByZXR1cm4gbV9kbnNQcmVmZXRjaGluZ0VuYWJsZWQ7IH0KIAo=