153860 2016-02-04 02:44:12 -0800 [GTK] Scrollbars not correctly rendered in non GNOME environments 2016-02-05 05:58:33 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk, Regression P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply clopez commit-queue esprehn+autocc glenn kondapallykalyan mcatanzaro oldest_to_newest 1161947 0 cgarcia 2016-02-04 02:44:12 -0800 I noticed this in a matchbox environment, where there's no gnome-setting-daemon running. The problem is only with the scrollbars, because we initialize the GtkSettings in RenderThemeGtk and notify the ScrollbarTheme when it changes, but ScrollbarTheme is created before RenderThemeGtk so we initialize the theme properties before the GtkSettings have been initialized. We could just let the ScrollbarTheme monitor the theme itself instead of relying on being notified by the WebCore layer. 1161948 1 270648 cgarcia 2016-02-04 02:46:14 -0800 Created attachment 270648 Patch 1162377 2 cgarcia 2016-02-05 05:58:33 -0800 Committed r196171: <http://trac.webkit.org/changeset/196171> 270648 2016-02-04 02:46:14 -0800 2016-02-04 11:58:12 -0800 Patch wcore-theme-settings.diff text/plain 2886 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzZTcwNGMyLi45NWI1Y2FhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjgg QEAKIDIwMTYtMDItMDQgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCisgICAgICAgIFtHVEtdIFNjcm9sbGJhcnMgbm90IGNvcnJlY3RseSByZW5kZXJlZCBpbiBu b24gR05PTUUgZW52aXJvbm1lbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNTM4NjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBJIG5vdGljZWQgdGhpcyBpbiBhIG1hdGNoYm94IGVudmlyb25tZW50LCB3 aGVyZSB0aGVyZSdzIG5vCisgICAgICAgIGdub21lLXNldHRpbmctZGFlbW9uIHJ1bm5pbmcuIFRo ZSBwcm9ibGVtIGlzIG9ubHkgd2l0aCB0aGUKKyAgICAgICAgc2Nyb2xsYmFycywgYmVjYXVzZSB3 ZSBpbml0aWFsaXplIHRoZSBHdGtTZXR0aW5ncyBpbgorICAgICAgICBSZW5kZXJUaGVtZUd0ayBh bmQgbm90aWZ5IHRoZSBTY3JvbGxiYXJUaGVtZSB3aGVuIGl0IGNoYW5nZXMsIGJ1dAorICAgICAg ICBTY3JvbGxiYXJUaGVtZSBpcyBjcmVhdGVkIGJlZm9yZSBSZW5kZXJUaGVtZUd0ayBzbyB3ZSBp bml0aWFsaXplCisgICAgICAgIHRoZSB0aGVtZSBwcm9wZXJ0aWVzIGJlZm9yZSB0aGUgR3RrU2V0 dGluZ3MgaGF2ZSBiZWVuCisgICAgICAgIGluaXRpYWxpemVkLiBXZSBjYW4ganVzdCBsZXQgdGhl IFNjcm9sbGJhclRoZW1lIG1vbml0b3IgdGhlCisgICAgICAgIHRoZW1lIGl0c2VsZiBpbnN0ZWFk IG9mIHJlbHlpbmcgb24gYmVpbmcgbm90aWZpZWQgYnkgdGhlIFdlYkNvcmUKKyAgICAgICAgbGF5 ZXIuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvU2Nyb2xsYmFyVGhlbWVHdGsuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6dGhlbWVDaGFuZ2VkQ2FsbGJhY2spOgorICAgICAgICAoV2ViQ29yZTo6 U2Nyb2xsYmFyVGhlbWVHdGs6OlNjcm9sbGJhclRoZW1lR3RrKToKKyAgICAgICAgKiByZW5kZXJp bmcvUmVuZGVyVGhlbWVHdGsuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Z3RrU3R5bGVDaGFuZ2Vk Q2FsbGJhY2spOiBEZWxldGVkLgorCisyMDE2LTAyLTA0ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAg PGNnYXJjaWFAaWdhbGlhLmNvbT4KKwogICAgICAgICBBZGQgYSB3YXkgdG8gdGVzdCBTY3JvbGxB bmltYXRvcgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTUzNDc5CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9TY3JvbGxi YXJUaGVtZUd0ay5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvU2Nyb2xsYmFyVGhl bWVHdGsuY3BwCmluZGV4IGUxMWVlOTIuLjY0NGE4OWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2d0ay9TY3JvbGxiYXJUaGVtZUd0ay5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3RrL1Njcm9sbGJhclRoZW1lR3RrLmNwcApAQCAtMjI5LDYgKzIyOSwxMSBA QCBzdGF0aWMgR1JlZlB0cjxHdGtTdHlsZUNvbnRleHQ+IGNyZWF0ZUNoaWxkU3R5bGVDb250ZXh0 KEd0a1N0eWxlQ29udGV4dCogcGFyZW50LAogICAgIHJldHVybiBzdHlsZUNvbnRleHQ7CiB9CiAK K3N0YXRpYyB2b2lkIHRoZW1lQ2hhbmdlZENhbGxiYWNrKCkKK3sKKyAgICBTY3JvbGxiYXJUaGVt ZTo6dGhlbWUoKS50aGVtZUNoYW5nZWQoKTsKK30KKwogU2Nyb2xsYmFyVGhlbWVHdGs6OlNjcm9s bGJhclRoZW1lR3RrKCkKIHsKICNpZiBHVEtfQ0hFQ0tfVkVSU0lPTigzLCAxOSwgMikKQEAgLTI0 MCw2ICsyNDUsMTIgQEAgU2Nyb2xsYmFyVGhlbWVHdGs6OlNjcm9sbGJhclRoZW1lR3RrKCkKICAg ICBtX3VzZXNPdmVybGF5U2Nyb2xsYmFycyA9ICFnX3N0cmNtcDAoZ19nZXRlbnYoIkdUS19PVkVS TEFZX1NDUk9MTElORyIpLCAiMSIpOwogI2VuZGlmCiAjZW5kaWYKKyAgICBzdGF0aWMgYm9vbCB0 aGVtZU1vbml0b3JJbml0aWFsaXplZCA9IGZhbHNlOworICAgIGlmICghdGhlbWVNb25pdG9ySW5p dGlhbGl6ZWQpIHsKKyAgICAgICAgZ19zaWduYWxfY29ubmVjdF9zd2FwcGVkKGd0a19zZXR0aW5n c19nZXRfZGVmYXVsdCgpLCAibm90aWZ5OjpndGstdGhlbWUtbmFtZSIsIEdfQ0FMTEJBQ0sodGhl bWVDaGFuZ2VkQ2FsbGJhY2spLCBudWxscHRyKTsKKyAgICAgICAgdGhlbWVNb25pdG9ySW5pdGlh bGl6ZWQgPSB0cnVlOworICAgIH0KKwogICAgIHVwZGF0ZVRoZW1lUHJvcGVydGllcygpOwogfQog CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVHdGsuY3Bw IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lR3RrLmNwcAppbmRleCAyYTYy MjhmLi4zYmMyMmQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy VGhlbWVHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUd0 ay5jcHAKQEAgLTE2OCw3ICsxNjgsNiBAQCBlbnVtIFJlbmRlclRoZW1lUGFydCB7CiAKIHN0YXRp YyB2b2lkIGd0a1N0eWxlQ2hhbmdlZENhbGxiYWNrKEdPYmplY3QqLCBHUGFyYW1TcGVjKikKIHsK LSAgICBzdGF0aWNfY2FzdDxTY3JvbGxiYXJUaGVtZUd0ayY+KFNjcm9sbGJhclRoZW1lOjp0aGVt ZSgpKS50aGVtZUNoYW5nZWQoKTsKICAgICBQYWdlOjp1cGRhdGVTdHlsZUZvckFsbFBhZ2VzQWZ0 ZXJHbG9iYWxDaGFuZ2VJbkVudmlyb25tZW50KCk7CiB9CiAK