153842 2016-02-03 13:23:35 -0800 git-add-reviewer should work when run from a subdirectory within the repository 2016-02-03 16:35:37 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bburg bburg bburg commit-queue dbates ddkilzer joepeck lforschler oldest_to_newest 1161763 0 bburg 2016-02-03 13:23:35 -0800 There is a very old FIXME i'm about to delete. 1161767 1 270598 bburg 2016-02-03 13:32:03 -0800 Created attachment 270598 Patch 1161769 2 270598 ddkilzer 2016-02-03 13:46:59 -0800 Comment on attachment 270598 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270598&action=review r=me > Tools/ChangeLog:14 > + fix this same issue for prepare-Changelogs. Nit: Capitalization of prepare-ChangeLogs. > Tools/Scripts/git-add-reviewer:89 > +my $gitDirectory = gitDirectory(); I tend to dislike adding globals (when you could just call gitDirectory() at each place it's needed), but I don't feel strongly enough to r- this. 1161825 3 bburg 2016-02-03 16:35:37 -0800 Committed r196097: <http://trac.webkit.org/changeset/196097> 270598 2016-02-03 13:32:03 -0800 2016-02-03 13:46:59 -0800 Patch bug-153842-20160203133138.patch text/plain 3868 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMTk2MDY5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTk2YmZkYmNhMzM0ZDYwNjg1YjI3NTZhYWJiM2Q2OWYw MjhlYjkwNS4uYzNlYjNjNGExOTRkZWFkNTExNzQ4MTJlZDg5NDQ0NTgyZTY5YTg4YiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1 IEBACisyMDE2LTAyLTAzICBCcmlhbiBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgorCisgICAgICAg IGdpdC1hZGQtcmV2aWV3ZXIgc2hvdWxkIHdvcmsgd2hlbiBydW4gZnJvbSBhIHN1YmRpcmVjdG9y eSB3aXRoaW4gdGhlIHJlcG9zaXRvcnkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE1Mzg0MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRoZXJlIGFyZSB0d28gcHJvYmxlbXMgdGhhdCBuZWVkZWQgdG8gYmUg Zml4ZWQ6CisKKyAgICAgICAgIC0gV2UgY2FuJ3QgYXNzdW1lIC5naXQgaXMgaW4gJFBXRC8uZ2l0 CisgICAgICAgICAtIFdlIGNhbid0IHNwZWNpZnkgYWJzb2x1dGUgcGF0aHMgdG8gYGdpdCBjb21t aXRgCisKKyAgICAgICAgRml4IHRoZXNlIHByb2JsZW1zIHVzaW5nIHRoZSBoZWxwZXJzIGluIFZD U1V0aWxzIHRoYXQgd2VyZSBhZGRlZCB0bworICAgICAgICBmaXggdGhpcyBzYW1lIGlzc3VlIGZv ciBwcmVwYXJlLUNoYW5nZWxvZ3MuCisKKyAgICAgICAgKiBTY3JpcHRzL1ZDU1V0aWxzLnBtOiBF eHBvcnQgZ2l0RGlyZWN0b3J5KCkKKyAgICAgICAgKiBTY3JpcHRzL2dpdC1hZGQtcmV2aWV3ZXI6 CisgICAgICAgIChub25JbnRlcmFjdGl2ZSk6IENhY2hlIGdpdERpcmVjdG9yeSgpIHJlc3VsdC4K KyAgICAgICAgKGFkZFJldmlld2VyKToKKyAgICAgICAgKGNvbW1pdCk6CisgICAgICAgIChjaGFu Z2VMb2dzRm9yQ29tbWl0KTogTWFrZSBwYXRocyByZWxhdGl2ZS4KKwogMjAxNi0wMi0wMyAgS29u c3RhbnRpbiBUb2thcmV2ICA8YW5udWxlbkB5YW5kZXgucnU+CiAKICAgICAgICAgW3dlYmtpdGRp cnNdIENsYXJpZnkgbG9naWMgYmVoaW5kIGlze1BvcnROYW1lfSBmdW5jdGlvbnMuCmRpZmYgLS1n aXQgYS9Ub29scy9TY3JpcHRzL1ZDU1V0aWxzLnBtIGIvVG9vbHMvU2NyaXB0cy9WQ1NVdGlscy5w bQppbmRleCA1NDYwYjkyODU0MTM5NWE3ODE1ZTg0ZTMyMzMzOTZhZDI5ZDUyY2EyLi4yMTQxNTBk MTJkNDVmNDBmOGRhZDhkNTllYWY0NTcwNmU3NzdmNmRhIDEwMDY0NAotLS0gYS9Ub29scy9TY3Jp cHRzL1ZDU1V0aWxzLnBtCisrKyBiL1Rvb2xzL1NjcmlwdHMvVkNTVXRpbHMucG0KQEAgLTYwLDYg KzYwLDcgQEAgQkVHSU4gewogICAgICAgICAmZXhpdFN0YXR1cwogICAgICAgICAmZml4Q2hhbmdl TG9nUGF0Y2gKICAgICAgICAgJmdpdEJyYW5jaAorICAgICAgICAmZ2l0RGlyZWN0b3J5CiAgICAg ICAgICZnaXRUcmVlRGlyZWN0b3J5CiAgICAgICAgICZnaXRkaWZmMnN2bmRpZmYKICAgICAgICAg JmlzR2l0CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL2dpdC1hZGQtcmV2aWV3ZXIgYi9Ub29s cy9TY3JpcHRzL2dpdC1hZGQtcmV2aWV3ZXIKaW5kZXggN2E2MjBkZTY2NmJjNmU4MTJhODNhMWU4 YWEzODRhNTVkZjFmYTU2ZC4uOTExNmNlNWU3YjAwZTk5NjBkZmNiODFkYzBmYTk2ZjMzOTIyOTQx MyAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9naXQtYWRkLXJldmlld2VyCisrKyBiL1Rvb2xz L1NjcmlwdHMvZ2l0LWFkZC1yZXZpZXdlcgpAQCAtMzEsNiArMzEsMTEgQEAgdXNlIEdldG9wdDo6 TG9uZzsKIHVzZSBQT1NJWDsKIHVzZSBJUEM6Ok9wZW4yOwogCit1c2UgRmluZEJpbjsKK3VzZSBs aWIgJEZpbmRCaW46OkJpbjsKK3VzZSB3ZWJraXRkaXJzOwordXNlIFZDU1V0aWxzOworCiBteSAk ZGVmYXVsdFJldmlld2VyID0gIk5PQk9EWSI7CiAKIHN1YiBhZGRSZXZpZXdlcihcJSk7CkBAIC04 MSw2ICs4Niw4IEBAIG15ICRnZXRPcHRpb25zUmVzdWx0ID0gR2V0T3B0aW9ucygKICAgICAnaXxp bnRlcmFjdGl2ZScgPT4gXCRpbnRlcmFjdGl2ZSwKICk7CiAKK215ICRnaXREaXJlY3RvcnkgPSBn aXREaXJlY3RvcnkoKTsKKwogdXNhZ2UoKSBpZiAhJGdldE9wdGlvbnNSZXN1bHQgfHwgJHNob3dI ZWxwOwogCiByZXF1aXJlQ2xlYW5Xb3JrVHJlZSgpOwpAQCAtMTgxLDggKzE4OCw3IEBAIHN1YiBu b25JbnRlcmFjdGl2ZSgpCiAgICAgJGl0ZW17Y2hhbmdlTG9nc30gb3IgZGllOwogCiAgICAgdW5s ZXNzICgoKCRjb21taXQgZXEgJGhlYWRDb21taXQpIG9yIGNoZWNrb3V0KCRjb21taXQpKQotICAg ICAgICAgICAgIyBGSVhNRTogV2UgbmVlZCB0byB1c2UgJEVOVntHSVRfRElSfS8uZ2l0L01FUkdF X01TRwotICAgICAgICAgICAgJiYgd3JpdGVDb21taXRNZXNzYWdlVG9GaWxlKCIuZ2l0L01FUkdF X01TRyIpCisgICAgICAgICAgICAmJiB3cml0ZUNvbW1pdE1lc3NhZ2VUb0ZpbGUoIiRnaXREaXJl Y3RvcnkvTUVSR0VfTVNHIikKICAgICAgICAgICAgICYmIGFkZFJldmlld2VyKCVpdGVtKQogICAg ICAgICAgICAgJiYgY29tbWl0KDEpCiAgICAgICAgICAgICAmJiAoKCRjb21taXQgZXEgJGhlYWRD b21taXQpIG9yIHJlYmFzZU9udG9IZWFkKCRjb21taXQsICRoZWFkKSkpIHsKQEAgLTIzMyw3ICsy MzksNyBAQCBzdWIgYWRkUmV2aWV3ZXIoXCUpCiAgICAgICAgIGFkZFJldmlld2VyVG9DaGFuZ2VM b2coJGl0ZW0tPntyZXZpZXdlcn0sICRpdGVtLT57cnViYmVyc3RhbXB9LCAkbG9nKSBvciByZXR1 cm4gZmFpbCgpOwogICAgIH0KIAotICAgIGFkZFJldmlld2VyVG9Db21taXRNZXNzYWdlKCRpdGVt LT57cmV2aWV3ZXJ9LCAkaXRlbS0+e3J1YmJlcnN0YW1wfSwgIi5naXQvTUVSR0VfTVNHIikgb3Ig cmV0dXJuIGZhaWwoKTsKKyAgICBhZGRSZXZpZXdlclRvQ29tbWl0TWVzc2FnZSgkaXRlbS0+e3Jl dmlld2VyfSwgJGl0ZW0tPntydWJiZXJzdGFtcH0sICIkZ2l0RGlyZWN0b3J5L01FUkdFX01TRyIp IG9yIHJldHVybiBmYWlsKCk7CiAKICAgICByZXR1cm4gMTsKIH0KQEAgLTI0Miw3ICsyNDgsOCBA QCBzdWIgY29tbWl0KDskKQogewogICAgIG15ICgkYW1lbmQpID0gQF87CiAKLSAgICBteSBAY29t bWFuZCA9IHF3KGdpdCBjb21taXQgLUYgLmdpdC9NRVJHRV9NU0cpOworICAgIG15IEBjb21tYW5k ID0gcXcoZ2l0IGNvbW1pdCAtRik7CisgICAgcHVzaCBAY29tbWFuZCwgIiRnaXREaXJlY3Rvcnkv TUVSR0VfTVNHIjsKICAgICBwdXNoIEBjb21tYW5kLCAiLS1hbWVuZCIgaWYgJGFtZW5kOwogICAg IG15ICRyZXN1bHQgPSBzeXN0ZW0gQGNvbW1hbmQ7CiAgICAgISgkcmVzdWx0ID4+IDgpIG9yIHJl dHVybiBmYWlsKCJGYWlsZWQgdG8gY29tbWl0IHJldmlzaW9uIik7CkBAIC0zMjksNyArMzM2LDcg QEAgc3ViIGNoYW5nZUxvZ3NGb3JDb21taXQoJCkKICAgICBteSBAZmlsZXMgPSBydW5Db21tYW5k V2l0aE91dHB1dCgnZ2l0JywgJ2RpZmYnLCAnLXInLCAnLS1uYW1lLXN0YXR1cycsICIkY29tbWl0 XiIsICIkY29tbWl0Iik7CiAgICAgQGZpbGVzIG9yIHJldHVybiBmYWlsKCJDb3VsZG4ndCBkZXRl cm1pbmUgY2hhbmdlZCBmaWxlcyBmb3IgJGNvbW1pdC4iKTsKIAotICAgIG15IEBjaGFuZ2VMb2dz ID0gbWFwIHsgL15bQUNNUl1ccyooLiopLzsgJDEgfSBncmVwIHsgL15bQUNNUl0uKlteLV1DaGFu Z2VMb2cvIH0gQGZpbGVzOworICAgIG15IEBjaGFuZ2VMb2dzID0gbWFwIHsgL15bQUNNUl1ccyoo LiopLzsgbWFrZUZpbGVQYXRoUmVsYXRpdmUoJDEpIH0gZ3JlcCB7IC9eW0FDTVJdLipbXi1dQ2hh bmdlTG9nLyB9IEBmaWxlczsKICAgICByZXR1cm4gXEBjaGFuZ2VMb2dzOwogfQogCg==