153827 2016-02-03 03:05:43 -0800 [Tools] Remove $additionalCMakeArgs variable because without this variable --cmakeargs options works well 2016-02-03 15:07:01 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jh718.park jh718.park achristensen annulen commit-queue dbates gyuyoung.kim lforschler mcatanzaro ossy oldest_to_newest 1161627 0 jh718.park 2016-02-03 03:05:43 -0800 When an array is passed to subroutines as argument in perl, a list containing its element is returned from the array. Currently @$ arguments are being passed, then it is going to be one list including all the elements not only from @ but also from $. As a result, $additionalCMakeArgs in sub generateBuildSystemFromCMakeProject is not being used. 1161637 1 270569 jh718.park 2016-02-03 04:25:22 -0800 Created attachment 270569 Patch 1161640 2 annulen 2016-02-03 04:39:13 -0800 I saw this bug but I decided that nobody needs $additionalCMakeArgs. 1161641 3 jh718.park 2016-02-03 04:41:20 -0800 (In reply to comment #2) > I saw this bug but I decided that nobody needs $additionalCMakeArgs. If the variable doesn't needed anymore, then maybe is it ok to be removed instead? 1161642 4 annulen 2016-02-03 04:44:28 -0800 Looks like --cmakeargs works fine with this issue present, so it seems to be a good idea to remove dead code. 1161643 5 jh718.park 2016-02-03 04:50:36 -0800 (In reply to comment #4) > Looks like --cmakeargs works fine with this issue present, so it seems to be > a good idea to remove dead code. All right, then I'm gonna remove this thing immediately. 1161644 6 270571 jh718.park 2016-02-03 05:01:59 -0800 Created attachment 270571 Patch 1161650 7 annulen 2016-02-03 05:37:49 -0800 LGTM. 1161801 8 270571 commit-queue 2016-02-03 15:06:56 -0800 Comment on attachment 270571 Patch Clearing flags on attachment: 270571 Committed r196085: <http://trac.webkit.org/changeset/196085> 1161802 9 commit-queue 2016-02-03 15:07:01 -0800 All reviewed patches have been landed. Closing bug. 270569 2016-02-03 04:25:22 -0800 2016-02-03 05:01:53 -0800 Patch bug-153827-20160203212457.patch text/plain 1750 jh718.park U3VidmVyc2lvbiBSZXZpc2lvbjogMTk2MDQxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTZlZThjNWU0YTEyZDA3YWNlYmI5MzE0YTc3MmEyZGM4 MWE1YTZmNi4uNWZkYTBlMDFjY2JlYTI3Mzg1N2E1ZTQyZDMwYTQ0NTRlNzM3NDE1YiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDE2LTAyLTAzICBKb29uZ2h1biBQYXJrICA8amg3MTgucGFya0BzYW1zdW5nLmNvbT4K KworICAgICAgICBbVG9vbHNdIC0tY21ha2VhcmdzIG9wdGlvbidzIHZhbHVlIGlzIG5vdCBhc3Np Z25lZCB0byAkYWRkaXRpb25hbENNYWtlQXJncyB2YXJpYWJsZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUzODI3CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiBhbiBhcnJheSBpcyBwYXNzZWQgdG8g c3Vicm91dGluZXMgYXMgYXJndW1lbnQgaW4gcGVybCwKKyAgICAgICAgYSBsaXN0IGNvbnRhaW5p bmcgaXRzIGVsZW1lbnQgaXMgcmV0dXJuZWQgZnJvbSB0aGUgYXJyYXkuCisgICAgICAgIEN1cnJl bnRseSBAJCBhcmd1bWVudHMgYXJlIGJlaW5nIHBhc3NlZCwgdGhlbiBpdCBpcyBnb2luZyB0byBi ZSBvbmUgbGlzdAorICAgICAgICBpbmNsdWRpbmcgYWxsIHRoZSBlbGVtZW50cyBub3Qgb25seSBm cm9tIEAgYnV0IGFsc28gZnJvbSAkLgorICAgICAgICBBcyBhIHJlc3VsdCwgJGFkZGl0aW9uYWxD TWFrZUFyZ3MgaW4gc3ViIGdlbmVyYXRlQnVpbGRTeXN0ZW1Gcm9tQ01ha2VQcm9qZWN0CisgICAg ICAgIGlzIG5vdCBiZWluZyB1c2VkLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBt OgorICAgICAgICAoZ2VuZXJhdGVCdWlsZFN5c3RlbUZyb21DTWFrZVByb2plY3QpOgorCiAyMDE2 LTAyLTAyICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgTGF5b3V0 IFRlc3QgZmFzdC9wYXJzZXIvZXh0ZXJuYWwtZW50aXRpZXMtaW4teHNsdC54bWwgaXMgZmxha3kg b24gRWwgQ2FwaXRhbiAoYnV0IGZhaWxzIG1vc3Qgb2YgdGhlIHRpbWUpCmRpZmYgLS1naXQgYS9U b29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0gYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0K aW5kZXggZGE1MzdlY2MzZmQ0NTE2OTJmYWU2MmU1OGJhNTE5MDYzMDQ5MzA5Mi4uZWI5ZDI2NzZh ZTk1Mjc3MTBhMTI2M2Q0N2NkMmZmYjFiNDgzYjYwMyAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0 cy93ZWJraXRkaXJzLnBtCisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQpAQCAtMTky OSw3ICsxOTI5LDggQEAgc3ViIGNtYWtlR2VuZXJhdGVkQnVpbGRmaWxlKEApCiAKIHN1YiBnZW5l cmF0ZUJ1aWxkU3lzdGVtRnJvbUNNYWtlUHJvamVjdAogewotICAgIG15ICgkcHJlZml4UGF0aCwg QGNtYWtlQXJncywgJGFkZGl0aW9uYWxDTWFrZUFyZ3MpID0gQF87CisgICAgbXkgKCRwcmVmaXhQ YXRoLCBAY21ha2VBcmdzKSA9IEBfOworICAgIG15ICRhZGRpdGlvbmFsQ01ha2VBcmdzID0gcG9w IEBjbWFrZUFyZ3M7CiAgICAgbXkgJGNvbmZpZyA9IGNvbmZpZ3VyYXRpb24oKTsKICAgICBteSAk cG9ydCA9IGNtYWtlQmFzZWRQb3J0TmFtZSgpOwogICAgIG15ICRidWlsZFBhdGggPSBGaWxlOjpT cGVjLT5jYXRkaXIoYmFzZVByb2R1Y3REaXIoKSwgJGNvbmZpZyk7Cg== 270571 2016-02-03 05:01:59 -0800 2016-02-03 15:06:56 -0800 Patch bug-153827-20160203220135.patch text/plain 2195 jh718.park U3VidmVyc2lvbiBSZXZpc2lvbjogMTk2MDQxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTZlZThjNWU0YTEyZDA3YWNlYmI5MzE0YTc3MmEyZGM4 MWE1YTZmNi4uMzNiOWM2MWNmMTY5ZDMyMWY5Y2JkNjMwNGU1OWVmNGUxZDA4OTZkNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDE2LTAyLTAzICBKb29uZ2h1biBQYXJrICA8amg3MTgucGFya0BzYW1zdW5nLmNvbT4K KworICAgICAgICBbVG9vbHNdIFJlbW92ZSAkYWRkaXRpb25hbENNYWtlQXJncyB2YXJpYWJsZSBi ZWNhdXNlIHdpdGhvdXQgdGhpcyB2YXJpYWJsZSAtLWNtYWtlYXJncyBvcHRpb25zIHdvcmtzIHdl bGwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1Mzgy NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4g YW4gYXJyYXkgaXMgcGFzc2VkIHRvIHN1YnJvdXRpbmVzIGFzIGFyZ3VtZW50IGluIHBlcmwsCisg ICAgICAgIGEgbGlzdCBjb250YWluaW5nIGl0cyBlbGVtZW50IGlzIHJldHVybmVkIGZyb20gdGhl IGFycmF5LgorICAgICAgICBDdXJyZW50bHkgQCQgYXJndW1lbnRzIGFyZSBiZWluZyBwYXNzZWQs IHRoZW4gaXQgaXMgZ29pbmcgdG8gYmUgb25lIGxpc3QKKyAgICAgICAgaW5jbHVkaW5nIGFsbCB0 aGUgZWxlbWVudHMgbm90IG9ubHkgZnJvbSBAIGJ1dCBhbHNvIGZyb20gJC4KKyAgICAgICAgQXMg YSByZXN1bHQsIC0tY21ha2VhcmdzIG9wdGlvbidzIHZhbHVlIGlzIGluY2x1ZGVkIGluIEBjbWFr ZUFyZ3MKKyAgICAgICAgYXQgZ2VuZXJhdGVCdWlsZFN5c3RlbUZyb21DTWFrZVByb2plY3Qgc3Vi cm91dGluZSwKKyAgICAgICAgc28gJGFkZGl0aW9uYWxDTWFrZUFyZ3MgZG9lc24ndCBuZWVkZWQg YW55bW9yZS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAgKGdl bmVyYXRlQnVpbGRTeXN0ZW1Gcm9tQ01ha2VQcm9qZWN0KToKKwogMjAxNi0wMi0wMiAgRGFuIEJl cm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIExheW91dCBUZXN0IGZhc3QvcGFy c2VyL2V4dGVybmFsLWVudGl0aWVzLWluLXhzbHQueG1sIGlzIGZsYWt5IG9uIEVsIENhcGl0YW4g KGJ1dCBmYWlscyBtb3N0IG9mIHRoZSB0aW1lKQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93 ZWJraXRkaXJzLnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4IGRhNTM3ZWNj M2ZkNDUxNjkyZmFlNjJlNThiYTUxOTA2MzA0OTMwOTIuLjBjYTI0OGY2Nzc0ZWQ2MzIyNDE5Yzk0 MDQ3MTg4MzhmYmY4MjM2ZmMgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5w bQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KQEAgLTE5MjksNyArMTkyOSw3IEBA IHN1YiBjbWFrZUdlbmVyYXRlZEJ1aWxkZmlsZShAKQogCiBzdWIgZ2VuZXJhdGVCdWlsZFN5c3Rl bUZyb21DTWFrZVByb2plY3QKIHsKLSAgICBteSAoJHByZWZpeFBhdGgsIEBjbWFrZUFyZ3MsICRh ZGRpdGlvbmFsQ01ha2VBcmdzKSA9IEBfOworICAgIG15ICgkcHJlZml4UGF0aCwgQGNtYWtlQXJn cykgPSBAXzsKICAgICBteSAkY29uZmlnID0gY29uZmlndXJhdGlvbigpOwogICAgIG15ICRwb3J0 ID0gY21ha2VCYXNlZFBvcnROYW1lKCk7CiAgICAgbXkgJGJ1aWxkUGF0aCA9IEZpbGU6OlNwZWMt PmNhdGRpcihiYXNlUHJvZHVjdERpcigpLCAkY29uZmlnKTsKQEAgLTE5NzAsNyArMTk3MCw2IEBA IHN1YiBnZW5lcmF0ZUJ1aWxkU3lzdGVtRnJvbUNNYWtlUHJvamVjdAogICAgICMgRG9uJ3Qgd2Fy biB2YXJpYWJsZXMgd2hpY2ggYXJlbid0IHVzZWQgYnkgY21ha2UgcG9ydHMuCiAgICAgcHVzaCBA YXJncywgIi0tbm8td2Fybi11bnVzZWQtY2xpIjsKICAgICBwdXNoIEBhcmdzLCBAY21ha2VBcmdz IGlmIEBjbWFrZUFyZ3M7Ci0gICAgcHVzaCBAYXJncywgJGFkZGl0aW9uYWxDTWFrZUFyZ3MgaWYg JGFkZGl0aW9uYWxDTWFrZUFyZ3M7CiAKICAgICBteSAkY21ha2VTb3VyY2VEaXIgPSBpc0N5Z3dp bigpID8gd2luZG93c1NvdXJjZURpcigpIDogc291cmNlRGlyKCk7CiAgICAgcHVzaCBAYXJncywg JyInIC4gJGNtYWtlU291cmNlRGlyIC4gJyInOwo=