153826 2016-02-03 02:13:52 -0800 [GStreamer] Performance problems with bigger video resolution in the webrtc media player 2016-08-12 03:40:20 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 153541 1 alex webkit-unassigned adam.bergkvist commit-queue mrobinson pnormand oldest_to_newest 1161619 0 alex 2016-02-03 02:13:52 -0800 We have a performance issue when the video resolution is bigger, there is a FIXME in the implementation file about this: MediaPlayerPrivateGstreamerOwr.cpp (InternalLoad): ... // FIXME: Remove hardcoded video dimensions when the rendering performance ... g_object_set(m_videoRenderer.get(), "width", 640, "height", 480, nullptr); ... 1219286 1 285822 pnormand 2016-08-11 02:19:15 -0700 Created attachment 285822 patch 1219289 2 commit-queue 2016-08-11 02:20:20 -0700 Attachment 285822 did not pass style-queue: ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:84: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1219290 3 285823 pnormand 2016-08-11 02:22:39 -0700 Created attachment 285823 patch 1219292 4 285823 alex 2016-08-11 02:32:21 -0700 Comment on attachment 285823 patch LGTM 1219574 5 pnormand 2016-08-12 03:40:20 -0700 Committed r204410: <http://trac.webkit.org/changeset/204410> 285822 2016-08-11 02:19:15 -0700 2016-08-11 02:22:39 -0700 patch patch.patch text/plain 4009 pnormand RnJvbSBiN2FhMGY0YmEyN2RlYWNiYzRiZjZjODU1MzFkOWQxY2IwODdiNmI4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUaHUsIDExIEF1ZyAyMDE2IDExOjE3OjEwICswMjAwClN1YmplY3Q6IFtQQVRDSF0g cGF0Y2gKCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICB8IDE0ICsrKysrKysrKysrKysrCiAuLi4vZ3JhcGhpY3MvZ3N0cmVhbWVy L01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuaCAgIHwgIDIgKy0KIC4uLi9ncmFwaGlj cy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyT3dyLmNwcCAgfCAxMyArKysr KysrKystLS0tCiAuLi4vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJl YW1lck93ci5oICAgIHwgIDIgKysKIDQgZmlsZXMgY2hhbmdlZCwgMjYgaW5zZXJ0aW9ucygrKSwg NSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjQ0NDc1Zi4uNzM2ZWNiYyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE3IEBACisyMDE2LTA4LTExICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1h bmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVyXSBQZXJmb3JtYW5jZSBwcm9ibGVt cyB3aXRoIGJpZ2dlciB2aWRlbyByZXNvbHV0aW9uIGluIHRoZSB3ZWJydGMgbWVkaWEgcGxheWVy CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTM4MjYK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBLZWVwIHRo ZSBPcGVuV2ViUlRDIHZpZGVvIHJlbmRlcmVyIHNpemUgc3luY2hyb25pemVkIHdpdGggdGhlIE1l ZGlhIGVsZW1lbnQgc2l6ZS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1l ci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmg6CisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lck93ci5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJPd3I6OnNldFNpemUp OgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZh dGVHU3RyZWFtZXJPd3IuaDoKKwogMjAxNi0wOC0xMCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jh cm9AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFNob3VsZCBiZSBhYmxlIHRv IEVkaXQgTm9kZSBBdHRyaWJ1dGVzIGFuZCBTdHlsZXMgZm9yIG5vbi1Vc2VyQWdlbnQgU2hhZG93 IERPTSBub2RlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Z3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuaCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFt ZXJCYXNlLmgKaW5kZXggYTJiNDAyZS4uMTczOGVmMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1l ckJhc2UuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIv TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5oCkBAIC04MSw3ICs4MSw3IEBAIHB1Ymxp YzoKICAgICBNZWRpYVBsYXllcjo6UmVhZHlTdGF0ZSByZWFkeVN0YXRlKCkgY29uc3Qgb3ZlcnJp ZGU7CiAKICAgICB2b2lkIHNldFZpc2libGUoYm9vbCkgb3ZlcnJpZGUgeyB9Ci0gICAgdm9pZCBz ZXRTaXplKGNvbnN0IEludFNpemUmKSBvdmVycmlkZTsKKyAgICB2aXJ0dWFsIHZvaWQgc2V0U2l6 ZShjb25zdCBJbnRTaXplJikgb3ZlcnJpZGU7CiAgICAgdm9pZCBzaXplQ2hhbmdlZCgpOwogCiAg ICAgdm9pZCBwYWludChHcmFwaGljc0NvbnRleHQmLCBjb25zdCBGbG9hdFJlY3QmKSBvdmVycmlk ZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1l ci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJPd3IuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lck93ci5j cHAKaW5kZXggMDJjZDIwNS4uODdiMmM4YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lck93ci5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlh UGxheWVyUHJpdmF0ZUdTdHJlYW1lck93ci5jcHAKQEAgLTMzMywxMyArMzMzLDE4IEBAIEdzdEVs ZW1lbnQqIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lck93cjo6Y3JlYXRlVmlkZW9TaW5rKCkK ICAgICBHc3RFbGVtZW50KiBzaW5rID0gTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZTo6 Y3JlYXRlVmlkZW9TaW5rKCk7CiAgICAgbV92aWRlb1JlbmRlcmVyID0gYWRvcHRHUmVmKG93cl9n c3RfdmlkZW9fcmVuZGVyZXJfbmV3KHNpbmspKTsKIAotICAgIC8vIEZJWE1FOiBSZW1vdmUgaGFy ZGNvZGVkIHZpZGVvIGRpbWVuc2lvbnMgd2hlbiB0aGUgcmVuZGVyaW5nIHBlcmZvcm1hbmNlOgot ICAgIC8vIGh0dHBzOi8vd2Via2l0Lm9yZy9iLzE1MzgyNi4KLSAgICBnX29iamVjdF9zZXQobV92 aWRlb1JlbmRlcmVyLmdldCgpLCAid2lkdGgiLCA2NDAsICJoZWlnaHQiLCA0ODAsIG51bGxwdHIp OwotCiAgICAgcmV0dXJuIHNpbms7CiB9CiAKK3ZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVh bWVyT3dyOjpzZXRTaXplKGNvbnN0IEludFNpemUmIHNpemUpCit7CisgICAgaWYgKHNpemUgPT0g bV9zaXplKQorICAgICAgICByZXR1cm47CisKKyAgICBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFt ZXJCYXNlOjpzZXRTaXplKHNpemUpOworICAgIGdfb2JqZWN0X3NldChtX3ZpZGVvUmVuZGVyZXIu Z2V0KCksICJ3aWR0aCIsIHNpemUud2lkdGgoKSwgImhlaWdodCIsIHNpemUuaGVpZ2h0KCksIG51 bGxwdHIpOworfQorCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCiAKICNlbmRpZiAvLyBFTkFCTEUo VklERU8pICYmIEVOQUJMRShNRURJQV9TVFJFQU0pICYmIFVTRShHU1RSRUFNRVIpICYmIFVTRShP UEVOV0VCUlRDKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Z3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lck93ci5oIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1l ck93ci5oCmluZGV4IGZkZjU0ZDEuLjZjNTllMDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJP d3IuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVk aWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyT3dyLmgKQEAgLTQwLDYgKzQwLDggQEAgcHVibGljOgog CiAgICAgc3RhdGljIHZvaWQgcmVnaXN0ZXJNZWRpYUVuZ2luZShNZWRpYUVuZ2luZVJlZ2lzdHJh cik7CiAKKyAgICB2b2lkIHNldFNpemUoY29uc3QgSW50U2l6ZSYpIG92ZXJyaWRlOworCiBwcml2 YXRlOgogICAgIEdzdEVsZW1lbnQqIGNyZWF0ZVZpZGVvU2luaygpIG92ZXJyaWRlOwogICAgIEdz dEVsZW1lbnQqIGF1ZGlvU2luaygpIGNvbnN0IG92ZXJyaWRlIHsgcmV0dXJuIG1fYXVkaW9TaW5r LmdldCgpOyB9Ci0tIAoyLjguMQ== 285823 2016-08-11 02:22:39 -0700 2016-08-11 02:32:21 -0700 patch patch.patch text/plain 3193 pnormand RnJvbSA5MzIzZThlOWQxZGFiYWMzMDk4YTVkZmNhMmJmYmYyYTc1YzA5OGVlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUaHUsIDExIEF1ZyAyMDE2IDExOjE3OjEwICswMjAwClN1YmplY3Q6IFtQQVRDSF0g cGF0Y2gKCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgfCAxMyArKysrKysrKysrKysrCiAuLi4vZ3JhcGhpY3MvZ3N0cmVhbWVy L01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lck93ci5jcHAgICB8IDEzICsrKysrKysrKy0tLS0K IC4uLi9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyT3dyLmgg ICAgIHwgIDIgKysKIDMgZmlsZXMgY2hhbmdlZCwgMjQgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlv bnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cKaW5kZXggMjQ0NDc1Zi4uMzQ5Zjk0OSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE2IEBACisyMDE2LTA4LTExICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlh LmNvbT4KKworICAgICAgICBbR1N0cmVhbWVyXSBQZXJmb3JtYW5jZSBwcm9ibGVtcyB3aXRoIGJp Z2dlciB2aWRlbyByZXNvbHV0aW9uIGluIHRoZSB3ZWJydGMgbWVkaWEgcGxheWVyCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTM4MjYKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBLZWVwIHRoZSBPcGVuV2Vi UlRDIHZpZGVvIHJlbmRlcmVyIHNpemUgc3luY2hyb25pemVkIHdpdGggdGhlIE1lZGlhIGVsZW1l bnQgc2l6ZS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBs YXllclByaXZhdGVHU3RyZWFtZXJPd3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5 ZXJQcml2YXRlR1N0cmVhbWVyT3dyOjpzZXRTaXplKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFw aGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyT3dyLmg6CisKIDIwMTYt MDgtMTAgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBX ZWIgSW5zcGVjdG9yOiBTaG91bGQgYmUgYWJsZSB0byBFZGl0IE5vZGUgQXR0cmlidXRlcyBhbmQg U3R5bGVzIGZvciBub24tVXNlckFnZW50IFNoYWRvdyBET00gbm9kZXMKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZh dGVHU3RyZWFtZXJPd3IuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0 cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lck93ci5jcHAKaW5kZXggMDJjZDIwNS4u ODdiMmM4YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0 cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lck93ci5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJl YW1lck93ci5jcHAKQEAgLTMzMywxMyArMzMzLDE4IEBAIEdzdEVsZW1lbnQqIE1lZGlhUGxheWVy UHJpdmF0ZUdTdHJlYW1lck93cjo6Y3JlYXRlVmlkZW9TaW5rKCkKICAgICBHc3RFbGVtZW50KiBz aW5rID0gTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZTo6Y3JlYXRlVmlkZW9TaW5rKCk7 CiAgICAgbV92aWRlb1JlbmRlcmVyID0gYWRvcHRHUmVmKG93cl9nc3RfdmlkZW9fcmVuZGVyZXJf bmV3KHNpbmspKTsKIAotICAgIC8vIEZJWE1FOiBSZW1vdmUgaGFyZGNvZGVkIHZpZGVvIGRpbWVu c2lvbnMgd2hlbiB0aGUgcmVuZGVyaW5nIHBlcmZvcm1hbmNlOgotICAgIC8vIGh0dHBzOi8vd2Vi a2l0Lm9yZy9iLzE1MzgyNi4KLSAgICBnX29iamVjdF9zZXQobV92aWRlb1JlbmRlcmVyLmdldCgp LCAid2lkdGgiLCA2NDAsICJoZWlnaHQiLCA0ODAsIG51bGxwdHIpOwotCiAgICAgcmV0dXJuIHNp bms7CiB9CiAKK3ZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyT3dyOjpzZXRTaXplKGNv bnN0IEludFNpemUmIHNpemUpCit7CisgICAgaWYgKHNpemUgPT0gbV9zaXplKQorICAgICAgICBy ZXR1cm47CisKKyAgICBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlOjpzZXRTaXplKHNp emUpOworICAgIGdfb2JqZWN0X3NldChtX3ZpZGVvUmVuZGVyZXIuZ2V0KCksICJ3aWR0aCIsIHNp emUud2lkdGgoKSwgImhlaWdodCIsIHNpemUuaGVpZ2h0KCksIG51bGxwdHIpOworfQorCiB9IC8v IG5hbWVzcGFjZSBXZWJDb3JlCiAKICNlbmRpZiAvLyBFTkFCTEUoVklERU8pICYmIEVOQUJMRShN RURJQV9TVFJFQU0pICYmIFVTRShHU1RSRUFNRVIpICYmIFVTRShPUEVOV0VCUlRDKQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxh eWVyUHJpdmF0ZUdTdHJlYW1lck93ci5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lck93ci5oCmluZGV4IGZkZjU0 ZDEuLjZjNTllMDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJPd3IuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0 cmVhbWVyT3dyLmgKQEAgLTQwLDYgKzQwLDggQEAgcHVibGljOgogCiAgICAgc3RhdGljIHZvaWQg cmVnaXN0ZXJNZWRpYUVuZ2luZShNZWRpYUVuZ2luZVJlZ2lzdHJhcik7CiAKKyAgICB2b2lkIHNl dFNpemUoY29uc3QgSW50U2l6ZSYpIG92ZXJyaWRlOworCiBwcml2YXRlOgogICAgIEdzdEVsZW1l bnQqIGNyZWF0ZVZpZGVvU2luaygpIG92ZXJyaWRlOwogICAgIEdzdEVsZW1lbnQqIGF1ZGlvU2lu aygpIGNvbnN0IG92ZXJyaWRlIHsgcmV0dXJuIG1fYXVkaW9TaW5rLmdldCgpOyB9Ci0tIAoyLjgu MQ==