153824 2016-02-02 23:18:05 -0800 Indent inline box test fails due to assertion in VisibleSelection::selectionFromContentsOfNode() 2016-02-08 05:41:54 -0800 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aplazas webkit-unassigned bugs-noreply cgarcia commit-queue oldest_to_newest 1161577 0 aplazas 2016-02-02 23:18:05 -0800 The editing/execCommand/indent-inline-box-crash.html test is crashing due to an assert in the GTK+ debug bot. It seems to be caused because we are not checking if the node we are trying to get a position from can offer one. STDERR: ASSERTION FAILED: !editingIgnoresContent(node) STDERR: ../../Source/WebCore/editing/VisibleSelection.cpp(98) : static WebCore::VisibleSelection WebCore::VisibleSelection::selectionFromContentsOfNode(WebCore::Node*) STDERR: 1 0x7f46bafbe161 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(WTFCrash+0x1e) [0x7f46bafbe161] STDERR: 2 0x7f46c1d64567 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::VisibleSelection::selectionFromContentsOfNode(WebCore::Node*)+0x45) [0x7f46c1d64567] STDERR: 3 0x7f46c1d7f2df /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(+0x5ad82df) [0x7f46c1d7f2df] STDERR: 4 0x7f46c1d7f9e4 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(+0x5ad89e4) [0x7f46c1d7f9e4] STDERR: 5 0x7f46c1d80642 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::createMarkup(WebCore::Range const&, WTF::Vector<WebCore::Node*, 0ul, WTF::CrashOnOverflow, 16ul>*, WebCore::EAnnotateForInterchange, bool, WebCore::EAbsoluteURLs)+0x5d) [0x7f46c1d80642] STDERR: 6 0x7f46c1468fff /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebKit::WebEditorClient::updateGlobalSelection(WebCore::Frame*)+0x197) [0x7f46c1468fff] STDERR: 7 0x7f46c12af3af /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebKit::WebEditorClient::respondToChangedSelection(WebCore::Frame*)+0xd7) [0x7f46c12af3af] STDERR: 8 0x7f46c1d00d21 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::Editor::respondToChangedSelection(WebCore::VisibleSelection const&, unsigned int)+0x51) [0x7f46c1d00d21] STDERR: 9 0x7f46c1d1184e /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::FrameSelection::setSelectionWithoutUpdatingAppearance(WebCore::VisibleSelection const&, unsigned int, WebCore::FrameSelection::CursorAlignOnScroll, WebCore::TextGranularity)+0x420) [0x7f46c1d1184e] STDERR: 10 0x7f46c1d11985 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::FrameSelection::setSelection(WebCore::VisibleSelection const&, unsigned int, WebCore::AXTextStateChangeIntent, WebCore::FrameSelection::CursorAlignOnScroll, WebCore::TextGranularity)+0x3f) [0x7f46c1d11985] STDERR: 11 0x7f46c1d1acd7 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::FrameSelection::selectAll()+0x3f7) [0x7f46c1d1acd7] STDERR: 12 0x7f46c1d0a0ca /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(+0x5a630ca) [0x7f46c1d0a0ca] STDERR: 13 0x7f46c1d0c066 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::Editor::Command::execute(WTF::String const&, WebCore::Event*) const+0xde) [0x7f46c1d0c066] STDERR: 14 0x7f46c1b7f626 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::Document::execCommand(WTF::String const&, bool, WTF::String const&)+0x56) [0x7f46c1b7f626] STDERR: 15 0x7f46c2c94347 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::jsDocumentPrototypeFunctionExecCommand(JSC::ExecState*)+0x29f) [0x7f46c2c94347] STDERR: 16 0x7f4668dfe0c8 [0x7f4668dfe0c8] STDERR: LEAK: 1 WebProcessPool STDERR: LEAK: 1 WebPageProxy 1161608 1 270565 aplazas 2016-02-03 00:59:41 -0800 Created attachment 270565 Check if the node can offer a position before trying to get one from it. 1161611 2 cgarcia 2016-02-03 01:11:22 -0800 This doesn't look specific to GTK+, patch changes only cross platform code. 1162431 3 270565 mcatanzaro 2016-02-05 10:36:27 -0800 Comment on attachment 270565 Check if the node can offer a position before trying to get one from it. View in context: https://bugs.webkit.org/attachment.cgi?id=270565&action=review > Source/WebCore/ChangeLog:3 > + [GTK] Indent inline box test fails due to assertion in VisibleSelection::selectionFromContentsOfNode() So, please remove the [GTK] prefix from the changelog 1162841 4 270848 aplazas 2016-02-08 00:43:03 -0800 Created attachment 270848 Check if the node can offer a position before trying to get one from it. 1162856 5 270848 mcatanzaro 2016-02-08 04:55:42 -0800 Comment on attachment 270848 Check if the node can offer a position before trying to get one from it. The change is small, the current code is obviously wrong, and no other reviewer has objected for several days, so r=me. 1162864 6 270848 commit-queue 2016-02-08 05:41:51 -0800 Comment on attachment 270848 Check if the node can offer a position before trying to get one from it. Clearing flags on attachment: 270848 Committed r196249: <http://trac.webkit.org/changeset/196249> 1162865 7 commit-queue 2016-02-08 05:41:54 -0800 All reviewed patches have been landed. Closing bug. 270565 2016-02-03 00:59:41 -0800 2016-02-08 00:43:03 -0800 Check if the node can offer a position before trying to get one from it. patch text/plain 1711 aplazas ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4ODEyNWFmLi42ODNjMDY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTYtMDItMDMgIEFkcmllbiBQbGF6YXMgIDxhcGxhemFzQGlnYWxpYS5jb20+CisKKyAg ICAgICAgW0dUS10gSW5kZW50IGlubGluZSBib3ggdGVzdCBmYWlscyBkdWUgdG8gYXNzZXJ0aW9u IGluIFZpc2libGVTZWxlY3Rpb246OnNlbGVjdGlvbkZyb21Db250ZW50c09mTm9kZSgpCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTM4MjQKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGVkaXRpbmcvbWFy a3VwLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmhpZ2hlc3RBbmNlc3RvclRvV3JhcE1hcmt1cCk6 CisKIDIwMTYtMDItMDIgIEppbnlvdW5nIEh1ciAgPGh1ci5pbXNAbmF2ZXJjb3JwLmNvbT4KIAog ICAgICAgICBXRUJHTF9kZWJ1Z19zaGFkZXJzIHNob3VsZCBiZSBkaXNhYmxlZCBmb3IgT3BlbkdM RVMgYmFja2VuZCBhbHNvCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL21hcmt1 cC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL21hcmt1cC5jcHAKaW5kZXggMzAyYjQ0Yy4u NDE3N2EyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9tYXJrdXAuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvbWFya3VwLmNwcApAQCAtNTM4LDcgKzUzOCw3IEBA IHN0YXRpYyBOb2RlKiBoaWdoZXN0QW5jZXN0b3JUb1dyYXBNYXJrdXAoY29uc3QgUmFuZ2UqIHJh bmdlLCBFQW5ub3RhdGVGb3JJbnRlcmNoCiAgICAgICAgIHNwZWNpYWxDb21tb25BbmNlc3RvciA9 IGFuY2VzdG9yVG9SZXRhaW5TdHJ1Y3R1cmVBbmRBcHBlYXJhbmNlKGNvbW1vbkFuY2VzdG9yKTsK IAogICAgICAgICBpZiAoTm9kZSogcGFyZW50TGlzdE5vZGUgPSBlbmNsb3NpbmdOb2RlT2ZUeXBl KGZpcnN0UG9zaXRpb25Jbk9yQmVmb3JlTm9kZShyYW5nZS0+Zmlyc3ROb2RlKCkpLCBpc0xpc3RJ dGVtKSkgewotICAgICAgICAgICAgaWYgKFdlYkNvcmU6OmFyZVJhbmdlc0VxdWFsKFZpc2libGVT ZWxlY3Rpb246OnNlbGVjdGlvbkZyb21Db250ZW50c09mTm9kZShwYXJlbnRMaXN0Tm9kZSkudG9O b3JtYWxpemVkUmFuZ2UoKS5nZXQoKSwgcmFuZ2UpKSB7CisgICAgICAgICAgICBpZiAoIWVkaXRp bmdJZ25vcmVzQ29udGVudChwYXJlbnRMaXN0Tm9kZSkgJiYgV2ViQ29yZTo6YXJlUmFuZ2VzRXF1 YWwoVmlzaWJsZVNlbGVjdGlvbjo6c2VsZWN0aW9uRnJvbUNvbnRlbnRzT2ZOb2RlKHBhcmVudExp c3ROb2RlKS50b05vcm1hbGl6ZWRSYW5nZSgpLmdldCgpLCByYW5nZSkpIHsKICAgICAgICAgICAg ICAgICBzcGVjaWFsQ29tbW9uQW5jZXN0b3IgPSBwYXJlbnRMaXN0Tm9kZS0+cGFyZW50Tm9kZSgp OwogICAgICAgICAgICAgICAgIHdoaWxlIChzcGVjaWFsQ29tbW9uQW5jZXN0b3IgJiYgIWlzTGlz dEVsZW1lbnQoc3BlY2lhbENvbW1vbkFuY2VzdG9yKSkKICAgICAgICAgICAgICAgICAgICAgc3Bl Y2lhbENvbW1vbkFuY2VzdG9yID0gc3BlY2lhbENvbW1vbkFuY2VzdG9yLT5wYXJlbnROb2RlKCk7 Cg== 270848 2016-02-08 00:43:03 -0800 2016-02-08 05:41:51 -0800 Check if the node can offer a position before trying to get one from it. patch text/plain 1705 aplazas ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4ODEyNWFmLi42ODNjMDY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTYtMDItMDMgIEFkcmllbiBQbGF6YXMgIDxhcGxhemFzQGlnYWxpYS5jb20+CisKKyAg ICAgICAgSW5kZW50IGlubGluZSBib3ggdGVzdCBmYWlscyBkdWUgdG8gYXNzZXJ0aW9uIGluIFZp c2libGVTZWxlY3Rpb246OnNlbGVjdGlvbkZyb21Db250ZW50c09mTm9kZSgpCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTM4MjQKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGVkaXRpbmcvbWFya3VwLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OmhpZ2hlc3RBbmNlc3RvclRvV3JhcE1hcmt1cCk6CisKIDIw MTYtMDItMDIgIEppbnlvdW5nIEh1ciAgPGh1ci5pbXNAbmF2ZXJjb3JwLmNvbT4KIAogICAgICAg ICBXRUJHTF9kZWJ1Z19zaGFkZXJzIHNob3VsZCBiZSBkaXNhYmxlZCBmb3IgT3BlbkdMRVMgYmFj a2VuZCBhbHNvCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL21hcmt1cC5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL21hcmt1cC5jcHAKaW5kZXggMzAyYjQ0Yy4uNDE3N2Ey ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9tYXJrdXAuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2VkaXRpbmcvbWFya3VwLmNwcApAQCAtNTM4LDcgKzUzOCw3IEBAIHN0YXRp YyBOb2RlKiBoaWdoZXN0QW5jZXN0b3JUb1dyYXBNYXJrdXAoY29uc3QgUmFuZ2UqIHJhbmdlLCBF QW5ub3RhdGVGb3JJbnRlcmNoCiAgICAgICAgIHNwZWNpYWxDb21tb25BbmNlc3RvciA9IGFuY2Vz dG9yVG9SZXRhaW5TdHJ1Y3R1cmVBbmRBcHBlYXJhbmNlKGNvbW1vbkFuY2VzdG9yKTsKIAogICAg ICAgICBpZiAoTm9kZSogcGFyZW50TGlzdE5vZGUgPSBlbmNsb3NpbmdOb2RlT2ZUeXBlKGZpcnN0 UG9zaXRpb25Jbk9yQmVmb3JlTm9kZShyYW5nZS0+Zmlyc3ROb2RlKCkpLCBpc0xpc3RJdGVtKSkg ewotICAgICAgICAgICAgaWYgKFdlYkNvcmU6OmFyZVJhbmdlc0VxdWFsKFZpc2libGVTZWxlY3Rp b246OnNlbGVjdGlvbkZyb21Db250ZW50c09mTm9kZShwYXJlbnRMaXN0Tm9kZSkudG9Ob3JtYWxp emVkUmFuZ2UoKS5nZXQoKSwgcmFuZ2UpKSB7CisgICAgICAgICAgICBpZiAoIWVkaXRpbmdJZ25v cmVzQ29udGVudChwYXJlbnRMaXN0Tm9kZSkgJiYgV2ViQ29yZTo6YXJlUmFuZ2VzRXF1YWwoVmlz aWJsZVNlbGVjdGlvbjo6c2VsZWN0aW9uRnJvbUNvbnRlbnRzT2ZOb2RlKHBhcmVudExpc3ROb2Rl KS50b05vcm1hbGl6ZWRSYW5nZSgpLmdldCgpLCByYW5nZSkpIHsKICAgICAgICAgICAgICAgICBz cGVjaWFsQ29tbW9uQW5jZXN0b3IgPSBwYXJlbnRMaXN0Tm9kZS0+cGFyZW50Tm9kZSgpOwogICAg ICAgICAgICAgICAgIHdoaWxlIChzcGVjaWFsQ29tbW9uQW5jZXN0b3IgJiYgIWlzTGlzdEVsZW1l bnQoc3BlY2lhbENvbW1vbkFuY2VzdG9yKSkKICAgICAgICAgICAgICAgICAgICAgc3BlY2lhbENv bW1vbkFuY2VzdG9yID0gc3BlY2lhbENvbW1vbkFuY2VzdG9yLT5wYXJlbnROb2RlKCk7Cg==