153823 2016-02-02 22:39:32 -0800 [CoordinatedGraphics] CompositingCoordinator destructor is scheduling layer flushes 2016-02-03 00:42:02 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan cmarcelo commit-queue kondapallykalyan luiz noam oldest_to_newest 1161566 0 zan 2016-02-02 22:39:32 -0800 [CoordinatedGraphics] CompositingCoordinator destructor is scheduling layer flushes 1161590 1 270559 zan 2016-02-03 00:03:24 -0800 Created attachment 270559 Patch 1161592 2 270559 cgarcia 2016-02-03 00:23:15 -0800 Comment on attachment 270559 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270559&action=review > Source/WebCore/platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:64 > + TemporaryChange<bool> destructing(m_isDestructing, true); Do we really need to make this temporal change? What's the point of setting back its original value if this is the destructor? 1161599 3 270559 zan 2016-02-03 00:36:07 -0800 Comment on attachment 270559 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270559&action=review >> Source/WebCore/platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:64 >> + TemporaryChange<bool> destructing(m_isDestructing, true); > > Do we really need to make this temporal change? What's the point of setting back its original value if this is the destructor? Heh, noted. 1161600 4 zan 2016-02-03 00:42:02 -0800 Committed r196056: <http://trac.webkit.org/changeset/196056> 270559 2016-02-03 00:03:24 -0800 2016-02-03 00:23:15 -0800 Patch bug-153823-20160203000259.patch text/plain 4760 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTk2MDQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTg4ZmEwODkzYWM2ODAx Yjg5M2U3NjE0YjlkZTE2YWM1OTAzZDljOS4uOTk4Nzc3NDM2Y2JjYTNlZWI3YTBmNTYwMzI0NTQ0 YzNhYzM4MDY4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMxIEBACisyMDE2LTAyLTAyICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbQ29vcmRpbmF0ZWRH cmFwaGljc10gQ29tcG9zaXRpbmdDb29yZGluYXRvciBkZXN0cnVjdG9yIGlzIHNjaGVkdWxpbmcg bGF5ZXIgZmx1c2hlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTUzODIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgUHVyZ2luZyB0aGUgYmFja2luZyBzdG9yZXMgZHVyaW5nIHRoZSBDb21wb3NpdGluZ0Nv b3JkaW5hdG9yIGRlc3RydWN0b3IKKyAgICAgICAgaXMgYWxzbyBzY2hlZHVsaW5nIGxheWVyIGZs dXNoZXMgaW4gdGhlIG9iamVjdCdzIGNsaWVudCwgd2hpY2ggaXMgYW4gb2JqZWN0CisgICAgICAg IG9mIHRoZSBMYXllclRyZWVIb3N0LWRlcml2aW5nIGNsYXNzIHRoYXQgb3ducyB0aGUgQ29tcG9z aXRpbmdDb29yZGluYXRvcgorICAgICAgICBvYmplY3QgaW4gcXVlc3Rpb24gYW5kIGlzIGFsc28g YmVpbmcgZGVzdHJveWVkLgorCisgICAgICAgIEluIGNhc2Ugb2YgVGhyZWFkZWRDb29yZGluYXRl ZExheWVyVHJlZUhvc3QsIHRoaXMgc2NoZWR1bGluZyBjYW4gYWNjZXNzCisgICAgICAgIHRoZSBS dW5Mb29wOjpUaW1lciBvYmplY3Qgd2hpY2ggaGFzIGFscmVhZHkgYmVlbiBkZXN0cm95ZWQsIGNh dXNpbmcgYQorICAgICAgICBjcmFzaC4gQW5vdGhlciBwcm9ibGVtIHdpdGggdGhpcyBpcyB0aGF0 IHdlJ3JlIGludm9raW5nIGEgdmlydHVhbCBmdW5jdGlvbgorICAgICAgICBvbiBhbiBvYmplY3Qg dGhhdCdzIGJlaW5nIGRlc3RydWN0ZWQsIHdoaWNoIHdvcmtzIHdlbGwgZW5vdWdoIGluIHRoaXMg Y2FzZQorICAgICAgICBidXQgc2hvdWxkIGJlIGRpc2NvdXJhZ2VkIGluIGdlbmVyYWwuCisKKyAg ICAgICAgSW4gb3JkZXIgdG8gYXZvaWQgdGhpcywgYWRkIHRoZSBtX2lzRGVzdHJ1Y3RpbmcgYm9v bGVhbiB0byB0aGUKKyAgICAgICAgQ29tcG9zaXRpbmdDb29yZGluYXRvciBjbGFzcywgZmxpcHMs IHRydWUgZHVyaW5nIHRoZSBkZXN0cnVjdGlvbiwgYW5kIGNoZWNrCisgICAgICAgIGZvciBpdHMg ZmFsc2VuZXNzIGJlZm9yZSBzY2hlZHVsaW5nIGEgbGF5ZXIgZmx1c2guCisKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvY29vcmRpbmF0ZWQvQ29tcG9zaXRpbmdDb29yZGluYXRv ci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDb21wb3NpdGluZ0Nvb3JkaW5hdG9yOjpDb21wb3Np dGluZ0Nvb3JkaW5hdG9yKToKKyAgICAgICAgKFdlYkNvcmU6OkNvbXBvc2l0aW5nQ29vcmRpbmF0 b3I6On5Db21wb3NpdGluZ0Nvb3JkaW5hdG9yKToKKyAgICAgICAgKFdlYkNvcmU6OkNvbXBvc2l0 aW5nQ29vcmRpbmF0b3I6Om5vdGlmeUZsdXNoUmVxdWlyZWQpOgorICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9Db21wb3NpdGluZ0Nvb3JkaW5hdG9yLmg6CisK IDIwMTYtMDItMDIgIEFha2FzaCBKYWluICA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgogCiAgICAg ICAgIFJlbW92ZSByZWZlcmVuY2VzIHRvIENhbGxGcmFtZUlubGluZXMuaApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVkL0NvbXBv c2l0aW5nQ29vcmRpbmF0b3IuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv dGV4bWFwL2Nvb3JkaW5hdGVkL0NvbXBvc2l0aW5nQ29vcmRpbmF0b3IuY3BwCmluZGV4IGM1M2Jj MDY4NzQwYjk1NWFmMjk3ZDQxMGQwZTVjYWFlOTYyZjkxY2UuLjFhZTdiOTA3NzYzOGFhYjY1MGQy ZDA3ZmQwMmQ1MjI0YzMxYTE4MGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9Db21wb3NpdGluZ0Nvb3JkaW5hdG9yLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvY29vcmRpbmF0ZWQv Q29tcG9zaXRpbmdDb29yZGluYXRvci5jcHAKQEAgLTQzLDE4ICs0MywxMSBAQAogCiBuYW1lc3Bh Y2UgV2ViQ29yZSB7CiAKLUNvbXBvc2l0aW5nQ29vcmRpbmF0b3I6On5Db21wb3NpdGluZ0Nvb3Jk aW5hdG9yKCkKLXsKLSAgICBwdXJnZUJhY2tpbmdTdG9yZXMoKTsKLQotICAgIGZvciAoYXV0byYg cmVnaXN0ZXJlZExheWVyIDogbV9yZWdpc3RlcmVkTGF5ZXJzLnZhbHVlcygpKQotICAgICAgICBy ZWdpc3RlcmVkTGF5ZXItPnNldENvb3JkaW5hdG9yKDApOwotfQotCiBDb21wb3NpdGluZ0Nvb3Jk aW5hdG9yOjpDb21wb3NpdGluZ0Nvb3JkaW5hdG9yKFBhZ2UqIHBhZ2UsIENvbXBvc2l0aW5nQ29v cmRpbmF0b3I6OkNsaWVudCogY2xpZW50KQogICAgIDogbV9wYWdlKHBhZ2UpCiAgICAgLCBtX2Ns aWVudChjbGllbnQpCi0gICAgLCBtX3Jvb3RDb21wb3NpdGluZ0xheWVyKDApCisgICAgLCBtX3Jv b3RDb21wb3NpdGluZ0xheWVyKG51bGxwdHIpCisgICAgLCBtX2lzRGVzdHJ1Y3RpbmcoZmFsc2Up CiAgICAgLCBtX2lzUHVyZ2luZyhmYWxzZSkKICAgICAsIG1faXNGbHVzaGluZ0xheWVyQ2hhbmdl cyhmYWxzZSkKICAgICAsIG1fc2hvdWxkU3luY0ZyYW1lKGZhbHNlKQpAQCAtNjYsNiArNTksMTYg QEAgQ29tcG9zaXRpbmdDb29yZGluYXRvcjo6Q29tcG9zaXRpbmdDb29yZGluYXRvcihQYWdlKiBw YWdlLCBDb21wb3NpdGluZ0Nvb3JkaW5hdG8KIHsKIH0KIAorQ29tcG9zaXRpbmdDb29yZGluYXRv cjo6fkNvbXBvc2l0aW5nQ29vcmRpbmF0b3IoKQoreworICAgIFRlbXBvcmFyeUNoYW5nZTxib29s PiBkZXN0cnVjdGluZyhtX2lzRGVzdHJ1Y3RpbmcsIHRydWUpOworCisgICAgcHVyZ2VCYWNraW5n U3RvcmVzKCk7CisKKyAgICBmb3IgKGF1dG8mIHJlZ2lzdGVyZWRMYXllciA6IG1fcmVnaXN0ZXJl ZExheWVycy52YWx1ZXMoKSkKKyAgICAgICAgcmVnaXN0ZXJlZExheWVyLT5zZXRDb29yZGluYXRv cihudWxscHRyKTsKK30KKwogdm9pZCBDb21wb3NpdGluZ0Nvb3JkaW5hdG9yOjpzZXRSb290Q29t cG9zaXRpbmdMYXllcihHcmFwaGljc0xheWVyKiBjb21wb3NpdGluZ0xheWVyLCBHcmFwaGljc0xh eWVyKiBvdmVybGF5TGF5ZXIpCiB7CiAgICAgaWYgKG1fcm9vdENvbXBvc2l0aW5nTGF5ZXIpCkBA IC0yNDAsMTEgKzI0MywxMCBAQCB2b2lkIENvbXBvc2l0aW5nQ29vcmRpbmF0b3I6Om5vdGlmeUFu aW1hdGlvblN0YXJ0ZWQoY29uc3QgR3JhcGhpY3NMYXllciosIGNvbnN0CiAKIHZvaWQgQ29tcG9z aXRpbmdDb29yZGluYXRvcjo6bm90aWZ5Rmx1c2hSZXF1aXJlZChjb25zdCBHcmFwaGljc0xheWVy KikKIHsKLSAgICBpZiAoIWlzRmx1c2hpbmdMYXllckNoYW5nZXMoKSkKKyAgICBpZiAoIW1faXNE ZXN0cnVjdGluZyAmJiAhaXNGbHVzaGluZ0xheWVyQ2hhbmdlcygpKQogICAgICAgICBtX2NsaWVu dC0+bm90aWZ5Rmx1c2hSZXF1aXJlZCgpOwogfQogCi0KIHZvaWQgQ29tcG9zaXRpbmdDb29yZGlu YXRvcjo6cGFpbnRDb250ZW50cyhjb25zdCBHcmFwaGljc0xheWVyKiBncmFwaGljc0xheWVyLCBH cmFwaGljc0NvbnRleHQmIGdyYXBoaWNzQ29udGV4dCwgR3JhcGhpY3NMYXllclBhaW50aW5nUGhh c2UsIGNvbnN0IEZsb2F0UmVjdCYgY2xpcFJlY3QpCiB7CiAgICAgbV9jbGllbnQtPnBhaW50TGF5 ZXJDb250ZW50cyhncmFwaGljc0xheWVyLCBncmFwaGljc0NvbnRleHQsIGVuY2xvc2luZ0ludFJl Y3QoY2xpcFJlY3QpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL3RleG1hcC9jb29yZGluYXRlZC9Db21wb3NpdGluZ0Nvb3JkaW5hdG9yLmggYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvY29vcmRpbmF0ZWQvQ29tcG9zaXRpbmdD b29yZGluYXRvci5oCmluZGV4IGZlMTBhM2VkZDg2OWY4ZTc0N2ZkMDU4MTMyNzlmMjRiMmExMmM4 MDUuLjc5ZTc2YmE0YThlNTI5OTk2YzdiZjg4YzJlOTcxOGI2YTMwYzIyM2IgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9Db21w b3NpdGluZ0Nvb3JkaW5hdG9yLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvdGV4bWFwL2Nvb3JkaW5hdGVkL0NvbXBvc2l0aW5nQ29vcmRpbmF0b3IuaApAQCAtMTM5LDYg KzEzOSw3IEBAIHByaXZhdGU6CiAgICAgVmVjdG9yPHN0ZDo6dW5pcXVlX3B0cjxVcGRhdGVBdGxh cz4+IG1fdXBkYXRlQXRsYXNlczsKIAogICAgIC8vIFdlIGRvbid0IHNlbmQgdGhlIG1lc3NhZ2Vz IHJlbGF0ZWQgdG8gcmVsZWFzaW5nIHJlc291cmNlcyB0byByZW5kZXJlciBkdXJpbmcgcHVyZ2lu ZywgYmVjYXVzZSByZW5kZXJlciBhbHJlYWR5IGhhZCByZW1vdmVkIGFsbCByZXNvdXJjZXMuCisg ICAgYm9vbCBtX2lzRGVzdHJ1Y3Rpbmc7CiAgICAgYm9vbCBtX2lzUHVyZ2luZzsKICAgICBib29s IG1faXNGbHVzaGluZ0xheWVyQ2hhbmdlczsKIAo=