153814 2016-02-02 19:44:31 -0800 [JSC] make Object.getOwnPropertyDescriptors() work with non-JSObject types 2016-02-03 08:49:47 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 caitp webkit-unassigned caitp commit-queue darin ggaren keith_miller kling ljharb mark.lam msaboff saam youennf ysuzuki oldest_to_newest 1161496 0 caitp 2016-02-02 19:44:31 -0800 [JSC] make Object.getOwnPropertyDescriptors() work with non-JSObject types 1161497 1 270541 caitp 2016-02-02 19:45:31 -0800 Created attachment 270541 Patch 1161499 2 270541 ysuzuki 2016-02-02 19:58:24 -0800 Comment on attachment 270541 Patch Nice, r=me 1161501 3 270541 caitp 2016-02-02 20:14:17 -0800 Comment on attachment 270541 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270541&action=review > Source/JavaScriptCore/tests/es6/Object_static_methods_Object.getOwnPropertyDescriptors.js:93 > + // delete global[symbol]; I think I have a fix for this crash (which is shipping in Safari atm :() --- I can include that in a separate bug though, I guess 1161505 4 270541 ysuzuki 2016-02-02 20:18:38 -0800 Comment on attachment 270541 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270541&action=review >> Source/JavaScriptCore/tests/es6/Object_static_methods_Object.getOwnPropertyDescriptors.js:93 >> + // delete global[symbol]; > > I think I have a fix for this crash (which is shipping in Safari atm :() --- I can include that in a separate bug though, I guess OK, could you open a bug for that? 1161506 5 270541 commit-queue 2016-02-02 20:22:45 -0800 Comment on attachment 270541 Patch Clearing flags on attachment: 270541 Committed r196042: <http://trac.webkit.org/changeset/196042> 1161507 6 commit-queue 2016-02-02 20:22:51 -0800 All reviewed patches have been landed. Closing bug. 270541 2016-02-02 19:45:31 -0800 2016-02-02 20:22:45 -0800 Patch bug-153814-20160202224507.patch text/plain 2840 caitp U3VidmVyc2lvbiBSZXZpc2lvbjogMTk2MDQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 NTdkNGIyZDFiOWJhNzVjNTk5MWUwNzAyMTgwYTI4NDBlMjI5OWQ1Li41M2I5MjhkMzcwNjA5ZWVm NDYxYzVmMzc2ZGI1NzQwZDEwMjcyZTUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxNyBAQAogMjAxNi0wMi0wMiAgQ2FpdGxpbiBQb3R0ZXIgIDxjYWl0cEBpZ2FsaWEuY29t PgogCisgICAgICAgIFtKU0NdIG1ha2UgT2JqZWN0LmdldE93blByb3BlcnR5RGVzY3JpcHRvcnMo KSB3b3JrIHdpdGggbm9uLUpTT2JqZWN0IHR5cGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTM4MTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIHJ1bnRpbWUvT2JqZWN0Q29uc3RydWN0b3IuY3BwOgor ICAgICAgICAoSlNDOjpvYmplY3RDb25zdHJ1Y3RvckdldE93blByb3BlcnR5RGVzY3JpcHRvcnMp OgorICAgICAgICAqIHRlc3RzL2VzNi9PYmplY3Rfc3RhdGljX21ldGhvZHNfT2JqZWN0LmdldE93 blByb3BlcnR5RGVzY3JpcHRvcnMuanM6CisgICAgICAgICh0ZXN0R2xvYmFsUHJveHkpOgorCisy MDE2LTAyLTAyICBDYWl0bGluIFBvdHRlciAgPGNhaXRwQGlnYWxpYS5jb20+CisKICAgICAgICAg W0pTQ10gSW1wbGVtZW50IE9iamVjdC5nZXRPd25Qcm9wZXJ0eURlc2NyaXB0b3JzKCkgcHJvcG9z YWwKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1Mzc5 OQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9PYmplY3RDb25z dHJ1Y3Rvci5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9PYmplY3RDb25zdHJ1 Y3Rvci5jcHAKaW5kZXggMzQ3YWUwODNkNmY2YWY5MzM0NGRlOThkMGY4NDkyM2U5ZTdmNzA4ZS4u Y2RiNzAwMjIzY2M3NDA0MDM1ZWYyM2Y2ZTBkMmM4ZjkwYTMyYzNhMyAxMDA2NDQKLS0tIGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT2JqZWN0Q29uc3RydWN0b3IuY3BwCisrKyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL09iamVjdENvbnN0cnVjdG9yLmNwcApAQCAtMjUx LDcgKzI1MSw3IEBAIEpTVmFsdWUgb2JqZWN0Q29uc3RydWN0b3JHZXRPd25Qcm9wZXJ0eURlc2Ny aXB0b3IoRXhlY1N0YXRlKiBleGVjLCBKU09iamVjdCogb2JqCiBKU1ZhbHVlIG9iamVjdENvbnN0 cnVjdG9yR2V0T3duUHJvcGVydHlEZXNjcmlwdG9ycyhFeGVjU3RhdGUqIGV4ZWMsIEpTT2JqZWN0 KiBvYmplY3QpCiB7CiAgICAgUHJvcGVydHlOYW1lQXJyYXkgcHJvcGVydGllcyhleGVjLCBQcm9w ZXJ0eU5hbWVNb2RlOjpTdHJpbmdzQW5kU3ltYm9scyk7Ci0gICAgb2JqZWN0LT5nZXRPd25Qcm9w ZXJ0eU5hbWVzKG9iamVjdCwgZXhlYywgcHJvcGVydGllcywgRW51bWVyYXRpb25Nb2RlKERvbnRF bnVtUHJvcGVydGllc01vZGU6OkluY2x1ZGUpKTsKKyAgICBvYmplY3QtPm1ldGhvZFRhYmxlKGV4 ZWMtPnZtKCkpLT5nZXRPd25Qcm9wZXJ0eU5hbWVzKG9iamVjdCwgZXhlYywgcHJvcGVydGllcywg RW51bWVyYXRpb25Nb2RlKERvbnRFbnVtUHJvcGVydGllc01vZGU6OkluY2x1ZGUpKTsKICAgICBp ZiAoZXhlYy0+aGFkRXhjZXB0aW9uKCkpCiAgICAgICAgIHJldHVybiBqc1VuZGVmaW5lZCgpOwog CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvZXM2L09iamVjdF9zdGF0 aWNfbWV0aG9kc19PYmplY3QuZ2V0T3duUHJvcGVydHlEZXNjcmlwdG9ycy5qcyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS90ZXN0cy9lczYvT2JqZWN0X3N0YXRpY19tZXRob2RzX09iamVjdC5nZXRP d25Qcm9wZXJ0eURlc2NyaXB0b3JzLmpzCmluZGV4IGQwYTJkOTM4NjdkNWMzYTNmZmY3OTU0NDQz MjdmM2FhNGY2MmUwMmQuLmUxNzZiMmVhNDU3ZDVkNDI0ODRjOGE1NDM3ZTEyYWZmNzY4YjhhNzIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9lczYvT2JqZWN0X3N0YXRp Y19tZXRob2RzX09iamVjdC5nZXRPd25Qcm9wZXJ0eURlc2NyaXB0b3JzLmpzCisrKyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9lczYvT2JqZWN0X3N0YXRpY19tZXRob2RzX09iamVjdC5n ZXRPd25Qcm9wZXJ0eURlc2NyaXB0b3JzLmpzCkBAIC04MSwzICs4MSwxNCBAQCBmdW5jdGlvbiBz aG91bGRCZURhdGFQcm9wZXJ0eShleHBlY3RlZCwgdmFsdWUsIG5hbWUpIHsKICAgICBzaG91bGRC ZShyZXN1bHQuYy53cml0YWJsZSwgZmFsc2UpOwogICAgIHNob3VsZEJlKHJlc3VsdC5jLnZhbHVl LCAnQycpOwogfSkoKTsKKworKGZ1bmN0aW9uIHRlc3RHbG9iYWxQcm94eShnbG9iYWwpIHsKKyAg ICB2YXIgc3ltYm9sID0gU3ltYm9sKCd0ZXN0Jyk7CisgICAgZ2xvYmFsW3N5bWJvbF0gPSAnU3lt Ym9sKHRlc3QpJzsKKworICAgIHZhciByZXN1bHQgPSBPYmplY3QuZ2V0T3duUHJvcGVydHlEZXNj cmlwdG9ycyhnbG9iYWwpOworCisgICAgc2hvdWxkQmVEYXRhUHJvcGVydHkocmVzdWx0W3N5bWJv bF0sICdTeW1ib2wodGVzdCknLCAnZ2xvYmFsW1N5bWJvbCh0ZXN0KV0nKTsKKyAgICAvLyBGSVhN RTogQ2FuJ3QgZGVsZXRlIFN5bWJvbCBwcm9wZXJ0aWVzIGZyb20gYSBKU1N5bWJvbFRhYmxlT2Jq ZWN0LgorICAgIC8vIGRlbGV0ZSBnbG9iYWxbc3ltYm9sXTsKK30pKHRoaXMpOwo=