153813 2016-02-02 18:59:40 -0800 Accepted candidates should not be autocorrected 2016-02-03 19:36:59 -0800 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned bdakin enrica sam thorton oldest_to_newest 1161486 0 bdakin 2016-02-02 18:59:40 -0800 Accepted candidates can be autocorrected. That should not happen. rdar://problem/24066924 1161490 1 270540 bdakin 2016-02-02 19:10:29 -0800 Created attachment 270540 Patch 1161510 2 270540 darin 2016-02-02 20:31:56 -0800 Comment on attachment 270540 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270540&action=review Can we make a regression test for this? > Source/WebCore/editing/Editor.cpp:3575 > + RefPtr<Range> insertedCandidateRange = rangeExpandedAroundPositionByCharacters(selection.visibleStart(), candidateLength); If we are guaranteed this can’t be null, I’m surprised it’s a RefPtr, not a Ref. If not, then the next line could result in a crash, and so we should add a null check. 1161541 3 thorton 2016-02-02 21:44:40 -0800 (In reply to comment #2) > Comment on attachment 270540 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=270540&action=review > > Can we make a regression test for this? > > > Source/WebCore/editing/Editor.cpp:3575 > > + RefPtr<Range> insertedCandidateRange = rangeExpandedAroundPositionByCharacters(selection.visibleStart(), candidateLength); > > If we are guaranteed this can’t be null, I’m surprised it’s a RefPtr, not a > Ref. If not, then the next line could result in a crash, and so we should > add a null check. Pretty sure it's the latter. 1161789 4 bdakin 2016-02-03 14:41:40 -0800 (In reply to comment #2) > Comment on attachment 270540 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=270540&action=review > > Can we make a regression test for this? > I've been working at it today. I thought it would be possible, and it is in the sense that I can easily add something to Internals to exercise this code path. However, I am having a lot of trouble making a test that fails without my fix. After a lot of fiddling, I am starting to believe that the only way to tigger autocorrection in the layout tests is to insert the characters one at a time. So in the context of the test harness, inserting a candidate all at once never triggered the bug. I think this is the case, but I am still trying to confirm. > > Source/WebCore/editing/Editor.cpp:3575 > > + RefPtr<Range> insertedCandidateRange = rangeExpandedAroundPositionByCharacters(selection.visibleStart(), candidateLength); > > If we are guaranteed this can’t be null, I’m surprised it’s a RefPtr, not a > Ref. If not, then the next line could result in a crash, and so we should > add a null check. Indeed, I think a null check is in order. I seem to have a mental block regarding null-checking ranges. 1161814 5 bdakin 2016-02-03 16:04:08 -0800 http://trac.webkit.org/changeset/196090 After sorting through some major confusion, I finally made a test! None of the spelling-correction tests work at all in WK2, and that was the root of much confusion. But I was able to write a test for WK1 that does indeed fail without the fix. 1161870 6 bdakin 2016-02-03 19:36:59 -0800 I forgot to commit the test!! http://trac.webkit.org/changeset/196105 270540 2016-02-02 19:10:29 -0800 2016-02-02 20:31:56 -0800 Patch for-review.txt text/plain 7581 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5NjAzOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMzIEBACisyMDE2LTAyLTAyICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBBY2NlcHRlZCBjYW5kaWRhdGVzIHNo b3VsZCBub3QgYmUgYXV0b2NvcnJlY3RlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTUzODEzCisgICAgICAgIC1hbmQgY29ycmVzcG9uZGluZy0KKyAg ICAgICAgcmRhcjovL3Byb2JsZW0vMjQwNjY5MjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBOZXcgZG9jdW1lbnQgbWFya2VyIHRvIG1hcmsgaW5zZXJ0 ZWQgY2FuZGlkYXRlcy4gVGhpcyB3YXMgd2UgY2FuIHRyZWF0IAorICAgICAgICBpbnNlcnRlZCBj YW5kaWRhdGVzIGp1c3QgbGlrZSBhIFJlamVjdGVkQ29ycmVjdGlvbiBhbmQgd2Ugd29u4oCZdCBh Y2NpZGVudGFsbHkgCisgICAgICAgIGF1dG9jb3JyZWN0IHRoZW0gbGF0ZXIgb24uCisgICAgICAg ICogZG9tL0RvY3VtZW50TWFya2VyLmg6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudE1hcmtl cjo6QWxsTWFya2Vyczo6QWxsTWFya2Vycyk6CisgICAgICAgICogZWRpdGluZy9BbHRlcm5hdGl2 ZVRleHRDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFsdGVybmF0aXZlVGV4dENv bnRyb2xsZXI6OnByb2Nlc3NNYXJrZXJzT25UZXh0VG9CZVJlcGxhY2VkQnlSZXN1bHQpOgorCisg ICAgICAgIFdoZW4gaGFuZGxpbmcgYW4gYWNjZXB0YW50IGNhbmRpZGF0ZSwgc2V0IG1faXNIYW5k bGluZ0FjY2VwdGVkQ2FuZGlkYXRlIHRvCisgICAgICAgIHRydWUgd2hpbGUgdGhlIHRleHQgaXMg YmVpbmcgaW5zZXJ0ZWQsIGFuZCB0aGVuIG1hcmsgdGhlIHJhbmdlIGFzIGFuIGFjY2VwdGVkIAor ICAgICAgICBjYW5kaWRhdGUuCisgICAgICAgICogZWRpdGluZy9FZGl0b3IuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6RWRpdG9yOjpoYW5kbGVBY2NlcHRlZENhbmRpZGF0ZSk6CisgICAgICAgICog ZWRpdGluZy9FZGl0b3IuaDoKKyAgICAgICAgKFdlYkNvcmU6OkVkaXRvcjo6aXNIYW5kbGluZ0Fj Y2VwdGVkQ2FuZGlkYXRlKToKKworICAgICAgICBJZiBmcmFtZS5lZGl0b3IuIGlzSGFuZGxpbmdB Y2NlcHRlZENhbmRpZGF0ZSgpIHRoZW4gcmV0dXJuIGVhcmx5IGZyb20gCisgICAgICAgIG1hcmtN aXNzcGVsbGluZ3NBZnRlclR5cGluZy4KKyAgICAgICAgKiBlZGl0aW5nL1R5cGluZ0NvbW1hbmQu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6VHlwaW5nQ29tbWFuZDo6bWFya01pc3NwZWxsaW5nc0Fm dGVyVHlwaW5nKToKKwogMjAxNi0wMi0wMiAgSmlueW91bmcgSHVyICA8aHVyLmltc0BuYXZlcmNv cnAuY29tPgogCiAgICAgICAgIFdFQkdMX2RlYnVnX3NoYWRlcnMgc2hvdWxkIGJlIGRpc2FibGVk IGZvciBPcGVuR0xFUyBiYWNrZW5kIGFsc28KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1 bWVudE1hcmtlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudE1h cmtlci5oCShyZXZpc2lvbiAxOTU5NjcpCisrKyBTb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnRN YXJrZXIuaAkod29ya2luZyBjb3B5KQpAQCAtNzksNiArNzksOCBAQCBwdWJsaWM6CiAgICAgICAg IERpY3RhdGlvblBocmFzZVdpdGhBbHRlcm5hdGl2ZXMgPSAxIDw8IDExLAogICAgICAgICBEaWN0 YXRpb25SZXN1bHQgPSAxIDw8IDEyLAogI2VuZGlmCisgICAgICAgIC8vIFRoaXMgbWFya2VyIGlu ZGljYXRlcyB0aGF0IHRoZSB1c2VyIGhhcyBzZWxlY3RlZCBhIHRleHQgY2FuZGlkYXRlLgorICAg ICAgICBBY2NlcHRlZENhbmRpZGF0ZSA9IDEgPDwgMTMsCiAgICAgfTsKIAogICAgIGNsYXNzIE1h cmtlclR5cGVzIHsKQEAgLTEwMiwxMiArMTA0LDEyIEBAIHB1YmxpYzoKICAgICAgICAgQWxsTWFy a2VycygpCiAjaWYgIVBMQVRGT1JNKElPUykKICNpZiAhRU5BQkxFKFRFTEVQSE9ORV9OVU1CRVJf REVURUNUSU9OKQotICAgICAgICAgICAgOiBNYXJrZXJUeXBlcyhTcGVsbGluZyB8IEdyYW1tYXIg fCBUZXh0TWF0Y2ggfCBSZXBsYWNlbWVudCB8IENvcnJlY3Rpb25JbmRpY2F0b3IgfCBSZWplY3Rl ZENvcnJlY3Rpb24gfCBBdXRvY29ycmVjdGVkIHwgU3BlbGxDaGVja2luZ0V4ZW1wdGlvbiB8IERl bGV0ZWRBdXRvY29ycmVjdGlvbiB8IERpY3RhdGlvbkFsdGVybmF0aXZlcykKKyAgICAgICAgICAg IDogTWFya2VyVHlwZXMoU3BlbGxpbmcgfCBHcmFtbWFyIHwgVGV4dE1hdGNoIHwgUmVwbGFjZW1l bnQgfCBDb3JyZWN0aW9uSW5kaWNhdG9yIHwgUmVqZWN0ZWRDb3JyZWN0aW9uIHwgQXV0b2NvcnJl Y3RlZCB8IFNwZWxsQ2hlY2tpbmdFeGVtcHRpb24gfCBEZWxldGVkQXV0b2NvcnJlY3Rpb24gfCBE aWN0YXRpb25BbHRlcm5hdGl2ZXMgfCBBY2NlcHRlZENhbmRpZGF0ZSkKICNlbHNlCi0gICAgICAg ICAgICA6IE1hcmtlclR5cGVzKFNwZWxsaW5nIHwgR3JhbW1hciB8IFRleHRNYXRjaCB8IFJlcGxh Y2VtZW50IHwgQ29ycmVjdGlvbkluZGljYXRvciB8IFJlamVjdGVkQ29ycmVjdGlvbiB8IEF1dG9j b3JyZWN0ZWQgfCBTcGVsbENoZWNraW5nRXhlbXB0aW9uIHwgRGVsZXRlZEF1dG9jb3JyZWN0aW9u IHwgRGljdGF0aW9uQWx0ZXJuYXRpdmVzIHwgVGVsZXBob25lTnVtYmVyKQorICAgICAgICAgICAg OiBNYXJrZXJUeXBlcyhTcGVsbGluZyB8IEdyYW1tYXIgfCBUZXh0TWF0Y2ggfCBSZXBsYWNlbWVu dCB8IENvcnJlY3Rpb25JbmRpY2F0b3IgfCBSZWplY3RlZENvcnJlY3Rpb24gfCBBdXRvY29ycmVj dGVkIHwgU3BlbGxDaGVja2luZ0V4ZW1wdGlvbiB8IERlbGV0ZWRBdXRvY29ycmVjdGlvbiB8IERp Y3RhdGlvbkFsdGVybmF0aXZlcyB8IFRlbGVwaG9uZU51bWJlciB8IEFjY2VwdGVkQ2FuZGlkYXRl KQogI2VuZGlmIC8vICFFTkFCTEUoVEVMRVBIT05FX05VTUJFUl9ERVRFQ1RJT04pCiAjZWxzZQot ICAgICAgICAgICAgOiBNYXJrZXJUeXBlcyhTcGVsbGluZyB8IEdyYW1tYXIgfCBUZXh0TWF0Y2gg fCBSZXBsYWNlbWVudCB8IENvcnJlY3Rpb25JbmRpY2F0b3IgfCBSZWplY3RlZENvcnJlY3Rpb24g fCBBdXRvY29ycmVjdGVkIHwgU3BlbGxDaGVja2luZ0V4ZW1wdGlvbiB8IERlbGV0ZWRBdXRvY29y cmVjdGlvbiB8IERpY3RhdGlvbkFsdGVybmF0aXZlcyB8IFRlbGVwaG9uZU51bWJlciB8IERpY3Rh dGlvblBocmFzZVdpdGhBbHRlcm5hdGl2ZXMgfCBEaWN0YXRpb25SZXN1bHQpCisgICAgICAgICAg ICA6IE1hcmtlclR5cGVzKFNwZWxsaW5nIHwgR3JhbW1hciB8IFRleHRNYXRjaCB8IFJlcGxhY2Vt ZW50IHwgQ29ycmVjdGlvbkluZGljYXRvciB8IFJlamVjdGVkQ29ycmVjdGlvbiB8IEF1dG9jb3Jy ZWN0ZWQgfCBTcGVsbENoZWNraW5nRXhlbXB0aW9uIHwgRGVsZXRlZEF1dG9jb3JyZWN0aW9uIHwg RGljdGF0aW9uQWx0ZXJuYXRpdmVzIHwgVGVsZXBob25lTnVtYmVyIHwgRGljdGF0aW9uUGhyYXNl V2l0aEFsdGVybmF0aXZlcyB8IERpY3RhdGlvblJlc3VsdCB8IEFjY2VwdGVkQ2FuZGlkYXRlKQog I2VuZGlmIC8vICFQTEFURk9STShJT1MpCiAgICAgICAgIHsKICAgICAgICAgfQpJbmRleDogU291 cmNlL1dlYkNvcmUvZWRpdGluZy9BbHRlcm5hdGl2ZVRleHRDb250cm9sbGVyLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0FsdGVybmF0aXZlVGV4dENvbnRyb2xsZXIu Y3BwCShyZXZpc2lvbiAxOTU5NjcpCisrKyBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0FsdGVybmF0 aXZlVGV4dENvbnRyb2xsZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02MDAsNiArNjAwLDkgQEAg Ym9vbCBBbHRlcm5hdGl2ZVRleHRDb250cm9sbGVyOjpwcm9jZXNzTQogICAgIGlmIChtYXJrZXJD b250cm9sbGVyLmhhc01hcmtlcnMocmFuZ2VXaXRoQWx0ZXJuYXRpdmUsIERvY3VtZW50TWFya2Vy OjpSZWplY3RlZENvcnJlY3Rpb24pKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKKyAgICBpZiAo bWFya2VyQ29udHJvbGxlci5oYXNNYXJrZXJzKHJhbmdlV2l0aEFsdGVybmF0aXZlLCBEb2N1bWVu dE1hcmtlcjo6QWNjZXB0ZWRDYW5kaWRhdGUpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisKICAg ICBQb3NpdGlvbiBiZWdpbm5pbmdPZlJhbmdlID0gcmFuZ2VXaXRoQWx0ZXJuYXRpdmUtPnN0YXJ0 UG9zaXRpb24oKTsKICAgICBQb3NpdGlvbiBwcmVjZWRpbmdDaGFyYWN0ZXJQb3NpdGlvbiA9IGJl Z2lubmluZ09mUmFuZ2UucHJldmlvdXMoKTsKICAgICBSZWZQdHI8UmFuZ2U+IHByZWNlZGluZ0No YXJhY3RlclJhbmdlID0gUmFuZ2U6OmNyZWF0ZSgqbV9mcmFtZS5kb2N1bWVudCgpLCBwcmVjZWRp bmdDaGFyYWN0ZXJQb3NpdGlvbiwgYmVnaW5uaW5nT2ZSYW5nZSk7CkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9lZGl0aW5nL0VkaXRvci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZWRp dGluZy9FZGl0b3IuY3BwCShyZXZpc2lvbiAxOTU5NjcpCisrKyBTb3VyY2UvV2ViQ29yZS9lZGl0 aW5nL0VkaXRvci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM1NTcsNiArMzU1Nyw5IEBAIHZvaWQg RWRpdG9yOjpoYW5kbGVBY2NlcHRlZENhbmRpZGF0ZShUZXgKIHsKICAgICBjb25zdCBWaXNpYmxl U2VsZWN0aW9uJiBzZWxlY3Rpb24gPSBtX2ZyYW1lLnNlbGVjdGlvbigpLnNlbGVjdGlvbigpOwog ICAgIFJlZlB0cjxSYW5nZT4gY2FuZGlkYXRlUmFuZ2UgPSBjYW5kaWRhdGVSYW5nZUZvclNlbGVj dGlvbihtX2ZyYW1lKTsKKyAgICBpbnQgY2FuZGlkYXRlTGVuZ3RoID0gYWNjZXB0ZWRDYW5kaWRh dGUubGVuZ3RoOworCisgICAgbV9pc0hhbmRsaW5nQWNjZXB0ZWRDYW5kaWRhdGUgPSB0cnVlOwog CiAgICAgaWYgKGNhbmRpZGF0ZVdvdWxkUmVwbGFjZVRleHQoc2VsZWN0aW9uKSkKICAgICAgICAg bV9mcmFtZS5zZWxlY3Rpb24oKS5zZXRTZWxlY3RlZFJhbmdlKGNhbmRpZGF0ZVJhbmdlLmdldCgp LCBVUFNUUkVBTSwgdHJ1ZSk7CkBAIC0zNTY0LDggKzM1NjcsMTUgQEAgdm9pZCBFZGl0b3I6Omhh bmRsZUFjY2VwdGVkQ2FuZGlkYXRlKFRleAogICAgIGluc2VydFRleHQoYWNjZXB0ZWRDYW5kaWRh dGUucmVwbGFjZW1lbnQsIDApOwogCiAgICAgLy8gU29tZSBjYW5kaWRhdGVzIGNvbWUgd2l0aCBh IHNwYWNlIGJ1aWx0IGluLCBhbmQgd2UgZG8gbm90IG5lZWQgdG8gYWRkIGFub3RoZXIgc3BhY2Ug aW4gdGhhdCBjYXNlLgotICAgIGlmICghYWNjZXB0ZWRDYW5kaWRhdGUucmVwbGFjZW1lbnQuZW5k c1dpdGgoJyAnKSkKKyAgICBpZiAoIWFjY2VwdGVkQ2FuZGlkYXRlLnJlcGxhY2VtZW50LmVuZHNX aXRoKCcgJykpIHsKICAgICAgICAgaW5zZXJ0VGV4dChBU0NJSUxpdGVyYWwoIiAiKSwgMCk7Cisg ICAgICAgICsrY2FuZGlkYXRlTGVuZ3RoOworICAgIH0KKworICAgIFJlZlB0cjxSYW5nZT4gaW5z ZXJ0ZWRDYW5kaWRhdGVSYW5nZSA9IHJhbmdlRXhwYW5kZWRBcm91bmRQb3NpdGlvbkJ5Q2hhcmFj dGVycyhzZWxlY3Rpb24udmlzaWJsZVN0YXJ0KCksIGNhbmRpZGF0ZUxlbmd0aCk7CisgICAgaW5z ZXJ0ZWRDYW5kaWRhdGVSYW5nZS0+c3RhcnRDb250YWluZXIoKS5kb2N1bWVudCgpLm1hcmtlcnMo KS5hZGRNYXJrZXIoaW5zZXJ0ZWRDYW5kaWRhdGVSYW5nZS5nZXQoKSwgRG9jdW1lbnRNYXJrZXI6 OkFjY2VwdGVkQ2FuZGlkYXRlLCBhY2NlcHRlZENhbmRpZGF0ZS5yZXBsYWNlbWVudCk7CisKKyAg ICBtX2lzSGFuZGxpbmdBY2NlcHRlZENhbmRpZGF0ZSA9IGZhbHNlOwogfQogCiBib29sIEVkaXRv cjo6dW5pZmllZFRleHRDaGVja2VyRW5hYmxlZCgpIGNvbnN0CkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9lZGl0aW5nL0VkaXRvci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcv RWRpdG9yLmgJKHJldmlzaW9uIDE5NTk2NykKKysrIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRWRp dG9yLmgJKHdvcmtpbmcgY29weSkKQEAgLTQ1Nyw2ICs0NTcsNyBAQCBwdWJsaWM6CiAKICAgICBX RUJDT1JFX0VYUE9SVCBTdHJpbmcgc3RyaW5nRm9yQ2FuZGlkYXRlUmVxdWVzdCgpIGNvbnN0Owog ICAgIFdFQkNPUkVfRVhQT1JUIHZvaWQgaGFuZGxlQWNjZXB0ZWRDYW5kaWRhdGUoVGV4dENoZWNr aW5nUmVzdWx0KTsKKyAgICBib29sIGlzSGFuZGxpbmdBY2NlcHRlZENhbmRpZGF0ZSgpIGNvbnN0 IHsgcmV0dXJuIG1faXNIYW5kbGluZ0FjY2VwdGVkQ2FuZGlkYXRlOyB9CiAKIHByaXZhdGU6CiAg ICAgY2xhc3MgV2ViQ29udGVudFJlYWRlcjsKQEAgLTUxOSw2ICs1MjAsNyBAQCBwcml2YXRlOgog ICAgIFRpbWVyIG1fZWRpdG9yVUlVcGRhdGVUaW1lcjsKICAgICBib29sIG1fZWRpdG9yVUlVcGRh dGVUaW1lclNob3VsZENoZWNrU3BlbGxpbmdBbmRHcmFtbWFyOwogICAgIGJvb2wgbV9lZGl0b3JV SVVwZGF0ZVRpbWVyV2FzVHJpZ2dlcmVkQnlEaWN0YXRpb247CisgICAgYm9vbCBtX2lzSGFuZGxp bmdBY2NlcHRlZENhbmRpZGF0ZSB7IGZhbHNlIH07CiAKICNpZiBFTkFCTEUoVEVMRVBIT05FX05V TUJFUl9ERVRFQ1RJT04pICYmICFQTEFURk9STShJT1MpCiAgICAgYm9vbCBzaG91bGREZXRlY3RU ZWxlcGhvbmVOdW1iZXJzKCk7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1R5cGluZ0Nv bW1hbmQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvVHlwaW5nQ29t bWFuZC5jcHAJKHJldmlzaW9uIDE5NTk2NykKKysrIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvVHlw aW5nQ29tbWFuZC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMwMSw2ICszMDEsOCBAQCB2b2lkIFR5 cGluZ0NvbW1hbmQ6Om1hcmtNaXNzcGVsbGluZ3NBZnRlCiAgICAgICAgICYmICFmcmFtZS5lZGl0 b3IoKS5pc0F1dG9tYXRpY0Rhc2hTdWJzdGl0dXRpb25FbmFibGVkKCkKICAgICAgICAgJiYgIWZy YW1lLmVkaXRvcigpLmlzQXV0b21hdGljVGV4dFJlcGxhY2VtZW50RW5hYmxlZCgpKQogICAgICAg ICAgICAgcmV0dXJuOworICAgIGlmIChmcmFtZS5lZGl0b3IoKS5pc0hhbmRsaW5nQWNjZXB0ZWRD YW5kaWRhdGUoKSkKKyAgICAgICAgcmV0dXJuOwogI2Vsc2UKICAgICBpZiAoIWZyYW1lLmVkaXRv cigpLmlzQ29udGludW91c1NwZWxsQ2hlY2tpbmdFbmFibGVkKCkpCiAgICAgICAgIHJldHVybjsK