15381 2007-10-05 14:04:00 -0700 execCommand justify modifies the contentEditable node 2009-02-16 15:42:40 -0800 1 1 1 Unclassified WebKit HTML Editing 523.x (Safari 3) All OS X 10.4 RESOLVED FIXED http://www.nick-santos.com/tests/justify_command.html GoogleBug P2 Normal --- 1 nicksantos webkit-unassigned jparent justin.garcia ojan oldest_to_newest 57872 0 nicksantos 2007-10-05 14:04:00 -0700 Steps to reproduce: 1) Create a contentEditable field with some text, and no display: block elements. 2) In javascript, call document.execCommand("justifyRight", false) Expected Result: A block-level element should be created around the text with style='text-align: right'. IE creates a <p> element. Actual Result: The contentEditable element has style='text-align: right.' Notes: As a general principle, execCommand should *never* modify the attributes of a node with contentEditable on. There are all sorts of reasons why this is bad: it may change the layout of the field itself, it makes it more difficult to get the contents of the field, etc. See the demo at the URL. 109565 1 justin.garcia 2009-02-12 14:45:54 -0800 This shouldn't be too hard to fix, ApplyStyleCommand::moveParagraphContentsToNewBlockIfNecessary just needs to know about this situation. 109566 2 justin.garcia 2009-02-12 14:51:25 -0800 I'm testing a fix... 109568 3 27624 justin.garcia 2009-02-12 15:10:28 -0800 Created attachment 27624 patch 109694 4 27624 eric 2009-02-13 09:35:59 -0800 Comment on attachment 27624 patch looks great! r=me. 109898 5 justin.garcia 2009-02-16 15:42:40 -0800 http://trac.webkit.org/changeset/41026 27624 2009-02-12 15:10:28 -0800 2009-02-13 09:35:59 -0800 patch 15381.txt text/plain 6988 justin.garcia SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MDk0MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDktMDItMTIgIEp1c3RpbiBHYXJjaWEgIDxqdXN0aW4uZ2FyY2lh QGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUzODEKKyAgICAg ICAgZXhlY0NvbW1hbmQganVzdGlmeSBtb2RpZmllcyB0aGUgY29udGVudEVkaXRhYmxlIG5vZGUK KworICAgICAgICAqIGVkaXRpbmcvQ29tcG9zaXRlRWRpdENvbW1hbmQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6Q29tcG9zaXRlRWRpdENvbW1hbmQ6Om1vdmVQYXJhZ3JhcGhDb250ZW50c1RvTmV3 QmxvY2tJZk5lY2Vzc2FyeSk6IEF2b2lkIG1vZGlmeWluZyBub3QganVzdAorICAgICAgICB0aGUg Ym9keSBlbGVtZW50LCBidXQgYW55IHJvb3QgZWRpdGFibGUgZWxlbWVudC4KKwogMjAwOS0wMi0x MiAgRXJpYyBDYXJsc29uICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBTaW1vbiBGcmFzZXIuCkluZGV4OiBXZWJDb3JlL2VkaXRpbmcvQ29tcG9zaXRlRWRp dENvbW1hbmQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvZWRpdGluZy9Db21wb3NpdGVFZGl0 Q29tbWFuZC5jcHAJKHJldmlzaW9uIDQwODc5KQorKysgV2ViQ29yZS9lZGl0aW5nL0NvbXBvc2l0 ZUVkaXRDb21tYW5kLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjU1LDExICs2NTUsMTAgQEAKIAog ICAgIC8vIFBlcmZvcm0gc29tZSBjaGVja3MgdG8gc2VlIGlmIHdlIG5lZWQgdG8gcGVyZm9ybSB3 b3JrIGluIHRoaXMgZnVuY3Rpb24uCiAgICAgaWYgKGlzQmxvY2sodXBzdHJlYW1TdGFydC5ub2Rl KCkpKSB7Ci0gICAgICAgIC8vIElmIHRoZSBibG9jayBpcyB0aGUgYm9keSBlbGVtZW50LCBhbHdh eXMgbW92ZSBjb250ZW50IHRvIGEgbmV3IGJsb2NrLCBzbyB0aGF0Ci0gICAgICAgIC8vIHdlIGF2 b2lkIGFkZGluZyBzdHlsZXMgdG8gdGhlIGJvZHkgZWxlbWVudCwgc2luY2UgTWFpbCdzIE1ha2Ug UGxhaW4gVGV4dCBmZWF0dXJlCi0gICAgICAgIC8vIGNhbid0IGhhbmRsZSB0aG9zZS4KLSAgICAg ICAgaWYgKHVwc3RyZWFtU3RhcnQubm9kZSgpLT5oYXNUYWdOYW1lKGJvZHlUYWcpKSB7Ci0gICAg ICAgICAgICAvLyBJZiB0aGUgYmxvY2sgaXMgdGhlIGJvZHkgZWxlbWVudCBhbmQgdGhlcmUgaXMg bm90aGluZyBpbnNkZSBvZiBpdCwgY3JlYXRlIGEgbmV3CisgICAgICAgIC8vIElmIHRoZSBibG9j ayBpcyB0aGUgcm9vdCBlZGl0YWJsZSBlbGVtZW50LCBhbHdheXMgbW92ZSBjb250ZW50IHRvIGEg bmV3IGJsb2NrLAorICAgICAgICAvLyBzaW5jZSBpdCBpcyBpbGxlZ2FsIHRvIG1vZGlmeSBhdHRy aWJ1dGVzIG9uIHRoZSByb290IGVkaXRhYmxlIGVsZW1lbnQgZm9yIGVkaXRpbmcuCisgICAgICAg IGlmICh1cHN0cmVhbVN0YXJ0Lm5vZGUoKSA9PSBlZGl0YWJsZVJvb3RGb3JQb3NpdGlvbih1cHN0 cmVhbVN0YXJ0KSkgeworICAgICAgICAgICAgLy8gSWYgdGhlIGJsb2NrIGlzIHRoZSByb290IGVk aXRhYmxlIGVsZW1lbnQgYW5kIHRoZXJlIGlzIG5vdGhpbmcgaW5zZGUgb2YgaXQsIGNyZWF0ZSBh IG5ldwogICAgICAgICAgICAgLy8gYmxvY2sgYnV0IGRvbid0IHRyeSBhbmQgbW92ZSBjb250ZW50 IGludG8gaXQsIHNpbmNlIHRoZXJlJ3Mgbm90aGluZyB0byBtb3ZlLgogICAgICAgICAgICAgaWYg KHVwc3RyZWFtU3RhcnQgPT0gdXBzdHJlYW1FbmQpCiAgICAgICAgICAgICAgICAgcmV0dXJuIGlu c2VydE5ld0RlZmF1bHRQYXJhZ3JhcGhFbGVtZW50QXQodXBzdHJlYW1TdGFydCk7CkluZGV4OiBM YXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kLzUwNjIzNzYtZXhwZWN0ZWQudHh0Cj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIExheW91dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1hbmQvNTA2MjM3Ni1leHBlY3Rl ZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kLzUw NjIzNzYtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDMgQEAKK1RoaXMgdGVz dHMgZm9yIGEgYnVnIHdoZXJlIGNlbnRlcmluZyB0ZXh0IHdvdWxkIHByZXZlbnQgaXQgZnJvbSBi ZWluZyByaWdodCBvciBsZWZ0IGFsaWduZWQgYWdhaW4uIFRoZSBwYXJhZ3JhcGggc2hvdWxkIGJl IHJpZ2h0IGFsaWduZWQuCisKK1N1Y2Nlc3MKSW5kZXg6IExheW91dFRlc3RzL2VkaXRpbmcvZXhl Y0NvbW1hbmQvNTA2MjM3Ni5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2VkaXRpbmcv ZXhlY0NvbW1hbmQvNTA2MjM3Ni5odG1sCShyZXZpc2lvbiA0MDg3OSkKKysrIExheW91dFRlc3Rz L2VkaXRpbmcvZXhlY0NvbW1hbmQvNTA2MjM3Ni5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0xLDkg KzEsMjMgQEAKLTxwPlRoaXMgdGVzdHMgZm9yIGEgYnVnIHdoZXJlIGNlbnRlcmluZyB0ZXh0IHdv dWxkIHByZXZlbnQgaXQgZnJvbSBiZWluZyByaWdodCBvciBsZWZ0IGFsaWduZWQgYWdhaW4uICBU aGUgcGFyYWdyYXBoIGJlbG93IHNob3VsZCBiZSByaWdodCBhbGlnbmVkLjwvcD4KIDxkaXYgaWQ9 ImRpdiIgY29udGVudGVkaXRhYmxlPSJ0cnVlIj5mb288L2Rpdj4KIAogPHNjcmlwdD4KK2lmICh3 aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgd2luZG93LmxheW91dFRlc3RDb250cm9s bGVyLmR1bXBBc1RleHQoKTsKKyAgICAKIHZhciBkaXYgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJ ZCgiZGl2Iik7CiBkaXYuZm9jdXMoKTsKIGRvY3VtZW50LmV4ZWNDb21tYW5kKCJKdXN0aWZ5Q2Vu dGVyIik7CiBkb2N1bWVudC5leGVjQ29tbWFuZCgiSnVzdGlmeVJpZ2h0Iik7CisKK2V4cGVjdGVk ID0gJzxkaXYgc3R5bGU9InRleHQtYWxpZ246IHJpZ2h0OyI+Zm9vPC9kaXY+JzsKK2FjdHVhbCA9 IGRpdi5pbm5lckhUTUw7CisKK291dHB1dCA9ICJUaGlzIHRlc3RzIGZvciBhIGJ1ZyB3aGVyZSBj ZW50ZXJpbmcgdGV4dCB3b3VsZCBwcmV2ZW50IGl0IGZyb20gYmVpbmcgcmlnaHQgb3IgbGVmdCBh bGlnbmVkIGFnYWluLiAgVGhlIHBhcmFncmFwaCBzaG91bGQgYmUgcmlnaHQgYWxpZ25lZC5cblxu IgorCitpZiAoYWN0dWFsID09IGV4cGVjdGVkKQorICAgIG91dHB1dCArPSAiU3VjY2VzcyI7Citl bHNlCisgICAgb3V0cHV0ICs9ICJGYWlsdXJlLiAgRXhwZWN0ZWQ6ICIgKyBleHBlY3RlZCArICIs IGZvdW5kOiAiICsgYWN0dWFsOworICAgIAorZG9jdW1lbnQuYm9keS5pbm5lclRleHQgPSBvdXRw dXQ7CiA8L3NjcmlwdD4KSW5kZXg6IExheW91dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1hbmQvMTUz ODEtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2VkaXRpbmcvZXhlY0Nv bW1hbmQvMTUzODEtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZWRp dGluZy9leGVjQ29tbWFuZC8xNTM4MS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAg KzEsMyBAQAorVGhpcyB0ZXN0cyB0byBtYWtlIHN1cmUgdGhhdCBjZW50ZXJpbmcgY29udGVudCB3 aG9zZSBlbmNsb3NpbmcgYmxvY2sgaXMgdGhlIHJvb3QgZWRpdGFibGUgZWxlbWVudCBkb2Vzbid0 IG1vZGlmeSB0aGUgcm9vdCBlZGl0YWJsZSBlbGVtZW50LgorCitTdWNjZXNzCkluZGV4OiBMYXlv dXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kLzE1MzgxLmh0bWwKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC8xNTM4MS5odG1sCShyZXZpc2lvbiAwKQorKysg TGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC8xNTM4MS5odG1sCShyZXZpc2lvbiAwKQpA QCAtMCwwICsxLDI0IEBACis8ZGl2IGlkPSJ0ZXN0Ij48ZGl2IGlkPSJlZGl0IiBjb250ZW50RWRp dGFibGU9InRydWUiPmNlbnRlcmVkIHRleHQ8L2Rpdj48L2Rpdj4KKworPHNjcmlwdD4KK2lmICh3 aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgd2luZG93LmxheW91dFRlc3RDb250cm9s bGVyLmR1bXBBc1RleHQoKTsKKyAgICAKK3Rlc3QgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgi dGVzdCIpOworZWRpdCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJlZGl0Iik7CisKK3dpbmRv dy5nZXRTZWxlY3Rpb24oKS5zZXRQb3NpdGlvbihlZGl0LCAwKTsKK2RvY3VtZW50LmV4ZWNDb21t YW5kKCJKdXN0aWZ5Q2VudGVyIik7CisKK2V4cGVjdGVkID0gJzxkaXYgaWQ9ImVkaXQiIGNvbnRl bnRlZGl0YWJsZT0idHJ1ZSI+PGRpdiBzdHlsZT0idGV4dC1hbGlnbjogY2VudGVyOyI+Y2VudGVy ZWQgdGV4dDwvZGl2PjwvZGl2Pic7CithY3R1YWwgPSB0ZXN0LmlubmVySFRNTDsKKworb3V0cHV0 ID0gIlRoaXMgdGVzdHMgdG8gbWFrZSBzdXJlIHRoYXQgY2VudGVyaW5nIGNvbnRlbnQgd2hvc2Ug ZW5jbG9zaW5nIGJsb2NrIGlzIHRoZSByb290IGVkaXRhYmxlIGVsZW1lbnQgZG9lc24ndCBtb2Rp ZnkgdGhlIHJvb3QgZWRpdGFibGUgZWxlbWVudC5cblxuIgorCitpZiAoYWN0dWFsID09IGV4cGVj dGVkKQorICAgIG91dHB1dCArPSAiU3VjY2VzcyI7CitlbHNlCisgICAgb3V0cHV0ICs9ICJGYWls dXJlLiAgRXhwZWN0ZWQ6ICIgKyBleHBlY3RlZCArICIsIGZvdW5kOiAiICsgYWN0dWFsOworICAg IAorZG9jdW1lbnQuYm9keS5pbm5lclRleHQgPSBvdXRwdXQ7Cis8L3NjcmlwdD4KSW5kZXg6IExh eW91dFRlc3RzL3BsYXRmb3JtL21hYy9lZGl0aW5nL2V4ZWNDb21tYW5kLzUwNjIzNzYtZXhwZWN0 ZWQuY2hlY2tzdW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2VkaXRp bmcvZXhlY0NvbW1hbmQvNTA2MjM3Ni1leHBlY3RlZC5jaGVja3N1bQkocmV2aXNpb24gNDA4Nzkp CisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZWRpdGluZy9leGVjQ29tbWFuZC81MDYyMzc2 LWV4cGVjdGVkLmNoZWNrc3VtCSh3b3JraW5nIGNvcHkpCkBAIC0xICswLDAgQEAKLWE0MzhmMTZk MzRiNzE1MjY1ZTg3ZWI0ZjM1MTg5NDkyClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQpJbmRl eDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2VkaXRpbmcvZXhlY0NvbW1hbmQvNTA2MjM3Ni1l eHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2VkaXRp bmcvZXhlY0NvbW1hbmQvNTA2MjM3Ni1leHBlY3RlZC50eHQJKHJldmlzaW9uIDQwODc5KQorKysg TGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2VkaXRpbmcvZXhlY0NvbW1hbmQvNTA2MjM3Ni1leHBl Y3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTEsMTUgKzAsMCBAQAotbGF5ZXIgYXQgKDAsMCkg c2l6ZSA4MDB4NjAwCi0gIFJlbmRlclZpZXcgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCi1sYXllciBh dCAoMCwwKSBzaXplIDgwMHg2MDAKLSAgUmVuZGVyQmxvY2sge0hUTUx9IGF0ICgwLDApIHNpemUg ODAweDYwMAotICAgIFJlbmRlckJvZHkge0JPRFl9IGF0ICg4LDgpIHNpemUgNzg0eDU4NAotICAg ICAgUmVuZGVyQmxvY2sge1B9IGF0ICgwLDApIHNpemUgNzg0eDM2Ci0gICAgICAgIFJlbmRlclRl eHQgeyN0ZXh0fSBhdCAoMCwwKSBzaXplIDc4M3gzNgotICAgICAgICAgIHRleHQgcnVuIGF0ICgw LDApIHdpZHRoIDYwMjogIlRoaXMgdGVzdHMgZm9yIGEgYnVnIHdoZXJlIGNlbnRlcmluZyB0ZXh0 IHdvdWxkIHByZXZlbnQgaXQgZnJvbSBiZWluZyByaWdodCBvciBsZWZ0IGFsaWduZWQgYWdhaW4u ICIKLSAgICAgICAgICB0ZXh0IHJ1biBhdCAoNjAyLDApIHdpZHRoIDE4MTogIlRoZSBwYXJhZ3Jh cGggYmVsb3cgc2hvdWxkIgotICAgICAgICAgIHRleHQgcnVuIGF0ICgwLDE4KSB3aWR0aCAxMDI6 ICJiZSByaWdodCBhbGlnbmVkLiIKLSAgICAgIFJlbmRlckJsb2NrIHtESVZ9IGF0ICgwLDUyKSBz aXplIDc4NHgxOAotICAgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDc2MywwKSBzaXplIDIx eDE4Ci0gICAgICAgICAgdGV4dCBydW4gYXQgKDc2MywwKSB3aWR0aCAyMTogImZvbyIKLXNlbGVj dGlvbiBzdGFydDogcG9zaXRpb24gMCBvZiBjaGlsZCAwIHsjdGV4dH0gb2YgY2hpbGQgMiB7RElW fSBvZiBjaGlsZCAwIHtCT0RZfSBvZiBjaGlsZCAwIHtIVE1MfSBvZiBkb2N1bWVudAotc2VsZWN0 aW9uIGVuZDogICBwb3NpdGlvbiAzIG9mIGNoaWxkIDAgeyN0ZXh0fSBvZiBjaGlsZCAyIHtESVZ9 IG9mIGNoaWxkIDAge0JPRFl9IG9mIGNoaWxkIDAge0hUTUx9IG9mIGRvY3VtZW50CkluZGV4OiBM YXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZWRpdGluZy9leGVjQ29tbWFuZC81MDYyMzc2LWV4cGVj dGVkLnBuZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09CkNhbm5vdCBkaXNwbGF5OiBmaWxlIG1hcmtlZCBhcyBhIGJpbmFy eSB0eXBlLgpzdm46bWltZS10eXBlID0gaW1hZ2UvcG5nCg==