153806 2016-02-02 15:17:16 -0800 Provide handleKeyWebEvent with completion handler 2016-02-02 16:09:55 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 enrica enrica thorton oldest_to_newest 1161431 0 enrica 2016-02-02 15:17:16 -0800 To support new keyboard architecture. 1161433 1 270527 enrica 2016-02-02 15:25:53 -0800 Created attachment 270527 Patch 1161435 2 270527 thorton 2016-02-02 15:29:36 -0800 Comment on attachment 270527 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270527&action=review > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2875 > + _keyWebEventHandler = [completionHandler copy]; I think we have a smart pointer for blocks now! > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2885 > + return; Confused. Why do you bail here? Don't we still have to do some of the work below? 1161437 3 enrica 2016-02-02 15:32:10 -0800 (In reply to comment #2) > Comment on attachment 270527 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=270527&action=review > > > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2875 > > + _keyWebEventHandler = [completionHandler copy]; > > I think we have a smart pointer for blocks now! > > > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2885 > > + return; > > Confused. Why do you bail here? Don't we still have to do some of the work > below? No we don't in this case. I'll adopt the BlockPtr. 1161448 4 enrica 2016-02-02 16:09:55 -0800 Committed revision 196037. 270527 2016-02-02 15:25:53 -0800 2016-02-02 16:06:15 -0800 Patch kbwithcompletion.txt text/plain 3029 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5NjAzMSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE2LTAyLTAyICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgUHJvdmlkZSBoYW5kbGVLZXlX ZWJFdmVudCB3aXRoIGNvbXBsZXRpb24gaGFuZGxlci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MzgwNgorICAgICAgICByZGFyOi8vcHJvYmxlbS8y NDM5OTIxOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24uaDoKKyAgICAgICAgKiBV SVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbToKKyAgICAgICAgKC1bV0tD b250ZW50VmlldyBoYW5kbGVLZXlXZWJFdmVudDp3aXRoQ29tcGxldGlvbkhhbmRsZXI6XSk6Cisg ICAgICAgICgtW1dLQ29udGVudFZpZXcgX2RpZEhhbmRsZUtleUV2ZW50OmV2ZW50V2FzSGFuZGxl ZDpdKToKKwogMjAxNi0wMi0wMSAgRGF2ZSBIeWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KIAogICAg ICAgICBBZGQgYSBsaW5lIGdyaWQgcGFnaW5hdGlvbiBTUEkgdG8gV2ViS2l0LgpJbmRleDogU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24uaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRl cmFjdGlvbi5oCShyZXZpc2lvbiAxOTYwMjgpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv aW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5oCSh3b3JraW5nIGNvcHkpCkBAIC03MCw2ICs3 MCw3IEBAIHR5cGVkZWYgdm9pZCAoXlVJV0tBdXRvY29ycmVjdGlvbkNvbnRleHQKIHR5cGVkZWYg dm9pZCAoXlVJV0tEaWN0YXRpb25Db250ZXh0SGFuZGxlcikoTlNTdHJpbmcgKnNlbGVjdGVkVGV4 dCwgTlNTdHJpbmcgKmJlZm9yZVRleHQsIE5TU3RyaW5nICphZnRlclRleHQpOwogdHlwZWRlZiB2 b2lkICheVUlXS1NlbGVjdGlvbkNvbXBsZXRpb25IYW5kbGVyKSh2b2lkKTsKIHR5cGVkZWYgdm9p ZCAoXlVJV0tTZWxlY3Rpb25XaXRoRGlyZWN0aW9uQ29tcGxldGlvbkhhbmRsZXIpKEJPT0wgc2Vs ZWN0aW9uRW5kSXNNb3ZpbmcpOwordHlwZWRlZiB2b2lkICheVUlXS0tleVdlYkV2ZW50Q29tcGxl dGlvbkhhbmRsZXIpKFdlYklPU0V2ZW50ICp0aGVFdmVudCwgQk9PTCB3YXNIYW5kbGVkKTsKIAog bmFtZXNwYWNlIFdlYktpdCB7CiBzdHJ1Y3QgV0tTZWxlY3Rpb25EcmF3aW5nSW5mbyB7CkBAIC0x NDIsNiArMTQzLDcgQEAgc3RydWN0IFdLQXV0b0NvcnJlY3Rpb25EYXRhIHsKICAgICBXZWJLaXQ6 OkFzc2lzdGVkTm9kZUluZm9ybWF0aW9uIF9hc3Npc3RlZE5vZGVJbmZvcm1hdGlvbjsKICAgICBS ZXRhaW5QdHI8TlNPYmplY3Q8V0tGb3JtUGVyaXBoZXJhbD4+IF9pbnB1dFBlcmlwaGVyYWw7CiAg ICAgUmV0YWluUHRyPFVJRXZlbnQ+IF91aUV2ZW50QmVpbmdSZXNlbnQ7CisgICAgVUlXS0tleVdl YkV2ZW50Q29tcGxldGlvbkhhbmRsZXIgX2tleVdlYkV2ZW50SGFuZGxlcjsKIAogICAgIENHUG9p bnQgX2xhc3RJbnRlcmFjdGlvbkxvY2F0aW9uOwogCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQkocmV2 aXNpb24gMTk2MDI4KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRW aWV3SW50ZXJhY3Rpb24ubW0JKHdvcmtpbmcgY29weSkKQEAgLTI4NzAsOCArMjg3MCwyMSBAQCAt ICh2b2lkKWhhbmRsZUtleVdlYkV2ZW50OihXZWJJT1NFdmVudCAqCiAgICAgX3BhZ2UtPmhhbmRs ZUtleWJvYXJkRXZlbnQoTmF0aXZlV2ViS2V5Ym9hcmRFdmVudCh0aGVFdmVudCkpOwogfQogCist ICh2b2lkKWhhbmRsZUtleVdlYkV2ZW50OihXZWJJT1NFdmVudCAqKXRoZUV2ZW50IHdpdGhDb21w bGV0aW9uSGFuZGxlcjoodm9pZCAoXikoV2ViSU9TRXZlbnQgKnRoZUV2ZW50LCBCT09MIHdhc0hh bmRsZWQpKWNvbXBsZXRpb25IYW5kbGVyCit7CisgICAgX2tleVdlYkV2ZW50SGFuZGxlciA9IFtj b21wbGV0aW9uSGFuZGxlciBjb3B5XTsKKyAgICBfcGFnZS0+aGFuZGxlS2V5Ym9hcmRFdmVudChO YXRpdmVXZWJLZXlib2FyZEV2ZW50KHRoZUV2ZW50KSk7Cit9CisKIC0gKHZvaWQpX2RpZEhhbmRs ZUtleUV2ZW50OihXZWJJT1NFdmVudCAqKWV2ZW50IGV2ZW50V2FzSGFuZGxlZDooQk9PTClldmVu dFdhc0hhbmRsZWQKIHsKKyAgICBpZiAoX2tleVdlYkV2ZW50SGFuZGxlcikgeworICAgICAgICBf a2V5V2ViRXZlbnRIYW5kbGVyKGV2ZW50LCBldmVudFdhc0hhbmRsZWQpOworICAgICAgICBbX2tl eVdlYkV2ZW50SGFuZGxlciByZWxlYXNlXTsKKyAgICAgICAgX2tleVdlYkV2ZW50SGFuZGxlciA9 IG5pbDsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKyAgICAgICAgCiAgICAgaWYgKGV2ZW50LnR5 cGUgPT0gV2ViRXZlbnRLZXlEb3duKSB7CiAgICAgICAgIC8vIEZJWE1FOiBUaGlzIGlzIG9ubHkg Zm9yIHN0YWdpbmcgcHVycG9zZXMuCiAgICAgICAgIGlmIChbW1VJS2V5Ym9hcmRJbXBsIHNoYXJl ZEluc3RhbmNlXSByZXNwb25kc1RvU2VsZWN0b3I6QHNlbGVjdG9yKGRpZEhhbmRsZVdlYktleUV2 ZW50OildKQo=