153784 2016-02-01 20:58:21 -0800 Web Inspector: Option+Up/Down should not move cursor outside of number 2016-02-01 22:16:06 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts hi joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1161189 0 joepeck 2016-02-01 20:58:21 -0800 * SUMMARY Option+Up/Down should not cursor outside of number * STEPS TO REPRODUCE 1. Inspect <body> 2. Add style: "background: rgb(10|, 10, 10)" 3. Place cursor where indicated 4. Option + Down => Results: rgb(9,| 10, 10) => Expected: rgb(9|, 10, 10) 1161190 1 webkit-bug-importer 2016-02-01 20:58:36 -0800 <rdar://problem/24453133> 1161191 2 270468 joepeck 2016-02-01 21:01:51 -0800 Created attachment 270468 [PATCH] Proposed Fix 1161196 3 270468 timothy 2016-02-01 21:27:28 -0800 Comment on attachment 270468 [PATCH] Proposed Fix Nice catch! 1161207 4 270468 commit-queue 2016-02-01 22:16:04 -0800 Comment on attachment 270468 [PATCH] Proposed Fix Clearing flags on attachment: 270468 Committed r196003: <http://trac.webkit.org/changeset/196003> 1161208 5 commit-queue 2016-02-01 22:16:06 -0800 All reviewed patches have been landed. Closing bug. 270468 2016-02-01 21:01:51 -0800 2016-02-01 22:16:04 -0800 [PATCH] Proposed Fix fix-arrow.patch text/plain 2655 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDYzZDUxYTYuLmQwYjRhNDQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDE2LTAyLTAxICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogT3B0aW9u K1VwL0Rvd24gc2hvdWxkIG5vdCBtb3ZlIGN1cnNvciBvdXRzaWRlIG9mIG51bWJlcgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUzNzg0CisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS8yNDQ1MzEzMz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvQ29kZU1pcnJvckFkZGl0 aW9ucy5qczoKKyAgICAgICAgV2hlbiBzZWxlY3Rpb25TdGFydCA9PT0gc2VsZWN0aW9uRW5kIHdl IHdlcmUgZHVwbGljYXRpbmcgdGhlCisgICAgICAgIG1vdmVtZW50IG11dGF0aW9uIGJ5IHBlcmZv cm1pbmcgaXQgdHdpY2Ugb24gdGhlIHNhbWUgb2JqZWN0LgorICAgICAgICBBZnRlciBtdWNoIGV4 cGVyaW1lbnRhdGlvbiwgSSBsZWZ0IGluIHRoZSBleGlzdGluZyBjb2RlIHBhdGgKKyAgICAgICAg Zm9yIGhhbmRsaW5nIG11dGF0aW9uIHdpdGggYSBzZWxlY3Rpb24uIEl0IGlzIG5vdCBwZXJmZWN0 LAorICAgICAgICBidXQgaXQgaXMgYmV0dGVyIHRoZW4ganVzdCBhcHBseWluZyB0aGUgY2ggZGlm Zi4KKworMjAxNi0wMi0wMSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgor CiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEhpZ2ggTGV2ZWwgTWVtb3J5IE92ZXJ2aWV3IEluc3Ry dW1lbnQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1 MzUxNgogICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjQzNTYzNzg+CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db2RlTWlycm9yQWRkaXRpb25z LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29kZU1pcnJv ckFkZGl0aW9ucy5qcwppbmRleCA3OTU0MGNmLi5hNjE4OThiIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db2RlTWlycm9yQWRkaXRpb25zLmpz CisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvZGVNaXJy b3JBZGRpdGlvbnMuanMKQEAgLTQ4NCwxMiArNDg0LDE3IEBACiAgICAgICAgICAgICB2YXIgbmV3 TGVuZ3RoID0gYWx0ZXJlZE51bWJlclN0cmluZy5sZW5ndGg7CiAKICAgICAgICAgICAgIC8vIEZp eCB1cCB0aGUgc2VsZWN0aW9uIHNvIGl0IGZvbGxvd3MgdGhlIGluY3JlYXNlIG9yIGRlY3JlYXNl IGluIHRoZSByZXBsYWNlbWVudCBsZW5ndGguCi0gICAgICAgICAgICBpZiAocHJldmlvdXNMZW5n dGggIT09IG5ld0xlbmd0aCkgewotICAgICAgICAgICAgICAgIGlmIChzZWxlY3Rpb25TdGFydC5s aW5lID09PSBmcm9tLmxpbmUgJiYgc2VsZWN0aW9uU3RhcnQuY2ggPiBmcm9tLmNoKQotICAgICAg ICAgICAgICAgICAgICBzZWxlY3Rpb25TdGFydC5jaCArPSBuZXdMZW5ndGggLSBwcmV2aW91c0xl bmd0aDsKLQotICAgICAgICAgICAgICAgIGlmIChzZWxlY3Rpb25FbmQubGluZSA9PT0gZnJvbS5s aW5lICYmIHNlbGVjdGlvbkVuZC5jaCA+IGZyb20uY2gpCi0gICAgICAgICAgICAgICAgICAgIHNl bGVjdGlvbkVuZC5jaCArPSBuZXdMZW5ndGggLSBwcmV2aW91c0xlbmd0aDsKKyAgICAgICAgICAg IC8vIHNlbGVjdGlvblN0YXJ0L0VuZCBtYXkgdGhlIHNhbWUgb2JqZWN0IGlmIHRoZXJlIGlzIG5v IHNlbGVjdGlvbi4gSWYgdGhhdCBpcyB0aGUgY2FzZQorICAgICAgICAgICAgLy8gbWFrZSBvbmx5 IG9uZSBtb2RpZmljYXRpb24gdG8gcHJldmVudCBhIGRvdWJsZSBhZGp1c3RtZW50LCBhbmQga2Vl cCBpdCBhIHNpbmdsZSBvYmplY3QKKyAgICAgICAgICAgIC8vIHRvIGF2b2lkIENvZGVNaXJyb3Ig aW5hZHZlcnRlbnRseSBjcmVhdGluZyBhbiBhY3R1YWwgc2VsZWN0aW9uIHJhbmdlLgorICAgICAg ICAgICAgbGV0IGRpZmYgPSAobmV3TGVuZ3RoIC0gcHJldmlvdXNMZW5ndGgpOworICAgICAgICAg ICAgaWYgKHNlbGVjdGlvblN0YXJ0ID09PSBzZWxlY3Rpb25FbmQpCisgICAgICAgICAgICAgICAg c2VsZWN0aW9uU3RhcnQuY2ggKz0gZGlmZjsKKyAgICAgICAgICAgIGVsc2UgeworICAgICAgICAg ICAgICAgIGlmIChzZWxlY3Rpb25TdGFydC5jaCA+IGZyb20uY2gpCisgICAgICAgICAgICAgICAg ICAgIHNlbGVjdGlvblN0YXJ0LmNoICs9IGRpZmY7CisgICAgICAgICAgICAgICAgaWYgKHNlbGVj dGlvbkVuZC5jaCA+IGZyb20uY2gpCisgICAgICAgICAgICAgICAgICAgIHNlbGVjdGlvbkVuZC5j aCArPSBkaWZmOwogICAgICAgICAgICAgfQogCiAgICAgICAgICAgICB0aGlzLnNldFNlbGVjdGlv bihzZWxlY3Rpb25TdGFydCwgc2VsZWN0aW9uRW5kKTsK