153778 2016-02-01 16:22:55 -0800 [CMake] Remove meaningless conditional statements in CMakeLists.txt 2016-02-18 00:28:48 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 jh718.park jh718.park achristensen commit-queue gyuyoung.kim mcatanzaro ossy oldest_to_newest 1161112 0 jh718.park 2016-02-01 16:22:55 -0800 Use CMAKE_FOO_OUTPUT_DIRECTORY located in CMakeLists.txt as default value. And remove conditional statements which has enclosed these one because they don't have meaning anymore. 1161114 1 270449 jh718.park 2016-02-01 16:28:40 -0800 Created attachment 270449 Patch 1161115 2 270449 achristensen 2016-02-01 16:31:28 -0800 Comment on attachment 270449 Patch This needs to be like this. See http://trac.webkit.org/changeset/195478 1161122 3 jh718.park 2016-02-01 16:38:55 -0800 (In reply to comment #2) > Comment on attachment 270449 [details] > Patch > > This needs to be like this. > See http://trac.webkit.org/changeset/195478 Hmm, doesn't those things be overwritten by OptionsWin.cmake? Because now those things are precede to include(OptionsCommon) by https://bugs.webkit.org/show_bug.cgi?id=153373. They don't follow the include(OptionsCommon) in order, so it seems that they don't need any conditionals there. But if I missed something, please let me know. 1161125 4 achristensen 2016-02-01 16:40:23 -0800 The internal Windows build builds each directory (WTF, JavaScriptCore, WebCore, and WebKit) without the other directories where they are. This causes problems with that setup. 1161133 5 jh718.park 2016-02-01 16:48:01 -0800 (In reply to comment #4) > The internal Windows build builds each directory (WTF, JavaScriptCore, > WebCore, and WebKit) without the other directories where they are. This > causes problems with that setup. Ah, I see. Thank you for letting me know about it 1161165 6 mcatanzaro 2016-02-01 18:09:18 -0800 Alex, now that include(WebKitCommon) has been moved, surely those conditionals will never be hit anymore? I think Joonghun's patch is correct. 1161365 7 achristensen 2016-02-02 12:43:13 -0800 I wasn't aware they had moved. We're still in the process of verifying the internal AppleWin build works, so I'd rather not touch this right now unless this is blocking something. 1165822 8 mcatanzaro 2016-02-17 17:28:45 -0800 (In reply to comment #7) > I wasn't aware they had moved. We're still in the process of verifying the > internal AppleWin build works, so I'd rather not touch this right now unless > this is blocking something. Any progress on this? I'd still like to r+ this, but don't mind delaying if that's convenient for you. 1165949 9 270449 ossy 2016-02-17 23:38:48 -0800 Comment on attachment 270449 Patch > The internal Windows build builds each directory (WTF, JavaScriptCore, WebCore, and WebKit) without the other directories where they are. This causes problems with that setup. So it is a dead code, out-of-tree use case isn't a good reason to keep dead code. But I'd be happy to add it back once there is a public use-case in trunk. (I know this strict policy since bug154323 from Filip Pizlo.) Let's go ahead and remove it, r=me. 1165958 10 270449 commit-queue 2016-02-18 00:28:44 -0800 Comment on attachment 270449 Patch Clearing flags on attachment: 270449 Committed r196748: <http://trac.webkit.org/changeset/196748> 1165959 11 commit-queue 2016-02-18 00:28:48 -0800 All reviewed patches have been landed. Closing bug. 270449 2016-02-01 16:28:40 -0800 2016-02-18 00:28:44 -0800 Patch bug-153778-20160202092814.patch text/plain 2025 jh718.park U3VidmVyc2lvbiBSZXZpc2lvbjogMTk1OTg2CmRpZmYgLS1naXQgYS9DTWFrZUxpc3RzLnR4dCBi L0NNYWtlTGlzdHMudHh0CmluZGV4IGQ1ODMyMTU4YTY4M2RhOTk5NjRkNjRmODI3NGVlMzE4ZjA5 YWNlZTUuLjBlMGVhMjMwOTliMjcyNWRiZDdhOThlY2EzNjU5ZGRmMjJjODdhZGUgMTAwNjQ0Ci0t LSBhL0NNYWtlTGlzdHMudHh0CisrKyBiL0NNYWtlTGlzdHMudHh0CkBAIC0xMDUsMTcgKzEwNSwx MSBAQCBzZXQoV2ViQ29yZVRlc3RTdXBwb3J0X0xJQlJBUllfVFlQRSBTVEFUSUMpCiBvcHRpb24o U0hPVUxEX0lOU1RBTExfSlNfU0hFTEwgImdlbmVyYXRlIGFuIGluc3RhbGxhdGlvbiBydWxlIHRv IGluc3RhbGwgdGhlIGJ1aWx0IEphdmFTY3JpcHQgc2hlbGwiKQogCiAjIC0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tCi0jIE91dHB1dCBkaXJlY3RvcmllcworIyBEZWZhdWx0IG91dHB1dCBkaXJlY3Rvcmll cywgd2hpY2ggY2FuIGJlIG92ZXJ3cml0dGVuIGJ5IHBvcnRzCiAjLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tCi1pZiAoTk9UIENNQUtFX0FSQ0hJVkVfT1VUUFVUX0RJUkVDVE9SWSkKLSAgICBzZXQoQ01B S0VfQVJDSElWRV9PVVRQVVRfRElSRUNUT1JZICR7Q01BS0VfQklOQVJZX0RJUn0vbGliKQotZW5k aWYgKCkKLWlmIChOT1QgQ01BS0VfTElCUkFSWV9PVVRQVVRfRElSRUNUT1JZKQotICAgIHNldChD TUFLRV9MSUJSQVJZX09VVFBVVF9ESVJFQ1RPUlkgJHtDTUFLRV9CSU5BUllfRElSfS9saWIpCi1l bmRpZiAoKQotaWYgKE5PVCBDTUFLRV9SVU5USU1FX09VVFBVVF9ESVJFQ1RPUlkpCi0gICAgc2V0 KENNQUtFX1JVTlRJTUVfT1VUUFVUX0RJUkVDVE9SWSAke0NNQUtFX0JJTkFSWV9ESVJ9L2JpbikK LWVuZGlmICgpCitzZXQoQ01BS0VfQVJDSElWRV9PVVRQVVRfRElSRUNUT1JZICR7Q01BS0VfQklO QVJZX0RJUn0vbGliKQorc2V0KENNQUtFX0xJQlJBUllfT1VUUFVUX0RJUkVDVE9SWSAke0NNQUtF X0JJTkFSWV9ESVJ9L2xpYikKK3NldChDTUFLRV9SVU5USU1FX09VVFBVVF9ESVJFQ1RPUlkgJHtD TUFLRV9CSU5BUllfRElSfS9iaW4pCiAKICMgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KICMgQ29tbW9u IGNvbmZpZ3VyYXRpb24KZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA1 NjYwNjQ4ZjMwOTg5ZGU1MTYwMWYwYzI5MzNmNDRjZjFhZGY5YzNjLi5lNTlhMzgwMDI3MmQ3MzUx YmFhYzIwZmYyZTM5NWY4MGNiOGE0MTM4IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTYtMDItMDEgIEpvb25naHVuIFBhcmsgIDxqaDcx OC5wYXJrQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtDTWFrZV0gUmVtb3ZlIG1lYW5pbmdsZXNz IGNvbmRpdGlvbmFsIHN0YXRlbWVudHMgaW4gQ01ha2VMaXN0cy50eHQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1Mzc3OAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQ01ha2VMaXN0cy50eHQ6CisgICAg ICAgIFVzZSBDTUFLRV9GT09fT1VUUFVUX0RJUkVDVE9SWSBsb2NhdGVkIGluIENNYWtlTGlzdHMu dHh0IGFzIGRlZmF1bHQgdmFsdWUuCisgICAgICAgIEFuZCByZW1vdmUgY29uZGl0aW9uYWwgc3Rh dGVtZW50cyB3aGljaCBoYXMgZW5jbG9zZWQgdGhlc2Ugb25lCisgICAgICAgIGJlY2F1c2UgdGhl eSBkb24ndCBoYXZlIG1lYW5pbmcgYW55bW9yZS4KKwogMjAxNi0wMi0wMSAgQWxleCBDaHJpc3Rl bnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIFtXaW5dIFdURkhlYWRl ckRldGVjdGlvbi5oIG5vIGxvbmdlciBuZWVkZWQK