153752 2016-02-01 10:29:58 -0800 LayoutTest http/tests/plugins/visible_plugins.html failing on Yosemite WK1 2016-02-03 15:02:20 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ryanhaddad bfulgham ap bfulgham webkit-bug-importer oldest_to_newest 1160935 0 ryanhaddad 2016-02-01 10:29:58 -0800 LayoutTest http/tests/plugins/visible_plugins.html failing on Yosemite WK1 Started after r195950. <https://build.webkit.org/results/Apple%20Yosemite%20Release%20WK1%20(Tests)/r195950%20(11677)/results.html> <http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fplugins%2Fvisible_plugins.html> --- /Volumes/Data/slave/yosemite-release-tests-wk1/build/layout-test-results/http/tests/plugins/visible_plugins-expected.txt +++ /Volumes/Data/slave/yosemite-release-tests-wk1/build/layout-test-results/http/tests/plugins/visible_plugins-actual.txt @@ -1,3 +1,3 @@ Check we only display the valid set of "public" plugins. -None +Java Applet Plug-in 1161144 1 webkit-bug-importer 2016-02-01 17:20:09 -0800 <rdar://problem/24450314> 1161151 2 ryanhaddad 2016-02-01 17:39:55 -0800 Skipped this test on Yosemite to get the bots back to green during investigation <https://trac.webkit.org/r195996> 1161184 3 bfulgham 2016-02-01 19:49:46 -0800 This result is inconsistent on our various test machines because they seem to have a different set of plugins installed: * Some have Java installed * Some have Quicktime installed * Some have neither We need to decide on a consistent set of plugins and deploy them on all the test machines. 1161200 4 ap 2016-02-01 21:59:38 -0800 I don;t think that this would be the correct response. Tests need to pass on engineers' machines too, so they should pass regardless of installed plug-ins. 1161716 5 270588 bfulgham 2016-02-03 10:36:26 -0800 Created attachment 270588 Patch 1161758 6 270588 darin 2016-02-03 13:11:42 -0800 Comment on attachment 270588 Patch Normally it’s better to do something to make it clear that the test ran and we didn’t just hit a JavaScript exception. Could just use "PASS" or "FAIL: Unexpected ..." and then we’d notice that the PASS was missing if the test didn't even run. 1161782 7 270588 ap 2016-02-03 14:24:59 -0800 Comment on attachment 270588 Patch I agree with Darin's comment, please do address it. That seems straightforward enough to not require additional review, so r=me. 1161799 8 bfulgham 2016-02-03 15:01:25 -0800 Committed r196084: <http://trac.webkit.org/changeset/196084> 1161800 9 bfulgham 2016-02-03 15:02:20 -0800 (In reply to comment #6) > Comment on attachment 270588 [details] > Patch > > Normally it’s better to do something to make it clear that the test ran and > we didn’t just hit a JavaScript exception. Could just use "PASS" or "FAIL: > Unexpected ..." and then we’d notice that the PASS was missing if the test > didn't even run. Understood -- I'll revise to address that. 270588 2016-02-03 10:36:26 -0800 2016-02-03 14:24:59 -0800 Patch bug-153752-20160203103605.patch text/plain 2601 bfulgham SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE5NjA3MSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE2LTAyLTAzICBCcmVudCBGdWxnaGFtICA8 YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT046IExheW91dFRlc3QgaHR0 cC90ZXN0cy9wbHVnaW5zL3Zpc2libGVfcGx1Z2lucy5odG1sIGZhaWxpbmcgb24gWW9zZW1pdGUg V0sxCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTM3 NTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZXZp c2UgdGVzdCB0byBza2lwIHRoZSBwbHVnaW5zIHdlIGV4cGVjdCB0byBiZSBkaXNwbGF5ZWQsIGFu ZCBvbmx5IGRpc3BsYXkgcGx1Z2lucworICAgICAgICB0aGF0IGFyZSBzdXJwcmlzaW5nLiBXZSBz aG91bGQgZ2V0IHRoZSByZXN1bHQgJ05vbmUnIGlmIHRoZSBmZWF0dXJlIGlzIHdvcmtpbmcgcHJv cGVybHkuCisKKyAgICAgICAgKiBodHRwL3Rlc3RzL3BsdWdpbnMvdmlzaWJsZV9wbHVnaW5zLmh0 bWw6CisgICAgICAgICogcGxhdGZvcm0vbWFjLXdrMi9odHRwL3Rlc3RzL3BsdWdpbnMvdmlzaWJs ZV9wbHVnaW5zLWV4cGVjdGVkLnR4dDogUmVtb3ZlZC4KKwogMjAxNi0wMi0wMyAgUnlhbiBIYWRk YWQgIDxyeWFuaGFkZGFkQGFwcGxlLmNvbT4KIAogICAgICAgICBTa2lwIGZhc3QvZm9ybXMvaW5w dXQtdXNlci1pbnB1dC1zYW5pdGl6YXRpb24uaHRtbCBvbiBpb3Mtc2ltdWxhdG9yCkluZGV4OiBM YXlvdXRUZXN0cy9odHRwL3Rlc3RzL3BsdWdpbnMvdmlzaWJsZV9wbHVnaW5zLmh0bWwKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9wbHVnaW5zL3Zpc2libGVfcGx1Z2lucy5o dG1sCShyZXZpc2lvbiAxOTYwMjkpCisrKyBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3BsdWdpbnMv dmlzaWJsZV9wbHVnaW5zLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTksMTUgKzksMjIgQEAgZnVu Y3Rpb24gdGVzdCgpCiAgICAgICAgIGludGVybmFscy5zZXRTaG93QWxsUGx1Z2lucyhmYWxzZSk7 CiAgICAgfQogCi0gICAgdmFyIHBsdWdpbkxpc3QgPSAiIjsKKyAgICB2YXIgdW5leHBlY3RlZFBs dWdpbnMgPSBbXTsKICAgICBBcnJheS5wcm90b3R5cGUuZm9yRWFjaC5jYWxsKG5hdmlnYXRvci5w bHVnaW5zLCBmdW5jdGlvbihwbHVnaW4pIHsKLSAgICAgICAgaWYgKHBsdWdpbkxpc3QubGVuZ3Ro KQotICAgICAgICAgICAgcGx1Z2luTGlzdCA9IHBsdWdpbkxpc3QgKyAiXG4iOwotICAgICAgICBw bHVnaW5MaXN0ID0gcGx1Z2luTGlzdCArIHBsdWdpbi5uYW1lOworICAgICAgICBpZiAocGx1Z2lu Lm5hbWUubWF0Y2goL1Nob2Nrd2F2ZS9pKSkKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAg aWYgKHBsdWdpbi5uYW1lLm1hdGNoKC9RdWlja1RpbWUvaSkpCisgICAgICAgICAgICByZXR1cm47 CisgICAgICAgIGlmIChwbHVnaW4ubmFtZS5tYXRjaCgvSmF2YS9pKSkKKyAgICAgICAgICAgIHJl dHVybjsKKyAgICAgICAgaWYgKHBsdWdpbi5uYW1lLm1hdGNoKC9XZWJLaXQgYnVpbHQtaW4gUERG L2kpKQorICAgICAgICAgICAgcmV0dXJuOworCisgICAgICAgIHVuZXhwZWN0ZWRQbHVnaW5zLnB1 c2gocGx1Z2luLm5hbWUpOwogICAgIH0pOwogCi0gICAgaWYgKHBsdWdpbkxpc3QubGVuZ3RoKQot ICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgicmVzdWx0IikuaW5uZXJUZXh0ID0gcGx1 Z2luTGlzdDsKKyAgICBpZiAodW5leHBlY3RlZFBsdWdpbnMubGVuZ3RoKQorICAgICAgICBkb2N1 bWVudC5nZXRFbGVtZW50QnlJZCgicmVzdWx0IikuaW5uZXJUZXh0ID0gIlVuZXhwZWN0ZWQgcGx1 Z2luczogIiArIHVuZXhwZWN0ZWRQbHVnaW5zLnRvU3RyaW5nKCk7CiAgICAgaWYgKHdpbmRvdy50 ZXN0UnVubmVyKQogICAgICAgICB0ZXN0UnVubmVyLm5vdGlmeURvbmUoKTsKIH0KSW5kZXg6IExh eW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvaHR0cC90ZXN0cy9wbHVnaW5zL3Zpc2libGVfcGx1 Z2lucy1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFj LXdrMi9odHRwL3Rlc3RzL3BsdWdpbnMvdmlzaWJsZV9wbHVnaW5zLWV4cGVjdGVkLnR4dAkocmV2 aXNpb24gMTk2MDI5KQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9odHRwL3Rlc3Rz L3BsdWdpbnMvdmlzaWJsZV9wbHVnaW5zLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAt MSwzICswLDAgQEAKLUNoZWNrIHdlIG9ubHkgZGlzcGxheSB0aGUgdmFsaWQgc2V0IG9mICJwdWJs aWMiIHBsdWdpbnMuCi0KLVdlYktpdCBidWlsdC1pbiBQREYK