153751 2016-02-01 10:23:52 -0800 Snapshot surfaces are forever wired after being compressed 2016-02-01 12:47:20 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton andersca commit-queue oldest_to_newest 1160924 0 thorton 2016-02-01 10:23:52 -0800 Snapshot surfaces are forever wired after being compressed 1160926 1 270399 thorton 2016-02-01 10:24:13 -0800 Created attachment 270399 Patch 1160929 2 270399 darin 2016-02-01 10:25:49 -0800 Comment on attachment 270399 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270399&action=review > Source/WebCore/platform/graphics/cocoa/IOSurface.mm:42 > CGContextRef CGIOSurfaceContextCreate(IOSurfaceRef, size_t, size_t, size_t, size_t, CGColorSpaceRef, CGBitmapInfo); > CGImageRef CGIOSurfaceContextCreateImage(CGContextRef); > CGImageRef CGIOSurfaceContextCreateImageReference(CGContextRef); Why isn’t any of this in the SPI header? > Source/WebCore/platform/graphics/cocoa/IOSurface.mm:45 > +const NSString *WebIOSurfaceAcceleratorUnwireSurfaceKey = @"UnwireSurface"; The const here is placed wrong. I think you want NSString * const. There’s no reason to put this inside the extern "C". 1160933 3 thorton 2016-02-01 10:28:13 -0800 (In reply to comment #2) > Comment on attachment 270399 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=270399&action=review > > > Source/WebCore/platform/graphics/cocoa/IOSurface.mm:42 > > CGContextRef CGIOSurfaceContextCreate(IOSurfaceRef, size_t, size_t, size_t, size_t, CGColorSpaceRef, CGBitmapInfo); > > CGImageRef CGIOSurfaceContextCreateImage(CGContextRef); > > CGImageRef CGIOSurfaceContextCreateImageReference(CGContextRef); > > Why isn’t any of this in the SPI header? Good question. > > Source/WebCore/platform/graphics/cocoa/IOSurface.mm:45 > > +const NSString *WebIOSurfaceAcceleratorUnwireSurfaceKey = @"UnwireSurface"; > > The const here is placed wrong. I think you want NSString * const. > > There’s no reason to put this inside the extern "C". OK! Thank you! 1160939 4 270401 thorton 2016-02-01 10:47:30 -0800 Created attachment 270401 Patch 1160954 5 270407 thorton 2016-02-01 11:29:47 -0800 Created attachment 270407 Patch 1160975 6 270407 commit-queue 2016-02-01 12:47:17 -0800 Comment on attachment 270407 Patch Clearing flags on attachment: 270407 Committed r195975: <http://trac.webkit.org/changeset/195975> 1160976 7 commit-queue 2016-02-01 12:47:20 -0800 All reviewed patches have been landed. Closing bug. 270399 2016-02-01 10:24:13 -0800 2016-02-01 10:47:28 -0800 Patch bug-153751-20160201102349.patch text/plain 2245 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMTk1OTYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmFhZjRhNjQ3ZDRiMDA4 ZDUwMWUxNTNmZTRhMDM1MjVhM2QzYjBkNy4uN2FhYjFjNDU1NjJiZjM5Y2RiYThhODZlM2VlNmJm ZDk2NGY4YTgyOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTAyLTAxICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIFNuYXBzaG90IHN1 cmZhY2VzIGFyZSBmb3JldmVyIHdpcmVkIGFmdGVyIGJlaW5nIGNvbXByZXNzZWQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1Mzc1MQorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vMjQzNTQ1NDY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9JT1N1cmZhY2UubW06 CisgICAgICAgIChJT1N1cmZhY2U6OmNvbnZlcnRUb0Zvcm1hdCk6CisgICAgICAgIEFsbG93IElP U3VyZmFjZUFjY2VsZXJhdG9yIHRvIHVud2lyZSBzdXJmYWNlcyBhZnRlciB0aGV5J3JlIHRyYW5z Zm9ybWVkLgorCiAyMDE2LTAyLTAxICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAK ICAgICAgICAgVHJpZWQgdG8gZml4IGEgYnVpbGQgYWZ0ZXIgcjE5NTg5OS4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL0lPU3VyZmFjZS5tbSBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL0lPU3VyZmFjZS5tbQppbmRleCAx MDFhOGUyYTExMzBlOTZjNzQ4NDMwZjVmYjg2MGZhYzI4MTc5ODVhLi43ODFhZjJiNTBhZmVmNzdh NTQ2ZmM0NmFmZDgzZDI0ZmNhMDBiM2Y2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jb2NvYS9JT1N1cmZhY2UubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvY29jb2EvSU9TdXJmYWNlLm1tCkBAIC00MCw2ICs0MCw5IEBAIGV4dGVy biAiQyIgewogQ0dDb250ZXh0UmVmIENHSU9TdXJmYWNlQ29udGV4dENyZWF0ZShJT1N1cmZhY2VS ZWYsIHNpemVfdCwgc2l6ZV90LCBzaXplX3QsIHNpemVfdCwgQ0dDb2xvclNwYWNlUmVmLCBDR0Jp dG1hcEluZm8pOwogQ0dJbWFnZVJlZiBDR0lPU3VyZmFjZUNvbnRleHRDcmVhdGVJbWFnZShDR0Nv bnRleHRSZWYpOwogQ0dJbWFnZVJlZiBDR0lPU3VyZmFjZUNvbnRleHRDcmVhdGVJbWFnZVJlZmVy ZW5jZShDR0NvbnRleHRSZWYpOworCisvLyBNb3ZlIHRoaXMgaW50byB0aGUgU1BJIGhlYWRlciBv bmNlIGl0J3MgcG9zc2libGUgdG8gcHV0IGluc2lkZSB0aGUgQVBQTEVfSU5URVJOQUxfU0RLIGJs b2NrLgorY29uc3QgTlNTdHJpbmcgKldlYklPU3VyZmFjZUFjY2VsZXJhdG9yVW53aXJlU3VyZmFj ZUtleSA9IEAiVW53aXJlU3VyZmFjZSI7CiB9CiAKIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwpA QCAtNDEwLDcgKzQxMyw5IEBAIHZvaWQgSU9TdXJmYWNlOjpjb252ZXJ0VG9Gb3JtYXQoc3RkOjp1 bmlxdWVfcHRyPFdlYkNvcmU6OklPU3VyZmFjZT4mJiBpblN1cmZhY2UsCiAgICAgICAgIGRlbGV0 ZSBjYWxsYmFjazsKICAgICB9OwogCi0gICAgSU9SZXR1cm4gcmV0ID0gSU9TdXJmYWNlQWNjZWxl cmF0b3JUcmFuc2Zvcm1TdXJmYWNlKGFjY2VsZXJhdG9yLCBpblN1cmZhY2UtPnN1cmZhY2UoKSwg ZGVzdGluYXRpb25JT1N1cmZhY2VSZWYsIG51bGxwdHIsIG51bGxwdHIsICZjb21wbGV0aW9uLCBu dWxscHRyLCBudWxscHRyKTsKKyAgICBOU0RpY3Rpb25hcnkgKm9wdGlvbnMgPSBAeyBXZWJJT1N1 cmZhY2VBY2NlbGVyYXRvclVud2lyZVN1cmZhY2VLZXkgOiBAWUVTIH07CisKKyAgICBJT1JldHVy biByZXQgPSBJT1N1cmZhY2VBY2NlbGVyYXRvclRyYW5zZm9ybVN1cmZhY2UoYWNjZWxlcmF0b3Is IGluU3VyZmFjZS0+c3VyZmFjZSgpLCBkZXN0aW5hdGlvbklPU3VyZmFjZVJlZiwgKENGRGljdGlv bmFyeVJlZilvcHRpb25zLCBudWxscHRyLCAmY29tcGxldGlvbiwgbnVsbHB0ciwgbnVsbHB0cik7 CiAgICAgQVNTRVJUX1VOVVNFRChyZXQsIHJldCA9PSBrSU9SZXR1cm5TdWNjZXNzKTsKIH0KICNl bmRpZiAvLyBQTEFURk9STShJT1MpCg== 270401 2016-02-01 10:47:30 -0800 2016-02-01 11:29:45 -0800 Patch bug-153751-20160201104706.patch text/plain 2254 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMTk1OTYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmFhZjRhNjQ3ZDRiMDA4 ZDUwMWUxNTNmZTRhMDM1MjVhM2QzYjBkNy4uNDY0NzRhNDdmOWFiZDg5YWZjNTA3NGFjOTNjMTYw MzA1YWJlMjRlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTAyLTAxICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIFNuYXBzaG90IHN1 cmZhY2VzIGFyZSBmb3JldmVyIHdpcmVkIGFmdGVyIGJlaW5nIGNvbXByZXNzZWQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1Mzc1MQorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vMjQzNTQ1NDY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRs ZXIuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9JT1N1cmZhY2UubW06Cisg ICAgICAgIChJT1N1cmZhY2U6OmNvbnZlcnRUb0Zvcm1hdCk6CisgICAgICAgIEFsbG93IElPU3Vy ZmFjZUFjY2VsZXJhdG9yIHRvIHVud2lyZSBzdXJmYWNlcyBhZnRlciB0aGV5J3JlIHRyYW5zZm9y bWVkLgorCiAyMDE2LTAyLTAxICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAg ICAgICAgVHJpZWQgdG8gZml4IGEgYnVpbGQgYWZ0ZXIgcjE5NTg5OS4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL0lPU3VyZmFjZS5tbSBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL0lPU3VyZmFjZS5tbQppbmRleCAxMDFh OGUyYTExMzBlOTZjNzQ4NDMwZjVmYjg2MGZhYzI4MTc5ODVhLi5hNzNiYzY5MjQ1Yjc5ZWYyODBm MDdhMWFiYjljYmNlNjRiODZjY2FhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9jb2NvYS9JT1N1cmZhY2UubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvY29jb2EvSU9TdXJmYWNlLm1tCkBAIC00Miw2ICs0Miw5IEBAIENHSW1hZ2VS ZWYgQ0dJT1N1cmZhY2VDb250ZXh0Q3JlYXRlSW1hZ2UoQ0dDb250ZXh0UmVmKTsKIENHSW1hZ2VS ZWYgQ0dJT1N1cmZhY2VDb250ZXh0Q3JlYXRlSW1hZ2VSZWZlcmVuY2UoQ0dDb250ZXh0UmVmKTsK IH0KIAorLy8gTW92ZSB0aGlzIGludG8gdGhlIFNQSSBoZWFkZXIgb25jZSBpdCdzIHBvc3NpYmxl IHRvIHB1dCBpbnNpZGUgdGhlIEFQUExFX0lOVEVSTkFMX1NESyBibG9jay4KK05TU3RyaW5nICog Y29uc3QgV2ViSU9TdXJmYWNlQWNjZWxlcmF0b3JVbndpcmVTdXJmYWNlS2V5ID0gQCJVbndpcmVT dXJmYWNlIjsKKwogdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAKIGlubGluZSBzdGQ6OnVuaXF1 ZV9wdHI8SU9TdXJmYWNlPiBJT1N1cmZhY2U6OnN1cmZhY2VGcm9tUG9vbChJbnRTaXplIHNpemUs IEludFNpemUgY29udGV4dFNpemUsIENvbG9yU3BhY2UgY29sb3JTcGFjZSwgRm9ybWF0IHBpeGVs Rm9ybWF0KQpAQCAtNDEwLDcgKzQxMyw5IEBAIHZvaWQgSU9TdXJmYWNlOjpjb252ZXJ0VG9Gb3Jt YXQoc3RkOjp1bmlxdWVfcHRyPFdlYkNvcmU6OklPU3VyZmFjZT4mJiBpblN1cmZhY2UsCiAgICAg ICAgIGRlbGV0ZSBjYWxsYmFjazsKICAgICB9OwogCi0gICAgSU9SZXR1cm4gcmV0ID0gSU9TdXJm YWNlQWNjZWxlcmF0b3JUcmFuc2Zvcm1TdXJmYWNlKGFjY2VsZXJhdG9yLCBpblN1cmZhY2UtPnN1 cmZhY2UoKSwgZGVzdGluYXRpb25JT1N1cmZhY2VSZWYsIG51bGxwdHIsIG51bGxwdHIsICZjb21w bGV0aW9uLCBudWxscHRyLCBudWxscHRyKTsKKyAgICBOU0RpY3Rpb25hcnkgKm9wdGlvbnMgPSBA eyBXZWJJT1N1cmZhY2VBY2NlbGVyYXRvclVud2lyZVN1cmZhY2VLZXkgOiBAWUVTIH07CisKKyAg ICBJT1JldHVybiByZXQgPSBJT1N1cmZhY2VBY2NlbGVyYXRvclRyYW5zZm9ybVN1cmZhY2UoYWNj ZWxlcmF0b3IsIGluU3VyZmFjZS0+c3VyZmFjZSgpLCBkZXN0aW5hdGlvbklPU3VyZmFjZVJlZiwg KENGRGljdGlvbmFyeVJlZilvcHRpb25zLCBudWxscHRyLCAmY29tcGxldGlvbiwgbnVsbHB0ciwg bnVsbHB0cik7CiAgICAgQVNTRVJUX1VOVVNFRChyZXQsIHJldCA9PSBrSU9SZXR1cm5TdWNjZXNz KTsKIH0KICNlbmRpZiAvLyBQTEFURk9STShJT1MpCg== 270407 2016-02-01 11:29:47 -0800 2016-02-01 12:47:17 -0800 Patch bug-153751-20160201112923.patch text/plain 2323 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMTk1OTY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmNjYjkyOGU4ZDEzZDI2 NGI1OTJmMTExZjRiODNlOWE1M2M5NjdmNC4uOGNiNzEyMGYxZGRlY2I0YWJjNzVlNDNjMmYzMDEz Y2QyYjA0ODJiOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTAyLTAxICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIFNuYXBzaG90IHN1 cmZhY2VzIGFyZSBmb3JldmVyIHdpcmVkIGFmdGVyIGJlaW5nIGNvbXByZXNzZWQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1Mzc1MQorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vMjQzNTQ1NDY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRs ZXIuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9JT1N1cmZhY2UubW06Cisg ICAgICAgIChJT1N1cmZhY2U6OmNvbnZlcnRUb0Zvcm1hdCk6CisgICAgICAgIEFsbG93IElPU3Vy ZmFjZUFjY2VsZXJhdG9yIHRvIHVud2lyZSBzdXJmYWNlcyBhZnRlciB0aGV5J3JlIHRyYW5zZm9y bWVkLgorCiAyMDE2LTAyLTAxICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAg ICAgICAgIFJFR1JFU1NJT04ocjE5NTc3MCk6IFVzZS1hZnRlci1mcmVlIGluIFJlc291cmNlTG9h ZGVyT3B0aW9uczo6Y2FjaGluZ1BvbGljeQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvY29jb2EvSU9TdXJmYWNlLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvY29jb2EvSU9TdXJmYWNlLm1tCmluZGV4IDEwMWE4ZTJhMTEzMGU5NmM3NDg0 MzBmNWZiODYwZmFjMjgxNzk4NWEuLjI2Y2NhODIyOTZlMGJkMmY2YWFkNzk0OGVmMTIwNzRiMjhh NjhlMjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29h L0lPU3VyZmFjZS5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2Nv YS9JT1N1cmZhY2UubW0KQEAgLTQyLDYgKzQyLDExIEBAIENHSW1hZ2VSZWYgQ0dJT1N1cmZhY2VD b250ZXh0Q3JlYXRlSW1hZ2UoQ0dDb250ZXh0UmVmKTsKIENHSW1hZ2VSZWYgQ0dJT1N1cmZhY2VD b250ZXh0Q3JlYXRlSW1hZ2VSZWZlcmVuY2UoQ0dDb250ZXh0UmVmKTsKIH0KIAorI2lmIFBMQVRG T1JNKElPUykKKy8vIE1vdmUgdGhpcyBpbnRvIHRoZSBTUEkgaGVhZGVyIG9uY2UgaXQncyBwb3Nz aWJsZSB0byBwdXQgaW5zaWRlIHRoZSBBUFBMRV9JTlRFUk5BTF9TREsgYmxvY2suCitOU1N0cmlu ZyAqIGNvbnN0IFdlYklPU3VyZmFjZUFjY2VsZXJhdG9yVW53aXJlU3VyZmFjZUtleSA9IEAiVW53 aXJlU3VyZmFjZSI7CisjZW5kaWYKKwogdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAKIGlubGlu ZSBzdGQ6OnVuaXF1ZV9wdHI8SU9TdXJmYWNlPiBJT1N1cmZhY2U6OnN1cmZhY2VGcm9tUG9vbChJ bnRTaXplIHNpemUsIEludFNpemUgY29udGV4dFNpemUsIENvbG9yU3BhY2UgY29sb3JTcGFjZSwg Rm9ybWF0IHBpeGVsRm9ybWF0KQpAQCAtNDEwLDcgKzQxNSw5IEBAIHZvaWQgSU9TdXJmYWNlOjpj b252ZXJ0VG9Gb3JtYXQoc3RkOjp1bmlxdWVfcHRyPFdlYkNvcmU6OklPU3VyZmFjZT4mJiBpblN1 cmZhY2UsCiAgICAgICAgIGRlbGV0ZSBjYWxsYmFjazsKICAgICB9OwogCi0gICAgSU9SZXR1cm4g cmV0ID0gSU9TdXJmYWNlQWNjZWxlcmF0b3JUcmFuc2Zvcm1TdXJmYWNlKGFjY2VsZXJhdG9yLCBp blN1cmZhY2UtPnN1cmZhY2UoKSwgZGVzdGluYXRpb25JT1N1cmZhY2VSZWYsIG51bGxwdHIsIG51 bGxwdHIsICZjb21wbGV0aW9uLCBudWxscHRyLCBudWxscHRyKTsKKyAgICBOU0RpY3Rpb25hcnkg Km9wdGlvbnMgPSBAeyBXZWJJT1N1cmZhY2VBY2NlbGVyYXRvclVud2lyZVN1cmZhY2VLZXkgOiBA WUVTIH07CisKKyAgICBJT1JldHVybiByZXQgPSBJT1N1cmZhY2VBY2NlbGVyYXRvclRyYW5zZm9y bVN1cmZhY2UoYWNjZWxlcmF0b3IsIGluU3VyZmFjZS0+c3VyZmFjZSgpLCBkZXN0aW5hdGlvbklP U3VyZmFjZVJlZiwgKENGRGljdGlvbmFyeVJlZilvcHRpb25zLCBudWxscHRyLCAmY29tcGxldGlv biwgbnVsbHB0ciwgbnVsbHB0cik7CiAgICAgQVNTRVJUX1VOVVNFRChyZXQsIHJldCA9PSBrSU9S ZXR1cm5TdWNjZXNzKTsKIH0KICNlbmRpZiAvLyBQTEFURk9STShJT1MpCg==