153747 2016-02-01 09:36:02 -0800 REGRESSION(r195949): [GTK] Test /webkit2/WebKitWebView/insert/link is failing since r195949 2016-02-24 02:41:15 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk, Regression P2 Normal --- 1 cgarcia webkit-unassigned aplazas bugs-noreply darin d_russell oldest_to_newest 1160886 0 cgarcia 2016-02-01 09:36:02 -0800 /webkit2/WebKitWebView/insert/link: ** ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:445:void testWebViewEditorCreateLink(EditorTest*, gconstpointer): assertion failed: (javascriptResult) FAIL I haven't had time to investigate this yet, just noticed it in the bots. 1163167 1 cgarcia 2016-02-09 04:06:28 -0800 Ok, what r195949 broke is MoveToEndOfLine and MoveToBeginningOfLine editing command when there's only one word and it's selected. It can be reproduced using any input field: 1. Write a single world 2. Select it entirely from left to right to ensure the cursor is at the end of the word. Double clicking should also work. 3. Press End key The selection should be cleared, but it's not. Same happens if you select the word from right to left and press the Start key. So, my guess is that when the cursor is already at the desired position, it does nothing. I'm not sure if this happens in mac too, or depends on the editor behavior, so I'm leaving this as GTK specific for now, could someone confirm? 1163198 2 darin 2016-02-09 09:13:44 -0800 On Mac it is Control-Right-Arrow, not End. The “End key moves cursor to the end of line” behavior comes from Windows; on Mac the End key scrolls to the end of the document and does not move the cursor. Also, this particular keyboard command is overridden by Mission Control by default in recent versions of Mac, so you have to turn off Mission Control’s "Move right a space" key binding in System Preferences Keyboard Shortcuts to test it. I tried to reproduce this with the local copy of Safari with the latest WebKit that I built and I could not reproduce the bug on Mac; it seemed to work fine. Might have done the testing wrong. 1163425 3 270981 cgarcia 2016-02-10 00:48:30 -0800 Created attachment 270981 Test Thanks for looking at this, Darin. I've written a test that fails with current trunk and passes with r195949 reverted, at least for the GTK+ port. It should be copied to LayoutTests/editing/selection. 1165212 4 271455 aplazas 2016-02-16 11:23:30 -0800 Created attachment 271455 Makes the test pass DISCLAIMER: This is very probably not the right thing to do, it makes the test pass though. 1165541 5 aplazas 2016-02-17 00:36:58 -0800 The problem seems to be caused by FrameSelection::modify() returning too early (in the added section) and hence not performing the switch (alter) {...} bloc. 1165547 6 aplazas 2016-02-17 00:44:14 -0800 I'm not sure how to fix this properly though, any help is welcome. 1165624 7 d_russell 2016-02-17 10:36:41 -0800 In the event that shouldNotify is true and the early return would kick in, I'd expect the position to be isNull() == true and the code path would have bailed early on the follow isNull() check, but if you have a case where that's not true, we should be able to adjust accordingly. Probably by moving the if (shouldNotify...) farther down when position isn't null. 1166723 8 271455 mcatanzaro 2016-02-20 07:41:51 -0800 Comment on attachment 271455 Makes the test pass I think this requires further investigation. 1166993 9 cgarcia 2016-02-22 05:02:56 -0800 The thing is why we are returning early in case of notifying the AT about the selection change. I guess we are assuming that reaching a boundary means that there won't be a selection change. Also, why aren't we also notifying when reaching a boundary in case of character granularity? 1166994 10 271916 cgarcia 2016-02-22 05:08:34 -0800 Created attachment 271916 Test case as a patch Just to check Mac behavior in EWS. 1167008 11 cgarcia 2016-02-22 06:03:33 -0800 Ok, so it seems to pass in Mac, I don't understand why, though. 1167011 12 271920 cgarcia 2016-02-22 06:09:00 -0800 Created attachment 271920 Patch This patch fixes the problem for GTK+, and hopefully doesn't break Mac. 1167070 13 d_russell 2016-02-22 10:20:32 -0800 This change looks sensible and as long it doesn't break the mac tests I'm on board. 1167128 14 271920 mcatanzaro 2016-02-22 12:06:29 -0800 Comment on attachment 271920 Patch OK then, I was waiting for Doug to comment. :) Thanks for the investigation, Adrian! 1167754 15 cgarcia 2016-02-24 02:41:15 -0800 Committed r197024: <http://trac.webkit.org/changeset/197024> 270981 2016-02-10 00:48:30 -0800 2016-02-22 05:08:34 -0800 Test move-to-line-boundary-clear-selection.html text/html 772 cgarcia PCFET0NUWVBFIGh0bWw+Cjxib2R5Pgo8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2pzLXRl c3QtcHJlLmpzIj48L3NjcmlwdD4KPHByZSBpZD0iY29uc29sZSI+PC9wcmU+CjxzY3JpcHQ+CmZ1 bmN0aW9uIGxvZyhzKSB7CiAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiY29uc29sZSIpLmlu bmVySFRNTCArPSBzICsgIlxuIjsKfQoKPC9zY3JpcHQ+CjxkaXYgY29udGVudGVkaXRhYmxlPjxz cGFuIGlkPSJzcGFuIj53ZWJraXQ8L3NwYW4+PC9kaXY+CjxzY3JpcHQ+CnZhciBzcGFuID0gZG9j dW1lbnQuZ2V0RWxlbWVudEJ5SWQoInNwYW4iKTsKZ2V0U2VsZWN0aW9uKCkuc2V0UG9zaXRpb24o c3BhbiwgMCk7CmdldFNlbGVjdGlvbigpLm1vZGlmeSgiZXh0ZW5kIiwgImZvcndhcmQiLCAibGlu ZSIpOwppZiAod2luZG93LnRlc3RSdW5uZXIpCiAgICB0ZXN0UnVubmVyLmV4ZWNDb21tYW5kKCJN b3ZlVG9FbmRPZkxpbmUiKTsKc2hvdWxkQmUoJ2dldFNlbGVjdGlvbigpLnRvU3RyaW5nKCknLCAi JyciKTsKZ2V0U2VsZWN0aW9uKCkuZW1wdHkoKTsKZ2V0U2VsZWN0aW9uKCkuc2V0UG9zaXRpb24o c3BhbiwgNSk7CmdldFNlbGVjdGlvbigpLm1vZGlmeSgiZXh0ZW5kIiwgImJhY2t3YXJkIiwgImxp bmUiKTsKaWYgKHdpbmRvdy50ZXN0UnVubmVyKQogICAgdGVzdFJ1bm5lci5leGVjQ29tbWFuZCgi TW92ZVRvQmVnaW5uaW5nT2ZMaW5lIik7CnNob3VsZEJlKCdnZXRTZWxlY3Rpb24oKS50b1N0cmlu ZygpJywgIicnIik7Cjwvc2NyaXB0Pgo8L2JvZHk+Cg== 271455 2016-02-16 11:23:30 -0800 2016-02-22 06:09:00 -0800 Makes the test pass patch text/plain 690 aplazas ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRnJhbWVTZWxlY3Rpb24uY3BwIGIv U291cmNlL1dlYkNvcmUvZWRpdGluZy9GcmFtZVNlbGVjdGlvbi5jcHAKaW5kZXggZWVkOTZmYi4u MzZlOGMwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9GcmFtZVNlbGVjdGlv bi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9GcmFtZVNlbGVjdGlvbi5jcHAKQEAg LTEyODUsNyArMTI4NSw5IEBAIGJvb2wgRnJhbWVTZWxlY3Rpb246Om1vZGlmeShFQWx0ZXJhdGlv biBhbHRlciwgU2VsZWN0aW9uRGlyZWN0aW9uIGRpcmVjdGlvbiwgVGV4CiAgICAgCiAgICAgaWYg KHNob3VsZE5vdGlmeSAmJiB1c2VyVHJpZ2dlcmVkID09IFVzZXJUcmlnZ2VyZWQgJiYgbV9mcmFt ZSAmJiBBWE9iamVjdENhY2hlOjphY2Nlc3NpYmlsaXR5RW5hYmxlZCgpKSB7CiAgICAgICAgIG5v dGlmeUFjY2Vzc2liaWxpdHlGb3JTZWxlY3Rpb25DaGFuZ2UoeyBBWFRleHRTdGF0ZUNoYW5nZVR5 cGVTZWxlY3Rpb25Cb3VuZGFyeSwgdGV4dFNlbGVjdGlvbldpdGhEaXJlY3Rpb25BbmRHcmFudWxh cml0eShkaXJlY3Rpb24sIGdyYW51bGFyaXR5KSB9KTsKKyNpZiAhUExBVEZPUk0oR1RLKQogICAg ICAgICByZXR1cm4gdHJ1ZTsKKyNlbmRpZgogICAgIH0KIAogICAgIGlmIChwb3NpdGlvbi5pc051 bGwoKSkK 271916 2016-02-22 05:08:34 -0800 2016-02-22 06:09:00 -0800 Test case as a patch move-to-line-boundary-clear-selection.diff text/plain 2091 cgarcia ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA3YTc4MjA1Li5hNTVkMzQ3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTAgQEAKKzIwMTYtMDIt MjIgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAg IFVucmV2aWV3ZWQuIEFkZCB0ZXN0IGZvciBidWcgIzE1Mzc0Ny4KKworICAgICAgICAqIGVkaXRp bmcvc2VsZWN0aW9uL21vdmUtdG8tbGluZS1ib3VuZGFyeS1jbGVhci1zZWxlY3Rpb24tZXhwZWN0 ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBlZGl0aW5nL3NlbGVjdGlvbi9tb3ZlLXRvLWxpbmUt Ym91bmRhcnktY2xlYXItc2VsZWN0aW9uLmh0bWw6IEFkZGVkLgorCiAyMDE2LTAyLTIyICBNYW51 ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtjc3MtZ3Jp ZF0gU3dhcCBjb2x1bW5zIGFuZCByb3dzIGluIGdyaWQgc2hvcnRoYW5kCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9tb3ZlLXRvLWxpbmUtYm91bmRhcnktY2xlYXIt c2VsZWN0aW9uLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL21v dmUtdG8tbGluZS1ib3VuZGFyeS1jbGVhci1zZWxlY3Rpb24tZXhwZWN0ZWQudHh0Cm5ldyBmaWxl IG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjZkNTQ3MzUKLS0tIC9kZXYvbnVsbAorKysgYi9M YXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9tb3ZlLXRvLWxpbmUtYm91bmRhcnktY2xlYXIt c2VsZWN0aW9uLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDMgQEAKK1BBU1MgZ2V0U2VsZWN0aW9u KCkudG9TdHJpbmcoKSBpcyAnJworUEFTUyBnZXRTZWxlY3Rpb24oKS50b1N0cmluZygpIGlzICcn Cit3ZWJraXQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL21vdmUt dG8tbGluZS1ib3VuZGFyeS1jbGVhci1zZWxlY3Rpb24uaHRtbCBiL0xheW91dFRlc3RzL2VkaXRp bmcvc2VsZWN0aW9uL21vdmUtdG8tbGluZS1ib3VuZGFyeS1jbGVhci1zZWxlY3Rpb24uaHRtbApu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi43ODQzYjQ0Ci0tLSAvZGV2L251bGwK KysrIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vbW92ZS10by1saW5lLWJvdW5kYXJ5 LWNsZWFyLXNlbGVjdGlvbi5odG1sCkBAIC0wLDAgKzEsMjYgQEAKKzwhRE9DVFlQRSBodG1sPgor PGJvZHk+Cis8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3Nj cmlwdD4KKzxwcmUgaWQ9ImNvbnNvbGUiPjwvcHJlPgorPHNjcmlwdD4KK2Z1bmN0aW9uIGxvZyhz KSB7CisgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImNvbnNvbGUiKS5pbm5lckhUTUwgKz0g cyArICJcbiI7Cit9CisKKzwvc2NyaXB0PgorPGRpdiBjb250ZW50ZWRpdGFibGU+PHNwYW4gaWQ9 InNwYW4iPndlYmtpdDwvc3Bhbj48L2Rpdj4KKzxzY3JpcHQ+Cit2YXIgc3BhbiA9IGRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCJzcGFuIik7CitnZXRTZWxlY3Rpb24oKS5zZXRQb3NpdGlvbihzcGFu LCAwKTsKK2dldFNlbGVjdGlvbigpLm1vZGlmeSgiZXh0ZW5kIiwgImZvcndhcmQiLCAibGluZSIp OworaWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAgIHRlc3RSdW5uZXIuZXhlY0NvbW1hbmQoIk1v dmVUb0VuZE9mTGluZSIpOworc2hvdWxkQmUoJ2dldFNlbGVjdGlvbigpLnRvU3RyaW5nKCknLCAi JyciKTsKK2dldFNlbGVjdGlvbigpLmVtcHR5KCk7CitnZXRTZWxlY3Rpb24oKS5zZXRQb3NpdGlv bihzcGFuLCA1KTsKK2dldFNlbGVjdGlvbigpLm1vZGlmeSgiZXh0ZW5kIiwgImJhY2t3YXJkIiwg ImxpbmUiKTsKK2lmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICB0ZXN0UnVubmVyLmV4ZWNDb21t YW5kKCJNb3ZlVG9CZWdpbm5pbmdPZkxpbmUiKTsKK3Nob3VsZEJlKCdnZXRTZWxlY3Rpb24oKS50 b1N0cmluZygpJywgIicnIik7Cis8L3NjcmlwdD4KKzwvYm9keT4K 271920 2016-02-22 06:09:00 -0800 2016-02-22 12:06:29 -0800 Patch wcore-move-to-line-end.diff text/plain 5675 cgarcia ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA3YTc4MjA1Li45ZjYwZjA0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTYtMDIt MjIgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAg IFJFR1JFU1NJT04ocjE5NTk0OSk6IFtHVEtdIFRlc3QgL3dlYmtpdDIvV2ViS2l0V2ViVmlldy9p bnNlcnQvbGluayBpcyBmYWlsaW5nIHNpbmNlIHIxOTU5NDkKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1Mzc0NworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCB0ZXN0IHRvIGNoZWNrIHRoYXQgbW92aW5n IHRvIGxpbmUgYm91bmRhcnkgY2xlYXJzIHRoZQorICAgICAgICBzZWxlY3Rpb24gZXZlbiBpZiB0 aGUgY3Vyc29yIGlzIGFscmVhZHkgYXQgdGhlIGJvdW5kYXJ5LgorCisgICAgICAgICogZWRpdGlu Zy9zZWxlY3Rpb24vbW92ZS10by1saW5lLWJvdW5kYXJ5LWNsZWFyLXNlbGVjdGlvbi1leHBlY3Rl ZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGVkaXRpbmcvc2VsZWN0aW9uL21vdmUtdG8tbGluZS1i b3VuZGFyeS1jbGVhci1zZWxlY3Rpb24uaHRtbDogQWRkZWQuCisKIDIwMTYtMDItMjIgIE1hbnVl bCBSZWdvIENhc2Fzbm92YXMgIDxyZWdvQGlnYWxpYS5jb20+CiAKICAgICAgICAgW2Nzcy1ncmlk XSBTd2FwIGNvbHVtbnMgYW5kIHJvd3MgaW4gZ3JpZCBzaG9ydGhhbmQKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL21vdmUtdG8tbGluZS1ib3VuZGFyeS1jbGVhci1z ZWxlY3Rpb24tZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vbW92 ZS10by1saW5lLWJvdW5kYXJ5LWNsZWFyLXNlbGVjdGlvbi1leHBlY3RlZC50eHQKbmV3IGZpbGUg bW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uNmQ1NDczNQotLS0gL2Rldi9udWxsCisrKyBiL0xh eW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL21vdmUtdG8tbGluZS1ib3VuZGFyeS1jbGVhci1z ZWxlY3Rpb24tZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMyBAQAorUEFTUyBnZXRTZWxlY3Rpb24o KS50b1N0cmluZygpIGlzICcnCitQQVNTIGdldFNlbGVjdGlvbigpLnRvU3RyaW5nKCkgaXMgJycK K3dlYmtpdApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vbW92ZS10 by1saW5lLWJvdW5kYXJ5LWNsZWFyLXNlbGVjdGlvbi5odG1sIGIvTGF5b3V0VGVzdHMvZWRpdGlu Zy9zZWxlY3Rpb24vbW92ZS10by1saW5lLWJvdW5kYXJ5LWNsZWFyLXNlbGVjdGlvbi5odG1sCm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjc4NDNiNDQKLS0tIC9kZXYvbnVsbAor KysgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9tb3ZlLXRvLWxpbmUtYm91bmRhcnkt Y2xlYXItc2VsZWN0aW9uLmh0bWwKQEAgLTAsMCArMSwyNiBAQAorPCFET0NUWVBFIGh0bWw+Cis8 Ym9keT4KKzxzY3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2Ny aXB0PgorPHByZSBpZD0iY29uc29sZSI+PC9wcmU+Cis8c2NyaXB0PgorZnVuY3Rpb24gbG9nKHMp IHsKKyAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiY29uc29sZSIpLmlubmVySFRNTCArPSBz ICsgIlxuIjsKK30KKworPC9zY3JpcHQ+Cis8ZGl2IGNvbnRlbnRlZGl0YWJsZT48c3BhbiBpZD0i c3BhbiI+d2Via2l0PC9zcGFuPjwvZGl2PgorPHNjcmlwdD4KK3ZhciBzcGFuID0gZG9jdW1lbnQu Z2V0RWxlbWVudEJ5SWQoInNwYW4iKTsKK2dldFNlbGVjdGlvbigpLnNldFBvc2l0aW9uKHNwYW4s IDApOworZ2V0U2VsZWN0aW9uKCkubW9kaWZ5KCJleHRlbmQiLCAiZm9yd2FyZCIsICJsaW5lIik7 CitpZiAod2luZG93LnRlc3RSdW5uZXIpCisgICAgdGVzdFJ1bm5lci5leGVjQ29tbWFuZCgiTW92 ZVRvRW5kT2ZMaW5lIik7CitzaG91bGRCZSgnZ2V0U2VsZWN0aW9uKCkudG9TdHJpbmcoKScsICIn JyIpOworZ2V0U2VsZWN0aW9uKCkuZW1wdHkoKTsKK2dldFNlbGVjdGlvbigpLnNldFBvc2l0aW9u KHNwYW4sIDUpOworZ2V0U2VsZWN0aW9uKCkubW9kaWZ5KCJleHRlbmQiLCAiYmFja3dhcmQiLCAi bGluZSIpOworaWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAgIHRlc3RSdW5uZXIuZXhlY0NvbW1h bmQoIk1vdmVUb0JlZ2lubmluZ09mTGluZSIpOworc2hvdWxkQmUoJ2dldFNlbGVjdGlvbigpLnRv U3RyaW5nKCknLCAiJyciKTsKKzwvc2NyaXB0PgorPC9ib2R5PgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDM2YTYz NjkuLmNhMzU2M2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxNi0wMi0yMiAgQ2Fy bG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgUkVHUkVT U0lPTihyMTk1OTQ5KTogW0dUS10gVGVzdCAvd2Via2l0Mi9XZWJLaXRXZWJWaWV3L2luc2VydC9s aW5rIGlzIGZhaWxpbmcgc2luY2UgcjE5NTk0OQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUzNzQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgRG8gbm90IHJldHVybiBlYXJseSB3aGVuIHJlYWNoaW5nIGEg Ym91bmRhcnkgaWYgdGhlcmUncyBhIHJhbmdlCisgICAgICAgIHNlbGVjdGlvbi4gSW4gdGhhdCBj YXNlLCB0aGUgc2VsZWN0aW9uIHdpbGwgYmUgY2xlYXJlZCBhbmQKKyAgICAgICAgYWNjZXNzaWJp bGl0eSB3aWxsIGJlIG5vdGlmaWVkLgorCisgICAgICAgIFRlc3Q6IGVkaXRpbmcvc2VsZWN0aW9u L21vdmUtdG8tbGluZS1ib3VuZGFyeS1jbGVhci1zZWxlY3Rpb24uaHRtbAorCisgICAgICAgICog ZWRpdGluZy9GcmFtZVNlbGVjdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZVNlbGVj dGlvbjo6bW9kaWZ5KToKKwogMjAxNi0wMi0yMiAgTWFudWVsIFJlZ28gQ2FzYXNub3ZhcyAgPHJl Z29AaWdhbGlhLmNvbT4KIAogICAgICAgICBbY3NzLWdyaWRdIFN3YXAgY29sdW1ucyBhbmQgcm93 cyBpbiBncmlkIHNob3J0aGFuZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9G cmFtZVNlbGVjdGlvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0ZyYW1lU2VsZWN0aW9u LmNwcAppbmRleCBlZWQ5NmZiLi4xOTRiMDhkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9l ZGl0aW5nL0ZyYW1lU2VsZWN0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0Zy YW1lU2VsZWN0aW9uLmNwcApAQCAtMTI1MiwxNCArMTI1MiwxNCBAQCBib29sIEZyYW1lU2VsZWN0 aW9uOjptb2RpZnkoRUFsdGVyYXRpb24gYWx0ZXIsIFNlbGVjdGlvbkRpcmVjdGlvbiBkaXJlY3Rp b24sIFRleAogCiAgICAgd2lsbEJlTW9kaWZpZWQoYWx0ZXIsIGRpcmVjdGlvbik7CiAKLSAgICBi b29sIHNob3VsZE5vdGlmeSA9IGZhbHNlOworICAgIGJvb2wgcmVhY2hlZEJvdW5kYXJ5ID0gZmFs c2U7CiAgICAgYm9vbCB3YXNSYW5nZSA9IG1fc2VsZWN0aW9uLmlzUmFuZ2UoKTsKICAgICBQb3Np dGlvbiBvcmlnaW5hbFN0YXJ0UG9zaXRpb24gPSBtX3NlbGVjdGlvbi5zdGFydCgpOwogICAgIFZp c2libGVQb3NpdGlvbiBwb3NpdGlvbjsKICAgICBzd2l0Y2ggKGRpcmVjdGlvbikgewogICAgIGNh c2UgRGlyZWN0aW9uUmlnaHQ6CiAgICAgICAgIGlmIChhbHRlciA9PSBBbHRlcmF0aW9uTW92ZSkK LSAgICAgICAgICAgIHBvc2l0aW9uID0gbW9kaWZ5TW92aW5nUmlnaHQoZ3JhbnVsYXJpdHksICZz aG91bGROb3RpZnkpOworICAgICAgICAgICAgcG9zaXRpb24gPSBtb2RpZnlNb3ZpbmdSaWdodChn cmFudWxhcml0eSwgJnJlYWNoZWRCb3VuZGFyeSk7CiAgICAgICAgIGVsc2UKICAgICAgICAgICAg IHBvc2l0aW9uID0gbW9kaWZ5RXh0ZW5kaW5nUmlnaHQoZ3JhbnVsYXJpdHkpOwogICAgICAgICBi cmVhazsKQEAgLTEyNjcsMTEgKzEyNjcsMTEgQEAgYm9vbCBGcmFtZVNlbGVjdGlvbjo6bW9kaWZ5 KEVBbHRlcmF0aW9uIGFsdGVyLCBTZWxlY3Rpb25EaXJlY3Rpb24gZGlyZWN0aW9uLCBUZXgKICAg ICAgICAgaWYgKGFsdGVyID09IEFsdGVyYXRpb25FeHRlbmQpCiAgICAgICAgICAgICBwb3NpdGlv biA9IG1vZGlmeUV4dGVuZGluZ0ZvcndhcmQoZ3JhbnVsYXJpdHkpOwogICAgICAgICBlbHNlCi0g ICAgICAgICAgICBwb3NpdGlvbiA9IG1vZGlmeU1vdmluZ0ZvcndhcmQoZ3JhbnVsYXJpdHksICZz aG91bGROb3RpZnkpOworICAgICAgICAgICAgcG9zaXRpb24gPSBtb2RpZnlNb3ZpbmdGb3J3YXJk KGdyYW51bGFyaXR5LCAmcmVhY2hlZEJvdW5kYXJ5KTsKICAgICAgICAgYnJlYWs7CiAgICAgY2Fz ZSBEaXJlY3Rpb25MZWZ0OgogICAgICAgICBpZiAoYWx0ZXIgPT0gQWx0ZXJhdGlvbk1vdmUpCi0g ICAgICAgICAgICBwb3NpdGlvbiA9IG1vZGlmeU1vdmluZ0xlZnQoZ3JhbnVsYXJpdHksICZzaG91 bGROb3RpZnkpOworICAgICAgICAgICAgcG9zaXRpb24gPSBtb2RpZnlNb3ZpbmdMZWZ0KGdyYW51 bGFyaXR5LCAmcmVhY2hlZEJvdW5kYXJ5KTsKICAgICAgICAgZWxzZQogICAgICAgICAgICAgcG9z aXRpb24gPSBtb2RpZnlFeHRlbmRpbmdMZWZ0KGdyYW51bGFyaXR5KTsKICAgICAgICAgYnJlYWs7 CkBAIC0xMjc5LDExICsxMjc5LDExIEBAIGJvb2wgRnJhbWVTZWxlY3Rpb246Om1vZGlmeShFQWx0 ZXJhdGlvbiBhbHRlciwgU2VsZWN0aW9uRGlyZWN0aW9uIGRpcmVjdGlvbiwgVGV4CiAgICAgICAg IGlmIChhbHRlciA9PSBBbHRlcmF0aW9uRXh0ZW5kKQogICAgICAgICAgICAgcG9zaXRpb24gPSBt b2RpZnlFeHRlbmRpbmdCYWNrd2FyZChncmFudWxhcml0eSk7CiAgICAgICAgIGVsc2UKLSAgICAg ICAgICAgIHBvc2l0aW9uID0gbW9kaWZ5TW92aW5nQmFja3dhcmQoZ3JhbnVsYXJpdHksICZzaG91 bGROb3RpZnkpOworICAgICAgICAgICAgcG9zaXRpb24gPSBtb2RpZnlNb3ZpbmdCYWNrd2FyZChn cmFudWxhcml0eSwgJnJlYWNoZWRCb3VuZGFyeSk7CiAgICAgICAgIGJyZWFrOwogICAgIH0KLSAg ICAKLSAgICBpZiAoc2hvdWxkTm90aWZ5ICYmIHVzZXJUcmlnZ2VyZWQgPT0gVXNlclRyaWdnZXJl ZCAmJiBtX2ZyYW1lICYmIEFYT2JqZWN0Q2FjaGU6OmFjY2Vzc2liaWxpdHlFbmFibGVkKCkpIHsK KworICAgIGlmIChyZWFjaGVkQm91bmRhcnkgJiYgIWlzUmFuZ2UoKSAmJiB1c2VyVHJpZ2dlcmVk ID09IFVzZXJUcmlnZ2VyZWQgJiYgbV9mcmFtZSAmJiBBWE9iamVjdENhY2hlOjphY2Nlc3NpYmls aXR5RW5hYmxlZCgpKSB7CiAgICAgICAgIG5vdGlmeUFjY2Vzc2liaWxpdHlGb3JTZWxlY3Rpb25D aGFuZ2UoeyBBWFRleHRTdGF0ZUNoYW5nZVR5cGVTZWxlY3Rpb25Cb3VuZGFyeSwgdGV4dFNlbGVj dGlvbldpdGhEaXJlY3Rpb25BbmRHcmFudWxhcml0eShkaXJlY3Rpb24sIGdyYW51bGFyaXR5KSB9 KTsKICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgfQo=