153741 2016-02-01 05:57:29 -0800 REGRESSION(r195899): ASSERTION FAILED: is<Target>(source) in EventPath::retargetTouch() since r195899 2016-02-02 08:16:45 -0800 1 1 1 Unclassified WebKit UI Events WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk, LayoutTestFailure, Regression P2 Normal --- 1 cgarcia webkit-unassigned cdumez clopez commit-queue esprehn+autocc kangil.han koivisto rniwa oldest_to_newest 1160829 0 cgarcia 2016-02-01 05:57:29 -0800 Several touch tests are crashing do to an assert in the GTK+ debug bot since r195899. It seems to be caused by an incorrect cast. STDERR: ASSERTION FAILED: is<Target>(source) STDERR: ../../Source/WTF/wtf/TypeCasts.h(80) : typename WTF::match_constness<Source, Target>::type& WTF::downcast(Source&) [with Target = WebCore::MouseOrFocusEventContext; Source = WebCore::EventContext; typename WTF::match_constness<Source, Target>::type = WebCore::MouseOrFocusEventContext] STDERR: 1 0x7ff5fc7fb68c /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(WTFCrashWithSecurityImplication+0x1e) [0x7ff5fc7fb68c] STDERR: 2 0x7ff603423954 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WTF::match_constness<WebCore::EventContext, WebCore::MouseOrFocusEventContext>::type& WTF::downcast<WebCore::MouseOrFocusEventContext, WebCore::EventContext>(WebCore::EventContext&)+0x43) [0x7ff603423954] STDERR: 3 0x7ff603421934 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::EventPath::retargetTouch(WebCore::TouchEventContext::TouchListType, WebCore::Touch const&)+0x8e) [0x7ff603421934] STDERR: 4 0x7ff603421b6f /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::EventPath::retargetTouchLists(WebCore::TouchEvent const&)+0x61) [0x7ff603421b6f] STDERR: 5 0x7ff603420a67 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::EventDispatcher::dispatchEvent(WebCore::Node*, WebCore::Event&)+0x167) [0x7ff603420a67] STDERR: 6 0x7ff60346447f /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::Node::dispatchTouchEvent(WebCore::TouchEvent&)+0x23) [0x7ff60346447f] STDERR: 7 0x7ff6039e31a0 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::EventHandler::handleTouchEvent(WebCore::PlatformTouchEvent const&)+0x10ee) [0x7ff6039e31a0] STDERR: 8 0x7ff602b2736d /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(+0x504b36d) [0x7ff602b2736d] STDERR: 9 0x7ff602b273fa /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebKit::WebPage::touchEvent(WebKit::WebTouchEvent const&)+0x5a) [0x7ff602b273fa] STDERR: 10 0x7ff602d3f96c /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(void IPC::callMemberFunctionImpl<WebKit::WebPage, void (WebKit::WebPage::*)(WebKit::WebTouchEvent const&), std::tuple<WebKit::WebTouchEvent>, 0ul>(WebKit::WebPage*, void (WebKit::WebPage::*)(WebKit::WebTouchEvent const&), std::tuple<WebKit::WebTouchEvent>&&, std::index_sequence<0ul>)+0x80) [0x7ff602d3f96c] STDERR: 11 0x7ff602d3dd54 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(void IPC::callMemberFunction<WebKit::WebPage, void (WebKit::WebPage::*)(WebKit::WebTouchEvent const&), std::tuple<WebKit::WebTouchEvent>, std::make_index_sequence<1ul> >(std::tuple<WebKit::WebTouchEvent>&&, WebKit::WebPage*, void (WebKit::WebPage::*)(WebKit::WebTouchEvent const&))+0x41) [0x7ff602d3dd54] STDERR: 12 0x7ff602d36f05 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(void IPC::handleMessage<Messages::WebPage::TouchEvent, WebKit::WebPage, void (WebKit::WebPage::*)(WebKit::WebTouchEvent const&)>(IPC::MessageDecoder&, WebKit::WebPage*, void (WebKit::WebPage::*)(WebKit::WebTouchEvent const&))+0xa3) [0x7ff602d36f05] STDERR: 13 0x7ff602d32069 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebKit::WebPage::didReceiveWebPageMessage(IPC::Connection&, IPC::MessageDecoder&)+0x6b5) [0x7ff602d32069] STDERR: 14 0x7ff602b2c896 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebKit::WebPage::didReceiveMessage(IPC::Connection&, IPC::MessageDecoder&)+0x18a) [0x7ff602b2c896] STDERR: 15 0x7ff60279c59c /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::MessageDecoder&)+0x120) [0x7ff60279c59c] STDERR: 16 0x7ff6029be846 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebKit::WebProcess::didReceiveMessage(IPC::Connection&, IPC::MessageDecoder&)+0x4c) [0x7ff6029be846] STDERR: 17 0x7ff602789bd0 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(IPC::Connection::dispatchMessage(IPC::MessageDecoder&)+0x3a) [0x7ff602789bd0] STDERR: 18 0x7ff602789d33 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(IPC::Connection::dispatchMessage(std::unique_ptr<IPC::MessageDecoder, std::default_delete<IPC::MessageDecoder> >)+0x161) [0x7ff602789d33] STDERR: 19 0x7ff602785412 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(IPC::Connection::SyncMessageState::dispatchMessages(IPC::Connection*)+0x158) [0x7ff602785412] STDERR: 20 0x7ff60278976c /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(IPC::Connection::dispatchSyncMessage(IPC::MessageDecoder&)+0x27e) [0x7ff60278976c] STDERR: 21 0x7ff602789d13 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(IPC::Connection::dispatchMessage(std::unique_ptr<IPC::MessageDecoder, std::default_delete<IPC::MessageDecoder> >)+0x141) [0x7ff602789d13] STDERR: 22 0x7ff602785412 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(IPC::Connection::SyncMessageState::dispatchMessages(IPC::Connection*)+0x158) [0x7ff602785412] STDERR: 23 0x7ff60278779a /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(IPC::Connection::waitForSyncReply(unsigned long, std::chrono::duration<long, std::ratio<1l, 1000l> >, unsigned int)+0x86) [0x7ff60278779a] STDERR: 24 0x7ff602787225 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(IPC::Connection::sendSyncMessage(unsigned long, std::unique_ptr<IPC::MessageEncoder, std::default_delete<IPC::MessageEncoder> >, std::chrono::duration<long, std::ratio<1l, 1000l> >, unsigned int)+0x265) [0x7ff602787225] STDERR: 25 0x7ff602b446ea /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(bool IPC::Connection::sendSync<Messages::WebPageProxy::HandleSynchronousMessage>(Messages::WebPageProxy::HandleSynchronousMessage&&, Messages::WebPageProxy::HandleSynchronousMessage::Reply&&, unsigned long, std::chrono::duration<long, std::ratio<1l, 1000l> >, unsigned int)+0xf2) [0x7ff602b446ea] STDERR: 26 0x7ff602b408de /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(bool IPC::MessageSender::sendSync<Messages::WebPageProxy::HandleSynchronousMessage>(Messages::WebPageProxy::HandleSynchronousMessage&&, Messages::WebPageProxy::HandleSynchronousMessage::Reply&&, unsigned long, std::chrono::duration<long, std::ratio<1l, 1000l> >, unsigned int)+0xba) [0x7ff602b408de] STDERR: 27 0x7ff602b3a014 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(bool IPC::MessageSender::sendSync<Messages::WebPageProxy::HandleSynchronousMessage>(Messages::WebPageProxy::HandleSynchronousMessage&&, Messages::WebPageProxy::HandleSynchronousMessage::Reply&&, std::chrono::duration<long, std::ratio<1l, 1000l> >, unsigned int)+0x76) [0x7ff602b3a014] STDERR: 28 0x7ff602b2fe53 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebKit::WebPage::postSynchronousMessageForTesting(WTF::String const&, API::Object*, WTF::RefPtr<API::Object>&)+0xb3) [0x7ff602b2fe53] STDERR: 29 0x7ff602a2c80b /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WKBundlePagePostSynchronousMessageForTesting+0x7d) [0x7ff602a2c80b] STDERR: 30 0x7ff5a8432790 /home/slave/webkitgtk/gtk-linux-64-debug-tests/build/WebKitBuild/Debug/lib/libTestRunnerInjectedBundle.so(WTR::EventSendingController::touchStart()+0x106) [0x7ff5a8432790] STDERR: 31 0x7ff5a845fe4c /home/slave/webkitgtk/gtk-linux-64-debug-tests/build/WebKitBuild/Debug/lib/libTestRunnerInjectedBundle.so(WTR::JSEventSendingController::touchStart(OpaqueJSContext const*, OpaqueJSValue*, OpaqueJSValue*, unsigned long, OpaqueJSValue const* const*, OpaqueJSValue const**)+0x58) [0x7ff5a845fe4c] 1160835 1 270384 aplazas 2016-02-01 06:30:14 -0800 Created attachment 270384 Fix an EventContext downcast. 1160848 2 270384 mcatanzaro 2016-02-01 08:01:09 -0800 Comment on attachment 270384 Fix an EventContext downcast. I didn't look closely at this, but I'm suspicious that there is a downcast there if the result of the downcast can be changed without breaking the build.... 1160852 3 cgarcia 2016-02-01 08:34:05 -0800 (In reply to comment #2) > Comment on attachment 270384 [details] > Fix an EventContext downcast. > > I didn't look closely at this, but I'm suspicious that there is a downcast > there if the result of the downcast can be changed without breaking the > build.... MouseOrFocusEventContext also derives from EventContext, so the cast is valid form the compiler point of view. That's why we have the type traits thing to check the cast is valid at runtime. It ended up calling EventContext::isMouseOrFocusEventContext() that return false, because the concrete type in this case is TouchEventContext. 1160880 4 cgarcia 2016-02-01 09:27:55 -0800 (In reply to comment #3) > (In reply to comment #2) > > Comment on attachment 270384 [details] > > Fix an EventContext downcast. > > > > I didn't look closely at this, but I'm suspicious that there is a downcast > > there if the result of the downcast can be changed without breaking the > > build.... > > MouseOrFocusEventContext also derives from EventContext, so the cast is > valid form the compiler point of view. That's why we have the type traits > thing to check the cast is valid at runtime. It ended up calling > EventContext::isMouseOrFocusEventContext() that return false, because the > concrete type in this case is TouchEventContext. But it's true that we are using EventContext::node(), and *m_path[0] is already an EventContext, so we don't even need the downcast, I would say. 1160932 5 270384 mcatanzaro 2016-02-01 10:27:18 -0800 Comment on attachment 270384 Fix an EventContext downcast. Let's try getting rid of the downcast! 1161219 6 270476 aplazas 2016-02-01 23:38:38 -0800 Created attachment 270476 Remove wrong and useless downcast to MouseOrFocusEventContext 1161270 7 270476 commit-queue 2016-02-02 08:16:38 -0800 Comment on attachment 270476 Remove wrong and useless downcast to MouseOrFocusEventContext Clearing flags on attachment: 270476 Committed r196009: <http://trac.webkit.org/changeset/196009> 1161271 8 commit-queue 2016-02-02 08:16:45 -0800 All reviewed patches have been landed. Closing bug. 270384 2016-02-01 06:30:14 -0800 2016-02-01 23:37:12 -0800 Fix an EventContext downcast. patch text/plain 1363 aplazas ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1NWEzOTdkLi5mOWMzY2JkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTYtMDItMDEgIEFkcmllbiBQbGF6YXMgIDxhcGxhemFzQGlnYWxpYS5jb20+CisKKyAg ICAgICAgUkVHUkVTU0lPTihyMTk1ODk5KTogQVNTRVJUSU9OIEZBSUxFRDogaXM8VGFyZ2V0Pihz b3VyY2UpIGluIEV2ZW50UGF0aDo6cmV0YXJnZXRUb3VjaCgpIHNpbmNlIHIxOTU4OTkKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1Mzc0MQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZG9tL0V2ZW50RGlz cGF0Y2hlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFdmVudFBhdGg6OnJldGFyZ2V0VG91Y2gp OgorCiAyMDE2LTAyLTAxICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24u ZnI+CiAKICAgICAgICAgW0ZldGNoIEFQSV0gSW1wbGVtZW50IEZldGNoIEFQSSBSZXF1ZXN0CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnREaXNwYXRjaGVyLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2RvbS9FdmVudERpc3BhdGNoZXIuY3BwCmluZGV4IDNkNzhlNmUuLjU0NGMwNDEg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FdmVudERpc3BhdGNoZXIuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2RvbS9FdmVudERpc3BhdGNoZXIuY3BwCkBAIC01NDksNyArNTQ5LDcg QEAgdm9pZCBFdmVudFBhdGg6OnJldGFyZ2V0VG91Y2goVG91Y2hFdmVudENvbnRleHQ6OlRvdWNo TGlzdFR5cGUgdG91Y2hMaXN0VHlwZSwgY28KICAgICBpZiAoIXRhcmdldE5vZGUpCiAgICAgICAg IHJldHVybjsKIAotICAgIFJlbGF0ZWROb2RlUmV0YXJnZXRlciByZXRhcmdldGVyKCp0YXJnZXRO b2RlLCBkb3duY2FzdDxNb3VzZU9yRm9jdXNFdmVudENvbnRleHQ+KCptX3BhdGhbMF0pLm5vZGUo KS0+dHJlZVNjb3BlKCkpOworICAgIFJlbGF0ZWROb2RlUmV0YXJnZXRlciByZXRhcmdldGVyKCp0 YXJnZXROb2RlLCBkb3duY2FzdDxUb3VjaEV2ZW50Q29udGV4dD4oKm1fcGF0aFswXSkubm9kZSgp LT50cmVlU2NvcGUoKSk7CiAgICAgVHJlZVNjb3BlKiBwcmV2aW91c1RyZWVTY29wZSA9IG51bGxw dHI7CiAgICAgZm9yIChhdXRvJiBjb250ZXh0IDogbV9wYXRoKSB7CiAgICAgICAgIFRyZWVTY29w ZSYgY3VycmVudFRyZWVTY29wZSA9IGNvbnRleHQtPm5vZGUoKS0+dHJlZVNjb3BlKCk7Cg== 270476 2016-02-01 23:38:38 -0800 2016-02-02 08:16:38 -0800 Remove wrong and useless downcast to MouseOrFocusEventContext patch text/plain 1341 aplazas ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzZDUwNzAwLi5kMTU2NzVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTYtMDItMDEgIEFkcmllbiBQbGF6YXMgIDxhcGxhemFzQGlnYWxpYS5jb20+CisKKyAg ICAgICAgUkVHUkVTU0lPTihyMTk1ODk5KTogQVNTRVJUSU9OIEZBSUxFRDogaXM8VGFyZ2V0Pihz b3VyY2UpIGluIEV2ZW50UGF0aDo6cmV0YXJnZXRUb3VjaCgpIHNpbmNlIHIxOTU4OTkKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1Mzc0MQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZG9tL0V2ZW50RGlz cGF0Y2hlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFdmVudFBhdGg6OnJldGFyZ2V0VG91Y2gp OgorCiAyMDE2LTAyLTAxICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAK ICAgICAgICAgV2ViIEluc3BlY3RvcjogSGlnaCBMZXZlbCBNZW1vcnkgT3ZlcnZpZXcgSW5zdHJ1 bWVudApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50RGlzcGF0Y2hlci5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnREaXNwYXRjaGVyLmNwcAppbmRleCAzZDc4ZTZlLi4z ZjEwZmQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnREaXNwYXRjaGVyLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnREaXNwYXRjaGVyLmNwcApAQCAtNTQ5LDcg KzU0OSw3IEBAIHZvaWQgRXZlbnRQYXRoOjpyZXRhcmdldFRvdWNoKFRvdWNoRXZlbnRDb250ZXh0 OjpUb3VjaExpc3RUeXBlIHRvdWNoTGlzdFR5cGUsIGNvCiAgICAgaWYgKCF0YXJnZXROb2RlKQog ICAgICAgICByZXR1cm47CiAKLSAgICBSZWxhdGVkTm9kZVJldGFyZ2V0ZXIgcmV0YXJnZXRlcigq dGFyZ2V0Tm9kZSwgZG93bmNhc3Q8TW91c2VPckZvY3VzRXZlbnRDb250ZXh0PigqbV9wYXRoWzBd KS5ub2RlKCktPnRyZWVTY29wZSgpKTsKKyAgICBSZWxhdGVkTm9kZVJldGFyZ2V0ZXIgcmV0YXJn ZXRlcigqdGFyZ2V0Tm9kZSwgbV9wYXRoWzBdLT5ub2RlKCktPnRyZWVTY29wZSgpKTsKICAgICBU cmVlU2NvcGUqIHByZXZpb3VzVHJlZVNjb3BlID0gbnVsbHB0cjsKICAgICBmb3IgKGF1dG8mIGNv bnRleHQgOiBtX3BhdGgpIHsKICAgICAgICAgVHJlZVNjb3BlJiBjdXJyZW50VHJlZVNjb3BlID0g Y29udGV4dC0+bm9kZSgpLT50cmVlU2NvcGUoKTsK