153719 2016-01-30 15:49:50 -0800 Debug build fails to link due to missing implementation of WebCore::Frame::isMainFrame() 2016-01-30 17:16:01 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jeremyhu webkit-unassigned commit-queue esprehn+autocc glenn kondapallykalyan oldest_to_newest 1160556 0 jeremyhu 2016-01-30 15:49:50 -0800 When building the debug configuration, libwebkit2gtk fails to link with: :info:build Undefined symbols for architecture x86_64: :info:build "WebCore::Frame::isMainFrame() const", referenced from: :info:build WebCore::printRenderTreeForLiveDocuments() in libWebCoreGTK.a(RenderObject.cpp.o) :info:build ld: symbol(s) not found for architecture x86_64 :info:build clang: error: linker command failed with exit code 1 (use -v to see invocation) :info:build make[2]: *** [lib/libwebkit2gtk-4.0.37.13.1.dylib] Error 1 The function is only present in debug builds, so it's certainly no surprise that the release build compiles fine: #ifndef NDEBUG void printRenderTreeForLiveDocuments() { for (const auto* document : Document::allDocuments()) { if (!document->renderView() || document->inPageCache()) continue; if (document->frame() && document->frame()->isMainFrame()) fprintf(stderr, "----------------------main frame--------------------------\n"); fprintf(stderr, "%s", document->url().string().utf8().data()); showRenderTree(document->renderView()); } } #endif } // namespace WebCore This was observed on OSX with webkitgtk-2.11.4 configured as: cmake -DCMAKE_INSTALL_PREFIX=/opt/local -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_COLOR_MAKEFILE=ON -DCMAKE_BUILD_TYPE=Debug -DCMAKE_BUILD_WITH_INSTALL_RPATH=ON -DCMAKE_INSTALL_RPATH=/opt/local/lib -DCMAKE_INSTALL_NAME_DIR=/opt/local/lib -DCMAKE_SYSTEM_PREFIX_PATH="/opt/local;/usr" -DCMAKE_MODULE_PATH=/opt/local/share/cmake/Modules -DCMAKE_FIND_FRAMEWORK=LAST -Wno-dev -DPORT=GTK -DUSE_SYSTEM_MALLOC=ON -DENABLE_MINIBROWSER=OFF -DENABLE_VIDEO=ON -DENABLE_INTROSPECTION=OFF -DLLVM_CONFIG_EXE=/opt/local/bin/llvm-config-mp-3.7 -DENABLE_QUARTZ_TARGET=OFF -DENABLE_X11_TARGET=ON -DENABLE_OPENGL=ON -DENABLE_PLUGIN_PROCESS_GTK2=ON -DCMAKE_C_FLAGS_RELEASE="-DNDEBUG" -DCMAKE_CXX_FLAGS_RELEASE="-DNDEBUG" -DCMAKE_OSX_ARCHITECTURES="x86_64" -DCMAKE_OSX_DEPLOYMENT_TARGET="10.11" -DCMAKE_OSX_SYSROOT="/" 1160558 1 jeremyhu 2016-01-30 15:59:39 -0800 I suspect this is just a missing include of MainFrame.h. Testing that out now. 1160559 2 270324 jeremyhu 2016-01-30 16:03:57 -0800 Created attachment 270324 patch 1160591 3 270324 commit-queue 2016-01-30 17:15:58 -0800 Comment on attachment 270324 patch Clearing flags on attachment: 270324 Committed r195918: <http://trac.webkit.org/changeset/195918> 1160592 4 commit-queue 2016-01-30 17:16:01 -0800 All reviewed patches have been landed. Closing bug. 270324 2016-01-30 16:03:57 -0800 2016-01-30 17:15:58 -0800 patch 0001-WebCore-Add-missing-include-to-fix-building-debug-co.patch text/plain 1472 jeremyhu RnJvbSBkYzlkYmQ0ODA3NzU4ZjI4NTQ2NWY1NjJmOTk1ZTdmODJhMDM1NzgyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKZXJlbXkgSHVkZGxlc3RvbiBTZXF1b2lhIDxqZXJlbXlodUBh cHBsZS5jb20+CkRhdGU6IFNhdCwgMzAgSmFuIDIwMTYgMTU6NTc6MzQgLTA4MDAKU3ViamVjdDog W1BBVENIXSBXZWJDb3JlOiBBZGQgbWlzc2luZyBpbmNsdWRlIHRvIGZpeCBidWlsZGluZyBkZWJ1 ZwogY29uZmlndXJhdGlvbgoKU2lnbmVkLW9mZi1ieTogSmVyZW15IEh1ZGRsZXN0b24gU2VxdW9p YSA8amVyZW15aHVAYXBwbGUuY29tPgotLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAg ICAgICAgICAgICAgIHwgMTEgKysrKysrKysrKysKIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJPYmplY3QuY3BwIHwgIDEgKwogMiBmaWxlcyBjaGFuZ2VkLCAxMiBpbnNlcnRpb25zKCsp CgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCmluZGV4IDdhMTA2ZTIuLjEzZWFhOWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx NCBAQAorMjAxNi0wMS0zMCAgSmVyZW15IEh1ZGRsZXN0b24gU2VxdW9pYSAgPGplcmVteWh1QGFw cGxlLmNvbT4KKworICAgICAgICBBZGQgbWlzc2luZyBpbmNsdWRlIHRvIGZpeCBidWlsZGluZyBk ZWJ1ZyBjb25maWd1cmF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNTM3MTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBObyBuZXcgdGVzdHMuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyT2Jq ZWN0LmNwcDoKKwogMjAxNi0wMS0xNiAgTXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4ZmllbGRAYXBw bGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBUZXh0UnVuOjphbGxvd3NSb3VuZGluZ0hhY2tzKCkK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuY3BwIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAKaW5kZXggOGM1OGQzMy4u NTRiMjhiOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVj dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAKQEAg LTQ1LDYgKzQ1LDcgQEAKICNpbmNsdWRlICJIaXRUZXN0UmVzdWx0LmgiCiAjaW5jbHVkZSAiTG9n Z2luZy5oIgogI2luY2x1ZGUgIkxvZ2ljYWxTZWxlY3Rpb25PZmZzZXRDYWNoZXMuaCIKKyNpbmNs dWRlICJNYWluRnJhbWUuaCIKICNpbmNsdWRlICJQYWdlLmgiCiAjaW5jbHVkZSAiUHNldWRvRWxl bWVudC5oIgogI2luY2x1ZGUgIlJlbmRlckNvdW50ZXIuaCIKLS0gCjIuNy4wCgo=