153709 2016-01-30 09:00:54 -0800 [GTK] http/tests/cache/disk-cache/disk-cache-disable.html is failing 2019-11-27 04:19:06 -0800 1 1 1 Unclassified WebKit WebKitGTK Other PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro webkit-unassigned bugs-noreply cdumez cgarcia csaavedra darin ggaren koivisto mcatanzaro zimmermann oldest_to_newest 1160463 0 mcatanzaro 2016-01-30 09:00:54 -0800 http/tests/cache/disk-cache/disk-cache-disable.html is failing since r188211: --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/cache/disk-cache/disk-cache-disable-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/cache/disk-cache/disk-cache-disable-actual.txt @@ -23,11 +23,11 @@ --------Testing loads through memory cache (XHR behavior)-------- response headers: {"Cache-control":"max-age=100"} -response source: Memory cache +response source: Network --------Testing loads through memory cache (subresource behavior)-------- response headers: {"Cache-control":"max-age=100"} -response source: Memory cache +response source: Network Re-enabling cache --------Testing loads from disk cache-------- 1161250 1 cgarcia 2016-02-02 04:42:30 -0800 I can't reproduce this locally. 1161628 2 cgarcia 2016-02-03 03:18:59 -0800 I'm stupid, I didn't notice there was already an expectation for this, so it failed for me, as expected :-D 1161635 3 cgarcia 2016-02-03 04:11:27 -0800 Antti, Chris I think the bug is actually in Mac, and our results are the correct ones. The thing is that we disable also the memory cache when cache model is document viewer, but cocoa implementation doesn't. If that's the desired behavior in Mac, we can simply add our own expectations for this test. 1163717 4 cgarcia 2016-02-11 01:10:17 -0800 Could someone confirm if document viewer cache model is expected to disable also the memory cache in mac? 1163757 5 darin 2016-02-11 09:29:01 -0800 I think Geoff’s the right person to answer that question. Might take him a little time to research and refresh his memory, though. 1321840 6 csaavedra 2017-06-22 05:49:54 -0700 Gently ping about this one. 1322505 7 mcatanzaro 2017-06-23 16:52:54 -0700 Hey Geoff, if you read this, there's a question for you up above. 1593834 8 zimmermann 2019-11-27 04:19:06 -0800 According to https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/11947/steps/layout-test/logs/stdio this test passes. Will update expectations.