153694 2016-01-29 20:10:04 -0800 [JSC] IRC can coalesce the frame pointer with a Tmp that is modified 2016-02-01 15:19:35 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin commit-queue fpizlo keith_miller mark.lam msaboff saam oldest_to_newest 1160391 0 benjamin 2016-01-29 20:10:04 -0800 [JSC] IRC can coalesce the frame pointer with a Tmp that is modified 1160397 1 270288 benjamin 2016-01-29 20:44:45 -0800 Created attachment 270288 Patch 1161036 2 270288 fpizlo 2016-02-01 14:29:36 -0800 Comment on attachment 270288 Patch Can you also fix the instruction selector to always have FramePointer use GPRInfo::callFrameRegister instead of creating a new tmp and pointless moves? 1161055 3 270288 commit-queue 2016-02-01 15:19:32 -0800 Comment on attachment 270288 Patch Clearing flags on attachment: 270288 Committed r195981: <http://trac.webkit.org/changeset/195981> 1161056 4 commit-queue 2016-02-01 15:19:35 -0800 All reviewed patches have been landed. Closing bug. 270288 2016-01-29 20:44:45 -0800 2016-02-01 15:19:32 -0800 Patch bug-153694-20160129204420.patch text/plain 7714 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTk1ODM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw ZDk1OTg0Yjg1MDJmZWI4NWRmZGQ3ZmJlMDhhNWI3OWFlYTRhZTQzLi4wYmViMmRiNWVjMjc5ZmEx Yjk0OGIwODIzYTkzNjk5YmRlN2FkZmZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSw0NCBAQAorMjAxNi0wMS0yOSAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluQHdlYmtp dC5vcmc+CisKKyAgICAgICAgW0pTQ10gSVJDIGNhbiBjb2FsZXNjZSB0aGUgZnJhbWUgcG9pbnRl ciB3aXRoIGEgVG1wIHRoYXQgaXMgbW9kaWZpZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MzY5NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIExldCdzIHNheSB3ZSBoYXZlOgorICAgICAgICAgICAgTW92 ZShGUCwgVG1wMSkKKyAgICAgICAgICAgIEFkZDY0KCMxLCBUbXAxKQorCisgICAgICAgIElmIHdl IHdlcmUgdG8gY29hbGVzY2UgdGhlIE1vdmUsIHdlIHdvdWxkIG1vZGlmeSB0aGUgZnJhbWUgcG9p bnRlci4KKyAgICAgICAgV2VsbCwgdGhhdCdzIGV4YWN0bHkgd2hhdCB3YXMgaGFwcGVuaW5nIHdp dGggSVJDLgorCisgICAgICAgIFNpbmNlIHRoZSBlcGlsb2d1ZSBpcyBub3Qga25vdyB0byBBaXIg YmVmb3JlIElSQywgdGhlIGxpdmVuZXNzIGFuYWx5c2lzCisgICAgICAgIG5ldmVyIGRpc2NvdmVy cyB0aGF0IEZQIGlzIGxpdmUgd2hlbiBUbXAxIGlzIFVzZURlZiBieSBBZGQ2NC4gQWRkaW5nCisg ICAgICAgIEZQIHdvdWxkIGEgYmUgYSBwcm9ibGVtIGFueXdheSBmb3IgYSBidW5jaCBvZiByZWFz b25zLgorCisgICAgICAgIEkgdHJpZWQgdHdvIHdheXMgdG8gcHJldmVudCBJUkMgdG8gb3ZlcnJp ZGUgSVJDOgorICAgICAgICAxKSBBZGQgYW4gaW50ZXJmZXJlbmNlIGVkZ2Ugd2l0aCBGUCBmb3Ig YWxsIG5vbi1kdXBsaWNhdGlvbiBEZWZzLgorICAgICAgICAyKSBMZXQgY29hbGVzY2UoKSBrbm93 IGFib3V0IEZQIGFuZCBjb25zdHJhaW50IGFueSBjb2FsZXNjaW5nIHdpdGggYSByZS1EZWYuCisK KyAgICAgICAgVGhlIHR3byBhcmUgd2l0aGluIG1hcmdpbiBvZiBlcnJvciBmb3IgcGVyZm9ybWFu Y2UuIFRoZSBzZWNvbmQgb25lIHdhcyBjb25zaWRlcmFibHkKKyAgICAgICAgbW9yZSBjb21wbGlj YXRlZC4gVGhpcyBwYXRjaCBpbXBsZW1lbnRzIHRoZSBmaXJzdCBvbmUuCisKKyAgICAgICAgU29t ZSBleHRyYSBub3RlOgorICAgICAgICAtSXQgaXMgdmVyeSBpbXBvcnRhbnQgdG8gbm90IGluY3Jl bWVudCB0aGUgZGVncmVlIG9mIGEgVG1wIHdoZW4gbWFraW5nIGl0IGludGVyZmVyZQorICAgICAg ICAgd2l0aCBGUC4gRlAgaXMgbm90IGEgdmFsaWQgY29sb3IsIGl0IGlzIG5vdCBjb3VudGVkIGlu IHRoZSAiSyIgY29sb3JzIGNvbnNpZGVyZWQKKyAgICAgICAgIGZvciBjb2xvcmluZy4gSW5jcmVh c2luZyB0aGUgZGVncmVlIHdpdGggdGhlIGVkZ2UgdG8gRlAgd291bGQgbWFrZSBldmVyeSBzdGFn ZQorICAgICAgICAgcGVzc2ltaXN0aWMgc2luY2UgdGhlcmUgaXMgYW4gZXh0cmEgZGVncmVlIHRo YXQgY2FuIG5ldmVyIGJlIHJlbW92ZWQuCisgICAgICAgIC1JIHB1dCAiaW50ZXJmZXJlbmNlRWRn ZXMiIGFuZCAiYWRqYWNlbmN5TGlzdCIgaW4gYW4gaW5jb25zaXN0ZW50IHN0YXRlLgorICAgICAg ICAgVGhpcyBpcyBpbnRlbnRpb25hbCwgImludGVyZmVyZW5jZUVkZ2VzIiBpcyB1c2VkIHRvIHRl c3QgdGhlIGV4aXN0ZW5jZSBvZiBhbiBlZGdlLAorICAgICAgICAgImFkamFjZW5jeUxpc3QiIGlz IHVzZWQgdG8gZ28gb3ZlciBhbGwgdGhlIGVkZ2VzLiBJbiB0aGlzIGNhc2UsIHdlIGRvbid0IHdh bnQKKyAgICAgICAgIHRoZSBlZGdlIHdpdGggRlAgdG8gYmUgY29uc2lkZXJlZCB3aGVuIHBydW5p bmcgdGhlIGdyYXBoLgorCisgICAgICAgICogYjMvYWlyL0Fpckl0ZXJhdGVkUmVnaXN0ZXJDb2Fs ZXNjaW5nLmNwcDoKKyAgICAgICAgT25lIGJyYW5jaCBjb3VsZCBiZSB0cmFuc2Zvcm1lZCBpbnRv IGFuIGFzc2VydGlvbjogVG1wTGl2ZW5lc3MgaXMgdHlwZSBzcGVjaWZpYyBub3cuCisgICAgICAg ICogYjMvdGVzdGIzLmNwcDoKKyAgICAgICAgKEpTQzo6QjM6OnRlc3RPdmVycmlkZUZyYW1lUG9p bnRlcik6CisgICAgICAgIChKU0M6OkIzOjpydW4pOgorCiAyMDE2LTAxLTI5ICBBbmRyZWFzIEts aW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBTaHJpbmsgQ29kZUJsb2NrIQpkaWZm IC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2IzL2Fpci9BaXJJdGVyYXRlZFJlZ2lzdGVy Q29hbGVzY2luZy5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvYWlyL0Fpckl0ZXJhdGVk UmVnaXN0ZXJDb2FsZXNjaW5nLmNwcAppbmRleCA5OTk2Yjk5ZTRhNzBkZWU0YjI0NTIzZWEwYzE0 ZGZjYTg0ODAyNGJjLi4xNDgzNjZjZDQ0ODVhY2VkZWM1MDRjMWFjZTAzMmNiYzg1NGMzZjc5IDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvYWlyL0Fpckl0ZXJhdGVkUmVnaXN0 ZXJDb2FsZXNjaW5nLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvYWlyL0Fpckl0 ZXJhdGVkUmVnaXN0ZXJDb2FsZXNjaW5nLmNwcApAQCAtODkxLDggKzg5MSwxNCBAQCBwcml2YXRl OgogICAgICAgICAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgICAgICAgICAgCiAgICAgICAg ICAgICAgICAgZm9yIChjb25zdCBUbXAmIGxpdmVUbXAgOiBsaXZlVG1wcykgewotICAgICAgICAg ICAgICAgICAgICBpZiAobGl2ZVRtcC5pc0dQKCkgPT0gKHR5cGUgPT0gQXJnOjpHUCkpCi0gICAg ICAgICAgICAgICAgICAgICAgICBhZGRFZGdlKGFyZywgbGl2ZVRtcCk7CisgICAgICAgICAgICAg ICAgICAgIEFTU0VSVChsaXZlVG1wLmlzR1AoKSA9PSAodHlwZSA9PSBBcmc6OkdQKSk7CisgICAg ICAgICAgICAgICAgICAgIGFkZEVkZ2UoYXJnLCBsaXZlVG1wKTsKKyAgICAgICAgICAgICAgICB9 CisKKyAgICAgICAgICAgICAgICBpZiAodHlwZSA9PSBBcmc6OkdQICYmICFhcmcuaXNHUFIoKSkg eworICAgICAgICAgICAgICAgICAgICBtX2ludGVyZmVyZW5jZUVkZ2VzLmFkZChJbnRlcmZlcmVu Y2VFZGdlKAorICAgICAgICAgICAgICAgICAgICAgICAgQWJzb2x1dGVUbXBNYXBwZXI8dHlwZT46 OmFic29sdXRlSW5kZXgoVG1wKE1hY3JvQXNzZW1ibGVyOjpmcmFtZVBvaW50ZXJSZWdpc3Rlcikp LAorICAgICAgICAgICAgICAgICAgICAgICAgQWJzb2x1dGVUbXBNYXBwZXI8dHlwZT46OmFic29s dXRlSW5kZXgoYXJnKSkpOwogICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgIH0pOwogICAg IH0KQEAgLTEwNjgsOCArMTA3NCwxMyBAQCBwcml2YXRlOgogICAgICAgICAgICAgdG1wc1dpdGhJ bnRlcmZlcmVuY2VzLmFkZChBYnNvbHV0ZVRtcE1hcHBlcjx0eXBlPjo6dG1wRnJvbUFic29sdXRl SW5kZXgoZWRnZS5zZWNvbmQoKSkpOwogICAgICAgICB9CiAKLSAgICAgICAgZm9yIChjb25zdCBh dXRvJiB0bXAgOiB0bXBzV2l0aEludGVyZmVyZW5jZXMpCi0gICAgICAgICAgICBvdXQucHJpbnQo IiAgICAiLCB0bXAuaW50ZXJuYWxWYWx1ZSgpLCAiIFtsYWJlbD1cIiIsIHRtcCwgIiAoIiwgbV9k ZWdyZWVzW0Fic29sdXRlVG1wTWFwcGVyPHR5cGU+OjphYnNvbHV0ZUluZGV4KHRtcCldLCAiKVwi XTtcbiIpOworICAgICAgICBmb3IgKGNvbnN0IGF1dG8mIHRtcCA6IHRtcHNXaXRoSW50ZXJmZXJl bmNlcykgeworICAgICAgICAgICAgdW5zaWduZWQgdG1wSW5kZXggPSBBYnNvbHV0ZVRtcE1hcHBl cjx0eXBlPjo6YWJzb2x1dGVJbmRleCh0bXApOworICAgICAgICAgICAgaWYgKHRtcEluZGV4IDwg bV9kZWdyZWVzLnNpemUoKSkKKyAgICAgICAgICAgICAgICBvdXQucHJpbnQoIiAgICAiLCB0bXAu aW50ZXJuYWxWYWx1ZSgpLCAiIFtsYWJlbD1cIiIsIHRtcCwgIiAoIiwgbV9kZWdyZWVzW3RtcElu ZGV4XSwgIilcIl07XG4iKTsKKyAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICBvdXQu cHJpbnQoIiAgICAiLCB0bXAuaW50ZXJuYWxWYWx1ZSgpLCAiIFtsYWJlbD1cIiIsIHRtcCwgIlwi XTtcbiIpOworICAgICAgICB9CiAKICAgICAgICAgZm9yIChjb25zdCBhdXRvJiBlZGdlIDogbV9p bnRlcmZlcmVuY2VFZGdlcykKICAgICAgICAgICAgIG91dC5wcmludCgiICAgICIsIGVkZ2UuZmly c3QoKSwgIiAtLSAiLCBlZGdlLnNlY29uZCgpLCAiO1xuIik7CkBAIC0xMTMwLDYgKzExNDEsOSBA QCBwcml2YXRlOgogICAgICAgICB3aGlsZSAodHJ1ZSkgewogICAgICAgICAgICAgKyttX251bUl0 ZXJhdGlvbnM7CiAKKyAgICAgICAgICAgIGlmICh0cmFjZURlYnVnKQorICAgICAgICAgICAgICAg IGRhdGFMb2coIkNvZGUgYXQgaXRlcmF0aW9uICIsIG1fbnVtSXRlcmF0aW9ucywgIjpcbiIsIG1f Y29kZSk7CisKICAgICAgICAgICAgIC8vIEZJWE1FOiBPbmUgd2F5IHRvIG9wdGltaXplIHRoaXMg Y29kZSBpcyB0byByZW1vdmUgdGhlIHJlY29tcHV0YXRpb24gaW5zaWRlIHRoZSBmaXhwb2ludC4K ICAgICAgICAgICAgIC8vIFdlIG5lZWQgdG8gcmVjb21wdXRlIGJlY2F1c2Ugc3BpbGxpbmcgYWRk cyB0bXBzLCBidXQgd2UgY291bGQganVzdCB1cGRhdGUgdG1wV2lkdGggd2hlbiB3ZQogICAgICAg ICAgICAgLy8gYWRkIHRob3NlIHRtcHMuIE5vdGUgdGhhdCBvbmUgZWFzeSB3YXkgdG8gcmVtb3Zl IHRoZSByZWNvbXB1dGF0aW9uIGlzIHRvIG1ha2UgYW55IG5ld2x5CkBAIC0xMTQ4LDYgKzExNjIs OSBAQCBwcml2YXRlOgogICAgICAgICAgICAgQ29sb3JpbmdBbGxvY2F0b3I8dHlwZT4gYWxsb2Nh dG9yKG1fY29kZSwgbV90bXBXaWR0aCwgbV91c2VDb3VudHMsIHVuc3BpbGxhYmxlVG1wcyk7CiAg ICAgICAgICAgICBpZiAoIWFsbG9jYXRvci5yZXF1aXJlc1NwaWxsaW5nKCkpIHsKICAgICAgICAg ICAgICAgICBhc3NpZ25SZWdpc3RlcnNUb1RtcChhbGxvY2F0b3IpOworICAgICAgICAgICAgICAg IGlmICh0cmFjZURlYnVnKQorICAgICAgICAgICAgICAgICAgICBkYXRhTG9nKCJTdWNjZXNzZnVs bCBhbGxvY2F0aW9uIGF0IGl0ZXJhdGlvbiAiLCBtX251bUl0ZXJhdGlvbnMsICI6XG4iLCBtX2Nv ZGUpOworCiAgICAgICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICAgICAgfQogICAgICAgICAg ICAgYWRkU3BpbGxBbmRGaWxsPHR5cGU+KGFsbG9jYXRvciwgdW5zcGlsbGFibGVUbXBzKTsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy90ZXN0YjMuY3BwIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL2IzL3Rlc3RiMy5jcHAKaW5kZXggYjI2NGU0Zjg2ZjFhOWYwNzY5Y2ViODI3 OGUwM2Y5NmUyODEzMzJkYy4uYjc5ODhiNzZlODkxMmEzMzNjMmMzMjA1YTZmYWEwYjUxNDJmYjlm NCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2IzL3Rlc3RiMy5jcHAKKysrIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL2IzL3Rlc3RiMy5jcHAKQEAgLTQ5ODIsNiArNDk4Miw0MSBA QCB2b2lkIHRlc3RGcmFtZVBvaW50ZXIoKQogICAgIENIRUNLKGZwID49IGJpdHdpc2VfY2FzdDxj aGFyKj4oJnByb2MpIC0gMTAwMDApOwogfQogCit2b2lkIHRlc3RPdmVycmlkZUZyYW1lUG9pbnRl cigpCit7CisgICAgeworICAgICAgICBQcm9jZWR1cmUgcHJvYzsKKyAgICAgICAgQmFzaWNCbG9j ayogcm9vdCA9IHByb2MuYWRkQmxvY2soKTsKKworICAgICAgICAvLyBBZGQgYSBzdGFjayBzbG90 IHRvIG1ha2UgdGhlIGZyYW1lIG5vbiB0cml2aWFsLgorICAgICAgICByb290LT5hcHBlbmROZXc8 U2xvdEJhc2VWYWx1ZT4ocHJvYywgT3JpZ2luKCksIHByb2MuYWRkU3RhY2tTbG90KDgsIFN0YWNr U2xvdEtpbmQ6OkxvY2tlZCkpOworCisgICAgICAgIC8vIFN1YiBvbiB4ODYgVXNlRGVmIHRoZSBz b3VyY2UuIElmIEZQIGlzIG5vdCBwcm90ZWN0ZWQgY29ycmVjdGx5LCBpdCB3aWxsIGJlIG92ZXJy aWRkZW4gc2luY2UgaXQgaXMgdGhlIGxhc3QgdmlzaWJsZSB1c2UuCisgICAgICAgIFZhbHVlKiBv ZmZzZXQgPSByb290LT5hcHBlbmROZXc8QXJndW1lbnRSZWdWYWx1ZT4ocHJvYywgT3JpZ2luKCks IEdQUkluZm86OmFyZ3VtZW50R1BSMCk7CisgICAgICAgIFZhbHVlKiBmcCA9IHJvb3QtPmFwcGVu ZE5ldzxWYWx1ZT4ocHJvYywgRnJhbWVQb2ludGVyLCBPcmlnaW4oKSk7CisgICAgICAgIFZhbHVl KiByZXN1bHQgPSByb290LT5hcHBlbmROZXc8VmFsdWU+KHByb2MsIFN1YiwgT3JpZ2luKCksIGZw LCBvZmZzZXQpOworCisgICAgICAgIHJvb3QtPmFwcGVuZE5ldzxDb250cm9sVmFsdWU+KHByb2Ms IFJldHVybiwgT3JpZ2luKCksIHJlc3VsdCk7CisgICAgICAgIENIRUNLKGNvbXBpbGVBbmRSdW48 aW50NjRfdD4ocHJvYywgMSkpOworICAgIH0KKyAgICB7CisgICAgICAgIFByb2NlZHVyZSBwcm9j OworICAgICAgICBCYXNpY0Jsb2NrKiByb290ID0gcHJvYy5hZGRCbG9jaygpOworCisgICAgICAg IHJvb3QtPmFwcGVuZE5ldzxTbG90QmFzZVZhbHVlPihwcm9jLCBPcmlnaW4oKSwgcHJvYy5hZGRT dGFja1Nsb3QoOCwgU3RhY2tTbG90S2luZDo6TG9ja2VkKSk7CisKKyAgICAgICAgVmFsdWUqIG9m ZnNldCA9IHJvb3QtPmFwcGVuZE5ldzxBcmd1bWVudFJlZ1ZhbHVlPihwcm9jLCBPcmlnaW4oKSwg R1BSSW5mbzo6YXJndW1lbnRHUFIwKTsKKyAgICAgICAgVmFsdWUqIGZwID0gcm9vdC0+YXBwZW5k TmV3PFZhbHVlPihwcm9jLCBGcmFtZVBvaW50ZXIsIE9yaWdpbigpKTsKKyAgICAgICAgVmFsdWUq IG9mZnNldEZQID0gcm9vdC0+YXBwZW5kTmV3PFZhbHVlPihwcm9jLCBCaXRBbmQsIE9yaWdpbigp LCBvZmZzZXQsIGZwKTsKKyAgICAgICAgVmFsdWUqIGFyZyA9IHJvb3QtPmFwcGVuZE5ldzxBcmd1 bWVudFJlZ1ZhbHVlPihwcm9jLCBPcmlnaW4oKSwgR1BSSW5mbzo6YXJndW1lbnRHUFIxKTsKKyAg ICAgICAgVmFsdWUqIG9mZnNldEFyZyA9IHJvb3QtPmFwcGVuZE5ldzxWYWx1ZT4ocHJvYywgQWRk LCBPcmlnaW4oKSwgb2Zmc2V0LCBhcmcpOworICAgICAgICBWYWx1ZSogcmVzdWx0ID0gcm9vdC0+ YXBwZW5kTmV3PFZhbHVlPihwcm9jLCBBZGQsIE9yaWdpbigpLCBvZmZzZXRBcmcsIG9mZnNldEZQ KTsKKworICAgICAgICByb290LT5hcHBlbmROZXc8Q29udHJvbFZhbHVlPihwcm9jLCBSZXR1cm4s IE9yaWdpbigpLCByZXN1bHQpOworICAgICAgICBDSEVDSyhjb21waWxlQW5kUnVuPGludDY0X3Q+ KHByb2MsIDEsIDIpKTsKKyAgICB9Cit9CisKIHZvaWQgdGVzdFN0YWNrU2xvdCgpCiB7CiAgICAg UHJvY2VkdXJlIHByb2M7CkBAIC0xMDc1Nyw2ICsxMDc5Miw3IEBAIHZvaWQgcnVuKGNvbnN0IGNo YXIqIGZpbHRlcikKICAgICBSVU4odGVzdExvYWRBZGRyU2hpZnQoMikpOwogICAgIFJVTih0ZXN0 TG9hZEFkZHJTaGlmdCgzKSk7CiAgICAgUlVOKHRlc3RGcmFtZVBvaW50ZXIoKSk7CisgICAgUlVO KHRlc3RPdmVycmlkZUZyYW1lUG9pbnRlcigpKTsKICAgICBSVU4odGVzdFN0YWNrU2xvdCgpKTsK ICAgICBSVU4odGVzdExvYWRGcm9tRnJhbWVQb2ludGVyKCkpOwogICAgIFJVTih0ZXN0U3RvcmVM b2FkU3RhY2tTbG90KDUwKSk7Cg==