153680 2016-01-29 15:45:44 -0800 Tab suspension code shouldn't use page cache cacheability logic 2016-02-02 11:47:08 -0800 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 koivisto webkit-unassigned cdumez kling oldest_to_newest 1160313 0 koivisto 2016-01-29 15:45:44 -0800 Most of the checks are unnecessary 1160323 1 270269 koivisto 2016-01-29 15:58:51 -0800 Created attachment 270269 patch 1160351 2 koivisto 2016-01-29 17:32:30 -0800 http://trac.webkit.org/changeset/195871 1160529 3 cdumez 2016-01-30 13:36:35 -0800 It looks like this patch may have caused 4 tests to fail: https://build.webkit.org/results/Apple%20El%20Capitan%20Release%20WK2%20(Tests)/r195871%20(2937)/results.html 1160531 4 cdumez 2016-01-30 13:39:09 -0800 Reverted r195871 for reason: Caused several layout tests to time out Committed r195909: <http://trac.webkit.org/changeset/195909> 1161342 5 koivisto 2016-02-02 11:47:08 -0800 Relanded in http://trac.webkit.org/changeset/196023 with 1 minute timer to avoid suspending tests that explicitly set page to non-visible state. 270269 2016-01-29 15:58:51 -0800 2016-01-29 16:12:10 -0800 patch tab-suspension-check.patch text/plain 5260 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5NTg2MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDQwIEBACisyMDE2LTAxLTI5ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBUYWIgc3VzcGVuc2lvbiBjb2Rl IHNob3VsZG4ndCB1c2UgcGFnZSBjYWNoZSBjYWNoZWFiaWxpdHkgbG9naWMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MzY4MAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1vc3Qgb2YgUGFnZUNhY2hlOjpj YW5DYWNoZSgpIGlzIHVubmVjZXNzYXJ5IGZvciB0YWIgc3VzcGVuc2lvbi4KKworICAgICAgICBB bHNvIGltcHJvdmUgcm9idXN0bmVzcy4KKworICAgICAgICAqIHBhZ2UvUGFnZS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpQYWdlOjpzZXRQYWdlQWN0aXZpdHlTdGF0ZSk6CisgICAgICAgIChXZWJD b3JlOjpQYWdlOjpzZXRJc1Zpc2libGUpOgorICAgICAgICAoV2ViQ29yZTo6UGFnZTo6c2V0SXNW aXNpYmxlSW50ZXJuYWwpOgorICAgICAgICAoV2ViQ29yZTo6UGFnZTo6c2V0SXNQcmVyZW5kZXIp OgorICAgICAgICAoV2ViQ29yZTo6UGFnZTo6Y2FuVGFiU3VzcGVuZCk6CisKKyAgICAgICAgICAg IEluY2x1ZGUgdmlzaWJpbGl0eSB0ZXN0IGhlcmUuCisKKyAgICAgICAgICAgIEluc3RlYWQgb2Yg Y2FsbGluZyBQYWdlQ2FjaGU6OmNhbkNhY2hlKCkganVzdCBjaGVjayBmb3IgZWFjaCBmcmFtZSB0 aGF0CisgICAgICAgICAgICAtIHRoYXQgdGhlIGRvY3VtZW50IGlzIGxvYWRlZAorICAgICAgICAg ICAgLSB0aGF0IGFjdGl2ZSBET00gb2JqZWN0cyBhbGxvdyBzdXNwZW5zaW9uCisKKyAgICAgICAg KFdlYkNvcmU6OlBhZ2U6OnNldElzVGFiU3VzcGVuZGVkKToKKyAgICAgICAgKFdlYkNvcmU6OlBh Z2U6OnNldFRhYlN1c3BlbnNpb25FbmFibGVkKToKKyAgICAgICAgKFdlYkNvcmU6OlBhZ2U6OnVw ZGF0ZVRhYlN1c3BlbnNpb25TdGF0ZSk6CisKKyAgICAgICAgICAgIFJlZmFjdG9yIGZvciByb2J1 c3RuZXNzLgorCisgICAgICAgIChXZWJDb3JlOjpQYWdlOjp0YWJTdXNwZW5zaW9uVGltZXJGaXJl ZCk6CisKKyAgICAgICAgICAgIENhbGwgY2FuVGFiU3VzcGVuZCwgdGhlIHJlc3VsdCBtaWdodCBo YXZlIGNoYW5nZWQuCisKKyAgICAgICAgKFdlYkNvcmU6OlBhZ2U6OnNjaGVkdWxlVGFiU3VzcGVu c2lvbik6IERlbGV0ZWQuCisgICAgICAgICogcGFnZS9QYWdlLmg6CisKIDIwMTYtMDEtMjkgIEJy YWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIE1vZGVybiBJREI6IEdl dHRpbmcgcmVjb3JkcyBmb3Iga2V5IHJhbmdlcyB3aXRoIG51bGwga2V5cyBhcmVuJ3QgcHJvcGVy bHkgaGFuZGxlZCBpbiBTUUxpdGUgYmFja2VuZApJbmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9Q YWdlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2UuY3BwCShyZXZp c2lvbiAxOTU4MzQpCisrKyBTb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2UuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0xMzA1LDEwICsxMzA1LDcgQEAgdm9pZCBQYWdlOjpzZXRQYWdlQWN0aXZpdHlTdGF0 ZShQYWdlQWN0aQogewogICAgIGNocm9tZSgpLmNsaWVudCgpLnNldFBhZ2VBY3Rpdml0eVN0YXRl KGFjdGl2aXR5U3RhdGUpOwogICAgIAotICAgIGlmIChhY3Rpdml0eVN0YXRlID09IFBhZ2VBY3Rp dml0eVN0YXRlOjpOb0ZsYWdzICYmICFpc1Zpc2libGUoKSkKLSAgICAgICAgc2NoZWR1bGVUYWJT dXNwZW5zaW9uKHRydWUpOwotICAgIGVsc2UKLSAgICAgICAgc2NoZWR1bGVUYWJTdXNwZW5zaW9u KGZhbHNlKTsKKyAgICB1cGRhdGVUYWJTdXNwZW5zaW9uU3RhdGUoKTsKIH0KIAogdm9pZCBQYWdl OjpzZXRJc1Zpc2libGUoYm9vbCBpc1Zpc2libGUpCkBAIC0xMzYxLDcgKzEzNTgsNyBAQCB2b2lk IFBhZ2U6OnNldElzVmlzaWJsZUludGVybmFsKGJvb2wgaXNWCiAgICAgICAgICAgICB2aWV3LT5o aWRlKCk7CiAgICAgfQogCi0gICAgc2NoZWR1bGVUYWJTdXNwZW5zaW9uKCFpc1Zpc2libGUpOwor ICAgIHVwZGF0ZVRhYlN1c3BlbnNpb25TdGF0ZSgpOwogfQogCiB2b2lkIFBhZ2U6OnNldElzUHJl cmVuZGVyKCkKQEAgLTE4NjcsMTcgKzE4NjQsMzAgQEAgYm9vbCBQYWdlOjpjYW5UYWJTdXNwZW5k KCkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIGlmIChtX2lzUHJlcmVuZGVyKQogICAgICAg ICByZXR1cm4gZmFsc2U7Ci0gICAgaWYgKG1fcGFnZVRocm90dGxlci5hY3Rpdml0eVN0YXRlKCkg IT0gUGFnZUFjdGl2aXR5U3RhdGU6Ok5vRmxhZ3MpCisgICAgaWYgKGlzVmlzaWJsZSgpKQogICAg ICAgICByZXR1cm4gZmFsc2U7Ci0gICAgLy8gRklYTUU6IFBhZ2VDYWNoZTo6Y2FuQ2FjaGUgZG9l cyBhIGJ1bmNoIG9mIGNoZWNrcyB0aGF0IGFyZSBub3QgbmVlZGVkIGZvciB0aGUgdGFiIHN1c3Bl bnNpb24gY2FzZS4gVGhlcmUgc2hvdWxkIGJlIGEgc3BlY2lmaWMgY2hlY2suCi0gICAgaWYgKCFQ YWdlQ2FjaGU6OnNpbmdsZXRvbigpLmNhbkNhY2hlKCp0aGlzKSkKKyAgICBpZiAobV9wYWdlVGhy b3R0bGVyLmFjdGl2aXR5U3RhdGUoKSAhPSBQYWdlQWN0aXZpdHlTdGF0ZTo6Tm9GbGFncykKICAg ICAgICAgcmV0dXJuIGZhbHNlOwogCisKKyAgICBmb3IgKEZyYW1lKiBmcmFtZSA9ICZtYWluRnJh bWUoKTsgZnJhbWU7IGZyYW1lID0gZnJhbWUtPnRyZWUoKS50cmF2ZXJzZU5leHQoKSkgeworICAg ICAgICBpZiAoZnJhbWUtPmxvYWRlcigpLnN0YXRlKCkgPT0gRnJhbWVTdGF0ZVByb3Zpc2lvbmFs KQorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAgICBpZiAoZnJhbWUtPmxvYWRlcigp LmlzTG9hZGluZygpKQorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAgICBpZiAoIWZy YW1lLT5kb2N1bWVudCgpIHx8ICFmcmFtZS0+ZG9jdW1lbnQoKS0+Y2FuU3VzcGVuZEFjdGl2ZURP TU9iamVjdHNGb3JEb2N1bWVudFN1c3BlbnNpb24obnVsbHB0cikpCisgICAgICAgICAgICByZXR1 cm4gZmFsc2U7CisgICAgfQorCiAgICAgcmV0dXJuIHRydWU7CiB9CiAKIHZvaWQgUGFnZTo6c2V0 SXNUYWJTdXNwZW5kZWQoYm9vbCBzaG91bGRTdXNwZW5kKQogeworICAgIGlmIChtX2lzVGFiU3Vz cGVuZGVkID09IHNob3VsZFN1c3BlbmQpCisgICAgICAgIHJldHVybjsKKyAgICBtX2lzVGFiU3Vz cGVuZGVkID0gc2hvdWxkU3VzcGVuZDsKKwogICAgIGZvciAoRnJhbWUqIGZyYW1lID0gJm1haW5G cmFtZSgpOyBmcmFtZTsgZnJhbWUgPSBmcmFtZS0+dHJlZSgpLnRyYXZlcnNlTmV4dCgpKSB7CiAg ICAgICAgIGlmIChhdXRvKiBkb2N1bWVudCA9IGZyYW1lLT5kb2N1bWVudCgpKSB7CiAgICAgICAg ICAgICBpZiAoc2hvdWxkU3VzcGVuZCkKQEAgLTE4OTMsMjYgKzE5MDMsMTkgQEAgdm9pZCBQYWdl OjpzZXRUYWJTdXNwZW5zaW9uRW5hYmxlZChib29sIAogICAgIHNfdGFiU3VzcGVuc2lvbklzRW5h YmxlZCA9IGVuYWJsZTsKIH0KIAotdm9pZCBQYWdlOjpzY2hlZHVsZVRhYlN1c3BlbnNpb24oYm9v bCBzaG91bGRTdXNwZW5kKQordm9pZCBQYWdlOjp1cGRhdGVUYWJTdXNwZW5zaW9uU3RhdGUoKQog ewotICAgIGlmIChtX3Nob3VsZFRhYlN1c3BlbmQgPT0gc2hvdWxkU3VzcGVuZCkKLSAgICAgICAg cmV0dXJuOwotICAgIAotICAgIGlmIChzaG91bGRTdXNwZW5kICYmIGNhblRhYlN1c3BlbmQoKSkg ewotICAgICAgICBtX3Nob3VsZFRhYlN1c3BlbmQgPSBzaG91bGRTdXNwZW5kOworICAgIGlmIChj YW5UYWJTdXNwZW5kKCkpIHsKICAgICAgICAgbV90YWJTdXNwZW5zaW9uVGltZXIuc3RhcnRPbmVT aG90KDApOwotICAgIH0gZWxzZSB7Ci0gICAgICAgIG1fdGFiU3VzcGVuc2lvblRpbWVyLnN0b3Ao KTsKLSAgICAgICAgaWYgKCFzaG91bGRTdXNwZW5kKSB7Ci0gICAgICAgICAgICBtX3Nob3VsZFRh YlN1c3BlbmQgPSBzaG91bGRTdXNwZW5kOwotICAgICAgICAgICAgc2V0SXNUYWJTdXNwZW5kZWQo ZmFsc2UpOwotICAgICAgICB9CisgICAgICAgIHJldHVybjsKICAgICB9CisgICAgbV90YWJTdXNw ZW5zaW9uVGltZXIuc3RvcCgpOworICAgIHNldElzVGFiU3VzcGVuZGVkKGZhbHNlKTsKIH0KIAog dm9pZCBQYWdlOjp0YWJTdXNwZW5zaW9uVGltZXJGaXJlZCgpCiB7Ci0gICAgc2V0SXNUYWJTdXNw ZW5kZWQodHJ1ZSk7CisgICAgc2V0SXNUYWJTdXNwZW5kZWQoY2FuVGFiU3VzcGVuZCgpKTsKIH0K IAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpJbmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9QYWdl LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmgJKHJldmlzaW9uIDE5 NTgzNCkKKysrIFNvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5oCSh3b3JraW5nIGNvcHkpCkBAIC01 MjEsNyArNTIxLDcgQEAgcHJpdmF0ZToKICAgICB2b2lkIGhpZGRlblBhZ2VET01UaW1lclRocm90 dGxpbmdTdGF0ZUNoYW5nZWQoKTsKICAgICB2b2lkIHNldFRpbWVyVGhyb3R0bGluZ0VuYWJsZWQo Ym9vbCk7CiAgICAgYm9vbCBjYW5UYWJTdXNwZW5kKCk7Ci0gICAgdm9pZCBzY2hlZHVsZVRhYlN1 c3BlbnNpb24oYm9vbCk7CisgICAgdm9pZCB1cGRhdGVUYWJTdXNwZW5zaW9uU3RhdGUoKTsKICAg ICB2b2lkIHRhYlN1c3BlbnNpb25UaW1lckZpcmVkKCk7CiAKICAgICBjb25zdCBzdGQ6OnVuaXF1 ZV9wdHI8Q2hyb21lPiBtX2Nocm9tZTsKQEAgLTY2Myw3ICs2NjMsNyBAQCBwcml2YXRlOgogICAg IFNlc3Npb25JRCBtX3Nlc3Npb25JRDsKIAogICAgIGJvb2wgbV9pc0Nsb3Npbmc7Ci0gICAgYm9v bCBtX3Nob3VsZFRhYlN1c3BlbmQgeyBmYWxzZSB9OworICAgIGJvb2wgbV9pc1RhYlN1c3BlbmRl ZCB7IGZhbHNlIH07CiAgICAgVGltZXIgbV90YWJTdXNwZW5zaW9uVGltZXI7CiAKICAgICBNZWRp YVByb2R1Y2VyOjpNZWRpYVN0YXRlRmxhZ3MgbV9tZWRpYVN0YXRlIHsgTWVkaWFQcm9kdWNlcjo6 SXNOb3RQbGF5aW5nIH07Cg==