153671 2016-01-29 13:55:23 -0800 Web Inspector: WebInspector.Setting should not access localStorage if the value did not change 2016-01-29 14:59:32 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1160256 0 joepeck 2016-01-29 13:55:23 -0800 * SUMMARY WebInspector.Setting should not access localStorage if the value did not change * NOTES Was seeing this in some profiles. We set the value of a setting, which did not change the setting, quite often. We can bail for most, trivial, cases. 1160257 1 webkit-bug-importer 2016-01-29 13:55:50 -0800 <rdar://problem/24417029> 1160258 2 270252 joepeck 2016-01-29 13:56:38 -0800 Created attachment 270252 [PATCH] Proposed Fix 1160264 3 270252 bburg 2016-01-29 14:10:38 -0800 Comment on attachment 270252 [PATCH] Proposed Fix r=me, whoops 1160282 4 270252 commit-queue 2016-01-29 14:59:27 -0800 Comment on attachment 270252 [PATCH] Proposed Fix Clearing flags on attachment: 270252 Committed r195842: <http://trac.webkit.org/changeset/195842> 1160283 5 commit-queue 2016-01-29 14:59:32 -0800 All reviewed patches have been landed. Closing bug. 270252 2016-01-29 13:56:38 -0800 2016-01-29 14:59:27 -0800 [PATCH] Proposed Fix bail.patch text/plain 1367 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGE1ZjgzMzguLjQwNGMxZTMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDE2LTAxLTI5ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogV2ViSW5z cGVjdG9yLlNldHRpbmcgc2hvdWxkIG5vdCBhY2Nlc3MgbG9jYWxTdG9yYWdlIGlmIHRoZSB2YWx1 ZSBkaWQgbm90IGNoYW5nZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTUzNjcxCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yNDQxNzAyOT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZh Y2UvQmFzZS9TZXR0aW5nLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNldHRpbmcucHJvdG90 eXBlLnNldCB2YWx1ZSk6CisKKzIwMTYtMDEtMjkgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJv QGFwcGxlLmNvbT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBEdXBsaWNhdGUgdGFiLXR5cGVz IGJlaW5nIHNhdmVkIHRvIHNldHRpbmcsIGNhdXNpbmcgZHVwbGljYXRlIHRhYnMgdG8gYmUgb3Bl bmVkCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTM2 NTkKICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI0NDEzMTU3PgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9TZXR0aW5nLmpzIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9TZXR0aW5nLmpzCmluZGV4IDJmOWMwODEu LjQxODQyY2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L0Jhc2UvU2V0dGluZy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9CYXNlL1NldHRpbmcuanMKQEAgLTcxLDYgKzcxLDkgQEAgV2ViSW5zcGVjdG9yLlNldHRpbmcg PSBjbGFzcyBTZXR0aW5nIGV4dGVuZHMgV2ViSW5zcGVjdG9yLk9iamVjdAogCiAgICAgc2V0IHZh bHVlKHZhbHVlKQogICAgIHsKKyAgICAgICAgaWYgKHRoaXMuX3ZhbHVlID09PSB2YWx1ZSkKKyAg ICAgICAgICAgIHJldHVybjsKKwogICAgICAgICB0aGlzLl92YWx1ZSA9IHZhbHVlOwogCiAgICAg ICAgIGlmICghd2luZG93Lkluc3BlY3RvclRlc3QgJiYgd2luZG93LmxvY2FsU3RvcmFnZSkgewo=