153666 2016-01-29 13:25:09 -0800 Modern IDB: Getting records for key ranges with null keys isn't properly handled in SQLite backend 2016-01-29 15:25:06 -0800 1 1 1 Unclassified WebKit WebCore Misc. Safari 9 Unspecified Unspecified RESOLVED FIXED P2 Normal --- 149117 153021 1 beidson beidson achristensen aestes alecflett commit-queue jsbell thorton oldest_to_newest 1160242 0 beidson 2016-01-29 13:25:09 -0800 Modern IDB: Getting records for key ranges with null keys aren't properly handled in SQLite backend 1160243 1 270247 beidson 2016-01-29 13:26:29 -0800 Created attachment 270247 Patch v1 1160247 2 270247 thorton 2016-01-29 13:32:14 -0800 Comment on attachment 270247 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=270247&action=review > Source/WebCore/ChangeLog:3 > + Modern IDB: Getting records for key ranges with null keys aren't properly handled in SQLite backend I think you meant "isn't" 1160302 3 beidson 2016-01-29 15:25:06 -0800 http://trac.webkit.org/changeset/195850 270247 2016-01-29 13:26:29 -0800 2016-01-29 13:32:14 -0800 Patch v1 patch text/plain 3656 beidson ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA2OWZkNDdjLi4xNzkxMWZiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAKIDIwMTYtMDEt MjkgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCisgICAgICAgIE1vZGVybiBJ REI6IEdldHRpbmcgcmVjb3JkcyBmb3Iga2V5IHJhbmdlcyB3aXRoIG51bGwga2V5cyBhcmVuJ3Qg cHJvcGVybHkgaGFuZGxlZCBpbiBTUUxpdGUgYmFja2VuZAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUzNjY2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMtd2sxL1Rlc3RFeHBlY3Rh dGlvbnM6CisKKzIwMTYtMDEtMjkgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgor CiAgICAgICAgIE1vZGVybiBJREI6IHN0b3JhZ2UvaW5kZXhlZGRiL21vZGVybi9pbmRleC0zLmh0 bWwgZmFpbHMuCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNTM2NjEKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMS9UZXN0 RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMS9UZXN0RXhwZWN0YXRp b25zCmluZGV4IDY2YWQ0ZDEuLjY0MmNiMmUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRm b3JtL21hYy13azEvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9t YWMtd2sxL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTI1Nyw4ICsyNTcsNiBAQCBpbnNwZWN0b3Ivc2Ny aXB0LXByb2ZpbGVyL2V2ZW50LXR5cGUtQVBJLmh0bWwKIGltcG9ydGVkL3czYy9pbmRleGVkZGIv aWRiaW5kZXgtbXVsdGllbnRyeS1iaWcuaHRtIFsgRmFpbHVyZSBdCiBzdG9yYWdlL2luZGV4ZWRk Yi9jdXJzb3ItY29udGludWUtdmFsaWRpdHkuaHRtbCBbIEZhaWx1cmUgXQogc3RvcmFnZS9pbmRl eGVkZGIvY3Vyc29yLXByaW1hcnkta2V5LW9yZGVyLmh0bWwgWyBGYWlsdXJlIF0KLXN0b3JhZ2Uv aW5kZXhlZGRiL2dldC1rZXlyYW5nZS5odG1sIFsgRmFpbHVyZSBdCi1zdG9yYWdlL2luZGV4ZWRk Yi9tb2Rlcm4vZ2V0LWtleXJhbmdlLmh0bWwgWyBGYWlsdXJlIF0KIAogIyBTUUxpdGUgYmFja2Vu ZCB0ZXN0cyB0aGF0IHRpbWVvdXQKIHN0b3JhZ2UvaW5kZXhlZGRiL21vZGVybi90cmFuc2FjdGlv bi1zY2hlZHVsZXItMS5odG1sIFsgU2tpcCBdCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTUxYmUyYy4uZjkxMjBm NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE2LTAxLTI5ICBCcmFkeSBFaWRzb24g IDxiZWlkc29uQGFwcGxlLmNvbT4KIAorICAgICAgICBNb2Rlcm4gSURCOiBHZXR0aW5nIHJlY29y ZHMgZm9yIGtleSByYW5nZXMgd2l0aCBudWxsIGtleXMgYXJlbid0IHByb3Blcmx5IGhhbmRsZWQg aW4gU1FMaXRlIGJhY2tlbmQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE1MzY2NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIE5vIG5ldyB0ZXN0cyAoVHdvIGZhaWxpbmcgdGVzdHMgbm93IHBhc3MpLgorCisg ICAgICAgICogTW9kdWxlcy9pbmRleGVkZGIvc2VydmVyL1NRTGl0ZUlEQkJhY2tpbmdTdG9yZS5j cHA6CisgICAgICAgIChXZWJDb3JlOjpJREJTZXJ2ZXI6OlNRTGl0ZUlEQkJhY2tpbmdTdG9yZTo6 Z2V0UmVjb3JkKToKKworMjAxNi0wMS0yOSAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5j b20+CisKICAgICAgICAgTW9kZXJuIElEQjogc3RvcmFnZS9pbmRleGVkZGIvbW9kZXJuL2luZGV4 LTMuaHRtbCBmYWlscy4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE1MzY2MQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4 ZWRkYi9zZXJ2ZXIvU1FMaXRlSURCQmFja2luZ1N0b3JlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01v ZHVsZXMvaW5kZXhlZGRiL3NlcnZlci9TUUxpdGVJREJCYWNraW5nU3RvcmUuY3BwCmluZGV4IDcw YTcxZWUuLjRhMWJkNzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhl ZGRiL3NlcnZlci9TUUxpdGVJREJCYWNraW5nU3RvcmUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L01vZHVsZXMvaW5kZXhlZGRiL3NlcnZlci9TUUxpdGVJREJCYWNraW5nU3RvcmUuY3BwCkBAIC0x MTk2LDEzICsxMTk2LDE5IEBAIElEQkVycm9yIFNRTGl0ZUlEQkJhY2tpbmdTdG9yZTo6Z2V0UmVj b3JkKGNvbnN0IElEQlJlc291cmNlSWRlbnRpZmllciYgdHJhbnNhY3RpCiAgICAgICAgIHJldHVy biB7IElEQkRhdGFiYXNlRXhjZXB0aW9uOjpVbmtub3duRXJyb3IsIEFTQ0lJTGl0ZXJhbCgiQXR0 ZW1wdCB0byBnZXQgYSByZWNvcmQgZnJvbSBkYXRhYmFzZSB3aXRob3V0IGFuIGluLXByb2dyZXNz IHRyYW5zYWN0aW9uIikgfTsKICAgICB9CiAKLSAgICBSZWZQdHI8U2hhcmVkQnVmZmVyPiBsb3dl ckJ1ZmZlciA9IHNlcmlhbGl6ZUlEQktleURhdGEoSURCS2V5RGF0YShrZXlSYW5nZS5sb3dlcktl eSkpOworICAgIGF1dG8ga2V5ID0ga2V5UmFuZ2UubG93ZXJLZXk7CisgICAgaWYgKGtleS5pc051 bGwoKSkKKyAgICAgICAga2V5ID0gSURCS2V5RGF0YTo6bWluaW11bSgpOworICAgIFJlZlB0cjxT aGFyZWRCdWZmZXI+IGxvd2VyQnVmZmVyID0gc2VyaWFsaXplSURCS2V5RGF0YShrZXkpOwogICAg IGlmICghbG93ZXJCdWZmZXIpIHsKICAgICAgICAgTE9HX0VSUk9SKCJVbmFibGUgdG8gc2VyaWFs aXplIGxvd2VyIElEQktleSBpbiBsb29rdXAgcmFuZ2UiKTsKICAgICAgICAgcmV0dXJuIHsgSURC RGF0YWJhc2VFeGNlcHRpb246OlVua25vd25FcnJvciwgQVNDSUlMaXRlcmFsKCJVbmFibGUgdG8g c2VyaWFsaXplIGxvd2VyIElEQktleSBpbiBsb29rdXAgcmFuZ2UiKSB9OwogICAgIH0KIAotICAg IFJlZlB0cjxTaGFyZWRCdWZmZXI+IHVwcGVyQnVmZmVyID0gc2VyaWFsaXplSURCS2V5RGF0YShJ REJLZXlEYXRhKGtleVJhbmdlLnVwcGVyS2V5KSk7CisgICAga2V5ID0ga2V5UmFuZ2UudXBwZXJL ZXk7CisgICAgaWYgKGtleS5pc051bGwoKSkKKyAgICAgICAga2V5ID0gSURCS2V5RGF0YTo6bWF4 aW11bSgpOworICAgIFJlZlB0cjxTaGFyZWRCdWZmZXI+IHVwcGVyQnVmZmVyID0gc2VyaWFsaXpl SURCS2V5RGF0YShrZXkpOwogICAgIGlmICghdXBwZXJCdWZmZXIpIHsKICAgICAgICAgTE9HX0VS Uk9SKCJVbmFibGUgdG8gc2VyaWFsaXplIHVwcGVyIElEQktleSBpbiBsb29rdXAgcmFuZ2UiKTsK ICAgICAgICAgcmV0dXJuIHsgSURCRGF0YWJhc2VFeGNlcHRpb246OlVua25vd25FcnJvciwgQVND SUlMaXRlcmFsKCJVbmFibGUgdG8gc2VyaWFsaXplIHVwcGVyIElEQktleSBpbiBsb29rdXAgcmFu Z2UiKSB9Owo=