153621 2016-01-28 16:07:19 -0800 Improvements to botwatcher's dashboard unit tests. 2016-02-01 09:02:46 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=152345 P2 Normal --- 1 jmarcell webkit-unassigned adele ap commit-queue dbates dean_johnson dino jmarcell lforschler oldest_to_newest 1159926 0 jmarcell 2016-01-28 16:07:19 -0800 Improvements to botwatcher's dashboard unit tests. 1159928 1 270158 jmarcell 2016-01-28 16:12:03 -0800 Created attachment 270158 Patch 1160865 2 270158 commit-queue 2016-02-01 09:02:43 -0800 Comment on attachment 270158 Patch Clearing flags on attachment: 270158 Committed r195962: <http://trac.webkit.org/changeset/195962> 1160867 3 commit-queue 2016-02-01 09:02:46 -0800 All reviewed patches have been landed. Closing bug. 270158 2016-01-28 16:12:03 -0800 2016-02-01 09:02:43 -0800 Patch bug-153621-20160128161138.patch text/plain 5655 jmarcell U3VidmVyc2lvbiBSZXZpc2lvbjogMTk1NzkwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjA5ZDlmNTczNWE0NzNhMGZlNDhlZGZkNmFkYzkxY2Vk NmMyOTE5NS4uYjZkMmZjM2I3OWFiMWI1ZDllNGQzNmYxM2JmOTBmNmFkZWYyNmUwNiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIx IEBACiAyMDE2LTAxLTI4ICBKYXNvbiBNYXJjZWxsICA8am1hcmNlbGxAYXBwbGUuY29tPgogCisg ICAgICAgIEltcHJvdmVtZW50cyB0byBib3R3YXRjaGVyJ3MgZGFzaGJvYXJkIHVuaXQgdGVzdHMu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTM2MjEK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEJ1aWxk U2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2Fy ZC9TY3JpcHRzL1BvcG92ZXJUcmFja2VyLmpzOgorICAgICAgICAoUG9wb3ZlclRyYWNrZXIpOiBS ZXRhaW4gYSByZWZlcmVuY2UgdG8gdGhlIFBvcG92ZXJUcmFja2VyIHNvIHRoYXQgd2UgY2FuIG1h a2UgYXNzZXJ0aW9ucyBhYm91dCBpdCBpbiB0aGUgdW5pdCB0ZXN0cy4KKyAgICAgICAgKiBCdWls ZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9h cmQvU2NyaXB0cy90ZXN0cy9Nb2NrVHJhYy5qczoKKyAgICAgICAgKE1vY2tUcmFjKTogQ2hhbmdp bmcgcmV2aXNpb24gMzMwMTkgdG8gYmUgb24gYSBkaWZmZXJlbnQgYnJhbmNoIHNvIHRoYXQgX2Fw cGVuZFBlbmRpbmdSZXZpc2lvbkNvdW50IGFuZAorICAgICAgICBfcG9wb3ZlckxpbmVzRm9yQ29t bWl0UmFuZ2UgaGF2ZSB0byB0cmF2ZXJzZSBjb21taXRzIGZyb20gZGlmZmVyZW50IGJyYW5jaGVz LgorICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1 YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL3Rlc3RzL3Rlc3RzLmpzOiBDaGFuZ2luZyBlcXVh bCB0byBzdHJpY3RFcXVhbAorICAgICAgICBpbiB1bml0IHRlc3QgZm9yIF9hcHBlbmRQZW5kaW5n UmV2aXNpb25Db3VudC4gQWxzbyBhZGRlZCBhc3NlcnRpb25zIGZvciBQb3BvdmVyIGluIHRlc3Qg Zm9yCisgICAgICAgIF9yZXZpc2lvbkNvbnRlbnRXaXRoUG9wb3ZlckZvckl0ZXJhdGlvbi4KKwor MjAxNi0wMS0yOCAgSmFzb24gTWFyY2VsbCAgPGptYXJjZWxsQGFwcGxlLmNvbT4KKwogICAgICAg ICBSZWZhY3RvciB0byBhZGQgZXZlbnQgbGlzdGVuZXJzIGFuZCBzdGFydCBwZXJpb2RpYyB1cGRh dGVzIGZvciBhbGwgdHJhYyBpbnN0YW5jZXMuCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNTM2MDkKIApkaWZmIC0tZ2l0IGEvVG9vbHMvQnVpbGRTbGF2 ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1Nj cmlwdHMvUG9wb3ZlclRyYWNrZXIuanMgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53 ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9Qb3BvdmVyVHJh Y2tlci5qcwppbmRleCAwZDkzM2ZhZDc2ZTM2NmRiNWQ2ZjEwMGM4YTE3Y2E1YTQzZjIwZDk2Li40 YTRhMjEwMjkyMjNkYmFjOTBlNGQ0MTY0NGViYmUzYTBhZmE2YjVlIDEwMDY0NAotLS0gYS9Ub29s cy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9k YXNoYm9hcmQvU2NyaXB0cy9Qb3BvdmVyVHJhY2tlci5qcworKysgYi9Ub29scy9CdWlsZFNsYXZl U3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2Ny aXB0cy9Qb3BvdmVyVHJhY2tlci5qcwpAQCAtMzgsNiArMzgsNyBAQCBQb3BvdmVyVHJhY2tlciA9 IGZ1bmN0aW9uKGVsZW1lbnQsIHByZXNlbnRQb3BvdmVyQ2FsbGJhY2ssIGNvbnRleHQpCiAgICAg ZWxlbWVudC5jbGFzc0xpc3QuYWRkKCJwb3BvdmVyLXRyYWNraW5nIik7CiAgICAgZWxlbWVudC5h ZGRFdmVudExpc3RlbmVyKCJtb3VzZWVudGVyIiwgdGhpcy5fbW91c2VFbnRlcmVkUG9wb3Zlck9y RWxlbWVudC5iaW5kKHRoaXMpLCB0cnVlKTsKICAgICBlbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIo Im1vdXNlbGVhdmUiLCB0aGlzLl9tb3VzZUV4aXRlZFBvcG92ZXJPckVsZW1lbnQuYmluZCh0aGlz KSwgdHJ1ZSk7CisgICAgZWxlbWVudC5wb3BvdmVyVHJhY2tlciA9IHRoaXM7CiB9OwogCiAvLyBP bmx5IG9uZSBwb3BvdmVyIG1heSBiZSBhY3RpdmUgYXQgYW55IHRpbWUuIEFuIGFjdGl2ZSBwb3Bv dmVyIGlzIG5vdCBuZWNlc3NhcmlseSB2aXNpYmxlIGFscmVhZHkuCmRpZmYgLS1naXQgYS9Ub29s cy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9k YXNoYm9hcmQvU2NyaXB0cy90ZXN0cy9Nb2NrVHJhYy5qcyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBw b3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRz L3Rlc3RzL01vY2tUcmFjLmpzCmluZGV4IDIwNGJkNDc4MmIyN2I2YjEwOGNiZjY1ODdiM2Q5Yzhl MzkxMmI2ZWQuLmI5NmQxM2I4ZDk5N2Y3ZTNlNmI5YWQ5ZjZkMjExMDY5OGU2N2Q4NDIgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1 YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL3Rlc3RzL01vY2tUcmFjLmpzCisrKyBiL1Rvb2xz L0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rh c2hib2FyZC9TY3JpcHRzL3Rlc3RzL01vY2tUcmFjLmpzCkBAIC00NSw3ICs0NSw3IEBAIE1vY2tU cmFjID0gZnVuY3Rpb24oKQogICAgICAgICAgICAgImRhdGUiOiBuZXcgRGF0ZSgiMjAxNS0xMS0x NlQwMToxODoyMy4wMDBaIiksCiAgICAgICAgICAgICAiZGVzY3JpcHRpb24iOiAiZGVzY3JpcHRp b24iLAogICAgICAgICAgICAgImNvbnRhaW5zQnJhbmNoTG9jYXRpb24iOiB0cnVlLAotICAgICAg ICAgICAgImJyYW5jaE5hbWUiOiAidHJ1bmsiCisgICAgICAgICAgICAiYnJhbmNoTmFtZSI6ICJz b21lT3RoZXJCcmFuY2giCiAgICAgICAgIH0sCiAgICAgICAgIHsKICAgICAgICAgICAgICJyZXZp c2lvbk51bWJlciI6IDMzMDIwLApkaWZmIC0tZ2l0IGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQv YnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvdGVz dHMvdGVzdHMuanMgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNv bmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy90ZXN0cy90ZXN0cy5qcwppbmRleCA2 MDY5M2E3YzRhZmYwYTU1YzBhYmIxYzRlNjc3NzBiYmU1NjIyZWU3Li41NTAyMGI1N2MzODAwYzY2 YTEyYTViMTFkYzYwZTM5OGI1ZDYwZTllIDEwMDY0NAotLS0gYS9Ub29scy9CdWlsZFNsYXZlU3Vw cG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0 cy90ZXN0cy90ZXN0cy5qcworKysgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJr aXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy90ZXN0cy90ZXN0cy5q cwpAQCAtNzYsMTMgKzc2LDEzIEBAIHRlc3QoIl9hcHBlbmRQZW5kaW5nUmV2aXNpb25Db3VudCIs IGZ1bmN0aW9uKCkKIHsKICAgICB0aGlzLnZpZXcuX2FwcGVuZFBlbmRpbmdSZXZpc2lvbkNvdW50 KHRoaXMucXVldWUpOwogICAgIHZhciByZXZpc2lvbnNCZWhpbmQgPSB0aGlzLnZpZXcuZWxlbWVu dC5nZXRFbGVtZW50c0J5Q2xhc3NOYW1lKCJtZXNzYWdlIilbMF0uaW5uZXJIVE1MLm1hdGNoKC8u KihcZCspIHJldmlzaW9uKHxzKSBiZWhpbmQvKVsxXTsKLSAgICBlcXVhbChyZXZpc2lvbnNCZWhp bmQsICIxIiwgImFzc2VydCByZXZpc2lvbnMgYmVoaW5kIik7CisgICAgc3RyaWN0RXF1YWwocmV2 aXNpb25zQmVoaW5kLCAiMSIsICJhc3NlcnQgcmV2aXNpb25zIGJlaGluZCIpOwogfSk7CiAKIHRl c3QoIl9wb3BvdmVyTGluZXNGb3JDb21taXRSYW5nZSIsIGZ1bmN0aW9uKCkKIHsKICAgICB2YXIg bGluZXMgPSB0aGlzLnZpZXcuX3BvcG92ZXJMaW5lc0ZvckNvbW1pdFJhbmdlKHRoaXMudHJhYywg dGhpcy50cnVua0JyYW5jaCwgMzMwMTgsIDMzMDIwKTsKLSAgICBzdHJpY3RFcXVhbChsaW5lcy5s ZW5ndGgsIDMsICJoYXMgMyBsaW5lcyIpOworICAgIHN0cmljdEVxdWFsKGxpbmVzLmxlbmd0aCwg MiwgImhhcyAyIGxpbmVzIik7CiB9KTsKIAogdGVzdCgiX3ByZXNlbnRQb3BvdmVyRm9yUGVuZGlu Z0NvbW1pdHMiLCBmdW5jdGlvbigpCkBAIC0xMDYsNyArMTA2LDcgQEAgdGVzdCgiX3ByZXNlbnRQ b3BvdmVyRm9yUmV2aXNpb25SYW5nZSIsIGZ1bmN0aW9uKCkKICAgICB9OwogICAgIHRoaXMudmll dy5fcHJlc2VudFBvcG92ZXJGb3JSZXZpc2lvblJhbmdlKGVsZW1lbnQsIHBvcG92ZXIsIGNvbnRl eHQpOwogICAgIHZhciBub2RlTGlzdCA9IHBvcG92ZXIuX2VsZW1lbnQuZ2V0RWxlbWVudHNCeUNs YXNzTmFtZSgicGVuZGluZy1jb21taXQiKTsKLSAgICBzdHJpY3RFcXVhbChub2RlTGlzdC5sZW5n dGgsIDMsICJoYXMgMyBjb21taXRzIik7CisgICAgc3RyaWN0RXF1YWwobm9kZUxpc3QubGVuZ3Ro LCAyLCAiaGFzIDIgY29tbWl0cyIpOwogfSk7CiAKIHRlc3QoIl9wcmVzZW50UG9wb3ZlckZvclJl dmlzaW9uUmFuZ2Ugbm8gY29tbWl0cyIsIGZ1bmN0aW9uKCkKQEAgLTE0Nyw2ICsxNDcsMTEgQEAg dGVzdCgiX3JldmlzaW9uQ29udGVudFdpdGhQb3BvdmVyRm9ySXRlcmF0aW9uIGhhcyBwcmV2aW91 c0l0ZXJhdGlvbiIsIGZ1bmN0aW9uKCkKICAgICBzdHJpY3RFcXVhbChjb250ZW50LmlubmVySFRN TCwgInIzMzAyMiIsICJzaG91bGQgaGF2ZSBjb3JyZWN0IHJldmlzaW9uIG51bWJlci4iKTsKICAg ICBzdHJpY3RFcXVhbChjb250ZW50LmNsYXNzTGlzdC5jb250YWlucygicmV2aXNpb24tbnVtYmVy IiksIHRydWUsICJzaG91bGQgaGF2ZSBjbGFzcyAncmV2aXNpb24tbnVtYmVyJy4iKTsKICAgICBz dHJpY3RFcXVhbChjb250ZW50LmNsYXNzTGlzdC5jb250YWlucygicG9wb3Zlci10cmFja2luZyIp LCB0cnVlLCAic2hvdWxkIGhhdmUgY2xhc3MgJ3BvcG92ZXItdHJhY2tpbmcnLiIpOworICAgIHZh ciBlbGVtZW50ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7CisgICAgdmFyIHBvcG92 ZXIgPSBuZXcgRGFzaGJvYXJkLlBvcG92ZXIoKTsKKyAgICB0aGlzLnZpZXcuX3ByZXNlbnRQb3Bv dmVyRm9yUmV2aXNpb25SYW5nZShlbGVtZW50LCBwb3BvdmVyLCBjb250ZW50LnBvcG92ZXJUcmFj a2VyLl9jb250ZXh0KTsKKyAgICB2YXIgbm9kZUxpc3QgPSBwb3BvdmVyLl9lbGVtZW50LmdldEVs ZW1lbnRzQnlDbGFzc05hbWUoInBlbmRpbmctY29tbWl0Iik7CisgICAgc3RyaWN0RXF1YWwobm9k ZUxpc3QubGVuZ3RoLCAyLCAiaGFzIDIgY29tbWl0cyIpOwogfSk7CiAKIG1vZHVsZSgiQnVpbGRC b3RRdWV1ZSIsIHsK