153608 2016-01-28 11:38:04 -0800 Web Inspector: Avoid recreating Timeline's DataGridNode data multiple times 2016-01-28 13:07:02 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1159819 0 joepeck 2016-01-28 11:38:04 -0800 * SUMMARY Avoid recreating Timeline's DataGridNode data multiple times Many TimelineDataGridNode subclasses do something like: get data() { // some work return { ... }; } createCellContent(columnIdentifier, cell) { // Invoke the `data` getter above to create the object... var value = this.data[columnIdentifier]; } We should avoid recreating lots of objects in data. Lets do it once and cache it. 1159821 1 webkit-bug-importer 2016-01-28 11:38:36 -0800 <rdar://problem/24393701> 1159822 2 270135 joepeck 2016-01-28 11:38:53 -0800 Created attachment 270135 [PATCH] Proposed Fix 1159847 3 270135 commit-queue 2016-01-28 13:06:58 -0800 Comment on attachment 270135 [PATCH] Proposed Fix Clearing flags on attachment: 270135 Committed r195779: <http://trac.webkit.org/changeset/195779> 1159848 4 commit-queue 2016-01-28 13:07:02 -0800 All reviewed patches have been landed. Closing bug. 270135 2016-01-28 11:38:53 -0800 2016-01-28 13:06:58 -0800 [PATCH] Proposed Fix cache-data.patch text/plain 7154 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGM4YzgzMTcuLjcyOTRmNDMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE2LTAxLTI4ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQXZvaWQg cmVjcmVhdGluZyBUaW1lbGluZSdzIERhdGFHcmlkTm9kZSBkYXRhIG11bHRpcGxlIHRpbWVzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTM2MDgKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRl cmZhY2UvVmlld3MvTGF5b3V0VGltZWxpbmVEYXRhR3JpZE5vZGUuanM6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuTGF5b3V0VGltZWxpbmVEYXRhR3JpZE5vZGUucHJvdG90eXBlLmdldCBkYXRhKToK KyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1JlbmRlcmluZ0ZyYW1lVGltZWxpbmVEYXRh R3JpZE5vZGUuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUmVuZGVyaW5nRnJhbWVUaW1lbGlu ZURhdGFHcmlkTm9kZS5wcm90b3R5cGUuZ2V0IGRhdGEpOgorICAgICAgICAqIFVzZXJJbnRlcmZh Y2UvVmlld3MvU2NyaXB0VGltZWxpbmVEYXRhR3JpZE5vZGUuanM6CisgICAgICAgIChXZWJJbnNw ZWN0b3IuU2NyaXB0VGltZWxpbmVEYXRhR3JpZE5vZGUucHJvdG90eXBlLmdldCBkYXRhKToKKyAg ICAgICAgQ2FjaGUgdGhlIGRhdGEgd2hlbiB3ZSBjcmVhdGUgaXQgdGhlIGZpcnN0IHRpbWUuCisK IDIwMTYtMDEtMjYgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAg ICAgICBXZWIgSW5zcGVjdG9yOiBSZW1vdmUgdW51c2VkIEZyYW1lc0xhcmdlLnBuZyB2YXJpYW50 cywgb25seSB0aGUgc21hbGxlciBGcmFtZXMgaWNvbiBpcyB1c2VkIGZvciB0aGUgUmVuZGVyaW5n IEZyYW1lcyB0aW1lbGluZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvTGF5b3V0VGltZWxpbmVEYXRhR3JpZE5vZGUuanMgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9MYXlvdXRUaW1lbGluZURhdGFHcmlkTm9k ZS5qcwppbmRleCA5MTZjYTE0Li5kZGI2ZjI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9MYXlvdXRUaW1lbGluZURhdGFHcmlkTm9kZS5qcwor KysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9MYXlvdXRUaW1l bGluZURhdGFHcmlkTm9kZS5qcwpAQCAtNDcsNyArNDcsMTkgQEAgV2ViSW5zcGVjdG9yLkxheW91 dFRpbWVsaW5lRGF0YUdyaWROb2RlID0gY2xhc3MgTGF5b3V0VGltZWxpbmVEYXRhR3JpZE5vZGUg ZXh0ZW4KIAogICAgIGdldCBkYXRhKCkKICAgICB7Ci0gICAgICAgIHJldHVybiB7ZXZlbnRUeXBl OiB0aGlzLl9yZWNvcmQuZXZlbnRUeXBlLCB3aWR0aDogdGhpcy5fcmVjb3JkLndpZHRoLCBoZWln aHQ6IHRoaXMuX3JlY29yZC5oZWlnaHQsIGFyZWE6IHRoaXMuX3JlY29yZC53aWR0aCAqIHRoaXMu X3JlY29yZC5oZWlnaHQsIHN0YXJ0VGltZTogdGhpcy5fcmVjb3JkLnN0YXJ0VGltZSwgdG90YWxU aW1lOiB0aGlzLl9yZWNvcmQuZHVyYXRpb24sIGxvY2F0aW9uOiB0aGlzLl9yZWNvcmQuaW5pdGlh dG9yQ2FsbEZyYW1lfTsKKyAgICAgICAgaWYgKCF0aGlzLl9jYWNoZWREYXRhKSB7CisgICAgICAg ICAgICB0aGlzLl9jYWNoZWREYXRhID0geworICAgICAgICAgICAgICAgIGV2ZW50VHlwZTogdGhp cy5fcmVjb3JkLmV2ZW50VHlwZSwKKyAgICAgICAgICAgICAgICB3aWR0aDogdGhpcy5fcmVjb3Jk LndpZHRoLAorICAgICAgICAgICAgICAgIGhlaWdodDogdGhpcy5fcmVjb3JkLmhlaWdodCwKKyAg ICAgICAgICAgICAgICBhcmVhOiB0aGlzLl9yZWNvcmQud2lkdGggKiB0aGlzLl9yZWNvcmQuaGVp Z2h0LAorICAgICAgICAgICAgICAgIHN0YXJ0VGltZTogdGhpcy5fcmVjb3JkLnN0YXJ0VGltZSwK KyAgICAgICAgICAgICAgICB0b3RhbFRpbWU6IHRoaXMuX3JlY29yZC5kdXJhdGlvbiwKKyAgICAg ICAgICAgICAgICBsb2NhdGlvbjogdGhpcy5fcmVjb3JkLmluaXRpYXRvckNhbGxGcmFtZSwKKyAg ICAgICAgICAgIH07CisgICAgICAgIH0KKworICAgICAgICByZXR1cm4gdGhpcy5fY2FjaGVkRGF0 YTsKICAgICB9CiAKICAgICBjcmVhdGVDZWxsQ29udGVudChjb2x1bW5JZGVudGlmaWVyLCBjZWxs KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv UmVuZGVyaW5nRnJhbWVUaW1lbGluZURhdGFHcmlkTm9kZS5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1JlbmRlcmluZ0ZyYW1lVGltZWxpbmVEYXRhR3JpZE5v ZGUuanMKaW5kZXggZmVkZjkyNy4uNzE1ZmQ3MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUmVuZGVyaW5nRnJhbWVUaW1lbGluZURhdGFHcmlk Tm9kZS5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9S ZW5kZXJpbmdGcmFtZVRpbWVsaW5lRGF0YUdyaWROb2RlLmpzCkBAIC00NywxMSArNDcsMjIgQEAg V2ViSW5zcGVjdG9yLlJlbmRlcmluZ0ZyYW1lVGltZWxpbmVEYXRhR3JpZE5vZGUgPSBjbGFzcyBS ZW5kZXJpbmdGcmFtZVRpbWVsaW5lRGEKIAogICAgIGdldCBkYXRhKCkKICAgICB7Ci0gICAgICAg IHZhciBzY3JpcHRUaW1lID0gdGhpcy5fcmVjb3JkLmR1cmF0aW9uRm9yVGFzayhXZWJJbnNwZWN0 b3IuUmVuZGVyaW5nRnJhbWVUaW1lbGluZVJlY29yZC5UYXNrVHlwZS5TY3JpcHQpOwotICAgICAg ICB2YXIgbGF5b3V0VGltZSA9IHRoaXMuX3JlY29yZC5kdXJhdGlvbkZvclRhc2soV2ViSW5zcGVj dG9yLlJlbmRlcmluZ0ZyYW1lVGltZWxpbmVSZWNvcmQuVGFza1R5cGUuTGF5b3V0KTsKLSAgICAg ICAgdmFyIHBhaW50VGltZSA9IHRoaXMuX3JlY29yZC5kdXJhdGlvbkZvclRhc2soV2ViSW5zcGVj dG9yLlJlbmRlcmluZ0ZyYW1lVGltZWxpbmVSZWNvcmQuVGFza1R5cGUuUGFpbnQpOwotICAgICAg ICB2YXIgb3RoZXJUaW1lID0gdGhpcy5fcmVjb3JkLmR1cmF0aW9uRm9yVGFzayhXZWJJbnNwZWN0 b3IuUmVuZGVyaW5nRnJhbWVUaW1lbGluZVJlY29yZC5UYXNrVHlwZS5PdGhlcik7Ci0gICAgICAg IHJldHVybiB7c3RhcnRUaW1lOiB0aGlzLl9yZWNvcmQuc3RhcnRUaW1lLCBzY3JpcHRUaW1lLCBs YXlvdXRUaW1lLCBwYWludFRpbWUsIG90aGVyVGltZSwgdG90YWxUaW1lOiB0aGlzLl9yZWNvcmQu ZHVyYXRpb259OworICAgICAgICBpZiAoIXRoaXMuX2NhY2hlZERhdGEpIHsKKyAgICAgICAgICAg IHZhciBzY3JpcHRUaW1lID0gdGhpcy5fcmVjb3JkLmR1cmF0aW9uRm9yVGFzayhXZWJJbnNwZWN0 b3IuUmVuZGVyaW5nRnJhbWVUaW1lbGluZVJlY29yZC5UYXNrVHlwZS5TY3JpcHQpOworICAgICAg ICAgICAgdmFyIGxheW91dFRpbWUgPSB0aGlzLl9yZWNvcmQuZHVyYXRpb25Gb3JUYXNrKFdlYklu c3BlY3Rvci5SZW5kZXJpbmdGcmFtZVRpbWVsaW5lUmVjb3JkLlRhc2tUeXBlLkxheW91dCk7Cisg ICAgICAgICAgICB2YXIgcGFpbnRUaW1lID0gdGhpcy5fcmVjb3JkLmR1cmF0aW9uRm9yVGFzayhX ZWJJbnNwZWN0b3IuUmVuZGVyaW5nRnJhbWVUaW1lbGluZVJlY29yZC5UYXNrVHlwZS5QYWludCk7 CisgICAgICAgICAgICB2YXIgb3RoZXJUaW1lID0gdGhpcy5fcmVjb3JkLmR1cmF0aW9uRm9yVGFz ayhXZWJJbnNwZWN0b3IuUmVuZGVyaW5nRnJhbWVUaW1lbGluZVJlY29yZC5UYXNrVHlwZS5PdGhl cik7CisgICAgICAgICAgICB0aGlzLl9jYWNoZWREYXRhID0geworICAgICAgICAgICAgICAgIHN0 YXJ0VGltZTogdGhpcy5fcmVjb3JkLnN0YXJ0VGltZSwKKyAgICAgICAgICAgICAgICB0b3RhbFRp bWU6IHRoaXMuX3JlY29yZC5kdXJhdGlvbiwKKyAgICAgICAgICAgICAgICBzY3JpcHRUaW1lLAor ICAgICAgICAgICAgICAgIGxheW91dFRpbWUsCisgICAgICAgICAgICAgICAgcGFpbnRUaW1lLAor ICAgICAgICAgICAgICAgIG90aGVyVGltZSwKKyAgICAgICAgICAgIH07CisgICAgICAgIH0KKwor ICAgICAgICByZXR1cm4gdGhpcy5fY2FjaGVkRGF0YTsKICAgICB9CiAKICAgICBjcmVhdGVDZWxs Q29udGVudChjb2x1bW5JZGVudGlmaWVyLCBjZWxsKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2NyaXB0VGltZWxpbmVEYXRhR3JpZE5vZGUu anMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TY3JpcHRUaW1l bGluZURhdGFHcmlkTm9kZS5qcwppbmRleCA4MjljZTgwLi41ZTlhOWFiIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TY3JpcHRUaW1lbGluZURh dGFHcmlkTm9kZS5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9TY3JpcHRUaW1lbGluZURhdGFHcmlkTm9kZS5qcwpAQCAtNjQsMjggKzY0LDMyIEBAIFdl Ykluc3BlY3Rvci5TY3JpcHRUaW1lbGluZURhdGFHcmlkTm9kZSA9IGNsYXNzIFNjcmlwdFRpbWVs aW5lRGF0YUdyaWROb2RlIGV4dGVuCiAKICAgICBnZXQgZGF0YSgpCiAgICAgewotICAgICAgICB2 YXIgc3RhcnRUaW1lID0gdGhpcy5fcmVjb3JkLnN0YXJ0VGltZTsKLSAgICAgICAgdmFyIGR1cmF0 aW9uID0gdGhpcy5fcmVjb3JkLnN0YXJ0VGltZSArIHRoaXMuX3JlY29yZC5kdXJhdGlvbiAtIHN0 YXJ0VGltZTsKLSAgICAgICAgdmFyIGNhbGxGcmFtZU9yU291cmNlQ29kZUxvY2F0aW9uID0gdGhp cy5fcmVjb3JkLmluaXRpYXRvckNhbGxGcmFtZSB8fCB0aGlzLl9yZWNvcmQuc291cmNlQ29kZUxv Y2F0aW9uOworICAgICAgICBpZiAoIXRoaXMuX2NhY2hlZERhdGEpIHsKKyAgICAgICAgICAgIHZh ciBzdGFydFRpbWUgPSB0aGlzLl9yZWNvcmQuc3RhcnRUaW1lOworICAgICAgICAgICAgdmFyIGR1 cmF0aW9uID0gdGhpcy5fcmVjb3JkLnN0YXJ0VGltZSArIHRoaXMuX3JlY29yZC5kdXJhdGlvbiAt IHN0YXJ0VGltZTsKKyAgICAgICAgICAgIHZhciBjYWxsRnJhbWVPclNvdXJjZUNvZGVMb2NhdGlv biA9IHRoaXMuX3JlY29yZC5pbml0aWF0b3JDYWxsRnJhbWUgfHwgdGhpcy5fcmVjb3JkLnNvdXJj ZUNvZGVMb2NhdGlvbjsKIAotICAgICAgICAvLyBDT01QQVRJQklMSVRZIChpT1MgOCk6IFByb2Zp bGVzIGluY2x1ZGVkIHBlci1jYWxsIGluZm9ybWF0aW9uIGFuZCBjYW4gYmUgZmluZWx5IHBhcnRp dGlvbmVkLgotICAgICAgICBpZiAodGhpcy5fcmVjb3JkLnByb2ZpbGUpIHsKLSAgICAgICAgICAg IHZhciBvbmVSb290Tm9kZSA9IHRoaXMuX3JlY29yZC5wcm9maWxlLnRvcERvd25Sb290Tm9kZXNb MF07Ci0gICAgICAgICAgICBpZiAob25lUm9vdE5vZGUgJiYgb25lUm9vdE5vZGUuY2FsbHMpIHsK LSAgICAgICAgICAgICAgICBzdGFydFRpbWUgPSBNYXRoLm1heCh0aGlzLl9yYW5nZVN0YXJ0VGlt ZSwgdGhpcy5fcmVjb3JkLnN0YXJ0VGltZSk7Ci0gICAgICAgICAgICAgICAgZHVyYXRpb24gPSBN YXRoLm1pbih0aGlzLl9yZWNvcmQuc3RhcnRUaW1lICsgdGhpcy5fcmVjb3JkLmR1cmF0aW9uLCB0 aGlzLl9yYW5nZUVuZFRpbWUpIC0gc3RhcnRUaW1lOworICAgICAgICAgICAgLy8gQ09NUEFUSUJJ TElUWSAoaU9TIDgpOiBQcm9maWxlcyBpbmNsdWRlZCBwZXItY2FsbCBpbmZvcm1hdGlvbiBhbmQg Y2FuIGJlIGZpbmVseSBwYXJ0aXRpb25lZC4KKyAgICAgICAgICAgIGlmICh0aGlzLl9yZWNvcmQu cHJvZmlsZSkgeworICAgICAgICAgICAgICAgIHZhciBvbmVSb290Tm9kZSA9IHRoaXMuX3JlY29y ZC5wcm9maWxlLnRvcERvd25Sb290Tm9kZXNbMF07CisgICAgICAgICAgICAgICAgaWYgKG9uZVJv b3ROb2RlICYmIG9uZVJvb3ROb2RlLmNhbGxzKSB7CisgICAgICAgICAgICAgICAgICAgIHN0YXJ0 VGltZSA9IE1hdGgubWF4KHRoaXMuX3JhbmdlU3RhcnRUaW1lLCB0aGlzLl9yZWNvcmQuc3RhcnRU aW1lKTsKKyAgICAgICAgICAgICAgICAgICAgZHVyYXRpb24gPSBNYXRoLm1pbih0aGlzLl9yZWNv cmQuc3RhcnRUaW1lICsgdGhpcy5fcmVjb3JkLmR1cmF0aW9uLCB0aGlzLl9yYW5nZUVuZFRpbWUp IC0gc3RhcnRUaW1lOworICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgIH0KKworICAgICAg ICAgICAgdGhpcy5fY2FjaGVkRGF0YSA9IHsKKyAgICAgICAgICAgICAgICBldmVudFR5cGU6IHRo aXMuX3JlY29yZC5ldmVudFR5cGUsCisgICAgICAgICAgICAgICAgc3RhcnRUaW1lLAorICAgICAg ICAgICAgICAgIHNlbGZUaW1lOiBkdXJhdGlvbiwKKyAgICAgICAgICAgICAgICB0b3RhbFRpbWU6 IGR1cmF0aW9uLAorICAgICAgICAgICAgICAgIGF2ZXJhZ2VUaW1lOiBkdXJhdGlvbiwKKyAgICAg ICAgICAgICAgICBjYWxsQ291bnQ6IHRoaXMuX3JlY29yZC5jYWxsQ291bnRPclNhbXBsZXMsCisg ICAgICAgICAgICAgICAgbG9jYXRpb246IGNhbGxGcmFtZU9yU291cmNlQ29kZUxvY2F0aW9uLAor ICAgICAgICAgICAgfTsKICAgICAgICAgfQogCi0gICAgICAgIHJldHVybiB7Ci0gICAgICAgICAg ICBldmVudFR5cGU6IHRoaXMuX3JlY29yZC5ldmVudFR5cGUsCi0gICAgICAgICAgICBzdGFydFRp bWUsCi0gICAgICAgICAgICBzZWxmVGltZTogZHVyYXRpb24sCi0gICAgICAgICAgICB0b3RhbFRp bWU6IGR1cmF0aW9uLAotICAgICAgICAgICAgYXZlcmFnZVRpbWU6IGR1cmF0aW9uLAotICAgICAg ICAgICAgY2FsbENvdW50OiB0aGlzLl9yZWNvcmQuY2FsbENvdW50T3JTYW1wbGVzLAotICAgICAg ICAgICAgbG9jYXRpb246IGNhbGxGcmFtZU9yU291cmNlQ29kZUxvY2F0aW9uCi0gICAgICAgIH07 CisgICAgICAgIHJldHVybiB0aGlzLl9jYWNoZWREYXRhOwogICAgIH0KIAogICAgIHVwZGF0ZVJh bmdlVGltZXMoc3RhcnRUaW1lLCBlbmRUaW1lKQo=