153589 2016-01-28 04:34:45 -0800 [webkitdirs] Don't pass cmakeBasedPortName around. 2016-01-28 08:18:46 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 annulen webkit-unassigned achristensen commit-queue dbates gyuyoung.kim lforschler mcatanzaro oldest_to_newest 1159692 0 annulen 2016-01-28 04:34:45 -0800 It should be local function of webkitdirs.pm instead. 1159695 1 270109 annulen 2016-01-28 05:22:10 -0800 Created attachment 270109 Patch 1159718 2 270109 commit-queue 2016-01-28 08:18:41 -0800 Comment on attachment 270109 Patch Clearing flags on attachment: 270109 Committed r195737: <http://trac.webkit.org/changeset/195737> 1159719 3 commit-queue 2016-01-28 08:18:46 -0800 All reviewed patches have been landed. Closing bug. 270109 2016-01-28 05:22:10 -0800 2016-01-28 08:18:41 -0800 Patch bug-153589-20160128162144.patch text/plain 5279 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMTk1NzM1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNWIzYWQ3MmUwNGI2NjRjMzc5YzkyZmE5ZmNmNjg1MjY4 NzBmYzRlNi4uMjIwNGFiZGVhNzZhYTcwZWEyZTdmNDg5ODVjYjUxMzU0MjNkNTQ0ZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIz IEBACisyMDE2LTAxLTI4ICBLb25zdGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4K KworICAgICAgICBbd2Via2l0ZGlyc10gRG9uJ3QgcGFzcyBjbWFrZUJhc2VkUG9ydE5hbWUgYXJv dW5kLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUz NTg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSXQg c2hvdWxkIGJlIGxvY2FsIGZ1bmN0aW9uIG9mIHdlYmtpdGRpcnMucG0gaW5zdGVhZC4KKworICAg ICAgICAqIFNjcmlwdHMvYnVpbGQtanNjOiBEb24ndCBwYXNzIGNtYWtlQmFzZWRQb3J0TmFtZSB0 bworICAgICAgICBidWlsZENNYWtlUHJvamVjdE9yRXhpdCgpLgorICAgICAgICAqIFNjcmlwdHMv YnVpbGQtd2Via2l0OiBEb24ndCBwYXNzIGNtYWtlQmFzZWRQb3J0TmFtZSB0bworICAgICAgICBi dWlsZENNYWtlUHJvamVjdE9yRXhpdCgpIGFuZCBnZW5lcmF0ZUJ1aWxkU3lzdGVtRnJvbUNNYWtl UHJvamVjdCgpLgorICAgICAgICAqIFNjcmlwdHMvcnVuLWVmbC10ZXN0czogRG9uJ3QgcGFzcyBj bWFrZUJhc2VkUG9ydE5hbWUgdG8KKyAgICAgICAgZ2VuZXJhdGVCdWlsZFN5c3RlbUZyb21DTWFr ZVByb2plY3QoKS4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdGRpcnMucG06IERvbid0IGV4cG9y dCBjbWFrZUJhc2VkUG9ydE5hbWUuCisgICAgICAgIChnZW5lcmF0ZUJ1aWxkU3lzdGVtRnJvbUNN YWtlUHJvamVjdCk6IFJlbW92ZWQgJHBvcnQgYXJndW1lbnQgYXMgd2UKKyAgICAgICAgY2FuIGdl dCBpdCBmcm9tIGNtYWtlQmFzZWRQb3J0TmFtZSgpLgorICAgICAgICAoYnVpbGRDTWFrZVByb2pl Y3RPckV4aXQpOiBEaXR0by4KKwogMjAxNi0wMS0yNyAgS3J6eXN6dG9mIEN6ZWNoICA8ay5jemVj aEBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZMXSBSZW1vdmUgdW51c2VkIGFjY2Vzc2liaWxp dHkgcmVsYXRlZCBjb2RlCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL2J1aWxkLWpzYyBiL1Rv b2xzL1NjcmlwdHMvYnVpbGQtanNjCmluZGV4IDg3MTcwOTE3NmRmMDY5NTBiZjY3NDNmNGY2YWE4 MWI1NTczM2QyOGEuLjVlNWU2MTM1ZTRiNTYyNjY3MDc1YzA0ZWQyMTM2YzNiZTE2OWQxNmQgMTAw NzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvYnVpbGQtanNjCisrKyBiL1Rvb2xzL1NjcmlwdHMvYnVp bGQtanNjCkBAIC0xMTIsNyArMTEyLDcgQEAgaWYgKGlzQ01ha2VCdWlsZCgpKSB7CiAgICAgfQog CiAgICAgIyBUaGlzIGNhbGwgb25seSByZXR1cm5zIGlmIG5vdGhpbmcgd3JvbmcgaGFwcGVuZWQK LSAgICBidWlsZENNYWtlUHJvamVjdE9yRXhpdCgwLCBjbWFrZUJhc2VkUG9ydE5hbWUoKSwgdW5k ZWYsICRidWlsZFRhcmdldCwgKGNtYWtlQmFzZWRQb3J0QXJndW1lbnRzKCksICRjbWFrZUFyZ3Mp KTsKKyAgICBidWlsZENNYWtlUHJvamVjdE9yRXhpdCgwLCB1bmRlZiwgJGJ1aWxkVGFyZ2V0LCAo Y21ha2VCYXNlZFBvcnRBcmd1bWVudHMoKSwgJGNtYWtlQXJncykpOwogICAgIHdyaXRlQ29uZ3Jh dHMoKTsKICAgICBleGl0IGV4aXRTdGF0dXMoMCk7CiB9CmRpZmYgLS1naXQgYS9Ub29scy9TY3Jp cHRzL2J1aWxkLXdlYmtpdCBiL1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CmluZGV4IGQwNmEx Mzc4YjEwOTUyMmVjMGM0ZWRjMGYxM2IzMGEyNTE1YzA0ZmIuLmQ5MWU5OWIwZjNkMjc3ODQ1ODUw NTY5ZTgyZTkxZjczYjUxMzAzMTYgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Vi a2l0CisrKyBiL1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CkBAIC0yNDYsMTMgKzI0NiwxMyBA QCBpZiAoaXNDTWFrZUJ1aWxkKCkgJiYgIWlzQW55V2luZG93cygpKSB7CiAgICAgbXkgQGZlYXR1 cmVBcmdzID0gY01ha2VBcmdzRnJvbUZlYXR1cmVzKCk7CiAgICAgcmVtb3ZlQ01ha2VDYWNoZShA ZmVhdHVyZUFyZ3MpOwogCi0gICAgYnVpbGRDTWFrZVByb2plY3RPckV4aXQoJGNsZWFuLCBjbWFr ZUJhc2VkUG9ydE5hbWUoKSwgJHByZWZpeFBhdGgsICRtYWtlQXJncywgKGNtYWtlQmFzZWRQb3J0 QXJndW1lbnRzKCksIEBmZWF0dXJlQXJncyksICRjbWFrZUFyZ3MpOworICAgIGJ1aWxkQ01ha2VQ cm9qZWN0T3JFeGl0KCRjbGVhbiwgJHByZWZpeFBhdGgsICRtYWtlQXJncywgKGNtYWtlQmFzZWRQ b3J0QXJndW1lbnRzKCksIEBmZWF0dXJlQXJncyksICRjbWFrZUFyZ3MpOwogfQogCiBteSAkYmFz ZVByb2R1Y3REaXIgPSBiYXNlUHJvZHVjdERpcigpOwogaWYgKGlzQXBwbGVXaW5XZWJLaXQoKSB8 fCBpc1dpbkNhaXJvKCkpIHsKICAgICBjaGRpcldlYktpdCgpOwotICAgIGlmIChleGl0U3RhdHVz KGdlbmVyYXRlQnVpbGRTeXN0ZW1Gcm9tQ01ha2VQcm9qZWN0KGNtYWtlQmFzZWRQb3J0TmFtZSgp KSkpIHsKKyAgICBpZiAoZXhpdFN0YXR1cyhnZW5lcmF0ZUJ1aWxkU3lzdGVtRnJvbUNNYWtlUHJv amVjdCgpKSkgewogICAgICAgICBkaWUgIlJ1biBcIkM6L1Byb2dyYW0gRmlsZXMgKHg4NikvTWlj cm9zb2Z0IFZpc3VhbCBTdHVkaW8gMTQuMC9WQy92Y3ZhcnNhbGwuYmF0XCIgYmVmb3JlIGJ1aWxk LXdlYmtpdCB3aGVuIHVzaW5nIG5pbmphIjsKICAgICB9CiAgICAgY2hkaXJXZWJLaXQoKTsKZGlm ZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvcnVuLWVmbC10ZXN0cyBiL1Rvb2xzL1NjcmlwdHMvcnVu LWVmbC10ZXN0cwppbmRleCBjYjZkZjViN2JiZDAwNTFhYzRiOWZjNGMyYTZkNDlmZjAwZDhhN2Ew Li5jOGQzZDdjZWZmNDIzMTZjOGRiMGNjMzYyNDdmODg1YjI3NzhmMDg1IDEwMDc1NQotLS0gYS9U b29scy9TY3JpcHRzL3J1bi1lZmwtdGVzdHMKKysrIGIvVG9vbHMvU2NyaXB0cy9ydW4tZWZsLXRl c3RzCkBAIC01MSw3ICs1MSw3IEBAIGlmICgkeHZmYl9waWQgPT0gMCkgewogICAgICMgTWFudWFs bHkgYWRkIHRoaXMgZm9yIGpoYnVpbGRXcmFwcGVyUHJlZml4SWZOZWVkZWQoKS4KICAgICBwdXNo KEBBUkdWLCAiLS1lZmwiKTsKIAotICAgIG15ICRyZXR1cm5Db2RlID0gZXhpdFN0YXR1cyhnZW5l cmF0ZUJ1aWxkU3lzdGVtRnJvbUNNYWtlUHJvamVjdCgiRWZsIiwgdW5kZWYsIGNtYWtlQmFzZWRQ b3J0QXJndW1lbnRzKCkpKTsKKyAgICBteSAkcmV0dXJuQ29kZSA9IGV4aXRTdGF0dXMoZ2VuZXJh dGVCdWlsZFN5c3RlbUZyb21DTWFrZVByb2plY3QodW5kZWYsIGNtYWtlQmFzZWRQb3J0QXJndW1l bnRzKCkpKTsKICAgICBleGl0KCRyZXR1cm5Db2RlKSBpZiAkcmV0dXJuQ29kZTsKIAogICAgICRy ZXR1cm5Db2RlID0gZXhpdFN0YXR1cyhidWlsZENNYWtlR2VuZXJhdGVkUHJvamVjdCgidGVzdCIp KTsKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbSBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0ZGlycy5wbQppbmRleCBmYzZlYTE2MDJlNjI4ZDZkZGM0MTUxNTE1OTY0OTkzYmRi OTY2NjM5Li4zYzE1YTY1ZDU4N2U4N2FmYzY3ZjBmZWYwNzcwMzNlZjc5NDM5ZDExIDEwMDc1NQot LS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRkaXJzLnBtCkBAIC02Myw3ICs2Myw2IEBAIEJFR0lOIHsKICAgICAgICAmY2hkaXJXZWJLaXQK ICAgICAgICAmY2hlY2tGcmFtZXdvcmtzCiAgICAgICAgJmNtYWtlQmFzZWRQb3J0QXJndW1lbnRz Ci0gICAgICAgJmNtYWtlQmFzZWRQb3J0TmFtZQogICAgICAgICZjdXJyZW50U1ZOUmV2aXNpb24K ICAgICAgICAmZGVidWdTYWZhcmkKICAgICAgICAmZXhlY3V0YWJsZVByb2R1Y3REaXIKQEAgLTE5 MjksOCArMTkyOCw5IEBAIHN1YiBjbWFrZUdlbmVyYXRlZEJ1aWxkZmlsZShAKQogCiBzdWIgZ2Vu ZXJhdGVCdWlsZFN5c3RlbUZyb21DTWFrZVByb2plY3QKIHsKLSAgICBteSAoJHBvcnQsICRwcmVm aXhQYXRoLCBAY21ha2VBcmdzLCAkYWRkaXRpb25hbENNYWtlQXJncykgPSBAXzsKKyAgICBteSAo JHByZWZpeFBhdGgsIEBjbWFrZUFyZ3MsICRhZGRpdGlvbmFsQ01ha2VBcmdzKSA9IEBfOwogICAg IG15ICRjb25maWcgPSBjb25maWd1cmF0aW9uKCk7CisgICAgbXkgJHBvcnQgPSBjbWFrZUJhc2Vk UG9ydE5hbWUoKTsKICAgICBteSAkYnVpbGRQYXRoID0gRmlsZTo6U3BlYy0+Y2F0ZGlyKGJhc2VQ cm9kdWN0RGlyKCksICRjb25maWcpOwogICAgIEZpbGU6OlBhdGg6Om1rcGF0aCgkYnVpbGRQYXRo KSB1bmxlc3MgLWQgJGJ1aWxkUGF0aDsKICAgICBteSAkb3JpZ2luYWxXb3JraW5nRGlyZWN0b3J5 ID0gZ2V0Y3dkKCk7CkBAIC0yMDMxLDkgKzIwMzEsOSBAQCBzdWIgY2xlYW5DTWFrZUdlbmVyYXRl ZFByb2plY3QoKQogICAgIHJldHVybiAwOwogfQogCi1zdWIgYnVpbGRDTWFrZVByb2plY3RPckV4 aXQoJCQkJEApCitzdWIgYnVpbGRDTWFrZVByb2plY3RPckV4aXQoJCQkQCkKIHsKLSAgICBteSAo JGNsZWFuLCAkcG9ydCwgJHByZWZpeFBhdGgsICRtYWtlQXJncywgQGNtYWtlQXJncykgPSBAXzsK KyAgICBteSAoJGNsZWFuLCAkcHJlZml4UGF0aCwgJG1ha2VBcmdzLCBAY21ha2VBcmdzKSA9IEBf OwogICAgIG15ICRyZXR1cm5Db2RlOwogCiAgICAgZXhpdChleGl0U3RhdHVzKGNsZWFuQ01ha2VH ZW5lcmF0ZWRQcm9qZWN0KCkpKSBpZiAkY2xlYW47CkBAIC0yMDQ2LDcgKzIwNDYsNyBAQCBzdWIg YnVpbGRDTWFrZVByb2plY3RPckV4aXQoJCQkJEApCiAgICAgICAgIHN5c3RlbSgicGVybCIsICIk c291cmNlRGlyL1Rvb2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtpdGd0ay1saWJzIikgPT0gMCBvciBk aWUgJCE7CiAgICAgfQogCi0gICAgJHJldHVybkNvZGUgPSBleGl0U3RhdHVzKGdlbmVyYXRlQnVp bGRTeXN0ZW1Gcm9tQ01ha2VQcm9qZWN0KCRwb3J0LCAkcHJlZml4UGF0aCwgQGNtYWtlQXJncykp OworICAgICRyZXR1cm5Db2RlID0gZXhpdFN0YXR1cyhnZW5lcmF0ZUJ1aWxkU3lzdGVtRnJvbUNN YWtlUHJvamVjdCgkcHJlZml4UGF0aCwgQGNtYWtlQXJncykpOwogICAgIGV4aXQoJHJldHVybkNv ZGUpIGlmICRyZXR1cm5Db2RlOwogCiAgICAgJHJldHVybkNvZGUgPSBleGl0U3RhdHVzKGJ1aWxk Q01ha2VHZW5lcmF0ZWRQcm9qZWN0KCRtYWtlQXJncykpOwo=