153555 2016-01-27 12:49:09 -0800 [FTL][Win64] Compile fix. 2016-01-27 14:10:16 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned achristensen commit-queue fpizlo keith_miller mark.lam msaboff saam oldest_to_newest 1159382 0 peavo 2016-01-27 12:49:09 -0800 When compiling FTLOSRExitCompiler.cpp, I get the following error: FTLOSRExitCompiler.cpp(585): error C2121: '#': invalid character: possibly the result of a macro expansion FTLOSRExitCompiler.cpp(570): error C2059: syntax error: 'if' MSVC does not accept preprocessor conditionals in macros, it seems. 1159385 1 270026 peavo 2016-01-27 12:54:14 -0800 Created attachment 270026 Patch 1159395 2 270026 achristensen 2016-01-27 13:10:53 -0800 Comment on attachment 270026 Patch I'm surprised other compilers accept this. 1159400 3 peavo 2016-01-27 13:29:28 -0800 (In reply to comment #2) > Comment on attachment 270026 [details] > Patch > > I'm surprised other compilers accept this. Yes, I am not sure what the standards says about this case. Thanks for reviewing :) 1159415 4 peavo 2016-01-27 14:10:16 -0800 Committed r195691: <http://trac.webkit.org/changeset/195691> 270026 2016-01-27 12:54:14 -0800 2016-01-27 13:10:53 -0800 Patch bug-153555-20160127215358.patch text/plain 2254 peavo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk1Njg4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE2LTAxLTI3ICBQZXIgQXJuZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNvbT4KKworICAg ICAgICBbRlRMXVtXaW42NF0gQ29tcGlsZSBmaXguCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTM1NTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBNU1ZDIGRvZXMgbm90IGFjY2VwdCBwcmVwcm9jZXNzb3Ig Y29uZGl0aW9uYWxzIGluIG1hY3Jvcy4KKworICAgICAgICAqIGZ0bC9GVExPU1JFeGl0Q29tcGls ZXIuY3BwOgorICAgICAgICAoSlNDOjpGVEw6OmNvbXBpbGVTdHViKToKKwogMjAxNi0wMS0yNyAg RmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIEFpcjo6VG1wV2lkdGgg dXNlcyBhIHN0YWxlIHBvaW50ZXIgaW50byBpdHMgSGFzaE1hcCBhZnRlciBpdCBjYWxscyBhZGQo KQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExPU1JFeGl0Q29tcGlsZXIuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMT1NSRXhpdENvbXBp bGVyLmNwcAkocmV2aXNpb24gMTk1NTg2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9G VExPU1JFeGl0Q29tcGlsZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01NjcsMjIgKzU2NywyNiBA QCBzdGF0aWMgdm9pZCBjb21waWxlU3R1YigKICAgICBhZGp1c3RBbmRKdW1wVG9UYXJnZXQoaml0 LCBleGl0LCBleGl0Lm1faXNFeGNlcHRpb25IYW5kbGVyKTsKICAgICAKICAgICBMaW5rQnVmZmVy IHBhdGNoQnVmZmVyKCp2bSwgaml0LCBjb2RlQmxvY2spOworI2lmIEZUTF9VU0VTX0IzCiAgICAg ZXhpdC5tX2NvZGUgPSBGSU5BTElaRV9DT0RFX0lGKAogICAgICAgICBzaG91bGREdW1wRGlzYXNz ZW1ibHkoKSB8fCBPcHRpb25zOjp2ZXJib3NlT1NSKCkgfHwgT3B0aW9uczo6dmVyYm9zZUZUTE9T UkV4aXQoKSwKICAgICAgICAgcGF0Y2hCdWZmZXIsCi0jaWYgRlRMX1VTRVNfQjMKICAgICAgICAg KCJGVEwgT1NSIGV4aXQgIyV1ICglcywgJXMpIGZyb20gJXMsIHdpdGggb3BlcmFuZHMgPSAlcyIs CiAgICAgICAgICAgICBleGl0SUQsIHRvQ1N0cmluZyhleGl0Lm1fY29kZU9yaWdpbikuZGF0YSgp LAogICAgICAgICAgICAgZXhpdEtpbmRUb1N0cmluZyhleGl0Lm1fa2luZCksIHRvQ1N0cmluZygq Y29kZUJsb2NrKS5kYXRhKCksCiAgICAgICAgICAgICB0b0NTdHJpbmcoaWdub3JpbmdDb250ZXh0 PER1bXBDb250ZXh0PihleGl0Lm1fZGVzY3JpcHRvci0+bV92YWx1ZXMpKS5kYXRhKCkpCisgICAg ICAgICk7CiAjZWxzZSAvLyBGVExfVVNFU19CMworICAgIGV4aXQubV9jb2RlID0gRklOQUxJWkVf Q09ERV9JRigKKyAgICAgICAgc2hvdWxkRHVtcERpc2Fzc2VtYmx5KCkgfHwgT3B0aW9uczo6dmVy Ym9zZU9TUigpIHx8IE9wdGlvbnM6OnZlcmJvc2VGVExPU1JFeGl0KCksCisgICAgICAgIHBhdGNo QnVmZmVyLAogICAgICAgICAoIkZUTCBPU1IgZXhpdCAjJXUgKCVzLCAlcykgZnJvbSAlcywgd2l0 aCBvcGVyYW5kcyA9ICVzLCBhbmQgcmVjb3JkID0gJXMiLAogICAgICAgICAgICAgZXhpdElELCB0 b0NTdHJpbmcoZXhpdC5tX2NvZGVPcmlnaW4pLmRhdGEoKSwKICAgICAgICAgICAgIGV4aXRLaW5k VG9TdHJpbmcoZXhpdC5tX2tpbmQpLCB0b0NTdHJpbmcoKmNvZGVCbG9jaykuZGF0YSgpLAogICAg ICAgICAgICAgdG9DU3RyaW5nKGlnbm9yaW5nQ29udGV4dDxEdW1wQ29udGV4dD4oZXhpdC5tX2Rl c2NyaXB0b3ItPm1fdmFsdWVzKSkuZGF0YSgpLAogICAgICAgICAgICAgdG9DU3RyaW5nKCpyZWNv cmQpLmRhdGEoKSkKLSNlbmRpZiAvLyBGVExfVVNFU19CMwogICAgICAgICApOworI2VuZGlmIC8v IEZUTF9VU0VTX0IzCiB9CiAKIGV4dGVybiAiQyIgdm9pZCogY29tcGlsZUZUTE9TUkV4aXQoRXhl Y1N0YXRlKiBleGVjLCB1bnNpZ25lZCBleGl0SUQpCg==